[0/2] Introduce simple pidfd to task helper

Message

Christian Brauner Oct. 4, 2021, 12:50 p.m. UTC

Hey everyone,

This adds a simple helper to get rid of some code duplication introduced
with the addition of two new pidfd-based syscalls in mm. We should've
probably added the helper right away and I think I mentioned this during
in the review on one of the revisions but we probably just lost track of
it. If this looks ok to you, I'll queue this up for next.

Thanks!
Christian

Christian Brauner (2):
  pid: add pidfd_get_task() helper
  mm: use pidfd_get_task()

 include/linux/pid.h |  1 +
 kernel/pid.c        | 34 ++++++++++++++++++++++++++++++++++
 mm/madvise.c        | 15 +++------------
 mm/oom_kill.c       | 15 +++------------
 4 files changed, 41 insertions(+), 24 deletions(-)


base-commit: 9e1ff307c779ce1f0f810c7ecce3d95bbae40896

Comments

Matthew Bobrowski Oct. 7, 2021, 10:12 p.m. UTC | #1

On Mon, Oct 04, 2021 at 02:50:48PM +0200, Christian Brauner wrote:
> Hey everyone,
> 
> This adds a simple helper to get rid of some code duplication introduced
> with the addition of two new pidfd-based syscalls in mm. We should've
> probably added the helper right away and I think I mentioned this during
> in the review on one of the revisions but we probably just lost track of
> it. If this looks ok to you, I'll queue this up for next.

I went through the series. Seems like a very sensible thing to do, so thanks for
adding the helper and updating the call sites accordingly.

Reviewed-by: Matthew Bobrowski <[e-mail]>

> Christian Brauner (2):
>   pid: add pidfd_get_task() helper
>   mm: use pidfd_get_task()
> 
>  include/linux/pid.h |  1 +
>  kernel/pid.c        | 34 ++++++++++++++++++++++++++++++++++
>  mm/madvise.c        | 15 +++------------
>  mm/oom_kill.c       | 15 +++------------
>  4 files changed, 41 insertions(+), 24 deletions(-)
> 
> 
> base-commit: 9e1ff307c779ce1f0f810c7ecce3d95bbae40896
> -- 
> 2.30.2
> 
/M