mbox series

[v2,0/2] mm/damon: Fix fake /proc/loadavg reports

Message ID 20211125160830.30153-1-sj@kernel.org (mailing list archive)
Headers show
Series mm/damon: Fix fake /proc/loadavg reports | expand

Message

SeongJae Park Nov. 25, 2021, 4:08 p.m. UTC 
This patchset fixes DAMON's fake load report issue.  The first patch
makes yet another variant of usleep_range() for this fix, and the second
patch fixes the issue of DAMON by making it using the newly introduced
function.

I think these need to be applied on v5.15.y, but the second patch cannot
cleanly applied there as is.  I will back-port this on v5.15.y and post
later once this is merged in the mainline.  If you think this is not
appropriate for stable tree, please let me know.

Changelog
---------

From v1
(https://lore.kernel.org/linux-mm/20211124145219.32866-1-sj@kernel.org/)
- Avoid copy-and-pasting usleep_delay() in DAMON code (Andrew Morton)

SeongJae Park (2):
  timers: Implement usleep_idle_range()
  mm/damon/core: Fix fake load reports due to uninterruptible sleeps

 include/linux/delay.h | 14 +++++++++++++-
 kernel/time/timer.c   | 16 +++++++++-------
 mm/damon/core.c       |  6 +++---
 3 files changed, 25 insertions(+), 11 deletions(-)

Comments

Oleksandr Natalenko Nov. 26, 2021, 2:37 p.m. UTC | #1 
Hello.

On čtvrtek 25. listopadu 2021 17:08:28 CET SeongJae Park wrote:
> This patchset fixes DAMON's fake load report issue.  The first patch
> makes yet another variant of usleep_range() for this fix, and the second
> patch fixes the issue of DAMON by making it using the newly introduced
> function.
> 
> I think these need to be applied on v5.15.y, but the second patch cannot
> cleanly applied there as is.  I will back-port this on v5.15.y and post
> later once this is merged in the mainline.  If you think this is not
> appropriate for stable tree, please let me know.
> 
> Changelog
> ---------
> 
> >From v1
> 
> (https://lore.kernel.org/linux-mm/20211124145219.32866-1-sj@kernel.org/)
> - Avoid copy-and-pasting usleep_delay() in DAMON code (Andrew Morton)
> 
> SeongJae Park (2):
>   timers: Implement usleep_idle_range()
>   mm/damon/core: Fix fake load reports due to uninterruptible sleeps
> 
>  include/linux/delay.h | 14 +++++++++++++-
>  kernel/time/timer.c   | 16 +++++++++-------
>  mm/damon/core.c       |  6 +++---
>  3 files changed, 25 insertions(+), 11 deletions(-)

I'd appreciate if you Cc me as a reporter since I'm going to test this.

Thanks.
SeongJae Park Nov. 26, 2021, 2:41 p.m. UTC | #2 
On Fri, 26 Nov 2021 15:37:12 +0100 Oleksandr Natalenko <oleksandr@natalenko.name> wrote:

> Hello.
> 
> On čtvrtek 25. listopadu 2021 17:08:28 CET SeongJae Park wrote:
> > This patchset fixes DAMON's fake load report issue.  The first patch
> > makes yet another variant of usleep_range() for this fix, and the second
> > patch fixes the issue of DAMON by making it using the newly introduced
> > function.
> > 
> > I think these need to be applied on v5.15.y, but the second patch cannot
> > cleanly applied there as is.  I will back-port this on v5.15.y and post
> > later once this is merged in the mainline.  If you think this is not
> > appropriate for stable tree, please let me know.
> > 
> > Changelog
> > ---------
> > 
> > >From v1
> > 
> > (https://lore.kernel.org/linux-mm/20211124145219.32866-1-sj@kernel.org/)
> > - Avoid copy-and-pasting usleep_delay() in DAMON code (Andrew Morton)
> > 
> > SeongJae Park (2):
> >   timers: Implement usleep_idle_range()
> >   mm/damon/core: Fix fake load reports due to uninterruptible sleeps
> > 
> >  include/linux/delay.h | 14 +++++++++++++-
> >  kernel/time/timer.c   | 16 +++++++++-------
> >  mm/damon/core.c       |  6 +++---
> >  3 files changed, 25 insertions(+), 11 deletions(-)
> 
> I'd appreciate if you Cc me as a reporter since I'm going to test this.

Oops, sorry for forgetting that.  I also forgot adding 'Suggested-by:' for
Andrew Morton on the first patch.  I will do that and resend, Cc-ing you.

> 
> Thanks.
> 
> -- 
> Oleksandr Natalenko (post-factum)
>