From patchwork Thu Dec 16 11:23:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kefeng Wang X-Patchwork-Id: 12680687 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98FFEC433EF for ; Thu, 16 Dec 2021 11:14:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 295D16B0075; Thu, 16 Dec 2021 06:14:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2442D6B007E; Thu, 16 Dec 2021 06:14:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14EAC6B0078; Thu, 16 Dec 2021 06:14:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 066FB6B0074 for ; Thu, 16 Dec 2021 06:14:12 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BF14C18084F54 for ; Thu, 16 Dec 2021 11:14:01 +0000 (UTC) X-FDA: 78923397882.15.8E4A009 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf05.hostedemail.com (Postfix) with ESMTP id 3139C10000B for ; Thu, 16 Dec 2021 11:14:00 +0000 (UTC) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4JF8ZQ0B4xz8vpZ; Thu, 16 Dec 2021 19:11:42 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 16 Dec 2021 19:13:56 +0800 Received: from localhost.localdomain.localdomain (10.175.113.25) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 16 Dec 2021 19:13:55 +0800 From: Kefeng Wang To: , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH 0/4] mm: percpu: Cleanup percpu first chunk function Date: Thu, 16 Dec 2021 19:23:55 +0800 Message-ID: <20211216112359.103822-1-wangkefeng.wang@huawei.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3139C10000B X-Stat-Signature: 5mnyxawn3ety5ct37dzbha5b789t431x Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-HE-Tag: 1639653240-341941 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When support page mapping percpu first chunk allocator on arm64, we found there are lots of duplicated codes in percpu embed/page first chunk allocator. This patchset is aimed to cleanup them and should no function change. The currently supported status about 'embed' and 'page' in Archs shows below, embed: NEED_PER_CPU_PAGE_FIRST_CHUNK page: NEED_PER_CPU_EMBED_FIRST_CHUNK embed page ------------------------ arm64 Y Y mips Y N powerpc Y Y riscv Y N sparc Y Y x86 Y Y ------------------------ There are two interfaces about percpu first chunk allocator, extern int __init pcpu_embed_first_chunk(size_t reserved_size, size_t dyn_size, size_t atom_size, pcpu_fc_cpu_distance_fn_t cpu_distance_fn, - pcpu_fc_alloc_fn_t alloc_fn, - pcpu_fc_free_fn_t free_fn); + pcpu_fc_cpu_to_node_fn_t cpu_to_nd_fn); extern int __init pcpu_page_first_chunk(size_t reserved_size, - pcpu_fc_alloc_fn_t alloc_fn, - pcpu_fc_free_fn_t free_fn, - pcpu_fc_populate_pte_fn_t populate_pte_fn); + pcpu_fc_cpu_to_node_fn_t cpu_to_nd_fn); The pcpu_fc_alloc_fn_t/pcpu_fc_free_fn_t is killed, we provide generic pcpu_fc_alloc() and pcpu_fc_free() function, which are called in the pcpu_embed/page_first_chunk(). 1) For pcpu_embed_first_chunk(), pcpu_fc_cpu_to_node_fn_t is needed to be provided when archs supported NUMA. 2) For pcpu_page_first_chunk(), the pcpu_fc_populate_pte_fn_t is killed too, a generic pcpu_populate_pte() which marked '__weak' is provided, if you need a different function to populate pte on the arch(like x86), please provide its own implementation. I have been built test on arm64/ia64/mips/powerpc/sparcx86/riscv based on v5.16-rc4 on my machine, also all patches are in[1], which checked by lkp too, [kevin78:percpu-cleanup] BUILD SUCCESS c14a59a0aad7db88ebddbeb5e914ddcccb406e1c. [1] https://github.com/kevin78/linux.git percpu-cleanup Changes since RFC - Address Dennis's comments RFC: https://lore.kernel.org/linux-mm/4fecd1ac-6c0a-f0fa-1ffb-18f3f266809d@huawei.com/T/ Kefeng Wang (4): mm: percpu: Generalize percpu related config mm: percpu: Add pcpu_fc_cpu_to_node_fn_t typedef mm: percpu: Add generic pcpu_fc_alloc/free funciton mm: percpu: Add generic pcpu_populate_pte() function arch/arm64/Kconfig | 20 +---- arch/ia64/Kconfig | 9 +- arch/mips/Kconfig | 10 +-- arch/mips/mm/init.c | 14 +-- arch/powerpc/Kconfig | 17 +--- arch/powerpc/kernel/setup_64.c | 97 ++------------------- arch/riscv/Kconfig | 10 +-- arch/sparc/Kconfig | 12 +-- arch/sparc/kernel/smp_64.c | 103 +--------------------- arch/x86/Kconfig | 17 +--- arch/x86/kernel/setup_percpu.c | 66 ++------------ drivers/base/arch_numa.c | 68 +-------------- include/linux/percpu.h | 13 +-- mm/Kconfig | 12 +++ mm/percpu.c | 154 +++++++++++++++++++++++++-------- 15 files changed, 180 insertions(+), 442 deletions(-)