| Message ID | 20220218102611.31895-1-tome01@ajou.ac.kr (mailing list archive) |
|---|---|
| Headers | show |
| Series | Rebase DAMON_RECALIM for NUMA system | expand |
Hello Jonghyeon, On Fri, 18 Feb 2022 19:26:08 +0900 Jonghyeon Kim <tome01@ajou.ac.kr> wrote: > > Current DAMON_RECALIM is not compatible with the NUMA memory system. To > proactively reclaim memory, DAMON_RECLAIM kernel thread(kdamond) has to wake up > before kswapd does reclaim memory. However, the current watermark for proactive > reclamation is based on entire system free memory. So, though the one memory > node is fully used, kdamond is not waked up. > > These patches clarify watermarks of DAMOS and enable monitoring per NUMA node > proactive reclamation on DAMON_RECLAIM. The high level concept of this patchset looks good to me. Nevertheless, maybe there is some rooms for improvement. I left some comments on patches. Thanks, SJ > > Jonghyeon Kim (3): > mm/damon: Rebase damos watermarks for NUMA systems > mm/damon/core: Add damon_start_one() > mm/damon/reclaim: Add per NUMA node proactive reclamation by > DAMON_RECLAIM. > > include/linux/damon.h | 3 + > mm/damon/core.c | 39 +++++++++-- > mm/damon/reclaim.c | 147 ++++++++++++++++++++++++++++++------------ > 3 files changed, 140 insertions(+), 49 deletions(-) > > -- > 2.17.1
On Wed, Feb 23, 2022 at 02:11:46PM +0900, Jonghyeon Kim wrote: > On Tue, Feb 22, 2022 at 09:53:02AM +0000, SeongJae Park wrote: > > Hello Jonghyeon, > > > > On Fri, 18 Feb 2022 19:26:08 +0900 Jonghyeon Kim <tome01@ajou.ac.kr> wrote: > > > > > > > > Current DAMON_RECALIM is not compatible with the NUMA memory system. To > > > proactively reclaim memory, DAMON_RECLAIM kernel thread(kdamond) has to wake up > > > before kswapd does reclaim memory. However, the current watermark for proactive > > > reclamation is based on entire system free memory. So, though the one memory > > > node is fully used, kdamond is not waked up. > > > > > > These patches clarify watermarks of DAMOS and enable monitoring per NUMA node > > > proactive reclamation on DAMON_RECLAIM. > > > > The high level concept of this patchset looks good to me. Nevertheless, maybe > > there is some rooms for improvement. I left some comments on patches. > > > > > > Thanks, > > SJ > > > > Hello SeongJae, > > Thanks for your patient comments about these patches. I will clean up and > develop these patches including your suggestion and correction in next version. > > > Jonghyeon
Current DAMON_RECALIM is not compatible with the NUMA memory system. To proactively reclaim memory, DAMON_RECLAIM kernel thread(kdamond) has to wake up before kswapd does reclaim memory. However, the current watermark for proactive reclamation is based on entire system free memory. So, though the one memory node is fully used, kdamond is not waked up. These patches clarify watermarks of DAMOS and enable monitoring per NUMA node proactive reclamation on DAMON_RECLAIM. Jonghyeon Kim (3): mm/damon: Rebase damos watermarks for NUMA systems mm/damon/core: Add damon_start_one() mm/damon/reclaim: Add per NUMA node proactive reclamation by DAMON_RECLAIM. include/linux/damon.h | 3 + mm/damon/core.c | 39 +++++++++-- mm/damon/reclaim.c | 147 ++++++++++++++++++++++++++++++------------ 3 files changed, 140 insertions(+), 49 deletions(-)