mbox series

[v7,0/4] Implement readahead for squashfs

Message ID 20220617083810.337573-1-hsinyi@chromium.org (mailing list archive)
Headers show
Series Implement readahead for squashfs | expand

Message

Hsin-Yi Wang June 17, 2022, 8:38 a.m. UTC
Commit 9eec1d897139("squashfs: provide backing_dev_info in order to
disable read-ahead") mitigates the performance drop issue for squashfs
by closing readahead for it.

This series implements readahead callback for squashfs. The previous
discussions are in [1] and [2].

[1]
https://lore.kernel.org/all/CAJMQK-g9G6KQmH-V=BRGX0swZji9Wxe_2c7ht-MMAapdFy2pXw@mail.gmail.com/T/
[2]
https://lore.kernel.org/linux-mm/Yn5Yij9pRPCzDozt@casper.infradead.org/t/#m4af4473b94f98a4996cb11756b633a07e5e059d1

v7 adds the patch to support reading fragments in readahead call[3]. No
changes on other patches since v6, which is included in next-20220617.

[3]
https://patchwork.kernel.org/project/linux-mm/patch/20220617030345.24712-1-phillip@squashfs.org.uk/

Hsin-Yi Wang (2):
  Revert "squashfs: provide backing_dev_info in order to disable
    read-ahead"
  squashfs: implement readahead

Phillip Lougher (2):
  squashfs: always build "file direct" version of page actor
  squashfs: support reading fragments in readahead call

 fs/squashfs/Makefile     |   4 +-
 fs/squashfs/file.c       | 133 ++++++++++++++++++++++++++++++++++++++-
 fs/squashfs/page_actor.h |  46 --------------
 fs/squashfs/super.c      |  33 ----------
 4 files changed, 134 insertions(+), 82 deletions(-)

Comments

Phillip Lougher June 21, 2022, 2:36 a.m. UTC | #1
On 17/06/2022 09:38, Hsin-Yi Wang wrote:
> Commit 9eec1d897139("squashfs: provide backing_dev_info in order to
> disable read-ahead") mitigates the performance drop issue for squashfs
> by closing readahead for it.
> 
> This series implements readahead callback for squashfs. The previous
> discussions are in [1] and [2].

Patch series looks OK to me.

I will be offline at the Glastonbury festival from Tuesday 21 June to
Monday 27 June.

Thanks

Phillip

> 
> [1]
> https://lore.kernel.org/all/CAJMQK-g9G6KQmH-V=BRGX0swZji9Wxe_2c7ht-MMAapdFy2pXw@mail.gmail.com/T/
> [2]
> https://lore.kernel.org/linux-mm/Yn5Yij9pRPCzDozt@casper.infradead.org/t/#m4af4473b94f98a4996cb11756b633a07e5e059d1
> 
> v7 adds the patch to support reading fragments in readahead call[3]. No
> changes on other patches since v6, which is included in next-20220617.
> 
> [3]
> https://patchwork.kernel.org/project/linux-mm/patch/20220617030345.24712-1-phillip@squashfs.org.uk/
> 
> Hsin-Yi Wang (2):
>    Revert "squashfs: provide backing_dev_info in order to disable
>      read-ahead"
>    squashfs: implement readahead
> 
> Phillip Lougher (2):
>    squashfs: always build "file direct" version of page actor
>    squashfs: support reading fragments in readahead call
> 
>   fs/squashfs/Makefile     |   4 +-
>   fs/squashfs/file.c       | 133 ++++++++++++++++++++++++++++++++++++++-
>   fs/squashfs/page_actor.h |  46 --------------
>   fs/squashfs/super.c      |  33 ----------
>   4 files changed, 134 insertions(+), 82 deletions(-)
>