[RFC,0/2] Introduce cgroup.top interface

Message

Lu Jialin Aug. 26, 2022, 1:15 a.m. UTC

Cgroup is used to organize and manage resource available processes.
Currently there are no handy tool for gathering reousrce usage
information for each and every child cgroups, makes it hard to detect
resource outage and debug resource issues.

To overcome this, we present the cgroup.top interface. Just like the
top command, user is able to easily gather resource usage information
, allowing user to detect and respond to resource outage in child
cgroups

Show case:
/ # mount -t cgroup2 none /sys/fs/cgroup
/ # cd /sys/fs/cgroup/
/sys/fs/cgroup # echo "+memory" > cgroup.subtree_control
/sys/fs/cgroup # mkdir test1
/sys/fs/cgroup # mkdir test2
/sys/fs/cgroup # mkdir test3
/sys/fs/cgroup # echo $$ > test2/cgroup.procs
/sys/fs/cgroup # cd /test
/test # ./memcg_malloc 512000 &
/test # ./memcg_malloc 512000 &
/test # ./memcg_malloc 512000 &
/test # cd /sys/fs/cgroup
/sys/fs/cgroup # echo $$ > test1/cgroup.procs
/sys/fs/cgroup # cd /test
/test # ./memcg_malloc 512000 &
/test # cd /sys/fs/cgroup
/sys/fs/cgroup # echo $$ > test3/cgroup.procs
/sys/fs/cgroup # cat cgroup.top
memory top:
name            usage           anon            file            kernel
test2           1974272         1671168         0               270336
test1           700416          569344          0               94208
test3           196608          86016           0               86016


Lu Jialin (1):
  memcg: Adapt cgroup.top into per-memcg

Xiu Jianfeng (1):
  cgroup: Introduce per-cgroup resource top show interface

 include/linux/cgroup-defs.h |  1 +
 kernel/cgroup/cgroup.c      | 20 +++++++++
 mm/memcontrol.c             | 87 +++++++++++++++++++++++++++++++++++++
 3 files changed, 108 insertions(+)

Comments

Tejun Heo Aug. 26, 2022, 3:17 a.m. UTC | #1

Hello,

On Fri, Aug 26, 2022 at 09:15:01AM +0800, Lu Jialin wrote:
> Cgroup is used to organize and manage resource available processes.
> Currently there are no handy tool for gathering reousrce usage
> information for each and every child cgroups, makes it hard to detect
> resource outage and debug resource issues.
> 
> To overcome this, we present the cgroup.top interface. Just like the
> top command, user is able to easily gather resource usage information
> , allowing user to detect and respond to resource outage in child
> cgroups

I don't think this is something we want build into the kernel. Maybe what
you want is something similar to below?

  https://github.com/facebookincubator/below

Thanks.

Lu Jialin Aug. 26, 2022, 9:50 a.m. UTC | #2

Ok, I got it, thanks

在 2022/8/26 11:17, Tejun Heo 写道:
> Hello,
>
> On Fri, Aug 26, 2022 at 09:15:01AM +0800, Lu Jialin wrote:
>> Cgroup is used to organize and manage resource available processes.
>> Currently there are no handy tool for gathering reousrce usage
>> information for each and every child cgroups, makes it hard to detect
>> resource outage and debug resource issues.
>>
>> To overcome this, we present the cgroup.top interface. Just like the
>> top command, user is able to easily gather resource usage information
>> , allowing user to detect and respond to resource outage in child
>> cgroups
> I don't think this is something we want build into the kernel. Maybe what
> you want is something similar to below?
>
>    https://github.com/facebookincubator/below
>
> Thanks.
>