mbox series

[v2,0/7] Add basic trace events for vmap/vmalloc (v2)

Message ID 20221018181053.434508-1-urezki@gmail.com (mailing list archive)
Headers show
Series Add basic trace events for vmap/vmalloc (v2) | expand

Message

Uladzislau Rezki (Sony) Oct. 18, 2022, 6:10 p.m. UTC 
Description is here https://lore.kernel.org/linux-mm/20221017160233.16582-1-urezki@gmail.com/

Changelog v1 -> v2:
- Fix a compilation error for the ARCH=um SUBARCH=i386

Uladzislau Rezki (Sony) (7):
  mm: vmalloc: Add alloc_vmap_area trace event
  mm: vmalloc: Add purge_vmap_area_lazy trace event
  mm: vmalloc: Add free_vmap_area_noflush trace event
  mm: vmalloc: Use trace_alloc_vmap_area event
  mm: vmalloc: Use trace_purge_vmap_area_lazy event
  mm: vmalloc: Use trace_free_vmap_area_noflush event
  vmalloc: Add reviewers for vmalloc code

 MAINTAINERS                    |  12 +++-
 include/trace/events/vmalloc.h | 123 +++++++++++++++++++++++++++++++++
 mm/vmalloc.c                   |  20 +++++-
 3 files changed, 151 insertions(+), 4 deletions(-)
 create mode 100644 include/trace/events/vmalloc.h

Comments

Steven Rostedt Oct. 18, 2022, 6:23 p.m. UTC | #1 
On Tue, 18 Oct 2022 20:10:46 +0200
"Uladzislau Rezki (Sony)" <urezki@gmail.com> wrote:

> Description is here https://lore.kernel.org/linux-mm/20221017160233.16582-1-urezki@gmail.com/

You should always copy the description in each version. It's annoying to
have to click a link from a console email client.

Anyway, it's pretty basic trace events.

For POV of tracing (not the usage of it)

Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>

for the entire series.

-- Steve

> 
> Changelog v1 -> v2:
> - Fix a compilation error for the ARCH=um SUBARCH=i386
> 
> Uladzislau Rezki (Sony) (7):
>   mm: vmalloc: Add alloc_vmap_area trace event
>   mm: vmalloc: Add purge_vmap_area_lazy trace event
>   mm: vmalloc: Add free_vmap_area_noflush trace event
>   mm: vmalloc: Use trace_alloc_vmap_area event
>   mm: vmalloc: Use trace_purge_vmap_area_lazy event
>   mm: vmalloc: Use trace_free_vmap_area_noflush event
>   vmalloc: Add reviewers for vmalloc code
> 
>  MAINTAINERS                    |  12 +++-
>  include/trace/events/vmalloc.h | 123 +++++++++++++++++++++++++++++++++
>  mm/vmalloc.c                   |  20 +++++-
>  3 files changed, 151 insertions(+), 4 deletions(-)
>  create mode 100644 include/trace/events/vmalloc.h
>
Steven Rostedt Oct. 18, 2022, 6:25 p.m. UTC | #2 
On Tue, 18 Oct 2022 14:23:02 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> > Description is here https://lore.kernel.org/linux-mm/20221017160233.16582-1-urezki@gmail.com/  
> 
> You should always copy the description in each version. It's annoying to
> have to click a link from a console email client.

Although, what I do is, include the previous version when talking about
differences in this version. That way the link to the old series can be
easily found.

> Changelog v1 -> v2: (https://lore.kernel.org/linux-mm/20221017160233.16582-1-urezki@gmail.com/)

-- Steve
Uladzislau Rezki (Sony) Oct. 19, 2022, 11:49 a.m. UTC | #3 
On Tue, Oct 18, 2022 at 02:25:09PM -0400, Steven Rostedt wrote:
> On Tue, 18 Oct 2022 14:23:02 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > > Description is here https://lore.kernel.org/linux-mm/20221017160233.16582-1-urezki@gmail.com/  
> > 
> > You should always copy the description in each version. It's annoying to
> > have to click a link from a console email client.
> 
> Although, what I do is, include the previous version when talking about
> differences in this version. That way the link to the old series can be
> easily found.
> 
OK. Thanks for the review!

--
Uladzislau Rezki
Christoph Hellwig Oct. 20, 2022, 11:22 a.m. UTC | #4 
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>