From patchwork Mon Oct 31 22:25:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Song Liu X-Patchwork-Id: 13026420 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD885ECAAA1 for ; Mon, 31 Oct 2022 22:25:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E9E36B0072; Mon, 31 Oct 2022 18:25:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 199B66B0073; Mon, 31 Oct 2022 18:25:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 088D16B0074; Mon, 31 Oct 2022 18:25:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E94C36B0072 for ; Mon, 31 Oct 2022 18:25:55 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 97874C0EBC for ; Mon, 31 Oct 2022 22:25:55 +0000 (UTC) X-FDA: 80082678270.18.468DB72 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf16.hostedemail.com (Postfix) with ESMTP id 2CB5A180004 for ; Mon, 31 Oct 2022 22:25:54 +0000 (UTC) Received: from pps.filterd (m0148461.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29VMPDVF013522 for ; Mon, 31 Oct 2022 15:25:54 -0700 Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3kh19tk5eg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 31 Oct 2022 15:25:54 -0700 Received: from twshared13940.35.frc1.facebook.com (2620:10d:c0a8:1b::d) by mail.thefacebook.com (2620:10d:c0a8:83::4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct 2022 15:25:52 -0700 Received: by devbig932.frc1.facebook.com (Postfix, from userid 4523) id 1D1CAF0CC5A7; Mon, 31 Oct 2022 15:25:48 -0700 (PDT) From: Song Liu To: , CC: , , , , , , , Song Liu Subject: [PATCH bpf-next v1 RESEND 0/5] vmalloc_exec for modules and BPF programs Date: Mon, 31 Oct 2022 15:25:36 -0700 Message-ID: <20221031222541.1773452-1-song@kernel.org> X-Mailer: git-send-email 2.30.2 X-FB-Internal: Safe X-Proofpoint-GUID: CNOAog-v7RyH7-ZfkVIWsteMzDVPsEjH X-Proofpoint-ORIG-GUID: CNOAog-v7RyH7-ZfkVIWsteMzDVPsEjH X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-31_21,2022-10-31_01,2022-06-22_01 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667255155; a=rsa-sha256; cv=none; b=B+/JQyDgwKLrf4REokAe8pmfwm7UsW7XmiXK+0skCfE/khMtLGZxtibpg7QscrwNFIuUZ1 i6vKyHJc/Re3aVMiiBJFOq0Pn8H/7UN6ouhZsq6XorR//Y1/ut9gkTe57rHh/ksSGdDGP0 R+Xj1ttEWcL/YqlEW2csjZR9xf0Y9u0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of "prvs=2303bf8861=songliubraving@meta.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=2303bf8861=songliubraving@meta.com"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667255155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=c2R/Ooc1cGxqKaXUT6xMs/Vs/OmT8+6U/sM3Hea53ek=; b=ETDqwKhahwAh2kAedXl+xIRbgHi7jXTmHdCiKtlZbSAqAyt7Xa3N3nOXXTmFYq4YR1pSWB DAXUxLM+kGpzuG+mOAR+kyoI0fcTI06UHE1VVd67sT88Yit8Sfrrf/9XaKRn5hwXS16TAF Z+u0isNbgsNvy+hLNJBFKM1mjflLn3k= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2CB5A180004 X-Rspam-User: X-Stat-Signature: gwnf7h1wzwka4emxwpck7dhbgkipxmey Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of "prvs=2303bf8861=songliubraving@meta.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=2303bf8861=songliubraving@meta.com"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) X-HE-Tag: 1667255154-30480 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Original email didn't make to lore, resend with a shorter CC list. This set enables bpf programs and bpf dispatchers to share huge pages with new API: vmalloc_exec() vfree_exec() vcopy_exec() The idea is similar to Peter's suggestion in [1]. vmalloc_exec() manages a set of PMD_SIZE RO+X memory, and allocates these memory to its users. vfree_exec() is used to free memory allocated by vmalloc_exec(). vcopy_exec() is used to update memory allocated by vmalloc_exec(). Memory allocated by vmalloc_exec() is RO+X, so this doesnot violate W^X. The caller has to update the content with text_poke like mechanism. Specifically, vcopy_exec() is provided to update memory allocated by vmalloc_exec(). vcopy_exec() also makes sure the update stays in the boundary of one chunk allocated by vmalloc_exec(). Please refer to patch 1/5 for more details of Patch 3/5 uses these new APIs in bpf program and bpf dispatcher. Patch 4/5 and 5/5 allows static kernel text (_stext to _etext) to share PMD_SIZE pages with dynamic kernel text on x86_64. This is achieved by allocating PMD_SIZE pages to roundup(_etext, PMD_SIZE), and then use _etext to roundup(_etext, PMD_SIZE) for dynamic kernel text. [1] https://lore.kernel.org/bpf/Ys6cWUMHO8XwyYgr@hirez.programming.kicks-ass.net/ [2] RFC v1: https://lore.kernel.org/linux-mm/20220818224218.2399791-3-song@kernel.org/T/ Changes RFC v2 => PATCH v1: 1. Add vcopy_exec(), which updates memory allocated by vmalloc_exec(). It also ensures vcopy_exec() is only used to update memory from one single vmalloc_exec() call. (Christoph Hellwig) 2. Add arch_vcopy_exec() and arch_invalidate_exec() as wrapper for the text_poke() like logic. 3. Drop changes for kernel modules and focus on BPF side changes. Changes RFC v1 => RFC v2: 1. Major rewrite of the logic of vmalloc_exec and vfree_exec. They now work fine with BPF programs (patch 1, 2, 4). But module side (patch 3) still need some work. Song Liu (5): vmalloc: introduce vmalloc_exec, vfree_exec, and vcopy_exec x86/alternative: support vmalloc_exec() and vfree_exec() bpf: use vmalloc_exec for bpf program and bpf dispatcher vmalloc: introduce register_text_tail_vm() x86: use register_text_tail_vm arch/x86/include/asm/pgtable_64_types.h | 1 + arch/x86/kernel/alternative.c | 12 + arch/x86/mm/init_64.c | 4 +- arch/x86/net/bpf_jit_comp.c | 23 +- include/linux/bpf.h | 3 - include/linux/filter.h | 5 - include/linux/vmalloc.h | 9 + kernel/bpf/core.c | 180 +----------- kernel/bpf/dispatcher.c | 11 +- mm/nommu.c | 7 + mm/vmalloc.c | 351 ++++++++++++++++++++++++ 11 files changed, 404 insertions(+), 202 deletions(-) --- 2.30.2