From patchwork Wed Nov 2 16:10:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vishal Moola X-Patchwork-Id: 13028379 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DABF5C4332F for ; Wed, 2 Nov 2022 16:11:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 606538E0002; Wed, 2 Nov 2022 12:11:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B6F28E0001; Wed, 2 Nov 2022 12:11:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47E118E0002; Wed, 2 Nov 2022 12:11:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 393088E0001 for ; Wed, 2 Nov 2022 12:11:09 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B1E6C412AC for ; Wed, 2 Nov 2022 16:11:08 +0000 (UTC) X-FDA: 80088991416.30.540BFA3 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf30.hostedemail.com (Postfix) with ESMTP id 129D580005 for ; Wed, 2 Nov 2022 16:11:07 +0000 (UTC) Received: by mail-pf1-f174.google.com with SMTP id 130so16834644pfu.8 for ; Wed, 02 Nov 2022 09:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Mngda3aHEeBTLGy2LfOMAwbMGwmKJm3kMZgi9Ib34ls=; b=CzwkZPeCCOjWsyC7BlL9IBJTrlmYa77xNpFSOioq+e8OPdv5fbZ/zAK/WD5VaCSnaf 5wiT7RR/cG5GPZCjJ+Co+cRbnq0d7qvJjY3sdWpdys5S6A8w0OZe4/5smnTYFKe3NLzZ 5wcozYB2mpTn2ymfQyRigL4lpLb5qvdDX4Kdyh4H+2z75vNY4RC4jXXiiTVaGfLOy97h uLbe3bGG1wM1TT2K00V5wMH2vpszUj/G4ZhsAUVnBiAEAK3CxOz0DxDqHYdVVOTDhWjV zp2OhnRtDn0qTZBfVT4zVHKT7w33B/qlC8Fh+c591akUyRXj9kHwG407cxvWxSpLW5pP 0PDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Mngda3aHEeBTLGy2LfOMAwbMGwmKJm3kMZgi9Ib34ls=; b=JN5N+F8SFvmBxvZrYqHmzfy593x8UK4C/9D4M+nx06seB1bcemVwF8ZQ7tUpRExP4X 6Cygw1v+0dfrPbwrXumPUDDFzsV0d1XQPAq8XZ0kWosKhv2OeehiDu4Bq9kVuSdsCdTt f+YQjO9YcODo1dyICb3NKVpt6JPTgdVM9rUpF/jMRKoYw3CDKwT/TZB82xBDDPTLDJ4c FJQDKlTkJfUDjBgYYIL0MR9ROnyGXxMOxJqtf28c1/0tBWMTqUD/5lW6GyASYVps86ht DoAG6ywG/hFfLy7nCmH1SFae/fpIiDfVkPb90xlFOvvxPTDfoELF13TEWiSqm3BYM2DP e2uQ== X-Gm-Message-State: ACrzQf1gp444LWfwEfYTcbUrFzU+3u3nJASjFeIgAkadEcA3/CkPx3v1 Cf0cnD3h8k0J0Q8d1683AaM= X-Google-Smtp-Source: AMsMyM7hDOKBTXi34y4zB4HRcT4xPCgGrRzz1Zqhk7+jgpV1qJt102zpwOy+bMEbiQ6tv1xeWLGSXw== X-Received: by 2002:a05:6a00:88f:b0:52c:6962:274f with SMTP id q15-20020a056a00088f00b0052c6962274fmr26591050pfj.12.1667405466831; Wed, 02 Nov 2022 09:11:06 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:8002:1c20::8080]) by smtp.googlemail.com with ESMTPSA id ms4-20020a17090b234400b00210c84b8ae5sm1632101pjb.35.2022.11.02.09.11.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 09:11:06 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nilfs@vger.kernel.org, linux-mm@kvack.org, "Vishal Moola (Oracle)" Subject: [PATCH v4 00/23] Convert to filemap_get_folios_tag() Date: Wed, 2 Nov 2022 09:10:08 -0700 Message-Id: <20221102161031.5820-1-vishal.moola@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667405468; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=Mngda3aHEeBTLGy2LfOMAwbMGwmKJm3kMZgi9Ib34ls=; b=HFEnxTtISpGB1YoV02xdohEohz2tnuyGIcVvac0dLlYZO5N/vh5HeH228v4wBu7XomLmyW rhPhW78TVtl8lLELJ40kPR24YlQ4VVsRiIQDm3yQtDCtDp24hfJr9wYJQGePKY39T90Btf O7f0hA9icSzAg0/im3b0DIKeT1IjcQ8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=CzwkZPeC; spf=pass (imf30.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667405468; a=rsa-sha256; cv=none; b=hY3jHGdV82II43EulcPWBL/KLLbiNndtTGADDfvEhRg3Dl7u7OH/h2/KX54PVsHOglwyQ5 tG/Mr11Qu4RovbA9i4KeyL9iFFcFVQpGqPBKsPGIToGKvIT66m+RF11ziLvtkTZ8rbl/o2 glf66xcLyaeIT67IgpA1n0riX97mUzk= X-Stat-Signature: rewy15kpxji6w7kw3sxx8xjmh3oycnq3 X-Rspamd-Queue-Id: 129D580005 X-Rspamd-Server: rspam06 X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=CzwkZPeC; spf=pass (imf30.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1667405467-530854 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This patch series replaces find_get_pages_range_tag() with filemap_get_folios_tag(). This also allows the removal of multiple calls to compound_head() throughout. It also makes a good chunk of the straightforward conversions to folios, and takes the opportunity to introduce a function that grabs a folio from the pagecache. F2fs and Ceph have quite a lot of work to be done regarding folios, so for now those patches only have the changes necessary for the removal of find_get_pages_range_tag(), and only support folios of size 1 (which is all they use right now anyways). I've run xfstests on btrfs, ext4, f2fs, and nilfs2, but more testing may be beneficial. The page-writeback and filemap changes implicitly work. Testing and review of the other changes (afs, ceph, cifs, gfs2) would be appreciated. --- v4: Fixed a bug with reference counting in cifs changes - Reported-by: kernel test robot Improved commit messages to be more meaningful Got some Acked-bys and Reviewed-bys v3: Rebased onto upstream 6.1 Simplified the ceph patch to only necessary changes Changed commit messages throughout to be clearer Got an Acked-by for another nilfs patch Got Tested-by for afs v2: Got Acked-By tags for nilfs and btrfs changes Fixed an error arising in f2fs - Reported-by: kernel test robot Vishal Moola (Oracle) (23): pagemap: Add filemap_grab_folio() filemap: Added filemap_get_folios_tag() filemap: Convert __filemap_fdatawait_range() to use filemap_get_folios_tag() page-writeback: Convert write_cache_pages() to use filemap_get_folios_tag() afs: Convert afs_writepages_region() to use filemap_get_folios_tag() btrfs: Convert btree_write_cache_pages() to use filemap_get_folio_tag() btrfs: Convert extent_write_cache_pages() to use filemap_get_folios_tag() ceph: Convert ceph_writepages_start() to use filemap_get_folios_tag() cifs: Convert wdata_alloc_and_fillpages() to use filemap_get_folios_tag() ext4: Convert mpage_prepare_extent_to_map() to use filemap_get_folios_tag() f2fs: Convert f2fs_fsync_node_pages() to use filemap_get_folios_tag() f2fs: Convert f2fs_flush_inline_data() to use filemap_get_folios_tag() f2fs: Convert f2fs_sync_node_pages() to use filemap_get_folios_tag() f2fs: Convert f2fs_write_cache_pages() to use filemap_get_folios_tag() f2fs: Convert last_fsync_dnode() to use filemap_get_folios_tag() f2fs: Convert f2fs_sync_meta_pages() to use filemap_get_folios_tag() gfs2: Convert gfs2_write_cache_jdata() to use filemap_get_folios_tag() nilfs2: Convert nilfs_lookup_dirty_data_buffers() to use filemap_get_folios_tag() nilfs2: Convert nilfs_lookup_dirty_node_buffers() to use filemap_get_folios_tag() nilfs2: Convert nilfs_btree_lookup_dirty_buffers() to use filemap_get_folios_tag() nilfs2: Convert nilfs_copy_dirty_pages() to use filemap_get_folios_tag() nilfs2: Convert nilfs_clear_dirty_pages() to use filemap_get_folios_tag() filemap: Remove find_get_pages_range_tag() fs/afs/write.c | 114 +++++++++++++++++++++------------------- fs/btrfs/extent_io.c | 57 ++++++++++---------- fs/ceph/addr.c | 58 ++++++++++---------- fs/cifs/file.c | 32 +++++++++-- fs/ext4/inode.c | 55 ++++++++++--------- fs/f2fs/checkpoint.c | 49 +++++++++-------- fs/f2fs/compress.c | 13 ++--- fs/f2fs/data.c | 69 +++++++++++++----------- fs/f2fs/f2fs.h | 5 +- fs/f2fs/node.c | 72 +++++++++++++------------ fs/gfs2/aops.c | 64 ++++++++++++---------- fs/nilfs2/btree.c | 14 ++--- fs/nilfs2/page.c | 59 +++++++++++---------- fs/nilfs2/segment.c | 44 ++++++++-------- include/linux/pagemap.h | 32 +++++++---- include/linux/pagevec.h | 8 --- mm/filemap.c | 84 ++++++++++++++--------------- mm/page-writeback.c | 44 ++++++++-------- mm/swap.c | 10 ---- 19 files changed, 465 insertions(+), 418 deletions(-)