From patchwork Tue Dec 6 17:13:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Weiner X-Patchwork-Id: 13066169 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAEEDC352A1 for ; Tue, 6 Dec 2022 17:13:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 539F28E0005; Tue, 6 Dec 2022 12:13:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E7D88E0001; Tue, 6 Dec 2022 12:13:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AFFC8E0005; Tue, 6 Dec 2022 12:13:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2D0978E0001 for ; Tue, 6 Dec 2022 12:13:58 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A1EC5AB206 for ; Tue, 6 Dec 2022 17:13:57 +0000 (UTC) X-FDA: 80212528914.30.2118D9E Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf29.hostedemail.com (Postfix) with ESMTP id 13016120008 for ; Tue, 6 Dec 2022 17:13:56 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=U3JPE2wp; spf=pass (imf29.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.218.49 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670346837; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=aHW4AF6UbouyjsoQjAo93Rw4CHPKsRNQFiH676IJZhI=; b=WFmoYP/Yw2N2d3eCEfpTMELzUgUmhb2hg/xrW/K2P+jL+1R7Un3n7LTLZt7z5MuSROfVs2 C7Ql4M/qViXX+Hn5jphmCruFUy2PiLrkcLSQ8CWfCiL3zSTapZupSlmbXDOmtsUv+yyuUk jIR/aF14cMWQBswocPJVO08RuWa6WMY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=U3JPE2wp; spf=pass (imf29.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.218.49 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670346837; a=rsa-sha256; cv=none; b=ZYQ5KWaPY38b+T71qUW8N9ti+9N6/O50RspuNfwKkfTg3wZkyUCOzt7BOFGDH6uJn9Qrwv PzV8nw2pUwwK0jkeCawDyJ5A7d2RRrkiEY1X+jTuScfKfGonkIGOG0MCvQ07znN6IQRY/O dry2fGtJdj2OBGaxPleXUfJjRCu47m8= Received: by mail-ej1-f49.google.com with SMTP id n20so7948256ejh.0 for ; Tue, 06 Dec 2022 09:13:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aHW4AF6UbouyjsoQjAo93Rw4CHPKsRNQFiH676IJZhI=; b=U3JPE2wpoXJXzygCbWmscmBrgC7FK5UJNHsQONmaGZiZmH3+sgAYjnYd5Ls05NwlQM vONDSCbVwBJkvD+yFM9ZlH2UrOXI+N1akE2rtdo0FhyTxLbcXJNrdp0P8+pXIposb+UE IGcNcfKz8Y8mljOCpJv3hMRSWaepYsKExZQ89Ffqglmn9IibZIsuj3nOEpTrpsOKREm8 f5yPVKxG2TqfCm71/bP+FY8Zs7eq1s5zzjEyw9tPwFRlJlN4dRk6a6hyVJyj1p1wafID e4W96vxjpUtly6cSO2Kh3gkhCt0wDtzy0xrJ0UNTk96w+7FtOjPNllJxXrMYRQbjBwzd 7Ijw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aHW4AF6UbouyjsoQjAo93Rw4CHPKsRNQFiH676IJZhI=; b=aLY0KkNGG7bkq5JnNt6laWwsb+9GhM/0o5M5aI5Xk3RxN7jN1jctPfIANZ/rxzlsC+ okn8udG5TluK67KDVzUQR0KZIHO9QqWj/fydHSBUgr/eT56qqslnkT1OHoklJYatapfO WSVXE1OCkOXO6y6Z7KU8uPX2naYGlRi9F4DfbrXTYxrEtze3FtzdWU75rKYxdSZEMMb6 Ev4HA+BQRiyCwxlRh2Q465dyegBWKpUHy7G6GGqPth+iqdddaRnEpLlkwGekXydYrtOn OeiKNV4Ne93EYEn0CE/RaNVplZZyjJKJf6HzvfFSO4OKlgsWsLb52bC5WTQk8X21QHAG cMrg== X-Gm-Message-State: ANoB5pmqk2mWcuw6g45tPi9NC8Sh7JVsqfmM2CUfSk+kHUudc1xuVZ6U ++RIfkTraW3v49lf/EO48O812g== X-Google-Smtp-Source: AA0mqf5W2qYVz5F/48F3bnWfVdeE4oLgzzBVbetcU0AUNKL0OBDRXLlvzL52A5PMrRggIG/5SLHwQQ== X-Received: by 2002:a17:906:a107:b0:77f:9082:73c7 with SMTP id t7-20020a170906a10700b0077f908273c7mr56670721ejy.517.1670346835640; Tue, 06 Dec 2022 09:13:55 -0800 (PST) Received: from localhost ([2a02:8070:6387:ab20:15aa:3c87:c206:d15e]) by smtp.gmail.com with ESMTPSA id iy17-20020a170907819100b007c03fa39c33sm7515048ejc.71.2022.12.06.09.13.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 09:13:55 -0800 (PST) From: Johannes Weiner To: Andrew Morton Cc: Linus Torvalds , Hugh Dickins , Shakeel Butt , Michal Hocko , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/3] mm: push down lock_page_memcg() Date: Tue, 6 Dec 2022 18:13:38 +0100 Message-Id: <20221206171340.139790-1-hannes@cmpxchg.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Rspamd-Queue-Id: 13016120008 X-Stat-Signature: sdzemaz1wj7cscqpz9ywahnq7ya49ha8 X-Rspam-User: X-Spamd-Result: default: False [5.05 / 9.00]; SORBS_IRL_BL(3.00)[209.85.218.49:from]; BAYES_HAM(-2.55)[89.85%]; R_MISSING_CHARSET(2.50)[]; MID_CONTAINS_FROM(1.00)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_SEVEN(0.00)[8]; R_DKIM_ALLOW(0.00)[cmpxchg-org.20210112.gappssmtp.com:s=20210112]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; DMARC_POLICY_ALLOW(0.00)[cmpxchg.org,none]; TO_MATCH_ENVRCPT_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; DKIM_TRACE(0.00)[cmpxchg-org.20210112.gappssmtp.com:+]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Server: rspam08 X-HE-Tag: 1670346836-161331 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: New series based on the discussion in the previous thread around getting lock_page_memcg() out of rmap. I beat on this with concurrent high-frequency moving of tasks that partially share a swapped out shmem file. I didn't spot anything problematic. That said, it is quite subtle, and Hugh, I'd feel better if you could also subject it to your torture suite ;) Thanks! Against yesterday's mm-unstable. Documentation/admin-guide/cgroup-v1/memory.rst | 11 ++++- mm/memcontrol.c | 56 ++++++++++++++++++------ mm/rmap.c | 26 ++++------- 3 files changed, 60 insertions(+), 33 deletions(-) Acked-by: Michal Hocko