From patchwork Wed Jan 4 21:14:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vishal Moola X-Patchwork-Id: 13088949 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92D20C53210 for ; Wed, 4 Jan 2023 21:14:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D652F8E0003; Wed, 4 Jan 2023 16:14:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D150E8E0001; Wed, 4 Jan 2023 16:14:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C04078E0003; Wed, 4 Jan 2023 16:14:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B151A8E0001 for ; Wed, 4 Jan 2023 16:14:58 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6805040512 for ; Wed, 4 Jan 2023 21:14:58 +0000 (UTC) X-FDA: 80318371476.03.0799B83 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf05.hostedemail.com (Postfix) with ESMTP id C7914100006 for ; Wed, 4 Jan 2023 21:14:56 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mwUaRHyX; spf=pass (imf05.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672866896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=XF0rWcwOaeOy9W3XDndGOlTI6VOcqMAlw6Z0kSP+ZIE=; b=oGWLteZc57m8O9jxFmoOCTmIWwdPzOM5fYBxnrR0bCELPVW3t+620Cvg5E7cVoPObqdgU5 A4WydbRsyHZNbihlML1NMuUtSlrTqme5UJfLTyeCZPkeaBDIAqKnSjF4GzEAfMflNq8XrA ZXGEgYpkjMGBAdAxkhBYWc59vg/oYIk= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mwUaRHyX; spf=pass (imf05.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672866896; a=rsa-sha256; cv=none; b=YWjtsNaJYaS01EQNBsEaTikcDY1fsa+AC12ywT2xYloY4vppLYUctaRknPoaKpLfu8qjBL zSMSM1xgONrdKcsV9r58PF0g9VH6xBunx9jt+HT4h3fFx6cgexpmHNnWGsYKCycv8AExgo IvwuNIol2jT4Pzita6pjPkecqUMFZEQ= Received: by mail-pj1-f42.google.com with SMTP id o2so32016906pjh.4 for ; Wed, 04 Jan 2023 13:14:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XF0rWcwOaeOy9W3XDndGOlTI6VOcqMAlw6Z0kSP+ZIE=; b=mwUaRHyXO3QpRK5P0JqCEjtDjkmGl7YgUMaT1I2YjsKhseOwqNkNS33mOlEf/eRTXu Dx4cepCH0DpI7UZias9hAXzrqhmP9FqJPQ5SpCcrNsEip5tDid5QCJ8rq3xSJ7zfXgzS VkkY41Iwf5a5gzpho+eHq9V7JD1kKJVPOfzCuRJq6ljFPE+NlmpfzNYoSMe4wocuCgzf S6i7hTWrnSsU5BeCV3tLAdKHoc+E6ZXdQXMGE1pFenz1nLeHJTOMKZAollRFOqAqS7OZ auFae1eJ8Ii2yGyYjhvy6b6WvXd1YJI0BgZbYV7R5btP09Ol+PqZuvdKcR/Dbg+8nqw5 sxBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XF0rWcwOaeOy9W3XDndGOlTI6VOcqMAlw6Z0kSP+ZIE=; b=5R1RVnu/kPxpNRjnPqBzchsaZsniGeiXMTspNISbobW8ft3Z+BQ8OslseIuIf6d9FX Q9YV8znuvNh8ulNGI9aSXxjG+pxWnBu/UzRf+UcV6e5Dz5HSR/1E9sj9yesGY4B8f8L/ tx3Nu31Ta90XnClygEA//wE08qu+Hf/oxfIffdpFB8GsoBesspWhk+xHN8W8XaRpRCpe BOchaYkC/84SWGyVExdg7mFla3LYuDjwNhc8fqkLaDxeRismPJ8J0P54NGo1BDk527j8 5kUt2T6DLFAq33b3fL3zBHN2Pcs9Qj1r+u4k/vPcoBPCvU4kYIYeCP/NEKxAC4gmHRrO Vv8A== X-Gm-Message-State: AFqh2kpVosPBFtuYSc9Uc3SjoLpovuBkzXtvOdayuvooqlHOZurxgNxQ Os0gfUkPjxKph8PmWtgGaJ4= X-Google-Smtp-Source: AMrXdXuHWcLr2ISD1AWLN6noveXBmNIMzDKhC6iHCDPkCElkMLkDu5P/j13SKsDU15gZnXatqrr41A== X-Received: by 2002:a17:90a:cc0b:b0:219:5955:7570 with SMTP id b11-20020a17090acc0b00b0021959557570mr23943541pju.46.1672866895416; Wed, 04 Jan 2023 13:14:55 -0800 (PST) Received: from fedora.hsd1.ca.comcast.net ([2601:644:8002:1c20::a55d]) by smtp.googlemail.com with ESMTPSA id i8-20020a17090a138800b00226369149cesm6408pja.21.2023.01.04.13.14.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 13:14:54 -0800 (PST) From: "Vishal Moola (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nilfs@vger.kernel.org, linux-mm@kvack.org, "Vishal Moola (Oracle)" Subject: [PATCH v5 00/23] Convert to filemap_get_folios_tag() Date: Wed, 4 Jan 2023 13:14:25 -0800 Message-Id: <20230104211448.4804-1-vishal.moola@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Stat-Signature: aibuzyapp6tsumqmg9bjq3ncpfhcpsng X-Rspam-User: X-Rspamd-Queue-Id: C7914100006 X-Rspamd-Server: rspam06 X-HE-Tag: 1672866896-775446 X-HE-Meta: U2FsdGVkX1/gExK61pq3WZttdCsjZsqcLSAh6UVg2Y33YGksGnUBlaKVGrI/SwLqXrvQDWAbj9iVaOosp2klDQqqDL8BY73k7TLNeAEpS3WfeCXQBdtwqYUsnM/FuCXcmDyRnFe0xbhMt+ORf0PnpqSCSEeoVi2m9ueLjAfPWdXga8PH/gw/Iv4bozcuvw+MjVSCwCjDRjHi7198Lmboh6/SzC0392Z7J5h4IlZEKPDpCYB/yf29zFuxbI92YRXk1uL3Pa7vbuzJagTMDklTsOTT9Du7CH2UX3bXvAMSHbb+StTkTT5ufM6ehgrauci49C4iQu4BoRmqQCUecfAK9ZJquqe4PuQhvYbcRGm37dQeumMk8AeltXHnaAxY5fbaDNPr30SuSuuZdxkHsEHIdsNl4az8FEU3RERPvQ8+6+u3UcOgd2tRL0/0lpoIuQ02wfC/3pysOdEdKH/PPtGh+oeV0Y4tyvUIS022UdIslQe6mdOYLRyUkWhlbM0kgSoa+QRkvyqjH43rD/ybLO5ucYZXbzHKZoRmI7EAklu5q+O4s2N9oGrPC4UGNbROuobVFVpCh42mdJc6bP7pNTLvQBrHcNH3hJrtYIVkEkb4Qo8NXuk7EkFHpXAfajzzDYvi3Jojc9rsUvFsM13Cuice7LV59Cau4OSGJr8oMRLC/2KxqqOUAVoE0WofosKqmNBBreqM5Mhj5ZLMg6JNK1y+tvjA0+3ZKWpFDbP4rtyVekkJxuA6aUoXKJGzD2JOAqfdFIl0J9LwsBzqXp5W3NXBLpVGN5N39gJmTSo1ZREgJLaoAY3tVpWmA6c3oiVXMnaEc/QqZf17t0vI1GVBRchakn7SKIJ34Q/0ocP2LWNUR83/b6E9X0iD9EFlJoE8n3+2sSfPC2CreJpsOEEaxaC7R5x1aFXGcYUNMVw/SQjzpiqLQiLgXrljtftE+kkTw6ieaSN6YUAeGQKU7d5HW4B 9jNZlqm9 QvdBrTwErv/01ckD1JeylPCeQMdAfctwRkWmiCs1SKgIh25nlhgU9hn8Fo5g+ithB72j7nGFyU9ILTUttewgG98NqqwAz94yLFwiM0scnABNo7zFMQM2KURKsUBjLbEjwdwQMrv242TncF2fmX5i2k4JvEuSaJKn+F0hil1sm4P9bp9CqcJL/I77e8Jvj1JlKTDNqbXDJtqJhwFSWHJjmBdVEZEYNQmEiC5hBsY5H3LAr8l0JS+qNSNxo6+pY4EGv9oNHYKkXtEPrXkDAYvx0Yh+LfQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This patch series replaces find_get_pages_range_tag() with filemap_get_folios_tag(). This also allows the removal of multiple calls to compound_head() throughout. It also makes a good chunk of the straightforward conversions to folios, and takes the opportunity to introduce a function that grabs a folio from the pagecache. I've run xfstests on xfs, btrfs, ext4, f2fs, and nilfs2, but more testing may be beneficial. The page-writeback and filemap changes implicitly work. Still looking for review of cifs, gfs2, and ext4. --- v5: Rebased onto upstream 6.2-rc2 Filesystems modified to use folio_get() instead of folio_ref_inc() F2fs modified to maintain use of F2FS_ONSTACK_PAGES v4: Fixed a bug with reference counting in cifs changes - Reported-by: kernel test robot Improved commit messages to be more meaningful Got some Acked-bys and Reviewed-bys v3: Rebased onto upstream 6.1 Simplified the ceph patch to only necessary changes Changed commit messages throughout to be clearer Got an Acked-by for another nilfs patch Got Tested-by for afs v2: Got Acked-By tags for nilfs and btrfs changes Fixed an error arising in f2fs - Reported-by: kernel test robot Vishal Moola (Oracle) (23): pagemap: Add filemap_grab_folio() filemap: Added filemap_get_folios_tag() filemap: Convert __filemap_fdatawait_range() to use filemap_get_folios_tag() page-writeback: Convert write_cache_pages() to use filemap_get_folios_tag() afs: Convert afs_writepages_region() to use filemap_get_folios_tag() btrfs: Convert btree_write_cache_pages() to use filemap_get_folio_tag() btrfs: Convert extent_write_cache_pages() to use filemap_get_folios_tag() ceph: Convert ceph_writepages_start() to use filemap_get_folios_tag() cifs: Convert wdata_alloc_and_fillpages() to use filemap_get_folios_tag() ext4: Convert mpage_prepare_extent_to_map() to use filemap_get_folios_tag() f2fs: Convert f2fs_fsync_node_pages() to use filemap_get_folios_tag() f2fs: Convert f2fs_flush_inline_data() to use filemap_get_folios_tag() f2fs: Convert f2fs_sync_node_pages() to use filemap_get_folios_tag() f2fs: Convert f2fs_write_cache_pages() to use filemap_get_folios_tag() f2fs: Convert last_fsync_dnode() to use filemap_get_folios_tag() f2fs: Convert f2fs_sync_meta_pages() to use filemap_get_folios_tag() gfs2: Convert gfs2_write_cache_jdata() to use filemap_get_folios_tag() nilfs2: Convert nilfs_lookup_dirty_data_buffers() to use filemap_get_folios_tag() nilfs2: Convert nilfs_lookup_dirty_node_buffers() to use filemap_get_folios_tag() nilfs2: Convert nilfs_btree_lookup_dirty_buffers() to use filemap_get_folios_tag() nilfs2: Convert nilfs_copy_dirty_pages() to use filemap_get_folios_tag() nilfs2: Convert nilfs_clear_dirty_pages() to use filemap_get_folios_tag() filemap: Remove find_get_pages_range_tag() fs/afs/write.c | 116 ++++++++++++++++++++-------------------- fs/btrfs/extent_io.c | 57 ++++++++++---------- fs/ceph/addr.c | 58 ++++++++++---------- fs/cifs/file.c | 32 +++++++++-- fs/ext4/inode.c | 65 +++++++++++----------- fs/f2fs/checkpoint.c | 49 +++++++++-------- fs/f2fs/data.c | 84 ++++++++++++++++++++--------- fs/f2fs/node.c | 72 +++++++++++++------------ fs/gfs2/aops.c | 64 ++++++++++++---------- fs/nilfs2/btree.c | 14 ++--- fs/nilfs2/page.c | 59 ++++++++++---------- fs/nilfs2/segment.c | 44 +++++++-------- include/linux/pagemap.h | 32 +++++++---- include/linux/pagevec.h | 8 --- mm/filemap.c | 84 ++++++++++++++--------------- mm/page-writeback.c | 44 +++++++-------- mm/swap.c | 10 ---- 17 files changed, 481 insertions(+), 411 deletions(-)