From patchwork Tue Jan 31 04:38:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rishabh Bhatnagar X-Patchwork-Id: 13122225 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4BA1C636D3 for ; Tue, 31 Jan 2023 04:39:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B58FE6B0072; Mon, 30 Jan 2023 23:38:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE2696B0073; Mon, 30 Jan 2023 23:38:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A9956B0074; Mon, 30 Jan 2023 23:38:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 861D96B0072 for ; Mon, 30 Jan 2023 23:38:59 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3F8F6A048B for ; Tue, 31 Jan 2023 04:38:59 +0000 (UTC) X-FDA: 80413839198.10.DD69BE6 Received: from smtp-fw-6001.amazon.com (smtp-fw-6001.amazon.com [52.95.48.154]) by imf21.hostedemail.com (Postfix) with ESMTP id 78AAB1C0005 for ; Tue, 31 Jan 2023 04:38:56 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=amazon.com header.s=amazon201209 header.b=fyARXLoY; spf=pass (imf21.hostedemail.com: domain of "prvs=3885f9781=risbhat@amazon.com" designates 52.95.48.154 as permitted sender) smtp.mailfrom="prvs=3885f9781=risbhat@amazon.com"; dmarc=pass (policy=quarantine) header.from=amazon.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675139936; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=CXKI8V8i96SMsRvHYzeufowrTOHGbbWXe38v5Z4Dvh4=; b=QwAQCf9o1XbnwbQtyCwy2DlfcwGRwdULiNscp5zpab5sR8r8nOfPjXMlKIBf/xxi50yoC4 E8afLkauEQ9u9RK7kMG5Kookcbw4koas5rSH/ftwyXncRuNHnM8Sf7XdVwRiy1j9VhKkE7 8E7lu4ax4BBq+t4rgdbRlLTIQAho4CU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=amazon.com header.s=amazon201209 header.b=fyARXLoY; spf=pass (imf21.hostedemail.com: domain of "prvs=3885f9781=risbhat@amazon.com" designates 52.95.48.154 as permitted sender) smtp.mailfrom="prvs=3885f9781=risbhat@amazon.com"; dmarc=pass (policy=quarantine) header.from=amazon.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675139936; a=rsa-sha256; cv=none; b=g1hka8tXl+CLZoABLAXd9gNsZc2GgDx4bTLhDopOpGHbkYjEp0CtF0p5wOhww/iyFTRHUD 3F5JYGdaKmEyrrikkKpY2vOfdilm8Km7HuutF5tNpZF/Xfx9zfXHfcN+OsWIpzNLZMmILP zpI2aJqbypvAzuSApzOui5mzrYKNlcY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1675139936; x=1706675936; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=CXKI8V8i96SMsRvHYzeufowrTOHGbbWXe38v5Z4Dvh4=; b=fyARXLoYZGPATEk5fv1o61j/hn8wqLcTKz0GOZY1kRGe8JMd+lMvHQr7 nVAGtDygDQ9ri4mJqiUloq66q75opmq3afq4dSts9sQIkLcj83Wn/uLPi GGqusXZ28Blr67JMBh7UeV2f0ONFUE9gzXkHGB3aByT4+WbHVKyk+KQO+ s=; X-IronPort-AV: E=Sophos;i="5.97,259,1669075200"; d="scan'208";a="293718495" Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-pdx-2c-m6i4x-b1c0e1d0.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-6001.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2023 04:38:55 +0000 Received: from EX13MTAUWC001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-pdx-2c-m6i4x-b1c0e1d0.us-west-2.amazon.com (Postfix) with ESMTPS id A1D3D81A5F; Tue, 31 Jan 2023 04:38:53 +0000 (UTC) Received: from EX19D002UWC004.ant.amazon.com (10.13.138.186) by EX13MTAUWC001.ant.amazon.com (10.43.162.135) with Microsoft SMTP Server (TLS) id 15.0.1497.45; Tue, 31 Jan 2023 04:38:51 +0000 Received: from EX13MTAUWA001.ant.amazon.com (10.43.160.58) by EX19D002UWC004.ant.amazon.com (10.13.138.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1118.24; Tue, 31 Jan 2023 04:38:51 +0000 Received: from dev-dsk-risbhat-2b-8bdc64cd.us-west-2.amazon.com (10.189.73.169) by mail-relay.amazon.com (10.43.160.118) with Microsoft SMTP Server id 15.0.1497.45 via Frontend Transport; Tue, 31 Jan 2023 04:38:51 +0000 Received: by dev-dsk-risbhat-2b-8bdc64cd.us-west-2.amazon.com (Postfix, from userid 22673075) id 429D5271E; Tue, 31 Jan 2023 04:38:50 +0000 (UTC) From: Rishabh Bhatnagar To: , CC: , , , Rishabh Bhatnagar Subject: [PATCH stable 4.14 0/1] Fix ext4 xfstests failure Date: Tue, 31 Jan 2023 04:38:14 +0000 Message-ID: <20230131043815.14989-1-risbhat@amazon.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 78AAB1C0005 X-Rspam-User: X-Stat-Signature: ffesqn3tyd97w7i7sods4ftz898soeci X-HE-Tag: 1675139936-426526 X-HE-Meta: U2FsdGVkX19/oxmG8tVKK322OjpP+r1/uRxgkLd6K8lUQ69nO1lthc1t2Wl/Nec5RG+b2fV8cnneb3snVErirADfQ8QSg5/0wfJIVwI58G1o3XlAHRTrO504E+PNsVrtz+LUolf6AIIX+NLE0UHaGbwZhYWdd4GSWTdxdA9cqgbhRNdRxfmWbVWt1VnSmWWS8eUhy9lelBs/drujAAYLdSZwAzgzRiHf2UbwUoFdtd5//oVxf41T971BdSGvKUJgkqwsPfVz9KxRplaODmr8/MetqOoV54G1tkxDE+tXq0SFUSPJN12L/Rh2H8UOmlnIWjHnAD/I2NWbXfWFQFtQDQMsx7MQrqFI/G2Bf8BRwb4G3cVHEffSLAQPL7zwrlJxfT01SvyouSAdJGzZxnZrbPOYXpn2eranVSqNQQfWoUy8ocQTKv70IGlQPn6Xa+UXw6tSbYAtf1bPjMd9JKJB0kL5CBheOk9FLrbKii5GcPw/VqGioL8+RWLikXXPRcoK7+s/MzJH6ru3MgEjYSh37YJ2Y57E7UV7pqPZNvT7l0oD+DlySmsv20cKPOnzvBY5j/Il19X7cNxiRxxN+ilEDp7i4q1NIPKq8hLeIQPrQmQOy0KXk1OV4gyNr529tSnggX32u5rt1+YHAG3Ha/oilYt5u4tWKN9BeDs90Dkhqv1HzlJW9acakIwgnwrclBHit0xCtDYSs1a/ZoctbsyrqWIKbMX4fuAkNmWtpFRvAGC2qO4f7bQdtvgPrAJTPaOIMlgMO0be4CyHCif86ZBvuSRQklaUwFsAOv9QTqyUg/8Z2mYIhMzJjvXf3Y2GtHzgBvHYDCeEvztDeUfchuU4NcbBiDzCP1hK7Om4sAAN6RrQGz2fQ6inEYrNbLvcoSLZt+jeCut9P5eglNZlcrrbEBHZcp4M7yP4raXOQrHiZo60ZbMorqDYhRufYa/4YVqWq0ite+FMOeLMZ0LNi9e 9QFrINJx WI3j7Jsn5xnd3St+4LnyIhHgAUBg7tT4KNKlKDn+eSAmVBFdScdeXouEWcazDaEUE6bW17Vkybbkira4KEvJc3ibG7o7M1xe4YcPF/LvHkW7MTVcqFolGFCxLk8XqTUAa+x+kj1l2mAZPrMb39CiyfRSdAgY8eZCiULR4ubdJU54rCcMhVH2SGW2Ab1bbgNCqXtj3HappdmvbMe2YoxF+QBaGBL5smlamAZMFrUIbEzmKtphJI5ZPcwGpCzDa4T9D0pvhSETty2u2/Bz8iOLenrxWoq/vItfBXrki61e4xx45WEANXNZc3xDKeU3htbBQ/xJj1cuVQO+j6vnaXM48qOdZrkEzZRnv9rDNlFUs9/KMrDw0e6NHD445FUQGB5jCZsn1P4+Hde55vcQ9nftlGeQm7dwSgxMXt6vSR0MRWqNwSeQqWAYP3ZdUii7ltlNgiF4DYJ1RxXAhjVY+aQtijKDYUvgo1S1P49OJovx17+MmVe+Y8nB1NqfvaEU6cE3+DfLA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: While running xfstests on 4.14.304 version we see a warning being generated in one of ext4 tests with the following stack trace. WARNING: CPU: 4 PID: 15332 at mm/util.c:414 kvmalloc_node+0x67/0x70 ext4_expand_extra_isize_ea+0x2b4/0x870 [ext4] __ext4_expand_extra_isize+0xcb/0x120 [ext4] ext4_mark_inode_dirty+0x1a5/0x1d0 [ext4] ext4_ext_truncate+0x1f/0x90 [ext4] ext4_truncate+0x363/0x400 [ext4] ext4_setattr+0x392/0xa00 [ext4] notify_change+0x300/0x420 ? ext4_xattr_security_set+0x20/0x20 [ext4] do_truncate+0x75/0xc0 ? ext4_release_file+0xa0/0xa0 [ext4] path_openat+0x737/0x16f0 do_filp_open+0x9b/0x110 ? __check_object_size+0xb4/0x190 ? do_sys_open+0x1bd/0x250 do_sys_open+0x1bd/0x250 do_syscall_64+0x67/0x110 entry_SYSCALL_64_after_hwframe+0x59/0xbe It seems rebase to 4.14.304 brings a bunch of ext4 changes. Commit ext4: allocate extended attribute value in vmalloc area (73c44f61dab180b5f2dee9f15397aba36a75a882) tries to allocate buffer using kvmalloc with improper flags that generates this warning. To fix backport an upstream commit mm: kvmalloc does not fallback to vmalloc for incompatible gfp flags (170f26afa0481c72af93aa61b7398b5663451651). This removes the WARN_ON and fallsback to kmalloc if correct flags are not passed. Michal Hocko (1): mm: kvmalloc does not fallback to vmalloc for incompatible gfp flags mm/util.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)