From patchwork Wed Feb 1 13:57:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Olsa X-Patchwork-Id: 13124342 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE1B2C636CD for ; Wed, 1 Feb 2023 13:57:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35E336B0071; Wed, 1 Feb 2023 08:57:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E58C6B0072; Wed, 1 Feb 2023 08:57:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 187186B0074; Wed, 1 Feb 2023 08:57:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0AB3D6B0071 for ; Wed, 1 Feb 2023 08:57:48 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B82F8140E1B for ; Wed, 1 Feb 2023 13:57:47 +0000 (UTC) X-FDA: 80418876174.01.37363F5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 0D726140016 for ; Wed, 1 Feb 2023 13:57:45 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=J+gWjVwh; spf=pass (imf26.hostedemail.com: domain of jolsa@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jolsa@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675259866; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=pNf9IOnnyCHBNYxsNOyGJgszqUAP3+Wd4NQfoX8s1Tk=; b=34F9d8gjpOSVJMfz9r1/CN11/upZfZBI31RVwCVGFU5ng0TXIH8aGQ+GjVMUmVSPRQP12L oaJlX99ny3O0g28anSMj+gB3J23Imt5wTFZlOjoKK037LXVZo9XGCsA2piKB0+5cmUDqtI 2jT5fsRB/FIjLEoR5sEMqcCWCJ8K8Rc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=J+gWjVwh; spf=pass (imf26.hostedemail.com: domain of jolsa@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jolsa@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675259866; a=rsa-sha256; cv=none; b=Pl76+Vf48i+yyRhy7UP9bDDrL5ug9JgAgQH2KswCDQTupVUtp5yZHjG/2/Xiq/UyRZaKuU R9MwxvJw2B5Y2b70imX1QMpmR/7YqcGxyJ1qNppDqeMZiP5MXLxPjW8Rb/cqphctOmBNZq lH4mUP9FnT0nUediyeS4+LTL6E/ulQ8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EB49E60B43; Wed, 1 Feb 2023 13:57:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9C58C433EF; Wed, 1 Feb 2023 13:57:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675259864; bh=SpI7KwADUFU7LsbCXaag3YbpvOzij0u/n2sLMpli8zM=; h=From:To:Cc:Subject:Date:From; b=J+gWjVwhlExx/kQG6HBH333Bk6FbQ3RN+UdWZ0kJIewW9wN3j8Mf3kQteaovGFv86 u2oE9NGNpu9NmrB/ownkgk2gQKCRIj2OedRN4vuA9WhTshG4lufDkeknzyQkpY6UdY AS6p64fr4NTxNvP/d5OkLNkzWL0qydlmOkQsI5l0bUeDwiPxwZB8EHJbZUyDFuFtbI sEijVQfSNJq7AqeMorekg6Z+53JqVokPn71gIEW/2r6QhiHNzBidvbYlGC3TeIdTsU cmSJkCagjvADr3IrUJ8WtYRbFaLwYhz0B0axL1N+J6ahLdweQ+b24KAxeJAbjW5ard H//g0Cj7MvffA== From: Jiri Olsa To: Alexei Starovoitov , Andrii Nakryiko , Hao Luo , Andrew Morton , Alexander Viro , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo Cc: bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Daniel Borkmann Subject: [RFC 0/5] mm/bpf/perf: Store build id in file object Date: Wed, 1 Feb 2023 14:57:32 +0100 Message-Id: <20230201135737.800527-1-jolsa@kernel.org> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Rspamd-Queue-Id: 0D726140016 X-Stat-Signature: 6887axf7tqzyi7wxbi96sij9yrgkxpes X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1675259865-548477 X-HE-Meta: U2FsdGVkX18iqtB+yuPeQ7zJYOw2b34XLGpmHjV4d2Bjkh4hbKwo6MRRb2fQCYPmaZXV1CMEDIntjAzgOWgYODxrcwr35zByGeh2YhhRt/oGhGSkNt0jVSlDNT7GLKs/Mp3EY2gc0KRcTsgYdhph2pljYrjpkCOs3cWzRj8NolsfZ10h0kzFRQlRcmMiwOzF3qtSToknxxGfmgYeM0d+8Ak9LyIr/DzkkoXqSHj7yDFeZEaXCPpSeiZpcY3P3j/g979NIYd6+FFKRQoG9cOwZ0r+RtFNGiwwFekIGs2zkymeZIAeMUbsk4Omw2tz6cVNCHYlKvyS63Wq/+sX8ZCmD6zX0brVqXwnZrx05qXUO1kPZys6gGWhA8KnqRG2FB8tOHa9Mq9NtqDPtpw1PDqqg063CRTowCrjWtNk9yhm7WOhiyJU1PTIu+8WC/8z9a0+LLzCXqtuiE7cES0SNu4wcsY/Mnim2IrvLQsuidO2Xkw6FRxFnBW0jPn8vUuNOqecuOnhfIp+GPObOp43p5KG2gUGHcrLPjlt1TqpWYbEHOkEOWN+HjDUqfPlhB/CPEvWmUrm729Xa+LA5iqSFxuLyagBpfW9bt6rLzM5d3TJ9BMVMXRy4RSNCbFnh/Ic1r10JQbNvnZckYUFJ1dPQe0zdsW6pIyNFy3tbUGUX2Td+mXoXIJzLzQ73jM2SenE/5R/o3zSaSjHuYN3Gka0KFsjRhh75iMYDx3kUyqRYXYLNw3zHLmGLR/BPXAhFrwYQZvtXmCAULqYNaxkg2yKrtJWirG7Y39y9G5SmykANMWfrb4KtDqwnUpkMk8XQCyoYC6AIMLNvgZLzxR5GiwYiJWBA6Tns4J5KwwIvq7xvoy9v6KZz1/G6eKYqzgeKY8InYWEUonLujj+gE1ngwh0nlAMCb31gK4nOcb9aIOSqsJNF/FZaJFhW1J9DvXMmpFXqoWeslejKuAeuF6oiG6kV2R LglI0jc5 VrLYn31Fw1uepjHpC5FgOuLZUZYswTxS4McDnt+gdhi+EvyV1I9CBjQaqs6EYD5CwoNFnQQIlq1EdNof1pN6M2nunD/rwKQ+SaULEpY1KPMN/LSfDRFhbl12AMbxX8VQk3QEP6DhPIChtT960JKb/4EzUbRML50lMnlQGLbez7PCobE2gFQuFKAemyGUfR4VsDximUpdRERtdmPl8Jkfv+7iP+i+gLJ2I1nWoJ4wK0LjDBVGtjvYq+D/WSeY5XmDw/ER/t4buDZ1fCKfnBT35Prv1U1ebCnhVJlAmz1DOCyMfYGnkjROh2rAEBjEFDS/IkI4ePVdOJTvJt7frOKwre91R7tvnFYTO8rrrNvxKZkInf2RgtxCVBZdl1YmWACjM1XMxV3BVvRM4qrsb0iNg/GJSJDv0lT7qLm2vzczjM7scvAWJh4pY39L6ZD0GZdBF+vbP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: hi, we have a use cases for bpf programs to use binary file's build id. After some attempts to add helpers/kfuncs [1] [2] Andrii had an idea [3] to store build id directly in the file object. That would solve our use case and might be beneficial for other profiling/tracing use cases with bpf programs. This RFC patchset adds new config CONFIG_FILE_BUILD_ID option, which adds build id object pointer to the file object when enabled. The build id is read/populated when the file is mmap-ed. I also added bpf and perf changes that would benefit from this. I'm not sure what's the policy on adding stuff to file object, so apologies if that's out of line. I'm open to any feedback or suggestions if there's better place or way to do this. thanks, jirka [1] https://lore.kernel.org/bpf/20221108222027.3409437-1-jolsa@kernel.org/ [2] https://lore.kernel.org/bpf/20221128132915.141211-1-jolsa@kernel.org/ [3] https://lore.kernel.org/bpf/CAEf4BzaZCUoxN_X2ALXwQeFTCwtL17R4P_B_-hUCcidfyO2xyQ@mail.gmail.com/ --- Jiri Olsa (5): mm: Store build id in file object bpf: Use file object build id in stackmap perf: Use file object build id in perf_event_mmap_event selftests/bpf: Add file_build_id test selftests/bpf: Add iter_task_vma_buildid test fs/file_table.c | 3 +++ include/linux/buildid.h | 17 +++++++++++++++++ include/linux/fs.h | 3 +++ kernel/bpf/stackmap.c | 8 ++++++++ kernel/events/core.c | 43 +++++++++++++++++++++++++++++++++++++++---- lib/buildid.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ mm/Kconfig | 7 +++++++ mm/mmap.c | 15 +++++++++++++++ tools/testing/selftests/bpf/prog_tests/bpf_iter.c | 88 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ tools/testing/selftests/bpf/prog_tests/file_build_id.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ tools/testing/selftests/bpf/progs/bpf_iter_task_vma_buildid.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ tools/testing/selftests/bpf/progs/file_build_id.c | 34 ++++++++++++++++++++++++++++++++++ tools/testing/selftests/bpf/trace_helpers.c | 35 +++++++++++++++++++++++++++++++++++ tools/testing/selftests/bpf/trace_helpers.h | 1 + 14 files changed, 413 insertions(+), 4 deletions(-) create mode 100644 tools/testing/selftests/bpf/prog_tests/file_build_id.c create mode 100644 tools/testing/selftests/bpf/progs/bpf_iter_task_vma_buildid.c create mode 100644 tools/testing/selftests/bpf/progs/file_build_id.c