From patchwork Thu Feb 2 03:10:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Longlong Xia X-Patchwork-Id: 13125225 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C957FC63797 for ; Thu, 2 Feb 2023 03:12:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 685D86B0078; Wed, 1 Feb 2023 22:12:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6368B6B007B; Wed, 1 Feb 2023 22:12:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FD6C6B007D; Wed, 1 Feb 2023 22:12:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4127E6B0078 for ; Wed, 1 Feb 2023 22:12:32 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1B42E8064E for ; Thu, 2 Feb 2023 03:12:32 +0000 (UTC) X-FDA: 80420878944.12.2B1B76B Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf11.hostedemail.com (Postfix) with ESMTP id E25E640003 for ; Thu, 2 Feb 2023 03:12:29 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf11.hostedemail.com: domain of xialonglong1@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=xialonglong1@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675307550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=Gu3zpGf5zVlYomD46avjpSeHPsRGoNaUTFDDt4/02fo=; b=p1e1Z9ADGQ2ohwYoHZuUdxpOyi8zaGBJUU/bVgxlua0qdg9cwN9W+VqlLNJB07+qUUn5JI TgRPAosvPtBTUTEhWLQP6BgHgAgB88BVzXaTapOMlUkxNk5E+trb4sbkYlMAuWbZ5R6F0E +URUlADRCLGhsxxKpcSHe3XSjJhag1o= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf11.hostedemail.com: domain of xialonglong1@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=xialonglong1@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675307550; a=rsa-sha256; cv=none; b=HXxRuENvX1hJdlQGGe+KSQkjnSMwIoNEmgZilojACnaexxxSQceOL0fI/pllO0vq56BT8j XUwSRYQwS26XYPREVXB+g32QfFBoTSYTOs+QjmOPBrj6p2sWny+7m3IQu4FmxP65b7o1Bs CvEoR7s7OytZXvM+gVFNffK+5KfeEMc= Received: from kwepemm600003.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4P6kLs369qzJsC3; Thu, 2 Feb 2023 11:10:45 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 2 Feb 2023 11:12:21 +0800 From: Longlong Xia To: CC: , , , , Subject: [PATCH -next 0/3] cleanup of devtmpfs_*_node() Date: Thu, 2 Feb 2023 03:10:43 +0000 Message-ID: <20230202031046.1224338-1-xialonglong1@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: E25E640003 X-Stat-Signature: rn3q8wpmqfauqjtyfisnsmmdq5e4s7ox X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1675307549-898981 X-HE-Meta: U2FsdGVkX18+pe2EJ5DASY4/l9O8gPC8C4pf2IzK27fEoJiW6EuzYQ77YF2GDwof+HcuslpHaCHjX2+roAkj/EBmD11faGZTTH0ypI6x54+R8ofckdzY7ZFH2TG1t+ZJeM+pusjbOF5hjguNCybuIjEV9E/biCmM0Jf8AtjSxbUKt8o6SebwBf96UfBl/t2oeoHKXS4O5WEke7kMbEYryoh4WYMXpsiZXJuOCIjhdNbth9IOcf/XlxJH26rf9+bN+aNiRSWNwzqovvjkgrGbfFWfr3BZ73kHEQIGEU8FA1P9XL1e1DzXtp5WYpBEF+yGcDSIJpPyE1OIkofpmHZAhY/75bCbk6Q9dPgYP+LZhQysX2HlL1FzWYaoMF0ITwQbWGpI9Lah6HtFub7DC24KFgeeHULvjkJJVuBgOblDZgKtsG2v4cJAPTeU0b/WapluI4OVE8vJuBV5MERU5EaiaE7y3lcsMlR08kWlW42IXd+0ac4N+DjYNF7Saq4mSHUxBHSjyBxT1CvE16pPiOpwTjte8lT8oz4hHxqw1zuETYu7aprRBDdJ2jE8CZH+4dXkVbHydgBmfWN6sD432oXORODRghlo7s4mBCLGSI6nUi/w66Vo5tooT+UmWVW5zDV8g+Fk7LygTMDTP4Cs9n9GvT7GsmEEFfZYYjEYVYbK5aIB0zvVQD/J8T36b8gkL0ZwsU7GrbFti66WbGazsuWhsQ0dw7EpQWJTWz1j2pn98TXp99vKBb98WB1nfTHNOixnk3qoBP4tY52qj2tKeA6avexnTpSNUl4A3jQqFX5/Z6wyLiMgBF3JU+uesEOm5sxYAOF/jaa84c2WbPF+4oqn/Llw9xNFIoDvmwDlE9E0E7UfFYvlxD/45mcGA04JKm36Tn8E2JgHhrR44DrvXBnjiPsy/rQeK4pyJU+jETxKB7zccRvJinGRptUeEqkMPflOOLtU1+iRT3UyHtcXW6R XrNYLdL7 VgAB+Cnxt9T+DvkgCHcDVCoLk6aM5ZAzI2GE49eCnPuEcbfTg1X6P5bsGUODvXVAQS5BqWODdegJ6y96Ao/6vFD/maFeh2qOFTI43AAXxmiOU5ytBtTOgXb95zM0+VnrMM1GOTqxfvXwVe0GPrssDyksDdHHx0d18vMstCaqwhukp0SHYnGZVer8xbw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In one test, when modprobe zram, no zram device was found in the /dev. But don't see any errors printed in jouranls/dmesg. Later we found out that the reason was that device_add() did not check its return value when calling devtmpfs_create_node(). So we hope to turn devtmpfs_*_node() & devtmpfs_submit_req() into a function with no return value, and add some debug info in the handle() that actually processes the request to let the user know why the creation was not successful. Patch [1] devtmpfs: convert to pr_fmt. Patch [2] devtmpfs: add debug info to handle(). Patch [3] devtmpfs: Remove return value of devtmpfs_*_node() & devtmpfs_submit_req(). Longlong Xia (3): devtmpfs: convert to pr_fmt devtmpfs: add debug info to handle() devtmpfs: remove return value of devtmpfs_*_node() & devtmpfs_submit_req() drivers/base/base.h | 8 +++---- drivers/base/devtmpfs.c | 48 +++++++++++++++++++++++------------------ 2 files changed, 31 insertions(+), 25 deletions(-)