From patchwork Mon May 15 11:33:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mel Gorman X-Patchwork-Id: 13241280 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6448DC77B7D for ; Mon, 15 May 2023 11:34:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9CA4900004; Mon, 15 May 2023 07:34:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4BDB900002; Mon, 15 May 2023 07:34:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93AEF900004; Mon, 15 May 2023 07:34:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 85006900002 for ; Mon, 15 May 2023 07:34:00 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 52BDE141405 for ; Mon, 15 May 2023 11:34:00 +0000 (UTC) X-FDA: 80792280240.20.0F74C4A Received: from outbound-smtp04.blacknight.com (outbound-smtp04.blacknight.com [81.17.249.35]) by imf15.hostedemail.com (Postfix) with ESMTP id 5E927A000F for ; Mon, 15 May 2023 11:33:58 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.35 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684150438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=BCyCn7NlvY/VpeZnl3gnwYR1mgaLdBLBzxIv9IQkIVY=; b=3/jJnDFe8qsySVS4sctz5XtP8g9GOhlSuer4emQXYAjPr1Cxd0s8NzuypfGZ9l5U/1tZcT PAD5xfHIAcgFoHKX8/suQXBGkqONDGRUQSU2AGmElXqjc7Yr44XwmSbcGXZ94khPgc7Ntl FHk3p7hKSSpB3FqExuXBwSHWeOKXNmg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684150438; a=rsa-sha256; cv=none; b=Y9k61MBIXGgSqGEUImDlY7xLxdGFFV/UiS1fExUY9MfSp/EFaxcBS4Q/dkQa5yiShj+4n7 c11fr2qvhf4cP3qMQlyNmSFtcsK49LfNIupTJZsnNHJasb3t8eFqH4z59rhQgZfqQKg7iB uzPF43RlhHTqhtJilPoyAb2fFDv5y5U= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.35 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp04.blacknight.com (Postfix) with ESMTPS id 726DFBEE66 for ; Mon, 15 May 2023 12:33:56 +0100 (IST) Received: (qmail 25051 invoked from network); 15 May 2023 11:33:56 -0000 Received: from unknown (HELO localhost.localdomain) (mgorman@techsingularity.net@[193.118.249.27]) by 81.17.254.9 with ESMTPA; 15 May 2023 11:33:56 -0000 From: Mel Gorman To: Vlastimil Babka Cc: Andrew Morton , Jiri Slaby , Maxim Levitsky , Michal Hocko , Pedro Falcato , Paolo Bonzini , Chuyi Zhou , Linux-MM , LKML , Mel Gorman Subject: [PATCH 0/4] Follow-up "Fix excessive CPU usage during compaction" Date: Mon, 15 May 2023 12:33:40 +0100 Message-Id: <20230515113344.6869-1-mgorman@techsingularity.net> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Stat-Signature: qp79iwntwao4wawgjmjx5om47qj9pqjc X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5E927A000F X-Rspam-User: X-HE-Tag: 1684150438-157043 X-HE-Meta: U2FsdGVkX18WBnkXKtBLvO6w2onoVXFPVIA7eWTce5+b7bp+WmLlUAM+wRoOaeWAg0lYcMdtIQ0ejr3U/sfbSwdLPmIzp13T4EolF4TA0DIgVFGmi1BMU1KCbISK2uEzxVknXZuN4xe9zI6Eun/x1377S7kjpWMeVk7snTHJZsRjpTdG4vJbzx3IcNccjPOa3b790ukyXbEkAtP/eeYdCACgwlxG7vs0GGkD6I/vtHlCsHNz0ZhSyeyq7sn7q93dny0T2/41sFNSqwNOMYDvLbA7yynP0I/Js7MUW8u/bDVjFmS93vJJSKlP/B+yZJSxLntjVrhkcvqTrTdZvx+AiO5GWJVTt6wun2KKBBtReZa17dErb7Mv8oN36Zyyw0+KOJnRL6EFTEfxy665iRyoQ5ad6K/FzhdUZG/6vcFw9l2tlN++TYesdvvvsNf07XyslsrHaTBFe7UA+YSky1pBpeRUJZVH/j1m4aQZDx/e19c/ebPOcQUsl9cuL8QcJoQLBeOeNb7CE1blYeIy7tZkYQFDBltAduq9MeZS41qb+lLDQ6A7QmOmEtVsrCLPWZ8lHwbHV4OpJDSPbWfI8e5d1ErcvONYHXII++2Rtqx9pJnXXwyiM4D8K2QIn9d+PXyGTVr8W355E/tfK6Vqtna6LJdOjPS30E9tX/lOqMd2kJYCrNaYmsadPU7+eheMCL3Fmtluz7bzpPmb53EHROUDmkE0Rbg1gXJRQkND6e7vLqc62M1deOt9sDERB2dLkcU3mrck9nQ4IpWcvAo5KZNIuGyv5SHc5nhNa9jOw7VVK7tbTEcgO7NvdvO6P6Tc9h5qnuzU9oP/V7BhwGU7aNCEBIJ0jMIzTVrcvU2eygaSKPfWOZt60IgRdXaTabbeDAlx8Qw3a4RJs5VHme26owkBnsTuj6IYRtw9bB+SsJTSuocxovLfoQTbuDJ0uLRtmtjTygOy7kn2NHd5qsXchYb aXMaiWdo bnQlonvytHYYGxs3rF9cRvJ7nC+tli/efSee9IFMAask9NBtLXjYGItaJ3BlZLIWq3uFXefDJBT838GZCTEsBlNXccgwk84RmmFwonjeKCMcqRsHssU9eqX+hjE+Twrb+jMpTLwmYJ+u4eUxBxyK4abFe3Ui1k1obMOF9sEsQUEeGZIlsFpFMYt0oMi0W4/1EhRTXln+ntlR4sj4jl43st1QdwN/pei9qRgDhCm36alxFcxGo/zl0SXCrtlIsiHHlBn2pSqkdEXdlbW2OSApxkHEv3hTH6HxnacxtEuvu41LCsJN7umOiGIaP96HKLaRK5X44+0qsznLu4Yk90iYjc1c042XPzP+bMG4DYazPPsNY12/mnIyOQhc99abwJSC1mSEFgZzoR7tFdnRcz0SKWdjLrgLStUX/MVDWmEgiul+TJ/QMfFqw7VVkTyWZ1sAsbzjYM4nIRermld0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The series "Fix excessive CPU usage during compaction" [1] attempted to fix a bug [2] but Vlastimil noted that the fix was incomplete [3]. While the series was merged, fast_find_migrateblock was still disabled. This series should fix the corner cases and allow 95e7a450b819 ("Revert "mm/compaction: fix set skip in fast_find_migrateblock"") to be safely reverted. Details on how many pageblocks are rescanned are in the changelog of the last patch. [1] https://lore.kernel.org/r/20230125134434.18017-1-mgorman@techsingularity.net [2] https://bugzilla.suse.com/show_bug.cgi?id=1206848 [3] https://lore.kernel.org/r/a55cf026-a2f9-ef01-9a4c-398693e048ea@suse.cz mm/compaction.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) Tested-by: Baolin Wang