From patchwork Fri Jul 7 21:55:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Rasmussen X-Patchwork-Id: 13305357 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E59E2EB64D9 for ; Fri, 7 Jul 2023 21:55:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E530B6B0072; Fri, 7 Jul 2023 17:55:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0D238D0002; Fri, 7 Jul 2023 17:55:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCB728D0001; Fri, 7 Jul 2023 17:55:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BCD1E6B0072 for ; Fri, 7 Jul 2023 17:55:46 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 810C540136 for ; Fri, 7 Jul 2023 21:55:46 +0000 (UTC) X-FDA: 80986173492.15.64D0EBB Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf30.hostedemail.com (Postfix) with ESMTP id CD3368000A for ; Fri, 7 Jul 2023 21:55:44 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="b6Gg/x1X"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 334moZA0KCMAg3krxgys0yyktmuumrk.iusrot03-ssq1giq.uxm@flex--axelrasmussen.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=334moZA0KCMAg3krxgys0yyktmuumrk.iusrot03-ssq1giq.uxm@flex--axelrasmussen.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688766944; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=dxkJHri43fmKt8R5z8YjbywDBegP4t1apGGC2ZsbmRA=; b=oh9MAOBPFX5dW9SIZVteb6zUH7fBYNQCMFfsF04ZiOdbex6mO6oCCL8thj3lt8zrIVzq4V 5c3AogU/RAiVXwNtwGkZSgyLKrmXWM7fHwZOUg7husxMWIzkONVAbqJa5jJJWX6Q+EvSps FVz/QU3hRFWn+EVyOXtfEHPJkTWxrFY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="b6Gg/x1X"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 334moZA0KCMAg3krxgys0yyktmuumrk.iusrot03-ssq1giq.uxm@flex--axelrasmussen.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=334moZA0KCMAg3krxgys0yyktmuumrk.iusrot03-ssq1giq.uxm@flex--axelrasmussen.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688766944; a=rsa-sha256; cv=none; b=Ld9ElhTtT8ygApIKeqNS4yK9Zg732bONL47tqdvyCuBoYMzyhaMzOydiGumVWfq9AiEH7s ycM1ngL9QDoATrmxt1som7eZALNeESgWh0P+t32mZy1KHaR1Skhah+UorbpZxjEClJgCXl THdjeFFJZd54QrteZinJkCmADevcRQ0= Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-573d70da2afso24840407b3.2 for ; Fri, 07 Jul 2023 14:55:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688766944; x=1691358944; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=dxkJHri43fmKt8R5z8YjbywDBegP4t1apGGC2ZsbmRA=; b=b6Gg/x1XQLR5WHo7raUdy++mKTypBcksDMGu02e/y2LL5dfcbwJiFOhepoOSxW7HAM qhQk33LqWKnM71Rvpocs6Lr+bSz5ZhRj5sg3FdfbYMGN+8p4ElscnOrSYWGgo9NdbeBs YqWu7gNHFKbEBF4wGvib7spB8LTWvvlt3jf0nVNZj8yh/iE3eEJDouH8rcp+vv1rwzrs OaeLBCVLl4aVNGJwOhAZ920phl/yxBux7NjuNVO4AJF/sR0lVnh49cUD2oPFxAdlkCQi LRZlOpO1kFVxD+URKOLjfLqZGFHxoUIOy3s0PvVD5zrkHb0DFDuFC2Eu8kKAB8/kCqrq wbaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688766944; x=1691358944; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dxkJHri43fmKt8R5z8YjbywDBegP4t1apGGC2ZsbmRA=; b=QVWZULCcD95rxx1VpwRbxhFgwheF5C3GS9ijHu8hXT9bpBBTUYjX7/+I5OIMuAVnWq j9RnDfd1nY/mTMRwKVp6E0iRbG6WKI+6tpqDpoPvm5/UUyTho77UfMDr1NdcD/ftScjq KlM2ZNFFBkpAtKQbQb+eJFPRXXk1RxW5YZup9p2+ujdpBHd76zqVgJU3yKuKna0JROs2 vk/QCzC9mZwyIfrZPpbflTOEi/h7+fOsAWs4HlEcAqvfUhNdQntLhQ6mTvCkRh2qFhqb uZIwDbnYPBCGxAATApZRJyWg75gESfbFSmzCJy5AKXfim5UDQxzVMbzlNosv7RxIkigF 5SEQ== X-Gm-Message-State: ABy/qLZQmZFzDBNYeh/0Sd4M1OlbYNolbdYTq3qyS60ubwJ8GbovFuPe K/CyeC/Kh3sInZVefWnW+ImdhtYEuy+HfqVtidQ+ X-Google-Smtp-Source: APBJJlFel5F91WF38N/Ma9BXBqSumdIUfaXPm38xcZEmd46V3Sw+DRUSf//YD6ttv9zQvAnO8kSEtklzmiH0ms9z3sUS X-Received: from axel.svl.corp.google.com ([2620:15c:2a3:200:c201:5125:39d1:ef3f]) (user=axelrasmussen job=sendgmr) by 2002:a81:a941:0:b0:579:e07c:2798 with SMTP id g62-20020a81a941000000b00579e07c2798mr45025ywh.2.1688766943660; Fri, 07 Jul 2023 14:55:43 -0700 (PDT) Date: Fri, 7 Jul 2023 14:55:32 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.41.0.255.g8b1d071c50-goog Message-ID: <20230707215540.2324998-1-axelrasmussen@google.com> Subject: [PATCH v4 0/8] add UFFDIO_POISON to simulate memory poisoning with UFFD From: Axel Rasmussen To: Alexander Viro , Andrew Morton , Brian Geffon , Christian Brauner , David Hildenbrand , Gaosheng Cui , Huang Ying , Hugh Dickins , James Houghton , "Jan Alexander Steffens (heftig)" , Jiaqi Yan , Jonathan Corbet , Kefeng Wang , "Liam R. Howlett" , Miaohe Lin , Mike Kravetz , "Mike Rapoport (IBM)" , Muchun Song , Nadav Amit , Naoya Horiguchi , Peter Xu , Ryan Roberts , Shuah Khan , Suleiman Souhlal , Suren Baghdasaryan , "T.J. Alumbaugh" , Yu Zhao , ZhangPeng Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Axel Rasmussen X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CD3368000A X-Stat-Signature: rqs3ogsz9ozgoe38613uej76ki7n4dyf X-Rspam-User: X-HE-Tag: 1688766944-835354 X-HE-Meta: U2FsdGVkX1/hAYR6nRUx0nKWzpBMWQX4U46y/oPT7/SV7YXql2FPqJRnZc1vDCVmzjZNNLdbYIvB8kILCUaLHo04spd0e2sUNgdQemSuNIER2W5hbbqnRcgItID8HMJ2V8FmKFU/6lmU/X0AWX12T3vy8sT91thDX6dCHjp1VLvtMMfit6c0bB/CPPQcKi386MUmlaFrsVZpmQT91msRGeW0cLq8j0+xKJmH5vLT8rl1AeD9xSoDBi+x/DikbcdRdNex0qFJAPAKds7nMYbk4FJMUEyV6d2UwasgLjUUy66ST/1oqx+XPF5TaADxwqwvDUQpigoJuJZ6QxWzgr086uuNK96DjvsWQdcJBbdQbmoXA2F9VBxxud8IvsrS8axR935CqCG/iCRop1BFTBEUP3JyQYpBXZQfZK5yJhyobWo938baImjohS/gbpc5RHmhqSirh9507Y4lnO/S+PQv9bF2y/9Lz9ORjNa5rObTi74tP/GwoR9gxrPbCmPPJbQFWurHBwYN4croj5TeLnkliWzVOq+Mg4ABLLFnaTael6dN3cGRPlkcHtZMFm5rVT4f/CUCi/0FetX5Oq/Ab5aCSahZRTIF8Jr52t3aInlmubVZUnLqO2QFs8lcr6VDQ2En6CP7LgVStPXwk7TIlPsqLPOBHkbZdMiQjA6EKGl+2rVQkVANSlnq9Ip6KirZ/usfqoThJlt5jradb3DHl1suVtxtkyJveiHsnOZWTbZoGXnb+OPNYEhMLFhN5frXqOxYiXgIID8a0fOSi/z/k+j97JggKFYbcJgfVpPAJ7VFCQRzA5Fd0ZNWoZZU9dZx88UZmgPt4bLFz17qhU9jil4SVoGjanQr0+8Fi4UBCx767T3V9OSvId8l+xA3VXjmycVF7lzmDw6dGOkGWE0z2IWFe2NolLSzEQWJ83V+NDXf4yg8OKWpGVN1S6ChO/ZZVnaNVld+TaaiyUw6OGY/Qyj O0QUkT29 Jy77RNN2hl7TWOCCflQ51P41ffHiFCKhlAq262imewAvIDw7mm7tENUJ/dT8e+GuEyE4kuMe5E/snznZK1rz4LxPPKdcAG9Y0t0Lv5VA3A0vpybyKOGVr2s6m+4qHslFpXQOHL7sxJWcnTI1xZkpJfI+8PXhRDsWhF5D+rA6Erzx/ko734DGrYeQimC+A2F8SSa+RLDV7jZTDNHvxc2Eg7fU4A18CwOKZiJ3yVhJ1jkbg7N12YmFOKXXHOaImZVPCXcTCaewkjIOwYdL6wHLHo7KsKyiC/lqHwQBucsRNmewt3xsFQbOndiln03QnmZmH9JzQVC46k8DCm/ZBUdT2NcB7eNbccDz8un9kUYqTzchWkW4yUod3oyG7r5+6NudeAAj5T6DJTKLAayFF5iKPVMZDldDwd6OuWAzkKSI0Qw8X3oGhKp7ZNZMlYurJh9Uy1uuBD7yO7upwl3sqRyZDtn9fEddKCLcUsbSOElYBl9urm3rQJ340+uKK8OUBnCE8P1x6/U7AIM14daXlsUSLrbGM5pfZIlE/MSsBx5J/alzhCToiKU1eGC7W/yli/GRWIXl03FQoEdyJ1AtGT8eCT504hfQ6vigyxKPk3s1zyOCdgPPYFdj8AILryT2u5hw0INHbg5/ykgFqbSjsdcOS57vepz5H0KB2ic8HUEvn4XYQ2EunK3MgfJ0I7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This series adds a new userfaultfd feature, UFFDIO_POISON. See commit 4 for a detailed description of the feature. The series is based on Linus master (partial 6.5 merge window), and structured like this: - Patches 1-3 are preparation / refactoring - Patches 4-6 implement and advertise the new feature - Patches 7-8 implement a unit test for the new feature Changelog: v3 -> v4: - [Peter] Rename PTE_MARKER_ERROR and helpers to PTE_MARKER_POISONED. - [Peter] Switch from calloc to memset for initializing some state in the selftest. v2 -> v3: - Rebase onto current Linus master. - Don't overwrite existing PTE markers for non-hugetlb UFFDIO_POISON. Before, non-hugetlb would override them, but hugetlb would not. I don't think there's a use case where we *want* to override a UFFD_WP marker for example, so take the more conservative behavior for all kinds of memory. - [Peter] Drop hugetlb mfill atomic refactoring, since it isn't needed for this series (we don't touch that code directly anyway). - [Peter] Switch to re-using PTE_MARKER_SWAPIN_ERROR instead of defining new PTE_MARKER_UFFD_POISON. - [Peter] Extract start / len range overflow check into existing validate_range helper; this fixes the style issue of unnecessary braces in the UFFDIO_POISON implementation, because this code is just deleted. - [Peter] Extract file size check out into a new helper. - [Peter] Defer actually "enabling" the new feature until the last commit in the series; combine this with adding the documentation. As a consequence, move the selftest commits after this one. - [Randy] Fix typo in documentation. v1 -> v2: - [Peter] Return VM_FAULT_HWPOISON not VM_FAULT_SIGBUS, to yield the correct behavior for KVM (guest MCE). - [Peter] Rename UFFDIO_SIGBUS to UFFDIO_POISON. - [Peter] Implement hugetlbfs support for UFFDIO_POISON. Axel Rasmussen (8): mm: make PTE_MARKER_SWAPIN_ERROR more general mm: userfaultfd: check for start + len overflow in validate_range mm: userfaultfd: extract file size check out into a helper mm: userfaultfd: add new UFFDIO_POISON ioctl mm: userfaultfd: support UFFDIO_POISON for hugetlbfs mm: userfaultfd: document and enable new UFFDIO_POISON feature selftests/mm: refactor uffd_poll_thread to allow custom fault handlers selftests/mm: add uffd unit test for UFFDIO_POISON Documentation/admin-guide/mm/userfaultfd.rst | 15 +++ fs/userfaultfd.c | 73 ++++++++++-- include/linux/mm_inline.h | 19 +++ include/linux/swapops.h | 15 ++- include/linux/userfaultfd_k.h | 4 + include/uapi/linux/userfaultfd.h | 25 +++- mm/hugetlb.c | 51 ++++++-- mm/madvise.c | 2 +- mm/memory.c | 15 ++- mm/mprotect.c | 4 +- mm/shmem.c | 4 +- mm/swapfile.c | 2 +- mm/userfaultfd.c | 83 ++++++++++--- tools/testing/selftests/mm/uffd-common.c | 5 +- tools/testing/selftests/mm/uffd-common.h | 3 + tools/testing/selftests/mm/uffd-stress.c | 8 +- tools/testing/selftests/mm/uffd-unit-tests.c | 117 +++++++++++++++++++ 17 files changed, 379 insertions(+), 66 deletions(-) --- 2.41.0.255.g8b1d071c50-goog