From patchwork Sun Jul 30 01:29:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Boqun Feng X-Patchwork-Id: 13333328 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5500CC41513 for ; Sun, 30 Jul 2023 01:29:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DF6C8D0002; Sat, 29 Jul 2023 21:29:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6922B8D0001; Sat, 29 Jul 2023 21:29:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52FB78D0002; Sat, 29 Jul 2023 21:29:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 403AB8D0001 for ; Sat, 29 Jul 2023 21:29:54 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EBFF6A045A for ; Sun, 30 Jul 2023 01:29:53 +0000 (UTC) X-FDA: 81066546666.25.B544642 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf22.hostedemail.com (Postfix) with ESMTP id B7CA6C000D for ; Sun, 30 Jul 2023 01:29:51 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=fSTNlLWf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690680591; a=rsa-sha256; cv=none; b=ahQ0YZ3RZ9OTapV54MHkjoxU99gU2PS+N7UmLQCqHT9wzU+pzuyadZzeJutx5+3E09BgtM PbASUI9XWb8l8xmH75KAerc1Hh75bvmLt5nuUgo14w7w/SuOJt85dMFDCbEE0xN7EdJzn9 Wny2Y0nZuawRbGtrqiwSXNpSM/sntjs= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=fSTNlLWf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690680591; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=sHPSm4abOb9l98MpBhFZNGhszS0pZcdCCKi7Bi/pqvI=; b=hmIIAhAswbxs/MlDADVnh+Hr3GJvDG1IWdI2+StNxk8eSON3zmGzuWR9GFFPuSXNihOoTI hq6sLJE+R5jbuMBhgWtZ3wCU6PwbYBT1GdsRJYMQ/7qI5YzjS8tGEue+9ZTCzsD7uVPCuF Y5CyokwiSVFl0oa102UKJjl6JuAW0cA= Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-9923833737eso476261666b.3 for ; Sat, 29 Jul 2023 18:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690680590; x=1691285390; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:feedback-id:from:to:cc:subject:date:message-id:reply-to; bh=sHPSm4abOb9l98MpBhFZNGhszS0pZcdCCKi7Bi/pqvI=; b=fSTNlLWfNz4UoXw+opBwkzeopFwjV7EL7X41MsBp7VcgKq6HqR//8ybtgJ5qfzp8FG 8gPfw76VQ/dmmaLkQY0IpqGwQ6a5B4djKNavWZ31xu/m5/b86+xEs4PfEjsWJdP0IdlE UpoSAalXythXlkg+YPSxc4KupZQZ33rixHeuuE/b+TXziz/718H7RNFxqid6VDdovybu U8PTWarYha5UcupNAJIHdBD/4q2T57x5J9bs8dknAbhVyMkvwcZ9DGuG13p8nXVHDdZg pEdi36dEO6bChjtC3GCtaHPi68XE1NY9lqG3t2W5f1lZBLyi3kcVKu7XhHKZp+k5fi/p Ed1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690680590; x=1691285390; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:feedback-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sHPSm4abOb9l98MpBhFZNGhszS0pZcdCCKi7Bi/pqvI=; b=JfD/d9P0qe1rNeqURWfFo21wk8lN8Qa/aSJcTOr5dDdGVbfin5QBazE09hb1wpBCnh eBm6c7CTkSCH+w0PkZSj5T/WQLqRfv2ZBbyuVRo35eWWzwxQR08f77EsSplCXRD1jy5Q FZJZ8wcwGa16MXCC892jnW9+XtJIfwWRwtcrrx7UsXZ6S47T+V53McQB+hDTMoEUeBtZ gpZyhH9VwfcVLhHBwSEK/xjMS5wk0eVszCnBiGf0GKrJLn1oJ5Eq3Sf2AewRRkI/SM7t cJ85WKa7DXucV0aDQcf2t3G7jKcK+N6x0/caYfKCXSc4czQVs2z9lOL48AWWcdzoDwVn vUiw== X-Gm-Message-State: ABy/qLbqo+k5rX8J2Zbi+ENS6gMbWb29rNZLfA9ne4wtYUbM6f5cyec2 Q7ZpkJuppBrrv6i3zagwNFc= X-Google-Smtp-Source: APBJJlEnRj1eTU/0PQU8AhT5UyCJsLMVbQ5xl0KZHPACbfNIzXty1iKA/b58dLi7nUq/bBkNlbSxFg== X-Received: by 2002:a17:906:1cf:b0:99b:ef86:60d8 with SMTP id 15-20020a17090601cf00b0099bef8660d8mr3401915ejj.5.1690680589930; Sat, 29 Jul 2023 18:29:49 -0700 (PDT) Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com. [66.111.4.228]) by smtp.gmail.com with ESMTPSA id br15-20020a170906d14f00b0098e42bef736sm3995349ejb.176.2023.07.29.18.29.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jul 2023 18:29:49 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 7477927C005A; Sat, 29 Jul 2023 21:29:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 29 Jul 2023 21:29:46 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrieelgdegiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffogggtgfesthekredtredtjeenucfhrhhomhepuehoqhhunhcu hfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtffrrghtth gvrhhnpeekgffgveeutdeuhfegteevudduffejjedvjefftedtkefgueejgedvtdeutdef keenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepsghoqhhunhdomhgvshhmthhprghuthhhphgv rhhsohhnrghlihhthidqieelvdeghedtieegqddujeejkeehheehvddqsghoqhhunhdrfh gvnhhgpeepghhmrghilhdrtghomhesfhhigihmvgdrnhgrmhgv X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 29 Jul 2023 21:29:44 -0400 (EDT) From: Boqun Feng To: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Martin Rodriguez Reboredo , Alice Ryhl , Dariusz Sosnowski , Geoffrey Thomas , Fox Chen , John Baublitz , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Kees Cook , stable@vger.kernel.org Subject: [PATCH 0/3] Fix alignment issue and prepare for rust 1.71 Date: Sat, 29 Jul 2023 18:29:01 -0700 Message-ID: <20230730012905.643822-1-boqun.feng@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B7CA6C000D X-Stat-Signature: 6qc7tsfho56t6uoesxqd7dw3jqzkzq7a X-HE-Tag: 1690680591-103553 X-HE-Meta: U2FsdGVkX19IxDCGN19d1JUqzRdjbu1hHr2/5PmJmfHr5Uhoq5i+kuudlIo70rfRtQlxrEq0kJBvFEKvMyDeZLdffk5ZFPrpFTFc77im/QJLQsCcco+1sxpBed0FmvuPAb0dlqUf98kLL0YV/flYmNGipSxpN2F7mEIeuqadnjWN5gFzJ7ZlA4V27NmFd1EHO2BqZyQKmX53wWpXZCImgRk9ZRSOhAU8nX3cVxZT28thUEZFiuvY89Q/jYa2q6fymRv+tkRdNRwReyfbLzDexXRCcbj5I70oGqt8MJDIyF+jwDipc0TALZc9bCq05wndyXBcOBe/TcvAipumYot0gRGO66glLk336qdhPiHB17zCfgLVAuOIaVloCpT9kGULe0Ebpgo4zSQ3/1IhnjMz7qeQUwUxjoui0mg/wu751BHeg5CgbmLUlcFb77hA8ATn20qI2PAUzIK6FqXNbbMqf5efyfSCcWuv6YzM1JtiYp8ZCSVlHJu6FdSihWnAD73PaZC3ywam+JRSNE0xQT0Q136GKbR2akg6hpClUcnauFO7+fX4kwf0FFZeEPPD9WtD16zSvEysM6apYJtxGgE637Qdm44WEcUNY5KKhaOCJrJn5xujSuFIymZAD58aJEzc3aY5Qevl+wMOs6J/fH4hzjwX/wMXja6nae+ow0UIyteQVRDiVlckK9zfo+ElvdFvEOmUNmxtubVZKIjh/2p+LHova40PUcbLIfNi3kanLMa8cBw8ob73iRkP1ivoJs4wuVbI5/C95NxxIPJBUjm8amYirLQYjq3+KPJhYllcSQSXwlsTIZtZXzO8JusVTwskQ2W17k7keNG85U1vHu4XlAaQLP2XAaaaUF3G52w3I8iiHTJZlS8SYUYUuEANuoXRRosnCnqlJDoiqu2DktoZ3NvHzQbxnFwJi1tFmS6NTEUBbAUcNxlhZz5yd6rQSln3NMAV8PkhgdYkxGZnO3f xSLPDAXK 332zPHTQ1QpLY1EJ5IGOZo/j0BzdzKcMOQQ060qBIZVMVkad05JLEzBVe5/sDQTmH8NDj7QyYyT4id/jm4NFC4VpSvLOC0IIR311sX6+PB5myYH8DGrtYmWCrv5+ugeoWV5iDVZNCB+2P+VkDaPkJRX/gvTe+BDwAT/ziPbDDb96bbE3oUbAqWkNBOft7OJFqV8rqjkUv9lB/SJuQ5c47xxMeVzv+luDN8J+3Q40wpLFRD2YLEoEm09kRMF/sJEZQYxsquDJue0iQQpaUuob9jqnGVsp9/MG9WXdV5/RTI9pCdokwMLYYaL92zp02T4jyZFbz5c20VVnGnK/6ShB+GqHv4IHU0AEIxn142/FJcJQbTL5JhPC7qTbl6+U1f6JtYCahsaoHhzCRckRN/sYKUeSRN11gxc68cn0cgbhplTIAhM5If9w0lJFppOh19yRHb3GUdaoIXSAvQg5nQSniKrOm4ve75je2mx9ejp3PbJkjZI0aYgAp53LiQLnieXv86tmu4bg8B6ydmzpzRYYrPRZfTRPqSqylFilvI2Y8oXbwj1VrGrg1CFKUwNC8HKZp4oAA3SYQVaAOHFAD0ZRmSmUvwj8oug7GABfy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Miguel, I end up with this series: (background: https://lore.kernel.org/rust-for-linux/CANiq72=pb18B6NOcXF03d0ctOP8kv2dqnUeNyEuSvuDb=vs-0g@mail.gmail.com/) Patch #1: introduces the core helper function that help calculate the correct size for krealloc(), and also use the helper function to fix `__rust_*` ones, this should be backported to stable kernels hence the Cc. Patch #2: use the helper function in KernelAllocator Patch #3: Bjorn's patch with correct use of the helper function. I have to add a few more SAFETY comments in these `__rust_*` functions, which may cause conflict with your 1.71 series. Since all previous patches get refactored a bit, I dropped all the Reviewed-bys, appreciate anyone to take a look, thanks! Regards, Boqun Björn Roy Baron (1): rust: alloc: Add realloc and alloc_zeroed to the GlobalAlloc impl Boqun Feng (2): rust: allocator: Prevent mis-aligned allocation rust: allocator: Use krealloc_aligned() in KernelAllocator::alloc rust/bindings/bindings_helper.h | 1 + rust/kernel/allocator.rs | 107 ++++++++++++++++++++++++++------ 2 files changed, 90 insertions(+), 18 deletions(-)