From patchwork Mon Jul 31 13:43:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 13334663 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 331C7C001DF for ; Mon, 31 Jul 2023 13:50:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B16D1280040; Mon, 31 Jul 2023 09:50:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC728280023; Mon, 31 Jul 2023 09:50:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9685F280040; Mon, 31 Jul 2023 09:50:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 88502280023 for ; Mon, 31 Jul 2023 09:50:51 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4AE79140B1B for ; Mon, 31 Jul 2023 13:50:51 +0000 (UTC) X-FDA: 81072042702.11.C948041 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 5A8CB8000A for ; Mon, 31 Jul 2023 13:50:49 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Llgoi3bJ; spf=pass (imf30.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690811449; a=rsa-sha256; cv=none; b=4R3Sd3u+UNdiN2J2d7G8hYQ+3Mkt2NKelpdLMT+EhD/vVX8gRNalzP3jggMuhDsk0MvX77 W5T/BDvecvJtGpvPqx6NhrTAx90Hq4E6wOmBfzOCp5TeBMaHNpWhAP2cVg0kbZR8lKd7PJ ZlumHQXylAODv4M8KSIRAdY1lEwnI4k= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Llgoi3bJ; spf=pass (imf30.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690811449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=jUyIapBIaEddMbEhPJPbvjNZtSb04Figz5q2svJWuKQ=; b=GTCTyNA+UoaQisRiiKQlOX9uuBa9+mn5jSTsLxy0Z+Fm7RygEmp37ZJBoKyWBJXy2q/XHT CK6Bpt4NX0Y7eG605XYbBo+kYlYo+6g5xq7Y0pwov1fxuuQieShRUP6zD+X/Mui/Q4nzha eq206tibDXvZh1R7CXhQHF6Zu9yNa/A= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 559626114A; Mon, 31 Jul 2023 13:50:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5931C433C8; Mon, 31 Jul 2023 13:50:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690811447; bh=50JVwzj8qJfjyIBPQpQeRTAaPHZ3dWWGHVPJY/gn04c=; h=From:Subject:Date:To:Cc:From; b=Llgoi3bJFFKaeaTlLL7dbwkfCoc4bm0OfDthXAZTm8fADrLelTE97sMux/WA6nnsM i5WpVVbhSyc+yMrX8ogHdxc4F63k40770UBkqNZbEh7NVtPbGwFveWQWh97vzN6bpV TO/UEtr/JHRs0JaDD+LQMqQnQoAYTeslngr7htGtnrSCP5tL1zIxgT97AW33kyJMmJ de2rjv21dXyXiQUHHYnHAwPijKew5PReAekSkT4DMjHOVAQkMsnfmAVINoowwHMU6f 1H7trRR78m1qmr1OxpDf4CLVHkRmSiU2SHdcfWPVus88rrYq6g5Rd6c8ZmfoER9sVS KscStz8a72FRQ== From: Mark Brown Subject: [PATCH v3 00/36] arm64/gcs: Provide support for GCS in userspace Date: Mon, 31 Jul 2023 14:43:09 +0100 Message-Id: <20230731-arm64-gcs-v3-0-cddf9f980d98@kernel.org> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAG66x2QC/1WNyw7CIBBFf6VhLQaGSq0r/8O44DFtiUobaIim6 b8LdVMzq3Mz596FRAwOI7lUCwmYXHSjzyAOFTGD8j1SZzMTYCBYPqrCS9a0N5Gi4FxpZs8NtCT /axWR6qC8GYoxv6aSTgE7994WbvfMg4vzGD7bYOIl/XU3XO66E6eM6u4km64VWit5fWDw+DyOo SelJsFOhXqvQlatAcNtXRtA/aeu6/oFLexvHvQAAAA= To: Catalin Marinas , Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Kees Cook , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy Cc: "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Mark Brown X-Mailer: b4 0.13-dev-099c9 X-Developer-Signature: v=1; a=openpgp-sha256; l=11031; i=broonie@kernel.org; h=from:subject:message-id; bh=50JVwzj8qJfjyIBPQpQeRTAaPHZ3dWWGHVPJY/gn04c=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBkx7wUH7If9xebjVodrbMHJwQj64DXdL7zmlc+L2J6 TXtCMESJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZMe8FAAKCRAk1otyXVSH0E5wB/ 40P2LqHoJcThv2r88xrDKPU+cAEwRY6SVJmy8ZYApLejIbyk2DF50F3nHiAICJPwz5GA72tLnfvaFy 2uWKYmWD00DxK0fVugzhhaiDEvcNkDbzJTQCmmwqh3/RrwqWzd5R4iLiuDJFKErFZagtfkUU00t07Q lrT6saMObg96CqbGaODQ3RjYNed9O0nORrIWy2f0+hEw/oWvP9Ps8iwUKuhp7aTYqGJPXBl/h0tdB3 In3wLoNv6ocrgXw+YAGBqbPgOy00bu7YB98Q2QOi5ZmboJfu4U+707g/YqfamcY8mEMfF+BzzVD+AE v94RIVK+3d3lNteS0Q5YDJTm1ofbYe X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5A8CB8000A X-Stat-Signature: ezm1euqn5gk4w7dshzhmbxgobi87js3e X-Rspam-User: X-HE-Tag: 1690811449-100460 X-HE-Meta: U2FsdGVkX1+3Y3TLQEhkM6P/A+3D4dORvJXId5S3ZXfqQ2ysULdSEgV5LMJhfOh2WjD1APuzioMmBgfm1ydNubtu22Sd3xHk689lmGmx8EjWTEzQRYqPl6SQX02Cqnz5eYTzhxdua7TLMikKnVk1trNW328isj1rtLO6WlNb0iOhzxlnGKmYz6uT10vPwvCCGevkFFk0kykQ0fV8xSWZRzUD5Ty+y4dqY0spW68pNZbM0j2PAzrH2T+Gp9/Uc3xCTnCE2qqjroJAxaCIlV4Cbchb5eigzZSm+mxLAvlRlbJrC8i0FiD4XTFMcd7dRW2vzIqJyfXWdjUQeLfslqItcq6Ur9r9KdyU0NWsOm6fKa0BOov7j9hL+EopzbarjSPFww59VXwM3AxdRzlXhhrHNqe6zGD0hmfqrjElJtm28+DTQfEmdXl3tlHMf98iSeEqly+iY6H+dyq+Yg+zxvmg1j5drvsdU1ACf74HUBB//98K/DoOhVwrjbmYx6fEAQJW8kpRUYPEjrG8VBclp6de/7tPfS9kwgodN5FT/GpfNlf4WhtfHzxvJau6Q/SFG+aDSUkaM4hyQzsfyEWtqKSBFtOfmIRUGtXriql5x2q7veNVcfe4vsYmLc0EDYwGYI0FesZUWyotres9QCBQyWxWc915jyH/6uakc8PyKKkz5QYMPhfyIWACyVht7zIH9yA7bg44NM7ASRQIGCKSfO2qGeugrDaWztVsxv3Y+q089RtwXpL+sARUnTnxsyIvLm/RicwnqmThles5DTJsRZ44npN2Rq/Lf76fvkTtryl+iMDBCGiY2tRshBLVRnX4zsKt6prdG5c3gIM+zHlAah3QEd3Puif6SyKh8cfuaHXU2NHUH9f8gHzvysTs3XxCdb/hbrL1ppWC7UURNlMMbM1t+kJXlcU6YItjCxwJkwJ5T02t8ydL7Cl+eRSNPv2Pzo2+SN9JevlMsW7iYnBUCzT XP9tJISh OUyUzFT+IZYPmmKrNbny7zrX+1HuwqrVmeo8PRkTuUdGyyeyrDnaCO4WwJO/CtpfJx5MMCeYr/SpqnzeD2msO2Cawu1pCHrhO4uxZa2hByc0vXUmTRsCJ1BQzxko2Liya8YNTtIac9SOCLwYMj2UkQUlDXqv/L9RMtzlXe1rrE+o1H+4FOG5sJygE6rnVLUuwQgufbizobEYC8w+AXPJVpHVtLQI3LbXHOD5HnxMgfLiL5mKxT2wkzFFF4sjzHIuNOz6ldJ/btXVnsrI4+KrI4HQnE17fDgXt/VvIz/lVso0JComHpY3nMzBFLCvofIJAObFn2lVITXnhVKefSGWcNSHIokNAWele1pBc8otQ0YEubE8QsW88l4uY2r4iq9DcOF9arXoEnnO419QnmvJbEqsE5PFQVCh1YAdGDu5CO0MgzMPRnFJDPBKbVqnKvm9UjQrtEo5+qhg8JjI6JL7FaMZawCIyYtdknc63ZhmaSBHbMikQqWDfs+itgTDzK9L4rI/W X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The arm64 Guarded Control Stack (GCS) feature provides support for hardware protected stacks of return addresses, intended to provide hardening against return oriented programming (ROP) attacks and to make it easier to gather call stacks for applications such as profiling. When GCS is active a secondary stack called the Guarded Control Stack is maintained, protected with a memory attribute which means that it can only be written with specific GCS operations. When a BL is executed the value stored in LR is also pushed onto the GCS, and when a RET is executed the top of the GCS is popped and compared to LR with a fault being raised if the values do not match. GCS operations may only be performed on GCS pages, a data abort is generated if they are not. This series implements support for use of GCS by userspace, along with support for use of GCS within KVM guests. It does not enable use of GCS by either EL1 or EL2. Executables are started without GCS and must use a prctl() to enable it, it is expected that this will be done very early in application execution by the dynamic linker or other startup code. x86 has an equivalent feature called shadow stacks, this series depends on the x86 patches for generic memory management support for the new guarded/shadow stack page type and shares APIs as much as possible. As there has been extensive discussion with the wider community around the ABI for shadow stacks I have as far as practical kept implementation decisions close to those for x86, anticipating that review would lead to similar conclusions in the absence of strong reasoning for divergence. The main divergence I am concious of is that x86 allows shadow stack to be enabled and disabled repeatedly, freeing the shadow stack for the thread whenever disabled, while this implementation keeps the GCS allocated after disable but refuses to reenable it. This is to avoid races with things actively walking the GCS during a disable, we do anticipate that some systems will wish to disable GCS at runtime but are not aware of any demand for subsequently reenabling it. x86 uses an arch_prctl() to manage enable and disable, since only x86 and S/390 use arch_prctl() a generic prctl() was proposed[1] as part of a patch set for the equivalent RISC-V zisslpcfi feature which I initially adopted fairly directly but following review feedback has been reviewed quite a bit. There is an open issue with support for CRIU, on x86 this required the ability to set the GCS mode via ptrace. This series supports configuring mode bits other than enable/disable via ptrace but it needs to be confirmed if this is sufficient. There's a few bits where I'm not convinced with where I've placed things, in particular the GCS write operation is in the GCS header not in uaccess.h, I wasn't sure what was clearest there and am probably too close to the code to have a clear opinion. The reporting of GCS in /proc/PID/smaps is also a bit awkward. The series depends on the x86 shadow stack support: https://lore.kernel.org/lkml/20230227222957.24501-1-rick.p.edgecombe@intel.com/ I've rebased this onto v6.5-rc3 but not included it in the series in order to avoid confusion with Rick's work and cut down the size of the series, you can see the branch at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/misc.git arm64-gcs [1] https://lore.kernel.org/lkml/20230213045351.3945824-1-debug@rivosinc.com/ Signed-off-by: Mark Brown --- Changes in v3: - Rebase onto v6.5-rc4. - Add a GCS barrier on context switch. - Add a GCS stress test. - Link to v2: https://lore.kernel.org/r/20230724-arm64-gcs-v2-0-dc2c1d44c2eb@kernel.org Changes in v2: - Rebase onto v6.5-rc3. - Rework prctl() interface to allow each bit to be locked independently. - map_shadow_stack() now places the cap token based on the size requested by the caller not the actual space allocated. - Mode changes other than enable via ptrace are now supported. - Expand test coverage. - Various smaller fixes and adjustments. - Link to v1: https://lore.kernel.org/r/20230716-arm64-gcs-v1-0-bf567f93bba6@kernel.org --- Mark Brown (36): prctl: arch-agnostic prctl for shadow stack arm64: Document boot requirements for Guarded Control Stacks arm64/gcs: Document the ABI for Guarded Control Stacks arm64/sysreg: Add new system registers for GCS arm64/sysreg: Add definitions for architected GCS caps arm64/gcs: Add manual encodings of GCS instructions arm64/gcs: Provide copy_to_user_gcs() arm64/cpufeature: Runtime detection of Guarded Control Stack (GCS) arm64/mm: Allocate PIE slots for EL0 guarded control stack mm: Define VM_SHADOW_STACK for arm64 when we support GCS arm64/mm: Map pages for guarded control stack KVM: arm64: Manage GCS registers for guests arm64/gcs: Allow GCS usage at EL0 and EL1 arm64/idreg: Add overrride for GCS arm64/hwcap: Add hwcap for GCS arm64/traps: Handle GCS exceptions arm64/mm: Handle GCS data aborts arm64/gcs: Context switch GCS state for EL0 arm64/gcs: Allocate a new GCS for threads with GCS enabled arm64/gcs: Implement shadow stack prctl() interface arm64/mm: Implement map_shadow_stack() arm64/signal: Set up and restore the GCS context for signal handlers arm64/signal: Expose GCS state in signal frames arm64/ptrace: Expose GCS via ptrace and core files arm64: Add Kconfig for Guarded Control Stack (GCS) kselftest/arm64: Verify the GCS hwcap kselftest/arm64: Add GCS as a detected feature in the signal tests kselftest/arm64: Add framework support for GCS to signal handling tests kselftest/arm64: Allow signals tests to specify an expected si_code kselftest/arm64: Always run signals tests with GCS enabled kselftest/arm64: Add very basic GCS test program kselftest/arm64: Add a GCS test program built with the system libc kselftest/arm64: Add test coverage for GCS mode locking selftests/arm64: Add GCS signal tests kselftest/arm64: Add a GCS stress test kselftest/arm64: Enable GCS for the FP stress tests Documentation/admin-guide/kernel-parameters.txt | 3 + Documentation/arch/arm64/booting.rst | 22 + Documentation/arch/arm64/elf_hwcaps.rst | 3 + Documentation/arch/arm64/gcs.rst | 225 +++++++++ Documentation/arch/arm64/index.rst | 1 + Documentation/filesystems/proc.rst | 2 +- arch/arm64/Kconfig | 19 + arch/arm64/include/asm/cpufeature.h | 6 + arch/arm64/include/asm/el2_setup.h | 17 + arch/arm64/include/asm/esr.h | 28 +- arch/arm64/include/asm/exception.h | 2 + arch/arm64/include/asm/gcs.h | 106 ++++ arch/arm64/include/asm/hwcap.h | 1 + arch/arm64/include/asm/kvm_arm.h | 4 +- arch/arm64/include/asm/kvm_host.h | 12 + arch/arm64/include/asm/pgtable-prot.h | 14 +- arch/arm64/include/asm/processor.h | 7 + arch/arm64/include/asm/sysreg.h | 20 + arch/arm64/include/asm/uaccess.h | 42 ++ arch/arm64/include/uapi/asm/hwcap.h | 1 + arch/arm64/include/uapi/asm/ptrace.h | 8 + arch/arm64/include/uapi/asm/sigcontext.h | 9 + arch/arm64/kernel/cpufeature.c | 19 + arch/arm64/kernel/cpuinfo.c | 1 + arch/arm64/kernel/entry-common.c | 23 + arch/arm64/kernel/idreg-override.c | 2 + arch/arm64/kernel/process.c | 85 ++++ arch/arm64/kernel/ptrace.c | 59 +++ arch/arm64/kernel/signal.c | 237 ++++++++- arch/arm64/kernel/traps.c | 11 + arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h | 17 + arch/arm64/kvm/sys_regs.c | 22 + arch/arm64/mm/Makefile | 1 + arch/arm64/mm/fault.c | 78 ++- arch/arm64/mm/gcs.c | 226 +++++++++ arch/arm64/mm/mmap.c | 17 +- arch/arm64/tools/cpucaps | 1 + arch/arm64/tools/sysreg | 55 +++ fs/proc/task_mmu.c | 3 + include/linux/mm.h | 16 +- include/linux/syscalls.h | 1 + include/uapi/asm-generic/unistd.h | 5 +- include/uapi/linux/elf.h | 1 + include/uapi/linux/prctl.h | 22 + kernel/sys.c | 30 ++ kernel/sys_ni.c | 1 + tools/testing/selftests/arm64/Makefile | 2 +- tools/testing/selftests/arm64/abi/hwcap.c | 19 + tools/testing/selftests/arm64/fp/assembler.h | 15 + tools/testing/selftests/arm64/fp/fpsimd-test.S | 2 + tools/testing/selftests/arm64/fp/sve-test.S | 2 + tools/testing/selftests/arm64/fp/za-test.S | 2 + tools/testing/selftests/arm64/fp/zt-test.S | 2 + tools/testing/selftests/arm64/gcs/.gitignore | 5 + tools/testing/selftests/arm64/gcs/Makefile | 23 + tools/testing/selftests/arm64/gcs/asm-offsets.h | 0 tools/testing/selftests/arm64/gcs/basic-gcs.c | 351 ++++++++++++++ tools/testing/selftests/arm64/gcs/gcs-locking.c | 200 ++++++++ .../selftests/arm64/gcs/gcs-stress-thread.S | 311 ++++++++++++ tools/testing/selftests/arm64/gcs/gcs-stress.c | 532 +++++++++++++++++++++ tools/testing/selftests/arm64/gcs/gcs-util.h | 87 ++++ tools/testing/selftests/arm64/gcs/libc-gcs.c | 372 ++++++++++++++ tools/testing/selftests/arm64/signal/.gitignore | 1 + .../testing/selftests/arm64/signal/test_signals.c | 17 +- .../testing/selftests/arm64/signal/test_signals.h | 6 + .../selftests/arm64/signal/test_signals_utils.c | 32 +- .../selftests/arm64/signal/test_signals_utils.h | 39 ++ .../arm64/signal/testcases/gcs_exception_fault.c | 59 +++ .../selftests/arm64/signal/testcases/gcs_frame.c | 78 +++ .../arm64/signal/testcases/gcs_write_fault.c | 67 +++ .../selftests/arm64/signal/testcases/testcases.c | 7 + .../selftests/arm64/signal/testcases/testcases.h | 1 + 72 files changed, 3683 insertions(+), 34 deletions(-) --- base-commit: 730a197c555893dfad0deebcace710d5c7425ba5 change-id: 20230303-arm64-gcs-e311ab0d8729 Best regards,