From patchwork Wed Aug 9 01:51:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charlie Jenkins X-Patchwork-Id: 13347308 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81AD3C001B0 for ; Wed, 9 Aug 2023 01:53:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB8B76B0071; Tue, 8 Aug 2023 21:53:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D68C86B0074; Tue, 8 Aug 2023 21:53:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C301B8D0001; Tue, 8 Aug 2023 21:53:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B0A2C6B0071 for ; Tue, 8 Aug 2023 21:53:09 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 75D3714035B for ; Wed, 9 Aug 2023 01:53:09 +0000 (UTC) X-FDA: 81102893298.27.A7B15E2 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf05.hostedemail.com (Postfix) with ESMTP id A9C64100019 for ; Wed, 9 Aug 2023 01:53:07 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b=Stgyxger; dmarc=none; spf=pass (imf05.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=charlie@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691545987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=UtoNrqFUKslO70ZXL4UNEXOjKDOXZBueUpk6sT8KlRA=; b=yz+GRNQrC/CtxjdddYSggKMcuuWmyXbtXvQfqkUG8+LkLeiudJUuwziLhlvBqQS7yd8HpR y6gderPhpfTaeaXRFl+lhQB1qie55mDHNSnzz4Dti7RIQ7vvzDDmcvWJd1CvihwgZaua3q lG+qBJ1G7uxYWv5Y5uaJfXBfIE8Qq6U= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b=Stgyxger; dmarc=none; spf=pass (imf05.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=charlie@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691545987; a=rsa-sha256; cv=none; b=okC950zjYRQz9awOfW1YHfl8o192JpURZ5YXJmBQ7MUWen3PNHn2SNUNhoin1aIM9WZn/p wx/DDzFmEBV8PghV8QA5bCRHtRA5Qsssj3T4F0bA2ABAd2QSymildKT4tE/yr0E4g1Fqae 82+cTROXZkgabUmGmMzpQrYKaFiBRdk= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1b8b2b60731so39944445ad.2 for ; Tue, 08 Aug 2023 18:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1691545986; x=1692150786; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UtoNrqFUKslO70ZXL4UNEXOjKDOXZBueUpk6sT8KlRA=; b=StgyxgerM/v48ko0wif1IouoNrGfeAt0DQ9gH4XXOfXEvWdda9w/lRT/W0WLrYHw8Y HCI7mRrtJwdyITpgruffl82O3nc4neJFoCZmYn2rwc6n5b5kkyueu/OV3qwN5pQNXVjl gD8c72+AoAbNzG6wi0yhhdTdeZvrG/v/2GNuSusbIxt4H5XAhxp95/5j4s6pBgDkjjgj F/RYJYuDwMyJLNFUBnuiYtOePN6sMW+75O0ck7p0+zzR2FqrHGhUp0KePrWL3VR1nPHt GqWhS4Dsi1mH1CKzHnPDOBNf/lzH42O7nktuH/HgyW4DJE8IY/sa6GNje/dgSwG+MxS+ CteQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691545986; x=1692150786; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UtoNrqFUKslO70ZXL4UNEXOjKDOXZBueUpk6sT8KlRA=; b=lRQD39zkicTRgr5f2uuA5fRqy+0R/YNOdBmQREUUghUJkYeD8Nf9vx1jRWIchOqi4+ FI6xbCUsteQUoKk1Hhcx40lM1XyaN41BrnLGhuqMPHl/AUAI0RJEwBEmZmA0jlz5Eyu/ BqcPkpFhJVouM/SngUpBduo4CaR7MPZrddiRbSSriO+2X9iBkRCoRCWm6nZ6Tq4Y8JEw SH7hXp6LLPFksDSuYWLRLDy01JaP9E/ut5bKtdcYCrFZMjX2IMemRUsZC7fvdcYfi8MA lZPEIdCok4YShMggg/uk6FVeJvTsbx5UNKHSyRqAG7HzHBi5x6WmzdM9eJJVqBwEeHso 0ULw== X-Gm-Message-State: AOJu0YzDMtQHSTV3cslr21VWGv+i++JgyB03QrCqhX0hW8iMHyhj24aM ScBibjD/UCs5qML6xSsK56ChcQ== X-Google-Smtp-Source: AGHT+IETK47y7WHfs1Fi+VVpMxPGO7IsKhzhbeCiVg2BmCKUP+WGC7R8S47dwV+JENhl+KILQ0Yv9A== X-Received: by 2002:a17:903:2351:b0:1b8:9ecd:8b86 with SMTP id c17-20020a170903235100b001b89ecd8b86mr1790925plh.5.1691545986411; Tue, 08 Aug 2023 18:53:06 -0700 (PDT) Received: from charlie.ba.rivosinc.com ([66.220.2.162]) by smtp.gmail.com with ESMTPSA id bj7-20020a170902850700b001b87bedcc6fsm9657591plb.93.2023.08.08.18.53.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 18:53:05 -0700 (PDT) From: Charlie Jenkins To: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Cc: charlie@rivosinc.com, conor@kernel.org, paul.walmsley@sifive.com, palmer@rivosinc.com, aou@eecs.berkeley.edu, anup@brainfault.org, konstantin@linuxfoundation.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, mick@ics.forth.gr, jrtc27@jrtc27.com, rdunlap@infradead.org, alexghiti@rivosinc.com Subject: [PATCH v9 0/4] RISC-V: mm: Make SV48 the default address space Date: Tue, 8 Aug 2023 18:51:06 -0700 Message-Id: <20230809015110.3290774-1-charlie@rivosinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Rspamd-Queue-Id: A9C64100019 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: a99dgxatoqjqq31dcyi5pqcbrfps9w1f X-HE-Tag: 1691545987-92543 X-HE-Meta: U2FsdGVkX1+deVh/MaTaf9nMw2d43fGJK5pHJGcaEgklA/lmnLFHsBlZj9Na287mDP+y+dODst+8Y7ceO7w8/iiDO8TNsaQYRfMJMpJ/biyfsIpKUyPlR4XyhzOGTq4R9sNsX44GR66MFY0uwb5OU5qAXGuq3M+O2on6JLVtJFH0jzTBjADKiByMoYwCUE+CSzvB2kSHKfHQh9o0sT1GBy3FuRscasTAyD28evLAJAlMur+xn1oHZ945cR9lXXftTE7PT0JW1Nr/mQPc8twt6seuh5fQp/MqeaBxuXBBxATZok0DVElrPeSLV2FxXwQKN+Gxwbxp2/2i/hucEc/XK+AsmtFIsdTnEGs2VuxuhekjMgNCVvNSw2zgbJd4ViGlkTHkoY4hQ7zcOl6sScum2HUkO7DA3lKCUhd1ItLGbyC2hkjUf3mGgnfR9lV8hTnV9U4V080odv1w3nHCqT5p3kUHTOC2YAQNg9wIpywNxvJ01BDWGZOx2KbDHJ+zaGHek3vEZKh6FBubI3LRrtx3NBsPAkbpLi0yWiawvlr94/lYukH5dvU1jwjRV5V5H64yWEQqlR9AfsJitht3ZNqbuNXk6v6ysBAbZhfCSdGpoC+wepbrIoi40ohp7CjaAfqG6uGHyzqfbIgb7R7ak7HVNWm/+q2PTMnTTfLD8PK90eHpCNp/CStmTLK/9lesV1ISy67FVR/CXaqKdipobyOqPUzRIayFXZwYwYBc05N5GVVfrFkAxvBF1wAsF86eDYmMeZehFh3YUfhIxwYrKbcmJwPR07yPQgwiWP2fHlua/0TfDhDGludqVcHUUOVGrMbOSgbUMO/ibWp3sMEd2fshZnWLzAhCvwjXOckdx7GKvzFWNDQVCPqN70OuLI/AOGlrl1aNDcDm/UNEaeyJKS2qXa1/w+ZPwFE/gyzPTo7jYb7mIW5kHpPsutsB5EqCqsUEoyyrvQf0n+sYdeD0HQc u5d8Pu3F h6evWCFdgHYH3tQlmpP+wX2zsBKN2gpwbdqPOWf1gskuvJtTB2XOOxXTzoj1fU9e/M0zh1dSwyQaNmcyViuTeJgw2h7pNtGC9wwxY0aOw1gW1tPh8vh9X1BtM2qcFKvfTWkJx6AcYsasBnvPl/WT1mJksp294tRlm/t9KyuvT5UrcVEdd+kMB9EHam5DD9Qi36G53cPwETSOJnGJo6iDouea0B6WeCc1YT1GGaNrhoHfURIUtTSEnye4T+2/VSKvfaA+0Eqr44inVzmVPPFNFT9+Wt4K0o5jTlAKczWKuFikb0vRCF+guBjHlDG7ZMaoxeA7BJT9y9ttV51UP9seE3Kvj3wXyoLrffFYFXZuaq3uZbZBBb+FjH8il3nRSdbpcpC3Y7jpAXjri7YI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Make sv48 the default address space for mmap as some applications currently depend on this assumption. Users can now select a desired address space using a non-zero hint address to mmap. Previously, requesting the default address space from mmap by passing zero as the hint address would result in using the largest address space possible. Some applications depend on empty bits in the virtual address space, like Go and Java, so this patch provides more flexibility for application developers. -Charlie --- v9: - Raise the mmap_end default to STACK_TOP_MAX to allow the address space to grow beyond the default of sv48 on sv57 machines as suggested by Alexandre - Some of the mmap macros had unnecessary conditionals that I have removed v8: - Fix RV32 and the RV32 compat mode of RV64 (suggested by Conor) - Extract out addr and base from the mmap macros (suggested by Alexandre) v7: - Changing RLIMIT_STACK inside of an executing program does not trigger arch_pick_mmap_layout(), so rewrite tests to change RLIMIT_STACK from a script before executing tests. RLIMIT_STACK of infinity forces bottomup mmap allocation. - Make arch_get_mmap_base macro more readible by extracting out the rnd calculation. - Use MMAP_MIN_VA_BITS in TASK_UNMAPPED_BASE to support case when mmap attempts to allocate address smaller than DEFAULT_MAP_WINDOW. - Fix incorrect wording in documentation. v6: - Rebase onto the correct base v5: - Minor wording change in documentation - Change some parenthesis in arch_get_mmap_ macros - Added case for addr==0 in arch_get_mmap_ because without this, programs would crash if RLIMIT_STACK was modified before executing the program. This was tested using the libhugetlbfs tests. v4: - Split testcases/document patch into test cases, in-code documentation, and formal documentation patches - Modified the mmap_base macro to be more legible and better represent memory layout - Fixed documentation to better reflect the implmentation - Renamed DEFAULT_VA_BITS to MMAP_VA_BITS - Added additional test case for rlimit changes --- Charlie Jenkins (4): RISC-V: mm: Restrict address space for sv39,sv48,sv57 RISC-V: mm: Add tests for RISC-V mm RISC-V: mm: Update pgtable comment documentation RISC-V: mm: Document mmap changes Documentation/riscv/vm-layout.rst | 22 +++++++ arch/riscv/include/asm/elf.h | 2 +- arch/riscv/include/asm/pgtable.h | 29 +++++++-- arch/riscv/include/asm/processor.h | 52 +++++++++++++-- tools/testing/selftests/riscv/Makefile | 2 +- tools/testing/selftests/riscv/mm/.gitignore | 2 + tools/testing/selftests/riscv/mm/Makefile | 15 +++++ .../riscv/mm/testcases/mmap_bottomup.c | 35 ++++++++++ .../riscv/mm/testcases/mmap_default.c | 35 ++++++++++ .../selftests/riscv/mm/testcases/mmap_test.h | 64 +++++++++++++++++++ .../selftests/riscv/mm/testcases/run_mmap.sh | 12 ++++ 11 files changed, 258 insertions(+), 12 deletions(-) create mode 100644 tools/testing/selftests/riscv/mm/.gitignore create mode 100644 tools/testing/selftests/riscv/mm/Makefile create mode 100644 tools/testing/selftests/riscv/mm/testcases/mmap_bottomup.c create mode 100644 tools/testing/selftests/riscv/mm/testcases/mmap_default.c create mode 100644 tools/testing/selftests/riscv/mm/testcases/mmap_test.h create mode 100755 tools/testing/selftests/riscv/mm/testcases/run_mmap.sh