[0/2] mm: memcg: fix tracking of pending stats updates values

Message

Yosry Ahmed Sept. 22, 2023, 8:25 a.m. UTC

While working on adjacent code [1], I realized that the values passed
into memcg_rstat_updated() to keep track of the magnitude of pending
updates is consistent. It is mostly in pages, but sometimes it can be in
bytes or KBs. Fix that.

Patch 1 reworks memcg_page_state_unit() so that we can reuse it in patch
2 to check and normalize the units of state updates.

[1]https://lore.kernel.org/lkml/[e-mail]/

Yosry Ahmed (2):
  mm: memcg: refactor page state unit helpers
  mm: memcg: normalize the value passed into memcg_rstat_updated()

 mm/memcontrol.c | 64 +++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 51 insertions(+), 13 deletions(-)

Comments

Andrew Morton Sept. 22, 2023, 5:03 p.m. UTC | #1

On Fri, 22 Sep 2023 08:25:40 +0000 Yosry Ahmed <[e-mail]> wrote:

> While working on adjacent code [1], I realized that the values passed
> into memcg_rstat_updated() to keep track of the magnitude of pending
> updates is consistent. It is mostly in pages, but sometimes it can be in
> bytes or KBs. Fix that.

Clashes with "memcg: remove unused do_memsw_account in
memcg1_stat_format", and maybe other things.  Can you please redo
against mm-unsstable or linux-next?

Yosry Ahmed Sept. 22, 2023, 5:59 p.m. UTC | #2

On Fri, Sep 22, 2023 at 10:03 AM Andrew Morton
<[e-mail]> wrote:
>
> On Fri, 22 Sep 2023 08:25:40 +0000 Yosry Ahmed <[e-mail]> wrote:
>
> > While working on adjacent code [1], I realized that the values passed
> > into memcg_rstat_updated() to keep track of the magnitude of pending
> > updates is consistent. It is mostly in pages, but sometimes it can be in
> > bytes or KBs. Fix that.
>
> Clashes with "memcg: remove unused do_memsw_account in
> memcg1_stat_format", and maybe other things.  Can you please redo
> against mm-unsstable or linux-next?

Done, sent v2:
https://lore.kernel.org/linux-mm/[e-mail]/

Thanks!