From patchwork Tue Nov 28 15:52:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumanth Korikkar X-Patchwork-Id: 13471398 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6959C4167B for ; Tue, 28 Nov 2023 15:52:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52E866B0287; Tue, 28 Nov 2023 10:52:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B6BA6B029A; Tue, 28 Nov 2023 10:52:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 330726B02B5; Tue, 28 Nov 2023 10:52:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1E7CC6B0287 for ; Tue, 28 Nov 2023 10:52:45 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C48B81A01EA for ; Tue, 28 Nov 2023 15:52:44 +0000 (UTC) X-FDA: 81507805848.09.09230A8 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf26.hostedemail.com (Postfix) with ESMTP id 4F53914001F for ; Tue, 28 Nov 2023 15:52:42 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=OtwMCGKf; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf26.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701186762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=A7bnXLY1jS/KppZEb/vgHlOoHBrkurLir9tElyqGFKw=; b=sfQMnv91X5QpB78WF5WysRR25+024jKlpFZY1hOkX6gw05V+GYS71QvLmNdip9l+wbvO8E GixXdKGuwRXhZx9TevlNAQbXUnULJTTwHpRc0WjsaS9zdw/iZ27DkpmMBcLEw9SDSBm7Cn VBrX5Iujt4Wqc4shso3yr5A/G8J/TJA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=OtwMCGKf; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf26.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701186762; a=rsa-sha256; cv=none; b=VyO+ZFDuCo7PaKIMN2YsqhtmFdSdaFGfmppJyizGFJiENhPKca8xyOoIYwES+YEwMPZQuY VLFEDz6KsKhCEv76QQsydQdb+DSpUOSMIGyxzE7BGhgxrcvpXTpQCqXcjK4he4L4IE+cKN yJB2ReP4LF/Q+x4xfnZ4Hl+n+UyuPJw= Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3ASFiPf2031336; Tue, 28 Nov 2023 15:52:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=A7bnXLY1jS/KppZEb/vgHlOoHBrkurLir9tElyqGFKw=; b=OtwMCGKfvcQ4C15jV4pV6ZwvknPxaAD+8LtTuzZHxWQBZPcSspCjhUES5le306Nc5eLZ LFLERtrYlinwhQVliNeIzeQbwSh7YEXbJwWxiteiHPgK/WIYrvAzfKn1FJNRJxN5o9Ve Bw4Iev/e3pY8C8Ho+ZdAYK8Et8Cah3TnQtSb9YgZxrwnAjqDKp8f7U3o2DW4NYfbuPcM Wa8g3jpWUMdpwHl22tozHr9Z+IVltlRPankXksajNvubixO9wTm0UQptYgyZ5GtBpItz IpOHF3NYumdwhD//+Rg3hUkDa36pM6j9//o9JiDO9taIWSOnj+HSRQI/hlBsz62Fx2Gq Iw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3unk3vrag3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Nov 2023 15:52:39 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3ASFimnw032172; Tue, 28 Nov 2023 15:52:38 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3unk3vraf3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Nov 2023 15:52:38 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3ASDT3Ph012226; Tue, 28 Nov 2023 15:52:37 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3ukvrkgjkc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Nov 2023 15:52:37 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3ASFqYs918809460 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Nov 2023 15:52:34 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4677A2004B; Tue, 28 Nov 2023 15:52:34 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DE06520040; Tue, 28 Nov 2023 15:52:33 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 28 Nov 2023 15:52:33 +0000 (GMT) From: Sumanth Korikkar To: linux-mm , Andrew Morton , David Hildenbrand Cc: Oscar Salvador , Michal Hocko , "Aneesh Kumar K.V" , Anshuman Khandual , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML Subject: [PATCH v5 0/5] implement "memmap on memory" feature on s390 Date: Tue, 28 Nov 2023 16:52:22 +0100 Message-Id: <20231128155227.1315063-1-sumanthk@linux.ibm.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: QhMbNXPxFeYCtmmLuA1d_MSrS7SfwvUD X-Proofpoint-GUID: dx6s_Kh1lOhRkXMcPr4LudEHWL98RGJz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-28_17,2023-11-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 phishscore=0 mlxscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 mlxlogscore=367 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311280126 X-Rspam-User: X-Stat-Signature: qtahkcmidghoxhag7kmyqn55waxjnxcj X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4F53914001F X-HE-Tag: 1701186762-778339 X-HE-Meta: U2FsdGVkX19QI3+/96W923DZ+EoCcH83q1z9DtLCjJFhNAdqPSaumSCDNA0ej5X+nSZb6qjqZhdOt1R+0mBefV1uQYLAZu3V3nkFLryuRNMvDj1QcPK5QlekqShmTE6wthFpJAglLQTJUWjkcMFhFrWc1tyB+N2Ze1Y69UOaH/bMA7Eb+rSq43K3jOz9RiBXuspMak2+nrcGEysRh1zzsV/J5KqHBKN0uKXI2IfFwkxMkwxscu1RbfZZeSn1r3c/ucdxuyDdORTtWsuZ+bwhI1abHTEf7vz21EW4XachFoBAnl4jgH3wBRSja4Xuvfnnz27B8IVEojNQvNDeSCCSIl3B0navX8x61GE6MZOU9v0qwI0rMSKLUg7vI58kkJZXvrScwXtInDFwlB4Hme9deKRsV2EiTTcYCJZEdyF2AD/i1mk+FncX1AI5Pq1y/p1TznpSChMUzsvJ6agIO17S9B4Z1DxkgSbcTUR1h793+AKUJxBO0Gu3P+QaEdzWGRnbnTtn2P8Z/UCV4Ufj/scxu0Q2LCzIKBzxlAkVHZ0C2vdSUvK1PUkALQUrunFejGEdaDljTyWZifcNSEvARvhLpM/+gHJzbdnWn75EbGIBMdBSgVfpIlNGKj3HbpyCez/W6uneEXddsjfF0v6GOBaDqGvnF+5SngWgvrLCk68iTu1oLnQSLvtzSLIxfHwRBdIeUIHDb4PmzINaqCboALr3mrNTXY5pB2qMLyMVnTCr2LId9PsJ1j8G91nGJVoFFvFp2pBPEZzIXFtUDZFyHXgHdgmGQAwfaAGsmGmpXMbsNR7kYKFDQk8HnEp6b3BI+aF8yCw50nvQFB1970Sf5RhRdwoUaciZQkvU5aS9iJDYt9GpWjoDimY6uYt+V93aSmiHol26HkU0USiwmNBbNhfjnfE36tOokm/WrkUzxd/V6vTlAoP3Df7nc+8Ls4HBx1Xwnm+11vJoRmOsYHSR042 cEgdIlxI F4G2eB3fa3LpF0Dq2/F7m0SbAFxNzbXjvps7Sq5wQSgDZ3y8N6B/NMkWPui6tfTX967AvBO8kcqnOpW/y8mBXRyiNeZb34yR40HjcqfkiMKrJSjwlYoi78hXZzA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi All, The patch series implements "memmap on memory" feature on s390. Patch 1 introduces MEM_PREPARE_ONLINE/MEM_FINISH_OFFLINE memory notifiers to prepare the transition of memory to and from a physically accessible state. New mhp_flag MHP_OFFLINE_INACCESSIBLE is introduced to ensure altmap cannot be written when addidng memory - before it is set online. This enhancement is crucial for implementing the "memmap on memory" feature for s390 in a subsequent patch. Patches 2 allocates vmemmap pages from self-contained memory range for s390. It allocates memory map (struct pages array) from the hotplugged memory range, rather than using system memory by passing altmap to vmemmap functions. Patch 3 removes unhandled memory notifier types on s390. Patch 4 implements MEM_PREPARE_ONLINE/MEM_FINISH_OFFLINE memory notifiers on s390. MEM_PREPARE_ONLINE memory notifier makes memory block physical accessible via sclp assign command. The notifier ensures self-contained memory maps are accessible and hence enabling the "memmap on memory" on s390. MEM_FINISH_OFFLINE memory notifier shifts the memory block to an inaccessible state via sclp unassign command Patch 5 finally enables MHP_MEMMAP_ON_MEMORY on s390 Note: These patches are rebased on top of three fixes: mm: use vmem_altmap code without CONFIG_ZONE_DEVICE mm/memory_hotplug: fix error handling in add_memory_resource() mm/memory_hotplug: add missing mem_hotplug_lock v5: * Added reviewed-by * Removed variables altmap_start, altmap_size in sclp_cmd.c * Used PFN_PHYS macro. Thanks for the valualble feedback. v4: * Introduced two new fields, altmap_start_pfn and altmap_nr_pages, in the memory_notify structure and document it that it is used only in MEM_PREPARE_ONLINE/MEM_FINISH_OFFLINE callbacks. * Incorporated the newly added fields into s390's MEM_PREPARE_ONLINE/MEM_FINISH_OFFLINE notifier callbacks. * Prevent access to memblock->altmap->free in the s390 notifier callback. * page_init_poison() could be performed similar to when adding new memory in sparse_add_section(). Perform it without cond_resched(). v3: * added comments to MHP_OFFLINE_ACCESSIBLE as suggested by David. * Squashed three commits related to new memory notifier. v2: * Fixes are integrated and hence removed from this patch series Suggestions from David: * Add new flag MHP_OFFLINE_INACCESSIBLE to avoid accessing memory during memory hotplug addition phase. * Avoid page_init_poison() on memmap during mhp addition phase, when MHP_OFFLINE_INACCESSIBLE mhp_flag is passed in add_memory(). * Do not skip add_pages() in arch_add_memory(). Similarly, remove similar hacks in arch_remove_memory(). * Use MHP_PREPARE_ONLINE/MHP_FINISH_OFFLINE naming convention for new memory notifiers. * Rearrange removal of unused s390 memory notifier. * Necessary commit messages changes. Thank you Sumanth Korikkar (5): mm/memory_hotplug: introduce MEM_PREPARE_ONLINE/MEM_FINISH_OFFLINE notifiers s390/mm: allocate vmemmap pages from self-contained memory range s390/sclp: remove unhandled memory notifier type s390/mm: implement MEM_PREPARE_ONLINE/MEM_FINISH_OFFLINE notifiers s390: enable MHP_MEMMAP_ON_MEMORY arch/s390/Kconfig | 1 + arch/s390/mm/init.c | 3 -- arch/s390/mm/vmem.c | 62 +++++++++++++++++++--------------- drivers/base/memory.c | 23 ++++++++++++- drivers/s390/char/sclp_cmd.c | 44 +++++++++++++++++++----- include/linux/memory.h | 9 +++++ include/linux/memory_hotplug.h | 18 +++++++++- include/linux/memremap.h | 1 + mm/memory_hotplug.c | 13 ++++++- mm/sparse.c | 3 +- 10 files changed, 134 insertions(+), 43 deletions(-)