| Message ID | 20231215034150.108783-1-sxwjean@me.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | supplement of slab allocator removal | expand |
On 12/15/23 04:41, sxwjean@me.com wrote: > From: Xiongwei Song <xiongwei.song@windriver.com> > > Hi, > > Patch 1 is to remove an unused parameter. It has a longer history, please > see the change history inside the patch. > > --- > Patch 2 is to replace slub_$params with slab_$params. > Vlastimil Babka pointed out we should use "slab_$param" as the primary > prefix for long-term plan. Please see [1] for more information. > > I did the basic tests with qemu, which passed values by sl[au]b_max_order, > sl[au]b_min_order, sl[au]b_min_objects and sl[au]b_debug in command line. > The values looks correct by printing them out before calculating orders. > > --- > Patch 3 is to replace slub_$params in Documentation/mm/slub.rst based on > the changes of patch 2. > > --- > Patch 4 is original patch 3. It is not related to slab allocator removal. > It's to correct the description of default value of slab_min_objects in > Documentation/mm/slub.rst. > > --- > This series is based on [2]. I will queue this for 6.9 after the merge window. But since the changes are mostly in Documentation, maybe Jon would prefer his tree, then we would split away the code comments changes in patch 2 to go through slab tree. Vlastimil
> -----Original Message----- > From: Vlastimil Babka <vbabka@suse.cz> > Sent: Wednesday, January 10, 2024 11:12 PM > To: sxwjean@me.com; 42.hyeyoo@gmail.com; cl@linux.com; linux-mm@kvack.org > Cc: penberg@kernel.org; rientjes@google.com; iamjoonsoo.kim@lge.com; > roman.gushchin@linux.dev; corbet@lwn.net; keescook@chromium.org; arnd@arndb.de; > akpm@linux-foundation.org; gregkh@linuxfoundation.org; quic_jjohnson@quicinc.com; > linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; Song, Xiongwei > <Xiongwei.Song@windriver.com> > Subject: Re: [PATCH v4 0/4] supplement of slab allocator removal > > CAUTION: This email comes from a non Wind River email account! > Do not click links or open attachments unless you recognize the sender and know the content > is safe. > > On 12/15/23 04:41, sxwjean@me.com wrote: > > From: Xiongwei Song <xiongwei.song@windriver.com> > > > > Hi, > > > > Patch 1 is to remove an unused parameter. It has a longer history, please > > see the change history inside the patch. > > > > --- > > Patch 2 is to replace slub_$params with slab_$params. > > Vlastimil Babka pointed out we should use "slab_$param" as the primary > > prefix for long-term plan. Please see [1] for more information. > > > > I did the basic tests with qemu, which passed values by sl[au]b_max_order, > > sl[au]b_min_order, sl[au]b_min_objects and sl[au]b_debug in command line. > > The values looks correct by printing them out before calculating orders. > > > > --- > > Patch 3 is to replace slub_$params in Documentation/mm/slub.rst based on > > the changes of patch 2. > > > > --- > > Patch 4 is original patch 3. It is not related to slab allocator removal. > > It's to correct the description of default value of slab_min_objects in > > Documentation/mm/slub.rst. > > > > --- > > This series is based on [2]. > > I will queue this for 6.9 after the merge window. But since the changes are > mostly in Documentation, maybe Jon would prefer his tree, then we would > split away the code comments changes in patch 2 to go through slab tree. Ok, got it. Thanks, Xiongwei
From: Xiongwei Song <xiongwei.song@windriver.com> Hi, Patch 1 is to remove an unused parameter. It has a longer history, please see the change history inside the patch. --- Patch 2 is to replace slub_$params with slab_$params. Vlastimil Babka pointed out we should use "slab_$param" as the primary prefix for long-term plan. Please see [1] for more information. I did the basic tests with qemu, which passed values by sl[au]b_max_order, sl[au]b_min_order, sl[au]b_min_objects and sl[au]b_debug in command line. The values looks correct by printing them out before calculating orders. --- Patch 3 is to replace slub_$params in Documentation/mm/slub.rst based on the changes of patch 2. --- Patch 4 is original patch 3. It is not related to slab allocator removal. It's to correct the description of default value of slab_min_objects in Documentation/mm/slub.rst. --- This series is based on [2]. --- CHANGES V4: - patch 1: Clean up typos. - patch 4: Make the description of slab_min_objects helpful. Refine the subject. V3: - patch 1: Collect Reviewed-by tag. Refine the commit message. - patch 2: Remove the changes for variables and functions. Resort slab_$params in doc. Refine the commit message. Remove RFC tag. - patch 3: Use slab_$params in slub.rst. - patch 4: It's original patch 3. Just resorted patch orders, no any other Changes. v2: https://lore.kernel.org/linux-mm/457899ac-baab-e976-44ec-dfdeb23be031@suse.cz/T/#t - patch 1: Collect Reviewed-by tag. - patch 3: Correct spelling mistakes in commit message. v1: https://lore.kernel.org/linux-mm/20231201031505.286117-1-sxwjean@me.com/ --- Regards, Xiongwei [1] https://lore.kernel.org/linux-mm/7512b350-4317-21a0-fab3-4101bc4d8f7a@suse.cz/ [2] https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git/log/?h=slab/for-next Xiongwei Song (4): Documentation: kernel-parameters: remove noaliencache mm/slub: unify all sl[au]b parameters with "slab_$param" mm/slub: replace slub_$params with slab_$params in slub.rst mm/slub: correct the default value of slub_min_objects in doc .../admin-guide/kernel-parameters.txt | 75 ++++++++----------- Documentation/mm/slub.rst | 60 +++++++-------- drivers/misc/lkdtm/heap.c | 2 +- mm/Kconfig.debug | 6 +- mm/slab.h | 2 +- mm/slab_common.c | 4 +- mm/slub.c | 41 +++++----- 7 files changed, 92 insertions(+), 98 deletions(-)