From patchwork Tue Jan 2 13:12:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gang Li X-Patchwork-Id: 13509011 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07B3FC46CD2 for ; Tue, 2 Jan 2024 13:13:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C41B8D0008; Tue, 2 Jan 2024 08:13:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8748F8D0006; Tue, 2 Jan 2024 08:13:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73B208D0008; Tue, 2 Jan 2024 08:13:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 64EA08D0006 for ; Tue, 2 Jan 2024 08:13:19 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 282941C0FE2 for ; Tue, 2 Jan 2024 13:13:19 +0000 (UTC) X-FDA: 81634412118.29.3A82DE6 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) by imf27.hostedemail.com (Postfix) with ESMTP id 2A27340010 for ; Tue, 2 Jan 2024 13:13:16 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=nUUoJdqW; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf27.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704201197; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=daO+8Vo0jNlvzwLRDw/Wt7KlxBb2Rk5joGViCE+fZW4=; b=2/SAMV7pHT2rZeeuOPBejdCu9hKbotVwKrRtOTyy0REMOLAOD0fNCC7JHLv/wzztdWCSFZ EUmnQn0Asw9Mi4F1xAGlTLC+4WifYH3Qm6W6WHKq7igcAbv01LtwQNZQmIy9boCD9wqnZf jPPbVZ0gnIhFRUCL3GmnkFJLgIBHNXY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=nUUoJdqW; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf27.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704201197; a=rsa-sha256; cv=none; b=L0Qv+83/ktMeDGLCuLs/grfLgR567Km6DXeivtzEXD0A6lv/7GxqBOS7zrQQv5PgK2JJ0Q abmq/+c6GtWapXSuhm8WPu/+dVYdPBsy1rtJMNsj7B304Wm8XBuS17P7aVOMcyyiGlt9oX D8N3azqm/d/0KV8/zPJKZdPIp7DLDeA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1704201194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=daO+8Vo0jNlvzwLRDw/Wt7KlxBb2Rk5joGViCE+fZW4=; b=nUUoJdqW8b8LoXHm6jHb9AQoY7w7usMJmtiAEiG2xDm2XoFPm+hkRBm6Jl/cdjHsWd+4Nr kezQIcH7hHdzuHg5+e9JelcznloIelv+/ZeX/+J885tGp/WhFMipVKmKMQiLZVYg0eD2hM gsnUdbwcikV11Key7utkhN+Cmo9mvXs= From: Gang Li To: David Hildenbrand , David Rientjes , Mike Kravetz , Muchun Song , Andrew Morton , Tim Chen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com, Gang Li Subject: [PATCH v3 0/7] hugetlb: parallelize hugetlb page init on boot Date: Tue, 2 Jan 2024 21:12:42 +0800 Message-Id: <20240102131249.76622-1-gang.li@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2A27340010 X-Stat-Signature: 5hrwcb4ajufxpuwrnq4dg4pfnxtp5557 X-Rspam-User: X-HE-Tag: 1704201196-74133 X-HE-Meta: U2FsdGVkX1/uQfGyqsDypwlDpuABTys6sksX3Hk5Jqj+qJ7PFWtolpv04d3JNwdIH2ocL0qD2l7URhgjXB0tX7HrjMIgruMcsh39A6hC3F4uw7uCLQDDOwea5ZU90ua1s2bGpXmH4xIZHcdJf0CdoXLEHwXuxjvOTFTcPfT0WnRv7E735m+6LCom0MC0AIRHg16676Xrd0hb/xIGS0l9UmaXrKMMIGu3DJIfTUp/rffrNU1yeZ/nXMb14Xn0/eF06IzLLYk6uSfljClEzyfnd968+t32asfO6ardMcFrKrbLU+M0gyAQil9Ks4HAE3rCPoAmAAkocWI39RKinll7tzDXzHirC0id0sY3exqXtM/VDv1FH1FnHgHzJIGKIbIDOFCkK0nb/17jGgAtqFVSAgXHu1YvkWa+TIsUn3SqarlrpCU63m4M0vMpmn2/eRFvEj0caK01L0IAVZZt7dWpvbRPadQgCYWv1L3lNkeU5EiGGCTGD6m6U2JqETMGyXctZ7IiAxWfUXTeReuwDZorumXZuQdDfx0avOCx8ZgvJaC6WOPR4bcYKHRIS3VHK8v3hSmfMm7D/6g6txzTAs+3htUcp5+j8oi5DV1z0HMXdTU0xbflj+8pzkWEgj/5n24GPVCzkQh3LjFip5OrLAMLIjHJX0y4DMgsLOfySgl2tlr68z/E0zRYOOC3nfuR7XjuZIgjhcN8voLtp0S4L2XhC6uQWtnb1buGNtRXbieyxiDAiLK/HI/dwpI74bhp75BegtpGu0Jx0xx3gxll2J5PKVIYiGoKTu28PJNZZk0ct5gr7+4g96a0AbwylRx+Bi4y4GfbgB+88gFUoaszIeml8692MjaQtNfO0XhiPlztHhxT2HLyTcfISDFxkHlvZCwTvRcHUQLfqFf9l561CFoBAW3bWV07kXkAUinsY8sfbs5XB3cBeBAH/EeRT7PcziBgRrtGk8NXKw7W1ZPnsWz sH5DemQx 9Xonb10FKOuT0NRSjxQTxrD62Abo1M0Cyo2EEp4oPJDzspK3ynsz+kpgI2V2VvcYYEYiglM71lDjBG8s2Atqt3FfLQx81cQawCVSW8yoVOrhfRYNwg9w6muT0E9OaTKNlDssWO7hHKs3RMJiCdQn6PHjTBoOX768gvZCpegp/aJxN2TXnC0GPbZpDZnnwnpr6cGFfXnGmFzatzlMm5hjj+YV37UTCdxL+UmHBA2xWmq9o8T8QyJPbEzWvoQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi all, hugetlb init parallelization has now been updated to v3. This series is tested on next-20240102 and can not be applied to v6.7-rc8. Update Summary: - Select CONFIG_PADATA as we use padata_do_multithreaded - Fix a race condition in h->next_nid_to_alloc - Fix local variable initialization issues - Remove RFC tag Thanks to the testing by David Rientjes, we now know that this patch reduce hugetlb 1G initialization time from 77s to 18.3s on a 12T machine[4]. # Introduction Hugetlb initialization during boot takes up a considerable amount of time. For instance, on a 2TB system, initializing 1,800 1GB huge pages takes 1-2 seconds out of 10 seconds. Initializing 11,776 1GB pages on a 12TB Intel host takes more than 1 minute[1]. This is a noteworthy figure. Inspired by [2] and [3], hugetlb initialization can also be accelerated through parallelization. Kernel already has infrastructure like padata_do_multithreaded, this patch uses it to achieve effective results by minimal modifications. [1] https://lore.kernel.org/all/783f8bac-55b8-5b95-eb6a-11a583675000@google.com/ [2] https://lore.kernel.org/all/20200527173608.2885243-1-daniel.m.jordan@oracle.com/ [3] https://lore.kernel.org/all/20230906112605.2286994-1-usama.arif@bytedance.com/ [4] https://lore.kernel.org/all/76becfc1-e609-e3e8-2966-4053143170b6@google.com/ # Test result test no patch(ms) patched(ms) saved ------------------- -------------- ------------- -------- 256c2t(4 node) 1G 4745 2024 57.34% 128c1t(2 node) 1G 3358 1712 49.02% 12t 1G 77000 18300 76.23% 256c2t(4 node) 2M 3336 1051 68.52% 128c1t(2 node) 2M 1943 716 63.15% # Change log Changes in v3: - Select CONFIG_PADATA as we use padata_do_multithreaded - Fix a race condition in h->next_nid_to_alloc - Fix local variable initialization issues - Remove RFC tag Changes in v2: - https://lore.kernel.org/all/20231208025240.4744-1-gang.li@linux.dev/ - Reduce complexity with `padata_do_multithreaded` - Support 1G hugetlb v1: - https://lore.kernel.org/all/20231123133036.68540-1-gang.li@linux.dev/ - parallelize 2M hugetlb initialization with workqueue Gang Li (7): hugetlb: code clean for hugetlb_hstate_alloc_pages hugetlb: split hugetlb_hstate_alloc_pages padata: dispatch works on different nodes hugetlb: pass *next_nid_to_alloc directly to for_each_node_mask_to_alloc hugetlb: have CONFIG_HUGETLBFS select CONFIG_PADATA hugetlb: parallelize 2M hugetlb allocation and initialization hugetlb: parallelize 1G hugetlb initialization fs/Kconfig | 1 + include/linux/hugetlb.h | 2 +- include/linux/padata.h | 3 + kernel/padata.c | 8 +- mm/hugetlb.c | 224 +++++++++++++++++++++++++++------------- mm/mm_init.c | 1 + 6 files changed, 163 insertions(+), 76 deletions(-)