From patchwork Thu Jan 25 19:32:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13531541 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C233BC47422 for ; Thu, 25 Jan 2024 19:32:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57311280006; Thu, 25 Jan 2024 14:32:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 52389280004; Thu, 25 Jan 2024 14:32:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EBB5280006; Thu, 25 Jan 2024 14:32:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2E0C6280004 for ; Thu, 25 Jan 2024 14:32:44 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C7E1DA0E49 for ; Thu, 25 Jan 2024 19:32:43 +0000 (UTC) X-FDA: 81718830606.24.68C9081 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 18AFF180006 for ; Thu, 25 Jan 2024 19:32:41 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jAVrtWBY; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706211162; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=hqBJXd3KYbSqBlyTsnJ+flUsuxWAbzNO3FAUVqkspqs=; b=Jg8UZcgX3zQuMJBT46qj/XwDbO4hg+HCFp5HZU10jZpdQ+9QnnjbnsDzkd/naddSgRjfYE BPblOCcBz3zjKhxftEUyhU9xJU0/mvEkFdjhqC4uiCxZqVq4k2qAGMKT1D7VlP7ua0bIgl VB1mRt8aWt84fymVtI8875CQp0909p0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706211162; a=rsa-sha256; cv=none; b=5wPF/EwDpfnDthxN7zp7pvaNgqBLyZxg5VE/PP279i3MfM/8iqDuupo2bhDUJzV/yw7eUi GgR1N4csMFOHKtw4qAkIWlqtfUGg7Q+lp9qI7ouGKkMvdHcMyHe5/Ny30FeDh5gXqNXTta LKzlEskKHjAI4EqQwb/wjZcBEhZWEBM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jAVrtWBY; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706211161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=hqBJXd3KYbSqBlyTsnJ+flUsuxWAbzNO3FAUVqkspqs=; b=jAVrtWBYCAiI9ueXQujfQMSc4y9xb1Iyx8dwm6JHqL3YYyLuQGs94Yok/iB+vf0oRz8Xym MkpOIFFV1FFqufnaLV5YkOiKQAErJiO+6thm142Z4ipzUBtnOIQ2uikJHX1aUI97V3viLv 4SZMXIL6Xi4e4jsz0aqH0wuGfoTVDec= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-3eXNfPC0PWK9Jn6kjBn6xQ-1; Thu, 25 Jan 2024 14:32:37 -0500 X-MC-Unique: 3eXNfPC0PWK9Jn6kjBn6xQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 23E903C1E9D4; Thu, 25 Jan 2024 19:32:35 +0000 (UTC) Received: from t14s.redhat.com (unknown [10.39.193.154]) by smtp.corp.redhat.com (Postfix) with ESMTP id 24466492BC6; Thu, 25 Jan 2024 19:32:27 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, David Hildenbrand , Andrew Morton , Matthew Wilcox , Ryan Roberts , Russell King , Catalin Marinas , Will Deacon , Dinh Nguyen , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org Subject: [PATCH v2 00/15] mm/memory: optimize fork() with PTE-mapped THP Date: Thu, 25 Jan 2024 20:32:12 +0100 Message-ID: <20240125193227.444072-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Rspamd-Queue-Id: 18AFF180006 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: qg6kn7asekizn8fsazca9uy8km4mycnz X-HE-Tag: 1706211161-713020 X-HE-Meta: U2FsdGVkX197tjIMJVioyR0HrRV9WagyXIntdgA6EaelA78vhToQoAAt7bfyy87oK6Xm9rVisHUOcdMjSPR2YJJScobJp+Nc3D1S3cfBI9//fGqRbzFWq9vslfCYLKFIi511xGPfQhPSm7UHZdKiiv7EML7Pc+YOfiQ7Cbc+cj0KQlMypeDmWDDZHFYIYkmNQNPxTPHdcvN2audDBJGrlf/hVThA2GSO+TpPr1A+2QcijpkAyncjFU/SYbLMrAu9pFw5b6hr7qj3Kj0z4Uyp210R0cuyacigt7AsqaCt3l9O0iZcmLew1ewkfN4SCU4J4Z/D78DXrCgQjeGg6jFsari5HUnzMkPdgEf8dCJrYoejBSS5jbaCqq3ouplzkMRBG3KwIHmhQSqEhjpgq5HnMolWmx5EWdzx61igBY7ytsFyiul7TcwSig0gUlsomY6oJLuCNpdGzKKtyb/1XZR7fRwR94pgAEryq5EheuO0h2qdQ+gbrjGIyo1vQmMvdrkwtOO1fCgdUIjwBoFEh3mhVPtPs/a5yQ3gTV44rbU4rSfPLGjHHa+t+eKDhcJdwlHa6gW+JEbH/9g0kHgACQ8+tTL0Tk+PzGZj0C4OmABYM8gKXFU9dEvfcJa3An7gO1ZBXXrCXeifqhpadfAgO3dibe+Zbo0e9R4bXvMGjR0ya5cuo/s3TI8mzZEDh0MMTSGWnfPkkjWuWJDVoqfB46yjx3Abj+qKBn+gYjyRtrw1l1YGqHDDpplMxiy3Yhlmm+RTH7JfXc0MCfFL/KsXXenp3WlsZxdWuItAM7cBffg29EkVx2Rftaq38mTdEbr6U2hmCz1Ud8OG9WhARgh/blTJYp3OqEU+R0iqVUYBTaZZ1CTJHb+qaAcMA++TshH3UlDISlH5/HrdnN6NCvVOWAoSgyZtBrNdjhBiQLRwna7J3BPfPtgszboegWgxuhMPhL90odWUNirp/lHC8k1ZLib /RQwa1Ap /IMbvQp4PvT/PGMcWkRj5BspYHjAfdDqEogDtJfx2mJYMj16Ji1gTxKkkb2/w4fHjXXI2gcf8ceuCekaIS9GzujXawCMM/W12+TyWo9qj1GYd1jqzEyhWEhFTmItZVg69csCtRYuiimVNXsPOuAMXVSaMXKTa+IkW0rogGQNkBJc6VU1/hgpsbCcpfoGoY4liPFwXjh4syvUBylmfoyx9cJzclva0TdfxCxXp4IOuDaRUZnbZx5R7op/AubVugVQS0nOoSGp8bZjkdAuiNVetZlbOiu50gQJMuhOSqQuIHttzCWVDu6zKgyihB+fTdiJe9xvzj6xxhv40jMQAqoz6wbQcZUAYsJr9g4d0XYzkTFT0T2VpNaVR3Qxg7iWMPrgO+1WFxM7zNK9n6C7agucbrBvlKVRA0Zd3T8yhIIKF0sg5jJxs3XbDFiRDVN6siJhS2dQYnhyl7UR42vLPpFRbdosSRRCcPeKgcAQ4mU5ztrRAgyLk2/TUh10fnqjUDQkGwUAVZ+yk/6D0o1R7K6NR1mqByVXjg2X3TKz6gsjK+QT3+++2dt2N2qkWjH9790R/GudWAW+cwC53/VJVaZVLFRIyQIvUy/t7Gi/8bFJ8hpDAEopAprENtkKD8uq85isq4Y8UjJyFcUcAdCTcleZQiaeVKp86tZ+Fw7+JNaji3AXfhAuqusFau4CGv6fbAViuh2vRTqyoE4nlOePytHR5s8wUrxVOc/+wP/FCFaG3VITA7Wn5YaUNO9VbTqZH6yVQyomF0eb+FqX0z5piMbrPzP0rVmGoEt4qMrGkoL9c5ZWRPFYw0DP7lF+cVA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Now that the rmap overhaul[1] is upstream that provides a clean interface for rmap batching, let's implement PTE batching during fork when processing PTE-mapped THPs. This series is partially based on Ryan's previous work[2] to implement cont-pte support on arm64, but its a complete rewrite based on [1] to optimize all architectures independent of any such PTE bits, and to use the new rmap batching functions that simplify the code and prepare for further rmap accounting changes. We collect consecutive PTEs that map consecutive pages of the same large folio, making sure that the other PTE bits are compatible, and (a) adjust the refcount only once per batch, (b) call rmap handling functions only once per batch and (c) perform batch PTE setting/updates. While this series should be beneficial for adding cont-pte support on ARM64[2], it's one of the requirements for maintaining a total mapcount[3] for large folios with minimal added overhead and further changes[4] that build up on top of the total mapcount. Independent of all that, this series results in a speedup during fork with PTE-mapped THP, which is the default with THPs that are smaller than a PMD (for example, 16KiB to 1024KiB mTHPs for anonymous memory[5]). On an Intel Xeon Silver 4210R CPU, fork'ing with 1GiB of PTE-mapped folios of the same size (stddev < 1%) results in the following runtimes for fork() (shorter is better): Folio Size | v6.8-rc1 | New | Change ------------------------------------------ 4KiB | 0.014328 | 0.014035 | - 2% 16KiB | 0.014263 | 0.01196 | -16% 32KiB | 0.014334 | 0.01094 | -24% 64KiB | 0.014046 | 0.010444 | -26% 128KiB | 0.014011 | 0.010063 | -28% 256KiB | 0.013993 | 0.009938 | -29% 512KiB | 0.013983 | 0.00985 | -30% 1024KiB | 0.013986 | 0.00982 | -30% 2048KiB | 0.014305 | 0.010076 | -30% Note that these numbers are even better than the ones from v1 (verified over multiple reboots), even though there were only minimal code changes. Well, I removed a pte_mclean() call for anon folios, maybe that also plays a role. Alternatively, either v1 or v2 is seriously buggy ;) But my experience is that fork() is extremely sensitive to code size, inlining, ... so I suspect we'll see on other architectures rather a change of -20% instead of -30%, and it will be easy to "lose" some of that speedup in the future by subtle code changes. Next up is PTE batching when unmapping, that I'll send out next week. Only tested on x86-64. Compile-tested on most other architectures. v1 -> v2: * "arm64/mm: Make set_ptes() robust when OAs cross 48-bit boundary" -> Added patch from Ryan * "arm/pgtable: define PFN_PTE_SHIFT" -> Removed the arm64 bits * "mm/pgtable: make pte_next_pfn() independent of set_ptes()" * "arm/mm: use pte_next_pfn() in set_ptes()" * "powerpc/mm: use pte_next_pfn() in set_ptes()" -> Added to use pte_next_pfn() in some arch set_ptes() implementations I tried to make use of pte_next_pfn() also in the others, but it's not trivial because the other archs implement set_ptes() in their asm/pgtable.h. Future work. * "mm/memory: factor out copying the actual PTE in copy_present_pte()" -> Move common folio_get() out of if/else * "mm/memory: optimize fork() with PTE-mapped THP" -> Add doc for wrprotect_ptes -> Extend description to mention handling of pinned folios -> Move common folio_ref_add() out of if/else * "mm/memory: ignore dirty/accessed/soft-dirty bits in folio_pte_batch()" -> Be more conservative with dirt/soft-dirty, let the caller specify using flags [1] https://lkml.kernel.org/r/20231220224504.646757-1-david@redhat.com [2] https://lkml.kernel.org/r/20231218105100.172635-1-ryan.roberts@arm.com [3] https://lkml.kernel.org/r/20230809083256.699513-1-david@redhat.com [4] https://lkml.kernel.org/r/20231124132626.235350-1-david@redhat.com [5] https://lkml.kernel.org/r/20231207161211.2374093-1-ryan.roberts@arm.com Cc: Andrew Morton Cc: Matthew Wilcox (Oracle) Cc: Ryan Roberts Cc: Russell King Cc: Catalin Marinas Cc: Will Deacon Cc: Dinh Nguyen Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: "Aneesh Kumar K.V" Cc: "Naveen N. Rao" Cc: Paul Walmsley Cc: Palmer Dabbelt Cc: Albert Ou Cc: Alexander Gordeev Cc: Gerald Schaefer Cc: Heiko Carstens Cc: Vasily Gorbik Cc: Christian Borntraeger Cc: Sven Schnelle Cc: "David S. Miller" Cc: linux-arm-kernel@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-riscv@lists.infradead.org Cc: linux-s390@vger.kernel.org Cc: sparclinux@vger.kernel.org David Hildenbrand (14): arm/pgtable: define PFN_PTE_SHIFT nios2/pgtable: define PFN_PTE_SHIFT powerpc/pgtable: define PFN_PTE_SHIFT riscv/pgtable: define PFN_PTE_SHIFT s390/pgtable: define PFN_PTE_SHIFT sparc/pgtable: define PFN_PTE_SHIFT mm/pgtable: make pte_next_pfn() independent of set_ptes() arm/mm: use pte_next_pfn() in set_ptes() powerpc/mm: use pte_next_pfn() in set_ptes() mm/memory: factor out copying the actual PTE in copy_present_pte() mm/memory: pass PTE to copy_present_pte() mm/memory: optimize fork() with PTE-mapped THP mm/memory: ignore dirty/accessed/soft-dirty bits in folio_pte_batch() mm/memory: ignore writable bit in folio_pte_batch() Ryan Roberts (1): arm64/mm: Make set_ptes() robust when OAs cross 48-bit boundary arch/arm/include/asm/pgtable.h | 2 + arch/arm/mm/mmu.c | 2 +- arch/arm64/include/asm/pgtable.h | 28 ++-- arch/nios2/include/asm/pgtable.h | 2 + arch/powerpc/include/asm/pgtable.h | 2 + arch/powerpc/mm/pgtable.c | 5 +- arch/riscv/include/asm/pgtable.h | 2 + arch/s390/include/asm/pgtable.h | 2 + arch/sparc/include/asm/pgtable_64.h | 2 + include/linux/pgtable.h | 33 ++++- mm/memory.c | 212 ++++++++++++++++++++++------ 11 files changed, 229 insertions(+), 63 deletions(-)