From patchwork Fri Jan 26 15:24:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gang Li X-Patchwork-Id: 13532814 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25FAEC47DDF for ; Fri, 26 Jan 2024 15:24:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71F816B0072; Fri, 26 Jan 2024 10:24:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CF8C6B0075; Fri, 26 Jan 2024 10:24:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 597696B007B; Fri, 26 Jan 2024 10:24:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4926D6B0072 for ; Fri, 26 Jan 2024 10:24:57 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DCE8880F5F for ; Fri, 26 Jan 2024 15:24:56 +0000 (UTC) X-FDA: 81721834992.14.8B16B5B Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) by imf23.hostedemail.com (Postfix) with ESMTP id D0CB914001B for ; Fri, 26 Jan 2024 15:24:54 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="I5quX/oG"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf23.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706282695; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=Lgnke4sUkqUF2pP50eUrQqO/+toTU6ZkY2mCk3wiX/M=; b=aTyv8nuH491kKoSZWIP8Jk/Nxp6Pje/2Hz7IXhXfs/cr5g80qPbd/LQn6fIvvInFc6CJtj t4re02Id8yTEjRhmUGfKjYiKpoR2vi/36q3jQrzv44P0/kUpYHHCldftYugAR6NmL4dMUh 1yyVQfuI4rjq1nMuIU9U/UqHtfLRoFk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="I5quX/oG"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf23.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706282695; a=rsa-sha256; cv=none; b=0b6gefgKBSM/oq1eksYhc6Cl/wF2QC4FJIpJTnR7rIjNnbVrJO7F2TxshswpbKHJnAYpxE mHi33HG2kUbgsnBsO0IB7RChw1TsOZx7jo8h2+HJJXN1F4rlObJ0+8zoFQb1jvUTZUAqMQ 8oU61G+5gtOndso9yK4mZss1opDXpPo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1706282692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Lgnke4sUkqUF2pP50eUrQqO/+toTU6ZkY2mCk3wiX/M=; b=I5quX/oGzhc+pgrMgx4pRy9+4HXJOwjBwGTQdCMAkq42FB1gw5jMK2DSusevSGdsUNcrqw ZzLYiZiG34Xz60A5MQin1gbU/V616IT6k+rln3GYBxdT1h67K9dXBOQHtoK9x/ZlF2oGg0 vu07KdhJEhwl7dVWBsQPSWuhyjXbW8s= From: Gang Li To: David Hildenbrand , David Rientjes , Mike Kravetz , Muchun Song , Andrew Morton , Tim Chen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com, Gang Li Subject: [PATCH v5 0/7] hugetlb: parallelize hugetlb page init on boot Date: Fri, 26 Jan 2024 23:24:04 +0800 Message-Id: <20240126152411.1238072-1-gang.li@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: x1bk88ibndz9j5syq7gonnar9c8ufzgn X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D0CB914001B X-HE-Tag: 1706282694-191891 X-HE-Meta: U2FsdGVkX1/RE2NDrj+JPjfDiOB3KzpKaxkuN8NAN3ITbLwOIs8An/gTOPT5PT7UXz7R24/SeqKpy8rnrlAu0LF2mDyPKkVPqkkqOgu3B/qimh2qZG/DrKoCKmgFqULagxdTCeSzPXgw8+RX3NuTkMuu2HsJevPCf74kWAgaHatOiZdUPrzO5xtKJ25F+sE8dnERC5aMxHygmhO5IXGO53HOLBExbG+EACn61JNwXaUMVp/PAk7x4NlYBSi39nQMYVDTjQYbOYUPLbanamP1dXNwB4o5Oy1uxgpeTrMBFIm+pDiym/d3ZXb8fEA3wAZIVlK9K5vuOJGc51f/LhvO8ktmmDBASrroQdLLicBPpU+WUStBpS9HpQ93HSYQNGG6qrwMCeGDueL+0FI2U8XPphTto7O7spBXT21C1Pg+XxvWNo0JqJDYC3rqEkY/Ygy40Cz3/IBGcK8FT1eOp5TFG05pCjwnNVswvnJrh2GpmWGFIQcnKkDZrimBBZiVPzew/Fw6UvDCwXITdwZw6sLztKojQxUggclNbF8SrvgA93jS6I65pPBqITC6j3pQEZrCQHsriWMjilKLug6OK7q1p3ZL8DDr+E43zMg5HKSrKZyZCTbClMOwE6ngw+vFj215xsSIRP+oUPFu4RQXpGA3RrItRRoy5SekTTU6kpaApflRJwpRc+3XXgACFFc68b2jY1W/QVynN3hbOKzb3E4aDWJkEWpMTaNg5lYQ1MSYyaGRAl+lM3+pFQfLDWrr/y8rKhvMjeVO+r0MyNl1kR8SmKTz4fH4uRGi3bbKyeiy8hmXvvIAHEUoy14S4gIXHObwtLVjYMe6SRNpa5wFa1Df64g2uqgTimuoLks+/q0qLTHZb6lNmwUYYCtGo8NXVOtBNHIppHwyZ/6LqPThCml/LbKPIb/miNQtr0/zIxOQbWQ/I/LN+x3TKZSLXW6KyMTog6T/HGzDOnTeEcne9MS 6DW+jmI3 VA+21eYWCZ3dXKFqZSsDshA03hqOOMcQmm9daGjBi5LGZhYykZhaTov4795IATS5Qh83gFWxlO9N4pp2CevCx1eln1CWfc/+eDII/LLX2xPy5nqSwL9KyHxng37ov5zhTAy1OsqemX7K/1Pn8RY+Yq++XsXW9lciCjxcDv/2w59TKGCuDU6QA9sK0cI5nk1SaWVBs2OKsGI6KZqgc9y0bCydiScUd6iUSr+OxnpzymsDjz2Og/9MWReX1cA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi all, hugetlb init parallelization has now been updated to v5. This version is tested on next-20240125. Update Summary: - Use prep_and_add_allocated_folios in 2M hugetlb parallelization - Update huge_boot_pages in arch/powerpc/mm/hugetlbpage.c - Revise struct padata_mt_job comment - Add 'max_threads' section in cover letter - Collect more Reviewed-by # Introduction Hugetlb initialization during boot takes up a considerable amount of time. For instance, on a 2TB system, initializing 1,800 1GB huge pages takes 1-2 seconds out of 10 seconds. Initializing 11,776 1GB pages on a 12TB Intel host takes more than 1 minute[1]. This is a noteworthy figure. Inspired by [2] and [3], hugetlb initialization can also be accelerated through parallelization. Kernel already has infrastructure like padata_do_multithreaded, this patch uses it to achieve effective results by minimal modifications. [1] https://lore.kernel.org/all/783f8bac-55b8-5b95-eb6a-11a583675000@google.com/ [2] https://lore.kernel.org/all/20200527173608.2885243-1-daniel.m.jordan@oracle.com/ [3] https://lore.kernel.org/all/20230906112605.2286994-1-usama.arif@bytedance.com/ [4] https://lore.kernel.org/all/76becfc1-e609-e3e8-2966-4053143170b6@google.com/ # max_threads This patch use `padata_do_multithreaded` like this: ``` job.max_threads = num_node_state(N_MEMORY) * multiplier; padata_do_multithreaded(&job); ``` To fully utilize the CPU, the number of parallel threads needs to be carefully considered. `max_threads = num_node_state(N_MEMORY)` does not fully utilize the CPU, so we need to multiply it by a multiplier. Tests below indicate that a multiplier of 2 significantly improves performance, and although larger values also provide improvements, the gains are marginal. multiplier 1 2 3 4 5 ------------ ------- ------- ------- ------- ------- 256G 2node 358ms 215ms 157ms 134ms 126ms 2T 4node 979ms 679ms 543ms 489ms 481ms 50G 2node 71ms 44ms 37ms 30ms 31ms Therefore, choosing 2 as the multiplier strikes a good balance between enhancing parallel processing capabilities and maintaining efficient resource management. # Test result test case no patch(ms) patched(ms) saved ------------------- -------------- ------------- -------- 256c2T(4 node) 1G 4745 2024 57.34% 128c1T(2 node) 1G 3358 1712 49.02% 12T 1G 77000 18300 76.23% 256c2T(4 node) 2M 3336 1051 68.52% 128c1T(2 node) 2M 1943 716 63.15% # Change log Changes in v5: - Use prep_and_add_allocated_folios in 2M hugetlb parallelization - Update huge_boot_pages in arch/powerpc/mm/hugetlbpage.c - Revise struct padata_mt_job comment - Add 'max_threads' section in cover letter - Collect more Reviewed-by Changes in v4: - https://lore.kernel.org/r/20240118123911.88833-1-gang.li@linux.dev - Make padata_do_multithreaded dispatch all jobs with a global iterator - Revise commit message - Rename some functions - Collect Tested-by and Reviewed-by Changes in v3: - https://lore.kernel.org/all/20240102131249.76622-1-gang.li@linux.dev/ - Select CONFIG_PADATA as we use padata_do_multithreaded - Fix a race condition in h->next_nid_to_alloc - Fix local variable initialization issues - Remove RFC tag Changes in v2: - https://lore.kernel.org/all/20231208025240.4744-1-gang.li@linux.dev/ - Reduce complexity with `padata_do_multithreaded` - Support 1G hugetlb v1: - https://lore.kernel.org/all/20231123133036.68540-1-gang.li@linux.dev/ - parallelize 2M hugetlb initialization with workqueue Gang Li (7): hugetlb: code clean for hugetlb_hstate_alloc_pages hugetlb: split hugetlb_hstate_alloc_pages padata: dispatch works on different nodes hugetlb: pass *next_nid_to_alloc directly to for_each_node_mask_to_alloc hugetlb: have CONFIG_HUGETLBFS select CONFIG_PADATA hugetlb: parallelize 2M hugetlb allocation and initialization hugetlb: parallelize 1G hugetlb initialization arch/powerpc/mm/hugetlbpage.c | 2 +- fs/Kconfig | 1 + include/linux/hugetlb.h | 2 +- include/linux/padata.h | 2 + kernel/padata.c | 14 +- mm/hugetlb.c | 234 +++++++++++++++++++++++----------- mm/mm_init.c | 1 + 7 files changed, 175 insertions(+), 81 deletions(-)