From patchwork Thu Feb 8 06:26:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Byungchul Park X-Patchwork-Id: 13549353 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC33BC48260 for ; Thu, 8 Feb 2024 06:26:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 620116B009D; Thu, 8 Feb 2024 01:26:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 577BB6B009C; Thu, 8 Feb 2024 01:26:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 419396B009B; Thu, 8 Feb 2024 01:26:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2AC7F6B0098 for ; Thu, 8 Feb 2024 01:26:26 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0329D1C1034 for ; Thu, 8 Feb 2024 06:26:25 +0000 (UTC) X-FDA: 81767652372.27.DB588C1 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf14.hostedemail.com (Postfix) with ESMTP id 7A40310001F for ; Thu, 8 Feb 2024 06:26:20 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707373584; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=4U7MoMbg975pmCt+EMgKBzsWZoyjhxPRqePVm5aEMt4=; b=8LuVBl/9WWjPtLOvWllV3prsVhDRNsrwVpwLsL97FTbjOaNaqMF1Wf0N19mHbYz9fcRylX yn3WE+zXilBU5Vk2cjV7z9EEt4ZUXH1soz2o6ZHe9G/h26CuGoe6PgbrHJimc66cjYBar1 acJcFHPRPzm/pTqu6Oq0owDAEUyfvCE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707373584; a=rsa-sha256; cv=none; b=qSeY+ta44oZ1NE8U5T4qsfXO5nT3qb/CMFRx9kw3fVSJPpexrWGxPK2LHrJUdfmZLD9fRh CkGwZP4nzqGg/qkbhDXbSuwehVdbMcfFf24Q5UBLoguK6UMfh7K9VCM6XdVNIPOLq2mLat QuhFF04tf1L8iYtqHj7IOeWgi+QXq3s= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none X-AuditID: a67dfc5b-d85ff70000001748-6f-65c4740a77c5 From: Byungchul Park To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: kernel_team@skhynix.com, akpm@linux-foundation.org, ying.huang@intel.com, namit@vmware.com, vernhao@tencent.com, mgorman@techsingularity.net, hughd@google.com, willy@infradead.org, david@redhat.com, peterz@infradead.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, rjgolo@gmail.com Subject: [RESEND PATCH v7 0/8] Reduce TLB flushes by 94% by improving folio migration Date: Thu, 8 Feb 2024 15:26:00 +0900 Message-Id: <20240208062608.44351-1-byungchul@sk.com> X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJLMWRmVeSWpSXmKPExsXC9ZZnkS53yZFUg7n3mCzmrF/DZvF5wz82 ixcb2hktvq7/xWzx9FMfi8XlXXPYLO6t+c9qcX7XWlaLHUv3MVlcOrCAyeL6roeMFsd7DzBZ zL/3mc1i86apzBbHp0xltPj9A6jj5KzJLA6CHt9b+1g8ds66y+6xYFOpx+YVWh6L97xk8ti0 qpPNY9OnSewe786dY/c4MeM3i8e8k4Ee7/ddZfPY+svOo3HqNTaPz5vkPN7Nf8sWwB/FZZOS mpNZllqkb5fAlXFuxVbWgnVmFdsnT2ZuYDyj2cXIySEhYCJx9+UcZhj7xvGD7CA2m4C6xI0b P8HiIgJmEgdb/wDFuTiYBT4ySaz+3sECkhAWCJVYNmE6mM0ioCqx8eA1JhCbV8BU4s4miBoJ AXmJ1RsOMIM0Swi8ZpO43tHPCpGQlDi44gbLBEbuBYwMqxiFMvPKchMzc0z0MirzMiv0kvNz NzECA3xZ7Z/oHYyfLgQfYhTgYFTi4T1RfjhViDWxrLgy9xCjBAezkgiv2Y4DqUK8KYmVValF +fFFpTmpxYcYpTlYlMR5jb6VpwgJpCeWpGanphakFsFkmTg4pRoYW+827a2/oWQfeoDpinLQ pKrWB+f/ZH2O7tNf5sXcE2pV4XQ4Tk3F4l/xglc/WudYT57vzaxeqmClw/ZHyXayOJOK1DSP vzYOhYzLX27z93ph1y3VvbVFdanRXUc/g2Tem4zhxzbnW7M4iv57H72tPDr1zcI9ob2urpUf vr+Niizb9HLKjklKLMUZiYZazEXFiQCY6KQbbAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrALMWRmVeSWpSXmKPExsXC5WfdrMtVciTVYOIMY4s569ewWXze8I/N 4sWGdkaLr+t/MVs8/dTHYnF47klWi8u75rBZ3Fvzn9Xi/K61rBY7lu5jsrh0YAGTxfVdDxkt jvceYLKYf+8zm8XmTVOZLY5Pmcpo8fsHUMfJWZNZHIQ8vrf2sXjsnHWX3WPBplKPzSu0PBbv ecnksWlVJ5vHpk+T2D3enTvH7nFixm8Wj3knAz3e77vK5rH4xQcmj62/7Dwap15j8/i8Sc7j 3fy3bAECUVw2Kak5mWWpRfp2CVwZ51ZsZS1YZ1axffJk5gbGM5pdjJwcEgImEjeOH2QHsdkE 1CVu3PjJDGKLCJhJHGz9AxTn4mAW+Mgksfp7BwtIQlggVGLZhOlgNouAqsTGg9eYQGxeAVOJ O5sgaiQE5CVWbzjAPIGRYwEjwypGkcy8stzEzBxTveLsjMq8zAq95PzcTYzAcF1W+2fiDsYv l90PMQpwMCrx8J4oP5wqxJpYVlyZe4hRgoNZSYTXbMeBVCHelMTKqtSi/Pii0pzU4kOM0hws SuK8XuGpCUIC6YklqdmpqQWpRTBZJg5OqQZGsaCclS8WcKWWp7s1/bM7q7TC+9H36ecPHZ/4 Zh6vYu9NwZ5fXK+vPebbEXz8qZm7bXYi+2IR5uzdR6akxEdtKm5eKrns6/yrzue1b1dsNr0a N/Hczc7tB7898Z33+OTT1SlvfBgeS2mdt1g7UzCdeddC6dnnbBZ5mSczd4R78ncFsrZc3tf3 TYmlOCPRUIu5qDgRAAbKCE1TAgAA X-CFilter-Loop: Reflected X-Stat-Signature: 1mpukf8e5p3ko8ddw4bhfigo49rzwm1e X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7A40310001F X-Rspam-User: X-HE-Tag: 1707373580-784148 X-HE-Meta: U2FsdGVkX1+WPSAx7BjhaRf+7JQdQgedU8d+PN0Y7jhqRBNXzh8QLcOMe/KM7452G2W80nNoigpkdBc4/Rky8Hb+PtoXQI8NaFogb+cagchkpGAYnTflGYTHTahSvg8kG3GL5bwPtM10+HVnucEXjCIuCZuBPi9Ky4rhYRe4wG0ogjBPhc/tTyvKO9GDFc+KxfX38vgIJIb3b8h7wlY/hjNSrh8BD3wTqTYWo7RA4a5LZIHvT5RJAN0t3tifblAbeIbWj+jV9pet1DQTxQ0BsbaTRytIegavaO6E/pKkWXfBdbje0IhHsEfRq1k3GmfXRNNTwVe9C6xRTigov5zg+d/lfnx1AfxXBv4GrpZGhqYVFkg3lDsqQm624VRNgpqPqlI3LFWQHdVdc1udq1i24iuxSBosvA7qJYwCSK6L+/cnyrF9Uqr1IixaS7VATVSIHF/XyTfZr5a0POWpgnjJlj2DNVXQrQxCU+OZfToSxLDqSoaKUJqQy+h3dKmd+iWJgcBUnpyaffFqgGl9+T89y5Qmpd3rlJ9AvTH6MXFtbMj12INaff0EaNanuERpF2bfEZOd0q/FLdUFjl6kZKkggIj/VZ9Uzc9dHw96VPxAB1odit7yq8Plo796Z0+NIYyxNAM7RpD2hHImd8hW0AP8cdv3b/ru9YwYl/3uxlTHj7l5ZXC/fDcDEAoJsTCw1Lnu1iWYch87xndKUD8Q7lsOUw02GNFYZjqqGn7olxu0qfh076BVKc5CsUU33LaCLGlOBKuFBMdT9QnpVUO57Avosh3sKhgKveO83i5WOY2sl2O92EY2wffdlia6E0cWCe2gnvQcgJloVx75A2pcBcNDwmXEzRmA2zT1RWvuxZtsUJF9zTgIgyw3/9oBZcauLxcSMGUR/4GTPCWAbDbARseNCEdAD/eF+Ci1zZSH9SvpKsx1J/CZB0PmLIsN2WSNrW3FCvnPvgMqdt784vDnGiS WVYyfTuH KPVT5CIdsb/b0UyfZIsvwYjqzKq1kK5JW8Rw2FpaYRhxH15PJAXN6WFbZsg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi everyone, While I'm working with CXL memory, I have been facing migration overhead esp. TLB shootdown on promotion or demotion between different tiers. Yeah.. most TLB shootdowns on migration through hinting fault can be avoided thanks to Huang Ying's work, commit 4d4b6d66db ("mm,unmap: avoid flushing TLB in batch if PTE is inaccessible"). See the following link: https://lore.kernel.org/lkml/20231115025755.GA29979@system.software.com/ However, it's only for ones using hinting fault. I thought it'd be much better if we have a general mechanism to reduce the number of TLB flushes and TLB misses, that we can apply to any type of migration. I tried it only for tiering migration for now tho. I'm suggesting a mechanism to reduce TLB flushes by keeping source and destination of folios participated in the migrations until all TLB flushes required are done, only if those folios are not mapped with write permission PTE entries at all. I worked Based on v6.7. I saw the number of iTLB full flush was reduced by 94%, iTLB miss was reduced by 45.5% and the total runtime was reduced by 3.5% with the workload I tested with, XSBench. However, I believe that it would help more with other ones or any real ones. It'd be appreciated to let me know if I'm missing something. Byungchul --- Changes from v6: 1. Fix build errors in case of CONFIG_ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH disabled by moving migrc_flush_{start,end}() calls from arch code to try_to_unmap_flush() in mm/rmap.c. Changes from v5: 1. Fix build errors in case of CONFIG_MIGRATION disabled or CONFIG_HWPOISON_INJECT moduled. (feedbacked by kernel test bot and Raymond Jay Golo) 2. Organize migrc code with two kconfigs, CONFIG_MIGRATION and CONFIG_ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH. Changes from v4: 1. Rebase on v6.7. 2. Fix build errors in arm64 that is doing nothing for TLB flush but has CONFIG_ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH. (reported by kernel test robot) 3. Don't use any page flag. So the system would give up migrc mechanism more often but it's okay. The final improvement is good enough. 4. Instead, optimize full TLB flush(arch_tlbbatch_flush()) by avoiding redundant CPUs from TLB flush. Changes from v3: 1. Don't use the kconfig, CONFIG_MIGRC, and remove sysctl knob, migrc_enable. (feedbacked by Nadav) 2. Remove the optimization skipping CPUs that have already performed TLB flushes needed by any reason when performing TLB flushes by migrc because I can't tell the performance difference between w/ the optimization and w/o that. (feedbacked by Nadav) 3. Minimize arch-specific code. While at it, move all the migrc declarations and inline functions from include/linux/mm.h to mm/internal.h (feedbacked by Dave Hansen, Nadav) 4. Separate a part making migrc paused when the system is in high memory pressure to another patch. (feedbacked by Nadav) 5. Rename: a. arch_tlbbatch_clean() to arch_tlbbatch_clear(), b. tlb_ubc_nowr to tlb_ubc_ro, c. migrc_try_flush_free_folios() to migrc_flush_free_folios(), d. migrc_stop to migrc_pause. (feedbacked by Nadav) 6. Use ->lru list_head instead of introducing a new llist_head. (feedbacked by Nadav) 7. Use non-atomic operations of page-flag when it's safe. (feedbacked by Nadav) 8. Use stack instead of keeping a pointer of 'struct migrc_req' in struct task, which is for manipulating it locally. (feedbacked by Nadav) 9. Replace a lot of simple functions to inline functions placed in a header, mm/internal.h. (feedbacked by Nadav) 10. Add additional sufficient comments. (feedbacked by Nadav) 11. Remove a lot of wrapper functions. (feedbacked by Nadav) Changes from RFC v2: 1. Remove additional occupation in struct page. To do that, unioned with lru field for migrc's list and added a page flag. I know page flag is a thing that we don't like to add but no choice because migrc should distinguish folios under migrc's control from others. Instead, I force migrc to be used only on 64 bit system to mitigate you guys from getting angry. 2. Remove meaningless internal object allocator that I introduced to minimize impact onto the system. However, a ton of tests showed there was no difference. 3. Stop migrc from working when the system is in high memory pressure like about to perform direct reclaim. At the condition where the swap mechanism is heavily used, I found the system suffered from regression without this control. 4. Exclude folios that pte_dirty() == true from migrc's interest so that migrc can work simpler. 5. Combine several patches that work tightly coupled to one. 6. Add sufficient comments for better review. 7. Manage migrc's request in per-node manner (from globally). 8. Add TLB miss improvement in commit message. 9. Test with more CPUs(4 -> 16) to see bigger improvement. Changes from RFC: 1. Fix a bug triggered when a destination folio at the previous migration becomes a source folio at the next migration, before the folio gets handled properly so that the folio can play with another migration. There was inconsistency in the folio's state. Fixed it. 2. Split the patch set into more pieces so that the folks can review better. (Feedbacked by Nadav Amit) 3. Fix a wrong usage of barrier e.g. smp_mb__after_atomic(). (Feedbacked by Nadav Amit) 4. Tried to add sufficient comments to explain the patch set better. (Feedbacked by Nadav Amit) Byungchul Park (8): x86/tlb: Add APIs manipulating tlb batch's arch data arm64: tlbflush: Add APIs manipulating tlb batch's arch data mm/rmap: Recognize read-only TLB entries during batched TLB flush x86/tlb, mm/rmap: Separate arch_tlbbatch_clear() out of arch_tlbbatch_flush() mm: Separate move/undo doing on folio list from migrate_pages_batch() mm: Add APIs to free a folio directly to the buddy bypassing pcp mm: Defer TLB flush by keeping both src and dst folios at migration mm: Pause migrc mechanism at high memory pressure arch/arm64/include/asm/tlbflush.h | 19 ++ arch/x86/include/asm/tlbflush.h | 18 ++ arch/x86/mm/tlb.c | 2 - include/linux/mm.h | 23 ++ include/linux/mmzone.h | 7 + include/linux/sched.h | 9 + mm/internal.h | 78 ++++++ mm/memory.c | 8 + mm/migrate.c | 411 ++++++++++++++++++++++++++---- mm/page_alloc.c | 34 ++- mm/rmap.c | 40 ++- mm/swap.c | 7 + 12 files changed, 597 insertions(+), 59 deletions(-) base-commit: 0dd3ee31125508cd67f7e7172247f05b7fd1753a