From patchwork Tue Feb 20 11:44:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 13563905 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 409F9C48BC3 for ; Tue, 20 Feb 2024 11:44:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4F896B0075; Tue, 20 Feb 2024 06:44:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BD8E76B0078; Tue, 20 Feb 2024 06:44:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A78A36B007D; Tue, 20 Feb 2024 06:44:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 94DC46B0075 for ; Tue, 20 Feb 2024 06:44:43 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 32D6F160624 for ; Tue, 20 Feb 2024 11:44:43 +0000 (UTC) X-FDA: 81812000046.01.DBF688A Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) by imf07.hostedemail.com (Postfix) with ESMTP id 94F5D40022 for ; Tue, 20 Feb 2024 11:44:40 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=YmHq88Nj; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708429480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=xPhvAK2/CwxqosuPKJ0uCWAeLXDmPfN7jw3gdgYocrs=; b=2FSfIIkHjW/MLv+qonnPQeRmg7nuw3hIXMBIUFxhdCkTwEgqs8pOKO3bkc84yJPE0EHXn6 4bCZ5ZB/g//wKtWLtgWMJf8Z6bozjlmnoKdtbpIpEuuYym/C7qfvXesOLVWY4oEZvEU2W0 NhNwT3zFkZtmzwQsTjptOCunvGBh0I0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=YmHq88Nj; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708429481; a=rsa-sha256; cv=none; b=bjjbZE7kT9R2g+VjJutPbtamldD1/75GSx4o2bZY12TRth88bvf1xCtcp/NR1P1nyD1ZA3 6j8yqCKWywcqXLF6QcZj9nKsIPOGpPFq/GxmTO2LtA6JgHYF1DSNN4ykdxM7VD2eA5ikXC YmJmr0JD6XO+4iqD5zIAFisWWGEn1dA= Subject: [PATCH RESEND 0/3] mm/zsmalloc: some cleanup for get/set_zspage_mapping() DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708429478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xPhvAK2/CwxqosuPKJ0uCWAeLXDmPfN7jw3gdgYocrs=; b=YmHq88Njyhm2Pr867Jk7e9cUM2YgV5Kw5R56B72cWgMekDcZeeLfL0BQPB9jq5YMk5MFmx mOIG0lcvWGGuVitAvxPsy8lXXPjObsqOO+eaM562LT9q7mhHjnN9CBmdLUdgnCr9Jp/3Bl 5wLfMRybgk/lk9sIi0HeifL5arIXVcg= MIME-Version: 1.0 X-b4-tracking: H4sIAJyQ1GUC/43OwY4CIQwG4FcxnMUAA4N68j02HmipDgkyZnDIqpl3t9mz2cyp+Zv8X/sWlaZEVR w3bzFRSzWNhYPebgQOoVxJpshZGGWsMkZJsPJVbyHnESVmCmW+S9erYLU7APQguAmhkoQpFBy4W+ac eTmk+hin59+lpnn8/I82LZV06IgsYox7f4LngyKjtMPxJs5sNrPCMewoH7UjD36P9pvTrXA6doL3Ti N/FDv45tgVjmXncnABLj0pZd0ppzL/7iI1cV6W5QM2/Mo3kwEAAA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou Date: Tue, 20 Feb 2024 11:44:28 +0000 Message-Id: <20240220-b4-zsmalloc-cleanup-v1-0-b7e9cbab9541@linux.dev> To: hannes@cmpxchg.org, Andrew Morton , Sergey Senozhatsky , nphamcs@gmail.com, yosryahmed@google.com, Minchan Kim Cc: linux-mm@kvack.org, Chengming Zhou , linux-kernel@vger.kernel.org X-Developer-Signature: v=1; a=ed25519-sha256; t=1708429476; l=1438; i=chengming.zhou@linux.dev; s=20240220; h=from:subject:message-id; bh=wFwGQOpNEBJ6RvCPo1NYthjN1KIzKMJfv7sjFw0IOrM=; b=7GscvdD0HgdL3NVA9Yals2j5vg6+eQzCDNJ83CWGDzCEBZF3YqfAw/rT+BdvASJen2APnlDj8 yDqQN8Y7o79AW5g1RKPfWYqrkF7aqBy4VANvhGNrzttBKKGJLrKZ4eM X-Developer-Key: i=chengming.zhou@linux.dev; a=ed25519; pk=5+68Wfci+T30FoQos5RH+hfToF6SlC+S9LMPSPBFWuw= X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 94F5D40022 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: hodkz4315ro9rejaean4eknnfhskupqz X-HE-Tag: 1708429480-567228 X-HE-Meta: U2FsdGVkX1/DzzZ6QNG59IuwuxrrPdNCUWK7CcwDak6pieQZTxitQTNVwGmXid1J1LFE46KxO+GnosCzx+biHVQKMCedSaFtQFIrxl+BPlxx1q33lq53+EnH3Y+JVcSIlAF4SOw1c9wlTpLrgCyw9WkIoexeJkPmqMkVpi1yLlUaO0Hncdh3A0Mz0mkOfdJM7yi6b1M5JqAehdcSZ1a5L809LBj3UZJnSlAurKNZb1mzwO5Mc8nS2pSHQaz97CQC9c83/Z+PsHOixSRXt4Y099nMHax+qPnyKaGIxkdQwdTYnPiyyLWMTbGgtSaRkJfCfAO9ggbWvEQtUyO9uvJCjF63uXPtfdZ3zXYJwmzWm3eFpMiNpBa2VC47cHHvsyQU7AGiXQngw+S2NUnm1KDB+44vQWpY6i5wgnEjRYucLgtK++NPpj549H3npL1ZuXxT2+c98WJ8xerEmh/tqoVqFC2hXjPjRXxjg9EkFmy6D63k7VAHW08UCi53ToyXGfroT0e0mQoeVP6vPxb6UPSDsF4qRjI0NeXiVIHGs4ff3Bc5dwXaXNk6pha25YOd1j9HcrFyXYmKEBCgnWBmC+z60e910dKbRFc2eO5SaVYDEPisoqBdL2V/yudzBOsDTQfLxcXc7bNM3sj5izA8XEdGcXL8fdlubCyOCp+vnPpjrTjlJ4/C/veYNYrMfpnsn4o5t6aNKqfjHLu4p0cNG1Wz6ZMqQhVj08zqPfgRZYYGmWKJM+CSNKW2nv0FarBC9xjhSh8DmXUjst5y4GZKmJD8DCmdlQnmvS7DEfXmsGWqiMaRHZIIh9rEMDqS6c6lfRb5lLB3V6YHE8US8zyq9q3UBZ8wTr5jf+ZE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: RESEND: - The sent patches were put into spam folder because of my mail problem, so resend after I fixed it, sorry! It should be ok this time. - Link to v1: https://lore.kernel.org/r/20240220-b4-zsmalloc-cleanup-v1-0-5c5ee4ccdd87@bytedance.com Hello, The discussion[1] with Sergey shows there are some cleanup works to do in get/set_zspage_mapping(): - the fullness returned from get_zspage_mapping() is not stable outside pool->lock, this usage pattern is confusing, but should be ok in this free_zspage path. - we seldom use the class_idx returned from get_zspage_mapping(), only free_zspage path use to get its class. - set_zspage_mapping() always set the zspage->class, but it's never changed after zspage allocated. Thanks for review and comments! [1] https://lore.kernel.org/all/a6c22e30-cf10-4122-91bc-ceb9fb57a5d6@bytedance.com/ Signed-off-by: Chengming Zhou --- Chengming Zhou (3): mm/zsmalloc: remove set_zspage_mapping() mm/zsmalloc: remove_zspage() don't need fullness parameter mm/zsmalloc: remove get_zspage_mapping() mm/zsmalloc.c | 55 +++++++++++++------------------------------------------ 1 file changed, 13 insertions(+), 42 deletions(-) --- base-commit: 207636f0f52428f3b46540b212d6f93c6ac484cf change-id: 20240220-b4-zsmalloc-cleanup-560a4159bb6b Best regards,