From patchwork Fri Feb 23 18:27:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vlastimil Babka X-Patchwork-Id: 13569863 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 038D6C54E49 for ; Fri, 23 Feb 2024 18:27:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A43CC6B007B; Fri, 23 Feb 2024 13:27:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F2D36B007D; Fri, 23 Feb 2024 13:27:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BB0A6B007E; Fri, 23 Feb 2024 13:27:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7D4006B007B for ; Fri, 23 Feb 2024 13:27:44 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 41635A1155 for ; Fri, 23 Feb 2024 18:27:43 +0000 (UTC) X-FDA: 81823902006.22.08BB3AA Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf13.hostedemail.com (Postfix) with ESMTP id 09FE72000C for ; Fri, 23 Feb 2024 18:27:40 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2pgIZN7M; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=w0RTxYkq; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2pgIZN7M; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=w0RTxYkq; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708712861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=jFPvU6fb5RZSwRXjaHsGExL2vu2XY+R4lmvjGVLfKDA=; b=8evXx1RoS9yduHnt8/Eto2N1TPZ9/i1zp3DVKYNjsdFwCsol7BcBxjilIab6cqSUXO7egA pG3PZ3LeMorHSwkMOE4tr41u4ynSrGjJRi31rpsfNVgsJEPHKIaPaxkaIPZk3nhjGoqkOP if0WMHy/Ofqg2j5JFxJ1wMiSbmSLhAQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708712861; a=rsa-sha256; cv=none; b=alEu2SL3Wzscopgm9Z+MpmROVnf1eQyoIIarpeSiCd9iCISGLJW3NuSm4SO0ObFUuVjgW1 01HUAwNKVCsjOYDis61QrcQ3zjhHuwrLimpf/b5SqeYDZgxSmyll4+9Ec0CIJsrwFAHSf+ LTI6iDGLcZFL0vjPHkWD7UC5CxpqmyY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2pgIZN7M; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=w0RTxYkq; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2pgIZN7M; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=w0RTxYkq; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 039261FC26; Fri, 23 Feb 2024 18:27:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708712859; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jFPvU6fb5RZSwRXjaHsGExL2vu2XY+R4lmvjGVLfKDA=; b=2pgIZN7MM6mn08ivR/pl0Z/SZbZJi+SVFITbXVbV55zjlyh+axlmtA28Ob3T5Wdo43hsTc MKDx/gz4LSfNa/5h9N8NzZGNLvmzHNdGfevCe5+VERaRPpu/BH9zQJQfYbUAXKwxrjfqp8 MKITDItNrlYt6Pph2j6R8N6SwX8PZn8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708712859; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jFPvU6fb5RZSwRXjaHsGExL2vu2XY+R4lmvjGVLfKDA=; b=w0RTxYkqn6lPsTMR61gqIHfzY/LejF3hVLRoTXu4qhD3YUDEjgNJUHSlB5tq92IkkJt3NX IFh9lHVDsmV/ckCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708712859; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jFPvU6fb5RZSwRXjaHsGExL2vu2XY+R4lmvjGVLfKDA=; b=2pgIZN7MM6mn08ivR/pl0Z/SZbZJi+SVFITbXVbV55zjlyh+axlmtA28Ob3T5Wdo43hsTc MKDx/gz4LSfNa/5h9N8NzZGNLvmzHNdGfevCe5+VERaRPpu/BH9zQJQfYbUAXKwxrjfqp8 MKITDItNrlYt6Pph2j6R8N6SwX8PZn8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708712859; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jFPvU6fb5RZSwRXjaHsGExL2vu2XY+R4lmvjGVLfKDA=; b=w0RTxYkqn6lPsTMR61gqIHfzY/LejF3hVLRoTXu4qhD3YUDEjgNJUHSlB5tq92IkkJt3NX IFh9lHVDsmV/ckCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CBEDE133DC; Fri, 23 Feb 2024 18:27:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zj5DMZrj2GUaTQAAD6G6ig (envelope-from ); Fri, 23 Feb 2024 18:27:38 +0000 From: Vlastimil Babka Subject: [PATCH v2 0/3] cleanup of SLAB_ flags Date: Fri, 23 Feb 2024 19:27:16 +0100 Message-Id: <20240223-slab-cleanup-flags-v2-0-02f1753e8303@suse.cz> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAIXj2GUC/22Nyw6CMBBFf4XM2jFtKc+V/2FY1DpAE1JIRxqV8 O9W4tLlOck9dwOm4IihzTYIFB272SdQpwzsaPxA6O6JQQmlhZIN8mRuaCcyfl2wn8zAaOtSa1m QtTVBGi6Bevc8otcu8ej4MYfX8RHl1/5ySvzLRYkCqSwqyqu80dpceGU62zd0+75/ANpg8i6yA AAA To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino Cc: Zheng Yejian , Xiongwei Song , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Vlastimil Babka , Steven Rostedt X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1960; i=vbabka@suse.cz; h=from:subject:message-id; bh=XEJyJuE3iDgp5Yng6UletIUmKt9m1Y+5GGOt7cPegGw=; b=owEBbQGS/pANAwAIAbvgsHXSRYiaAcsmYgBl2OOPG1gBtDkksy5t20lOzP2N4CSXyxrsDwd0s 01QGR/m+zCJATMEAAEIAB0WIQR7u8hBFZkjSJZITfG74LB10kWImgUCZdjjjwAKCRC74LB10kWI mmavB/9y5AI6D6IRww4XMiiwjjYlhMmza4+TL9mAHyfVi8XpuIwqg006twc5K90zh55wDZTaOMV 5x2bQLz3DZ8wXClbIqMwagmHpF2COF6dhzwEPi2sYkklX+d1vWOafBnlw0oA+wNbl3Wb059yLog TbRNeQ1TyL1AVvyvYt+Ad2EqZNpwdPhc/ejFwHhqlZrpMkRH/GXRNOT6xfTnsZg8uFc84q/kDSH 50sbJijMHg56BIQrZ77wlMEX+EX2c8zmFm7r8Ij14CR5zBNHudZ0y+EbwZBneWYQx+/Wrzocvf8 K1ZPa0fBU96x0wOYdNb8eg/g24hvX4ekw5rDFhHwTp+wFv6p X-Developer-Key: i=vbabka@suse.cz; a=openpgp; fpr=A940D434992C2E8E99103D50224FA7E7CC82A664 X-Rspamd-Queue-Id: 09FE72000C X-Rspam-User: X-Stat-Signature: 3qq3huudfnry73b4sqokr9p779ygktda X-Rspamd-Server: rspam03 X-HE-Tag: 1708712860-875413 X-HE-Meta: U2FsdGVkX18zTDUInRDi4oN8N8NI75OSxOn+xiPgnqKzDFdMvF3rjAFzlRNFcOabLi8uukm/r5Siwm5Nj6W885HTS1NMvcTcD3fdSDeGeLVirnBAwASKM3HB4aFnYroVzm4xJt+OTHHFASKHdhFHZATmvYY4vRMBkYrzfycqecFI1d9yNaoK50FxXoNoSz/9J7KMnbWXUpckRdeAu7o4nvkCkKmAaStFHql0OCCFLboTZ1z/lhm6hQSUeufsyZaIaNNjY0q2TXveRcfzQoqfPDTY/GZpSv2nrPuRUJNQP8U6tGAbiJYzSB7EYzr6a3r33IoD/f13ynA3drO+SYSrRj5P1A5zU/0vDyx/OFURwctRPCd9argT/j3wimbKhnKP6IEpBj3x6jKDnM/buMj//W1lnLUd311sHinrI26e6+CB4iGaRWttZ23jpdsidk5VuOcu/QH/W7JaMX4bAMTZessJhO9kU84xtFZmxkuCJX68/6/RWmQW7Q7QbXht8G2H3uzGya66AXMWfa5ZGlD6XYmUSBQ7L332+PgnqO7EsN+UPHcbfXcc/Rk/kqi7z0dWSxFBIGWOcRM/Dpz4HKCjctS8KnJTwc4x0CjB5Yo4AwT/G0nQ3YytRSQ4u4jxL8PZakn87Szv+jMayKDWOeZgVijewJ1D2XoKVffHHUoD7Ntb+HZS1KgKL043e3HJMHgP3h5CY6N45nzS7oCX1GY9RiveLwhSh9DIKlMpkY2MJFBbCik+gsFSmDBSejBZ2aVMchjgrgs4Kn+FkWAAGXc8d0IBAKjAsRff7gD+lb52Q/2X6C0TuY1DaKzRYhehW+rDwdHTz2kgb25PiufuGZIqoLeWcLQSZBpaRzKmj9KRuCjKCv77z00jBNNwowKKckDLdqBCIA9OvAvFFIUzYkaopaAo9E+WdGl14XJj0cZ3vhXBTCsNtX5ul3PM8goGCLZgdFO/5yp1mdJMI+fkapi wg+gBbM2 XRyS0J41myPfovAPa1MnroMUHM9jxkvSWD2ScH3UPOvdvtAs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This started by the report that SLAB_MEM_SPREAD flag is dead (Patch 1). Then in the alloc profiling series we realized it's too easy to reuse an existing SLAB_ flag's value when defining a new one, by mistake. Thus let the compiler do that for us via a new helper enum (Patch 2). When checking if more flags are dead or could be removed, didn't spot any, but found out the SLAB_KASAN handling of preventing cache merging can be simplified since we now have an explicit SLAB_NO_MERGE (Patch 3). The SLAB_MEM_SPREAD flag is now marked as unused and for removal, and has a value of 0 so it's a no-op. Patches to remove its usage can/will be submitted to respective subsystems independently of this series - the flag is already dead as of v6.8-rc1 with SLAB removed. The removal of dead cpuset_do_slab_mem_spread() code can also be submitted independently. Signed-off-by: Vlastimil Babka --- Changes in v2: - Collect R-b, T-b (thanks!) - Unify all disabled flags's value to a sparse-happy zero with a new macro (lkp/sparse). - Rename __SF_BIT to __SLAB_FLAG_BIT (Roman Gushchin) - Rewrod kasan_cache_create() comment (Andrey Konovalov) - Link to v1: https://lore.kernel.org/r/20240220-slab-cleanup-flags-v1-0-e657e373944a@suse.cz --- Vlastimil Babka (3): mm, slab: deprecate SLAB_MEM_SPREAD flag mm, slab: use an enum to define SLAB_ cache creation flags mm, slab, kasan: replace kasan_never_merge() with SLAB_NO_MERGE include/linux/kasan.h | 6 ---- include/linux/slab.h | 97 ++++++++++++++++++++++++++++++++++++--------------- mm/kasan/generic.c | 22 ++++-------- mm/slab.h | 1 - mm/slab_common.c | 2 +- mm/slub.c | 6 ++-- 6 files changed, 79 insertions(+), 55 deletions(-) --- base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d change-id: 20240219-slab-cleanup-flags-c864415ecc8e Best regards,