From patchwork Mon Mar 25 23:50:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yosry Ahmed X-Patchwork-Id: 13603181 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64BC0C54E58 for ; Mon, 25 Mar 2024 23:50:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 876776B007B; Mon, 25 Mar 2024 19:50:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FF366B0082; Mon, 25 Mar 2024 19:50:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 678F86B0083; Mon, 25 Mar 2024 19:50:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 530A46B007B for ; Mon, 25 Mar 2024 19:50:23 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C0512C041B for ; Mon, 25 Mar 2024 23:50:22 +0000 (UTC) X-FDA: 81937207884.12.8144206 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf04.hostedemail.com (Postfix) with ESMTP id 1797A4000E for ; Mon, 25 Mar 2024 23:50:20 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LRaps6sb; spf=pass (imf04.hostedemail.com: domain of 3vA0CZgoKCBcLBFELx49103BB381.zB985AHK-997Ixz7.BE3@flex--yosryahmed.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3vA0CZgoKCBcLBFELx49103BB381.zB985AHK-997Ixz7.BE3@flex--yosryahmed.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711410621; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=u7aBwaC4ODAeR/XYxC4V8jgRmUuIBcBfSCKvbyeibW0=; b=MFWJwKfr0b5TwshAgr8CKDpqtMRpOlJK6CuHVs3G+X90l2YS0QjVrdKc6dPYiqm7iwmrOD xlcYkZCVBGkHtoDFvbeZHsOkXV18QK93sGXO/0fIuVYypnlAcyHkMfTVQLz0bNfY1GY3jO oK2A+tTD557cWyG7NXk1Frde91Urm4A= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LRaps6sb; spf=pass (imf04.hostedemail.com: domain of 3vA0CZgoKCBcLBFELx49103BB381.zB985AHK-997Ixz7.BE3@flex--yosryahmed.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3vA0CZgoKCBcLBFELx49103BB381.zB985AHK-997Ixz7.BE3@flex--yosryahmed.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711410621; a=rsa-sha256; cv=none; b=KsEsQj1uMkiydPHqJ5XVRVWD4i09A1T22lXls/M7o68fWILLR+Qb3/0Qv612FO9I1Vba/v l7lqCXriz2+S+tpHi1AGv3dPaAeoOxG24pjIdjdYYEWefN7w2p2utYFc5E12AkwzXtgmIn LDQ2UVdF3j01i5kNIspgewKe8o+OXYw= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dd1395fd1bfso7410113276.0 for ; Mon, 25 Mar 2024 16:50:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711410620; x=1712015420; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=u7aBwaC4ODAeR/XYxC4V8jgRmUuIBcBfSCKvbyeibW0=; b=LRaps6sbFPSbGVlGkZpIQWWk5HkgXE++Hx5vSjI4FoK8ZTNkKG1i15cZ39EwNKrQg4 9wiNWp/Y4tok34zV57jRo3rFAFpxJkcM1h+haH7bbJhX7fUxVN/0URJZrXg5xWnZTtal rUlAWyKDltBU/XeqfX1z4ePXsFimFXxio8aJB77MPSliKy+LIWJabGDPhdPcUSPrgbyh lGn/CkbxGXM7sb/sopINojsrwCU/7GA5RD9jbxSTaV0PAkfPwIyDo9QIHTGMnaW8B0GI 3e/DiOCXtFdHRkNJwqbcmHWZBMH1er86fPBr2ny9/A4XD6mhSSppORzuPeiV8ZfZYXE5 bFCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711410620; x=1712015420; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=u7aBwaC4ODAeR/XYxC4V8jgRmUuIBcBfSCKvbyeibW0=; b=XTxJNjuL7KJZoRIQuk9IXYW5FNiPBj73C4lrsW4Ym/TJ+iD3h2Jz2exPmRDvpHk/IG dC3e49Jdc83n09X7l0FnxDBUpIx+kxP3yGATVEELQu7ec1BQ4n+5xeIYojTzbhbK4ZBy i7WTVeBTNUPOyfCE6tbDJ7ZDTN3Q3EUyCD5f69bNqQnTku4p0CAIU+c+IYHZkAQU3ry4 kdWrp7hXZoxLEJjpAYszESZUVAy93yYtzTsBtWx2t9MMztjpcdHHjyLAaLcDST84Jsmk wtvxTFCgxiZEj509mIO4EPCu4vXyNOOnqRBanNiKSX9sD13R6drRTzWflv8dwjrh71ud NiuQ== X-Forwarded-Encrypted: i=1; AJvYcCVMCgcNPTUMKbU6mWjS4lWcgVA/BPdIEyWnYMlHQz3IjOxeaVPGOZOa5ExDJkCQzVre3rm++6go/2W826MpcyA2knA= X-Gm-Message-State: AOJu0Yxpv5QaigYXaFyVFygmHg4AtnRpprSMtYJ473bWrbFU2KbXkaRb leg85jcCLp6NfELnsMmwAAcMLDNUcB/SxwKxEZJKcpWR/h6mNNATKKdvpF5ZyDXVuIgfMe04XM1 8rewyNsk7cNi2i0GQKA== X-Google-Smtp-Source: AGHT+IFCdSCNI12vl7kQFBLpUa6o4Lix7+E5B+fsD9bW1doNy+Mmb1MlgwxyNG6gk4wPRI3jQ5rMwciD3YXfahGz X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:6902:2388:b0:dda:ce5f:b4c3 with SMTP id dp8-20020a056902238800b00ddace5fb4c3mr2112625ybb.1.1711410620214; Mon, 25 Mar 2024 16:50:20 -0700 (PDT) Date: Mon, 25 Mar 2024 23:50:08 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.44.0.396.g6e790dbe36-goog Message-ID: <20240325235018.2028408-1-yosryahmed@google.com> Subject: [RFC PATCH 0/9] zswap: store zero-filled pages more efficiently From: Yosry Ahmed To: Andrew Morton Cc: Johannes Weiner , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yosry Ahmed X-Rspamd-Queue-Id: 1797A4000E X-Rspam-User: X-Stat-Signature: educyscze6ozypozk8yor7jtjduwe7jr X-Rspamd-Server: rspam01 X-HE-Tag: 1711410620-363363 X-HE-Meta: U2FsdGVkX1+jcfG0g/ubNnMXJF9P3lEU+k4jcdtiqaiJPxb4OZbLUtvs8wT7aurduvuMidpGLqya96/KQFNlHN3sypiTb+QHPUjQLJRLktL5867RaqOarBxLoMyaDN3FF1zqd1PaRf39AE88k/uqKc1bgr+h0XhY3ydbXpiRUxM+gDv+QZ8QUBd02cLMaKn1TN8HzOqgkyv3Mpz5Gm9J8ND1i2o7VBvqiS6q/4dv/S5+Lud1p+NQV1LPWU7DCuqYPeaze2wh/Z5IH611EXjxPi8ij3iGDHv2nsTCd7ok87oZPddpD74BZPGvF7IxeYGZ/FCV7E3OYuVRasIUXvtdPYgrDKNOJw6tVeXBHmfJRydnOJLQ1h3j4CyompaB2fMXmyrTzr6YBw8AZZtRIvU60t1nPIhGhFHYBoqpxK4UgHqBnsrcjSdlIquPEQj+HNex2fzg5wZwA7ZGIuUkjZW64EDLe4SgTSrzFJq/RKfB2j4seZ1mJjrHqWOFhhmVHAdCyJSMjPMJb2bEZOVTlcemoGKKZWygSPwKar+5GsOwU4d19C7Ea5DbMmNVwoF5JH/K7+jWfw9Fh2fxNjzo7kspOeTzOWH2JsVCDCofzweGB3sAxKg7VjB+O7ODZxSkQkcRC+o04aPJ5QFCyCTmB/O5X4zCpMOdD3/sgzHSI/cg0rcvqKPoaeaYlo570ez2WbbgcLCF0fqhvXoVGZAxQI1tY5VJKhfOXzRaaD1Wk/f0zAOfjztSpkcBSuJMxgCzTSGYHzu6izuwJ4crwE7Eq7/i1U3SvmUS1vUc7Lnweqg4puuabkaZ7Y0bxCajlSjZlniJ9P/TkFUlzgKM32SmV2IyewmS3TPL1ovY1xHAIiiqgsVxzs/ghCm3P7Pcmle7FSuPiUmhevJE5cDmGso/fkJ0onbO8Rd42dsLRS4V9lpCWVeolYWvWwrKVSrSMbkTabJ7b3lEzq/IksMSBLIrbkM P7dcduDh 8Ra37ywPo2nI7xzSaKoyzkSEtToOmYflSjFZhEaOyMXgFlcfUuuSB3w8nD7nRzmkZ9QuENS0V31F+JkfCyQfEsp6WUMPxQMapcutNj70DJGh7+0O6S0dmLCcfjZBdwZft7wzGnk2cOx/dth8ABqPMY/DExnjxpLXGl+Ilc/XNDnjMMnDwBUInZ1h7Hn6enD1998wrrwKKm8NEYw9xXcZVcIrFZNNB9d21QAakVcBxGL3/Wbsf031tg4tGpnxytVHw10swxp2Eq6TyDEK1WS5xwLLHLLpTel/RP4sybMX/bWqKyKQ1IhpXrT6pmetpKaMAF0Es4mBfFVKm1I9LqQcv/f9dl0yVthhJdge3zAeyyga66aZhwbzopUgORSNlTMEPiPFHokZZCnJvN8A5okFlXmsKQKPNOg4iTL66aeaXC5mectYaJftzoIeHt/IRBHaEkyW39zZ2muzCgBCeLiJZFpn5CC4omTKLxl+Va20ogfn4e92v/tjJ+/zyiN2x97wbiLESRn2nX8Empb0VQoxiisB2xJXCmVp+HK+cohBVFbqX3Y4+4JpurkkJSlcIII/6hT+nyV6HufN820gXy9BbtkF1GLdgnFSc3sMxXwkF6ZQJh3o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patch series drops the support for non-zero same-filled pages from zswap and makes storing zero-filled pages faster and more efficient. Non-zero same-filled pages should not be nearly as common as zero-filled pages, so dropping support for them in favor of improving the more common zero-filled pages makes sense. It also allows for a lot of code cleanups. Patch 1 is a small cleanup for zswap_store() cleanup path that also implies a small behavioral change. Patches 2-4 are groundword refactoring. Patch 5 removes the userspace tunable to enable same-filled pages handling. It arguably makes no sense anyway. Patch 6 drops the support for non-zero same-filled pages, and patch 7 allows for storing them more efficiently. Both of these patch cause around 1.4% improvement in the system time on kernbench. The kernel build test only produces around 1.5% zero-filled pages. Some real workloads are expected to have higher ratios of zero-filled pages and hence more improvement. They also save a little bit of memory. Exact numbers are in the commit logs. Patch 8 drops the limit checks before handling zero-filled pages and patch 9 does a followup cleanup of zswap_store() made possible by this series. This series is tagged as an RFC because it makes some potentially controversial decisions :) The series is based on a slightly outdated mm-unstable. Yosry Ahmed (9): mm: zswap: always shrink in zswap_store() if zswap_pool_reached_full mm: zswap: refactor storing to the tree out of zswap_store() mm: zswap: refactor limit checking from zswap_store() mm: zswap: move more same-filled pages checks outside of zswap_store() mm: zswap: remove zswap_same_filled_pages_enabled mm: zswap: drop support for non-zero same-filled pages handling mm: zswap: store zero-filled pages without a zswap_entry mm: zswap: do not check the global limit for zero-filled pages mm: zswap: use zswap_entry_free() for partially initialized entries mm/zswap.c | 297 +++++++++++++++++++++++++---------------------------- 1 file changed, 139 insertions(+), 158 deletions(-)