From patchwork Tue Apr 23 07:54:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 13639460 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3804C10F15 for ; Tue, 23 Apr 2024 07:56:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A12E6B00C2; Tue, 23 Apr 2024 03:56:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49AD26B00C6; Tue, 23 Apr 2024 03:56:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FE0E6B00C4; Tue, 23 Apr 2024 03:56:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EE8DD6B00C3 for ; Tue, 23 Apr 2024 03:56:06 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 88AD7A189B for ; Tue, 23 Apr 2024 07:56:06 +0000 (UTC) X-FDA: 82040038332.01.2AAD8E3 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by imf21.hostedemail.com (Postfix) with ESMTP id CDF681C0003 for ; Tue, 23 Apr 2024 07:56:04 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=weissschuh.net header.s=mail header.b=XZeV3YWG; dmarc=none; spf=pass (imf21.hostedemail.com: domain of linux@weissschuh.net designates 159.69.126.157 as permitted sender) smtp.mailfrom=linux@weissschuh.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713858965; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=9NcmxJHYCh8V4GKL81XvutCiY2ffNa04Tbdop6aGqp0=; b=FUTX8JA5rkWLb/9Vxj78sunnnZ8oOsAwuso2aAbc4oI3FtfGLeLfGtoNhLDM/iOhYDFETm fKFfw/iYTPVVb3r942B/tS2gsRdCVs/NpPmO2ieR5nWbHVjFgz+w7eXOlq4vYR1zj6ZPv1 /lnIgxXtf8XDlf7rqC6UxQxY9OYFpBA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=weissschuh.net header.s=mail header.b=XZeV3YWG; dmarc=none; spf=pass (imf21.hostedemail.com: domain of linux@weissschuh.net designates 159.69.126.157 as permitted sender) smtp.mailfrom=linux@weissschuh.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713858965; a=rsa-sha256; cv=none; b=qvXeuuwe3gC+MRHePeH7DLBqQE4a1sxmvqfyAVDJN694OpCiT/VpIlwFY2+XZ8LPj2wbVr 2WYgP+mSc13zKXKofgQzK+703SMkSWDPzUzOv9Elk89f4aPgvAeSk5f2XsCf+jw8CG1/WB IDj+L6XK7BPGAm/2uLSRR71Nj/vPuPE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1713858962; bh=O54mll2lZcxHuSuV6IhzlmRJxXGkXc6uykp5lefHyQg=; h=From:Subject:Date:To:Cc:From; b=XZeV3YWGKdzXDyt2gGdiSBu+tAR9ehmxCo0/cgGTgNF4l9KeVxXCrFY2tRLq1+ykl c6TDhFBKGpJkh/D8HY03220W94T6e0r+dDxGxBkrr0k1umozRGS6gkzuySz0B7Xa/g 8yXILGrDVWsr+D5Q4C7df89uD11g1JxsYDcXWzP0= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Subject: [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers Date: Tue, 23 Apr 2024 09:54:35 +0200 Message-Id: <20240423-sysctl-const-handler-v3-0-e0beccb836e2@weissschuh.net> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIADtpJ2YC/3XOwQ7CIAwG4FdZOIuB4oR48j2Mh411QrIwQxFdl r27bCcT9fg3/b92ZoTRI7FTNbOI2ZMfQwlqVzHrmnBD7ruSGQhQEuDIaSKbBm7HQImXjW7AyI1 RbY1to9EIVqr3iL1/bezlWrLzlMY4bVeyXKcreBBK1r/BLLngUgE0VttWqO78RE9E1j3cPmBiq 5rhQwL1R4IilbdaqU0vNegvaVmWN33FrUoHAQAA To: Luis Chamberlain , Joel Granados , Kees Cook Cc: Eric Dumazet , Dave Chinner , linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-xfs@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-hardening@vger.kernel.org, bridge@lists.linux.dev, lvs-devel@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-sctp@vger.kernel.org, linux-nfs@vger.kernel.org, apparmor@lists.ubuntu.com, =?utf-8?q?Thomas_Wei?= =?utf-8?q?=C3=9Fschuh?= X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1713858961; l=7199; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=O54mll2lZcxHuSuV6IhzlmRJxXGkXc6uykp5lefHyQg=; b=SEVrV4QL0aRQf4sZAyD6Lh+KIYjBicAEwKhtJ0PUAXQvKQVj+Lo8XxYFfez7YZFSvNW40HQoh r7IOwglEOGsCcMSO1z8xH6fte/UGc8Ay9QjWTKXdmQpGpMwPGKciBsV X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: CDF681C0003 X-Stat-Signature: pinpsf4tick5p3hysrep6te13xnq4mf4 X-HE-Tag: 1713858964-284290 X-HE-Meta: U2FsdGVkX1/rRvwp690L9bzBIxN4l0F9px/jDC+8ycDhwBaqCCa3FzWn5o6Wi4myMrTktninE2bih9sFnHsKfGpW1YL24lp7qIw7DMFevnyCtMpdxUvYj396TN0cblxfcORtTaa0m2j4nilPgmKXUF9RKBoQTBUaiOL07c4XNanzCCpW2QtZuZQES6tAmq6Cg8AnxVvk3V/WydvYN8ccEogkqRCvrrEj4wEk8rYOtZw08J9D3js92adnjNerSpA5DDv0MHxnpwHjoUOBSIUcw7SOREwSHpMUcRZ+05j63PnFea6oHnkk2PDX0uLxH0+zpUtCjoLydZi0d5E7r4mhuBWR09EBrcmjm+0OkBeCz8zyTWn8fj1jjhghFkJrDcX4q2aot22ZvCR5rWN2qZyNIrxWARd6YWjCrEmLV2zzJ4MCJpQxKnxOdcv4d3TXFX7/FWIrnI3Y4fFsEIMzXihoYfIj3LgIXUFb29iULRxp46U1x5BVdZrfgDQMlFr1hQoS/uZLixpMKPCOpw2PvUUM/vffWmonK4nrGArgIKrpm3c2DR8xFTe3rQUI7NDyX9mWkqTZfzKNAzyY68fR7uwNp0BcExbEBHUUMxkZ/PRjnAa1G/ty37vXejFCByTEp8Sle/v7H0SFWpptALflJ/h1u+Ehmsdw/DnmJcTllTIWW/7L399DagnQi0eEjKMD812WDRvfOsuaP7EWU6BW4aamo0Q5hoPMl0TVeNsaSfjCN0tU0IOTYxl4p/fdBOzRLCNxo3tNGWMEpMh0eU1XCbTaRYYXUpvS11yGk63zp7dteXE85Dx8+7SNyLJ+Rl++QOi4qSjACQ8NHhU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Patch 1 is a bugfix for the stack_erasing sysctl handler * Patches 2-10 change various helper functions throughout the kernel to be able to handle 'const ctl_table'. * Patch 11 changes the signatures of all proc handlers through the tree. Some other signatures are also adapted, for details see the commit message. Only patch 1 changes any code at all. The series was compile-tested on top of next-20230423 for i386, x86_64, arm, arm64, riscv, loongarch, s390 and m68k. The series was split from my larger series sysctl-const series [0]. It only focusses on the proc_handlers but is an important step to be able to move all static definitions of ctl_table into .rodata. [0] https://lore.kernel.org/lkml/20231204-const-sysctl-v2-0-7a5060b11447@weissschuh.net/ Signed-off-by: Thomas Weißschuh Reviewed-by: Luis Chamberlain --- Changes in v3: - Rebase on current -next - Cc affected mailing lists again to gather feedback - Link to v2: https://lore.kernel.org/r/20240323-sysctl-const-handler-v2-0-e80b178f1727@weissschuh.net Changes in v2: - Reduce recipient list - Fix source formatting - Rebase onto next-20240322 - Link to v1: https://lore.kernel.org/r/20240315-sysctl-const-handler-v1-0-1322ac7cb03d@weissschuh.net --- Thomas Weißschuh (11): stackleak: don't modify ctl_table argument cgroup: bpf: constify ctl_table arguments and fields hugetlb: constify ctl_table arguments of utility functions utsname: constify ctl_table arguments of utility function neighbour: constify ctl_table arguments of utility function ipv4/sysctl: constify ctl_table arguments of utility functions ipv6/addrconf: constify ctl_table arguments of utility functions ipv6/ndisc: constify ctl_table arguments of utility function ipvs: constify ctl_table arguments of utility functions sysctl: constify ctl_table arguments of utility function sysctl: treewide: constify the ctl_table argument of handlers arch/arm64/kernel/armv8_deprecated.c | 2 +- arch/arm64/kernel/fpsimd.c | 2 +- arch/s390/appldata/appldata_base.c | 10 ++-- arch/s390/kernel/debug.c | 2 +- arch/s390/kernel/topology.c | 2 +- arch/s390/mm/cmm.c | 6 +-- arch/x86/kernel/itmt.c | 2 +- drivers/cdrom/cdrom.c | 4 +- drivers/char/random.c | 6 +-- drivers/macintosh/mac_hid.c | 2 +- drivers/net/vrf.c | 2 +- drivers/parport/procfs.c | 12 ++--- drivers/perf/arm_pmuv3.c | 4 +- drivers/perf/riscv_pmu_sbi.c | 2 +- fs/coredump.c | 2 +- fs/dcache.c | 4 +- fs/drop_caches.c | 2 +- fs/exec.c | 4 +- fs/file_table.c | 4 +- fs/fs-writeback.c | 2 +- fs/inode.c | 4 +- fs/pipe.c | 2 +- fs/quota/dquot.c | 2 +- fs/xfs/xfs_sysctl.c | 6 +-- include/linux/filter.h | 2 +- include/linux/ftrace.h | 4 +- include/linux/mm.h | 8 +-- include/linux/perf_event.h | 6 +-- include/linux/security.h | 2 +- include/linux/sysctl.h | 36 ++++++------- include/linux/vmstat.h | 6 +-- include/linux/writeback.h | 2 +- include/net/ndisc.h | 2 +- include/net/neighbour.h | 6 +-- include/net/netfilter/nf_hooks_lwtunnel.h | 2 +- ipc/ipc_sysctl.c | 8 +-- kernel/bpf/syscall.c | 4 +- kernel/delayacct.c | 4 +- kernel/events/callchain.c | 2 +- kernel/events/core.c | 4 +- kernel/fork.c | 2 +- kernel/hung_task.c | 6 +-- kernel/kexec_core.c | 2 +- kernel/kprobes.c | 2 +- kernel/latencytop.c | 4 +- kernel/pid_namespace.c | 2 +- kernel/pid_sysctl.h | 2 +- kernel/printk/internal.h | 2 +- kernel/printk/printk.c | 2 +- kernel/printk/sysctl.c | 5 +- kernel/sched/core.c | 8 +-- kernel/sched/rt.c | 16 +++--- kernel/sched/topology.c | 2 +- kernel/seccomp.c | 10 ++-- kernel/stackleak.c | 9 ++-- kernel/sysctl.c | 89 ++++++++++++++++--------------- kernel/time/timer.c | 2 +- kernel/trace/ftrace.c | 2 +- kernel/trace/trace.c | 2 +- kernel/trace/trace_events_user.c | 2 +- kernel/trace/trace_stack.c | 2 +- kernel/umh.c | 2 +- kernel/utsname_sysctl.c | 4 +- kernel/watchdog.c | 12 ++--- mm/compaction.c | 6 +-- mm/hugetlb.c | 12 ++--- mm/page-writeback.c | 18 +++---- mm/page_alloc.c | 14 ++--- mm/util.c | 12 ++--- mm/vmstat.c | 4 +- net/bridge/br_netfilter_hooks.c | 2 +- net/core/neighbour.c | 20 +++---- net/core/sysctl_net_core.c | 20 +++---- net/ipv4/devinet.c | 6 +-- net/ipv4/route.c | 2 +- net/ipv4/sysctl_net_ipv4.c | 38 ++++++------- net/ipv6/addrconf.c | 27 +++++----- net/ipv6/ndisc.c | 4 +- net/ipv6/route.c | 2 +- net/ipv6/sysctl_net_ipv6.c | 4 +- net/mpls/af_mpls.c | 4 +- net/netfilter/ipvs/ip_vs_ctl.c | 19 +++---- net/netfilter/nf_conntrack_standalone.c | 2 +- net/netfilter/nf_hooks_lwtunnel.c | 2 +- net/netfilter/nf_log.c | 2 +- net/phonet/sysctl.c | 2 +- net/rds/tcp.c | 4 +- net/sctp/sysctl.c | 32 +++++------ net/sunrpc/sysctl.c | 6 +-- net/sunrpc/xprtrdma/svc_rdma.c | 2 +- security/apparmor/lsm.c | 2 +- security/min_addr.c | 2 +- security/yama/yama_lsm.c | 2 +- 93 files changed, 329 insertions(+), 322 deletions(-) --- base-commit: a59668a9397e7245b26e9be85d23f242ff757ae8 change-id: 20231226-sysctl-const-handler-883b5eba7e80 Best regards,