Message ID | 20240508-b4-ksm-unstable-insert-v1-0-631cdbc2b77f@linux.dev (mailing list archive) |
---|---|
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31228C04FFE for <linux-mm@archiver.kernel.org>; Wed, 8 May 2024 11:37:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB33A6B014B; Wed, 8 May 2024 07:37:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3C226B0156; Wed, 8 May 2024 07:37:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DD806B0157; Wed, 8 May 2024 07:37:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7E9ED6B014B for <linux-mm@kvack.org>; Wed, 8 May 2024 07:37:54 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2AE5541432 for <linux-mm@kvack.org>; Wed, 8 May 2024 11:37:54 +0000 (UTC) X-FDA: 82095029268.04.BC438D0 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by imf18.hostedemail.com (Postfix) with ESMTP id 2C2011C0008 for <linux-mm@kvack.org>; Wed, 8 May 2024 11:37:51 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ex3Q7xo6; spf=pass (imf18.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715168272; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=nriJEVBMEpCdnex06+BPZnBx6tE8hsLyPOQq2hal354=; b=iyWabgJAaBBjFV2nmm1pq8hwlIghI9bugKKlI4m96jxkuEiKAV0br4+xv3GkPeYrQNLCwN nZnZNBYiCcy7RnBxnF2UC6m8fuSLYLsrMUNDwTNqPDymmDU53AJLkJkegSi+rtt1qv15El f0SCO5uzfKcQyFYa68gXJCUlHD9Zy6Y= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ex3Q7xo6; spf=pass (imf18.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715168272; a=rsa-sha256; cv=none; b=LcqPWa5IJo6Pf4xEdOW6+ExMxULHWyMGmYFNOeVaoDcTjSmhb5lXAAjBUUiXQ5PWgP2I4Y xp1+hB5oeU1MLJLwjtQqaD1x0MWz7oYIT7lpQWYs2lxOZ79JCk8Y0XyH1LKrRyY1NpKzvF mXZNDQAJ2cfoF/dRO932WuCAZmyXV4Y= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1715168270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nriJEVBMEpCdnex06+BPZnBx6tE8hsLyPOQq2hal354=; b=ex3Q7xo6XxXF9sAXpowIwtq58PLnspUgVPY7Jq67105CmPW5K8ZUerwT2EcgIiEadTMPlc huyN3mAiw9RQq9uTbS2fzOh5XtoPRXdokFTA4viKM3qK0/m+h0XN80hoQWzn/K5wo8Mi0P 1EhyYdbqJ3g37Qh2MBFEMmtqh5W6wFQ= From: Chengming Zhou <chengming.zhou@linux.dev> Subject: [PATCH 0/2] mm/ksm: optimize unstable_tree_search_insert() Date: Wed, 08 May 2024 19:35:40 +0800 Message-Id: <20240508-b4-ksm-unstable-insert-v1-0-631cdbc2b77f@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAIxjO2YC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIxMDUwML3SQT3eziXN3SvOKSxKQcoHQe0IQSXQNjI0sTEzNjQ/NUQyWg5oK i1LTMCrDB0bG1tQCaTOApaAAAAA== To: Andrew Morton <akpm@linux-foundation.org>, David Hildenbrand <david@redhat.com>, Andrea Arcangeli <aarcange@redhat.com>, Stefan Roesch <shr@devkernel.io>, Hugh Dickins <hughd@google.com> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com, Chengming Zhou <chengming.zhou@linux.dev> X-Developer-Signature: v=1; a=ed25519-sha256; t=1715168266; l=1099; i=chengming.zhou@linux.dev; s=20240508; h=from:subject:message-id; bh=sxN0YLCXI7Y0n4Vqh32lIleqSk9k9glYHc0FeQ3opkw=; b=auCEXbRktUQ9FKc3gKpYnYUR7iK9/N90VPMUkT6rOdxgYnMpoJViDw/Krb3BzqjXzp9UHYrax bnrgoo4ea6RCOB7VY06Xr/EL6EdKRT1LTL9bxwJvwOKZkl7vTIb/cut X-Developer-Key: i=chengming.zhou@linux.dev; a=ed25519; pk=kx40VUetZeR6MuiqrM7kPCcGakk1md0Az5qHwb6gBdU= X-Migadu-Flow: FLOW_OUT X-Stat-Signature: hak73h6hnyoofk8o3hbmf885ce7b6w1m X-Rspamd-Queue-Id: 2C2011C0008 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1715168271-822765 X-HE-Meta: U2FsdGVkX1+tB3xf2mYaivyHsttlY0VFcBxjspHsr7iIHsjwWKxVt7ciCLT/V4mrHj5rU+rLMk3Cey4fwhavFIBlCYH5wOfTjuP9F2rPoOp4WIVfKBffuL7YUfbLenIf1s+aHkAKHXqmHUvut3TiOeQsfm9DZw5ZNW3RAvo/++3/94Ma2J2q9OXvSQyXAKmw96oTc+jiqPDUDQdXq/1qYPk/qkGkr3xMVcVcTZSdE0/4WfgwqfN1vbTJlsyQCkg2UZYYq7NhljqFlFTmBv0hJJlfjHf24QkRq+d2CbA7z/GSmI6LyZplMwlCDyl+DVjxI5/2x5QEdCHAd/yzgsIrFSTFl2ztKl7aqvRQ1ea3Jp23QM3gkibutfPgSiC2rwKWUPuR/Jdp3C5Vki63TSynTIahF359YwLXfzXDHXLqbsObxU4DNVJ2vd0nsjXUqFqRiiDy0Stfastw17MAPgfEedDOnUEwpDRUUMO9zgt2GKBuloMUONb2x2QXqSOzClbVQ1BA0k8p49m8n1DknBHkm61KVq099OzPQM+iFcuU8j5Zr92bZsZw8/vyhzgySPrqbysnpUNZHCV0rTZu1zQQdFqq5nAY2Z+QlVZXwfO2rw+CH3DdBF1pWt7446Y2tukciML7CT3KEJTnZVnOs3PiOAajr9DoODkeQ6FozK3hAORL1yJaw/QzcbOpNaYKr0n1Mqcd/YqsAK1HI9CaVn5YX6ArvleuIqHvjUhO5fwzaycLYrrsnsk9YM6JDpRIp45K2O+WRKcXGW5214XY4ccI4kY21lPmMduDEc3tlyoz4x20IPx2nwfoP+CJNSmPusbOEp5dSx2w4vsck6mG3Al9TncKjkwy6LTxTH+k786A55lHjO+gxGI6Z9C/j4/CggaQnqtdsMf+M/oxvi3Sx68PKFV97eHGm1BLVw+FXjtXyHiWdJyVYa1yufU0bMFuVpS835QKct4XejEdDfyT/mN WwUcFVHc F/AI6T6ZU0ksU1ccA/VnJS2al1ZHFZ1jHqNOxVTLs8n66gP2lsxpkGkda9qCPYNXubCEV5Z+O1UFPvRrMLDXporYaReZ5PH2rPjvahxmpwYyGFPoex1sqRaDnZzbax1Sm7O4q5Qyo1rP3CUg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
mm/ksm: optimize unstable_tree_search_insert()
|
expand
|
We use unstable_tree_search_insert() to find matched page or insert our rmap_item into the unstable tree if no matched found. Now it may return NULL too early in which cases we can do better: 1. get_mergeable_page() return NULL: which means tree_rmap_item is stale. 2. tree_page is migrated to another node and !ksm_merge_across_nodes. In both cases, we can just remove the staled or migrated one out of the unstable tree, so our rmap_item can be inserted successfully. The code flow becomes clearer and may increase the merge possibility too. Thanks for review and comments! Signed-off-by: Chengming Zhou <chengming.zhou@linux.dev> --- Chengming Zhou (2): mm/ksm: re-search unstable tree when tree_rmap_item is stale mm/ksm: flush out migrated rmap_item to insert our rmap_item mm/ksm.c | 31 +++++++++++++++++++------------ 1 file changed, 19 insertions(+), 12 deletions(-) --- base-commit: fb0f40125feec3de7ef4524600ac83946207117e change-id: 20240508-b4-ksm-unstable-insert-0329446317e1 Best regards,