From patchwork Wed May 22 07:46:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sukrit.Bhatnagar@sony.com" X-Patchwork-Id: 13670525 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35529C25B78 for ; Wed, 22 May 2024 07:42:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCEB26B009B; Wed, 22 May 2024 03:42:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7E666B009C; Wed, 22 May 2024 03:42:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6D746B009D; Wed, 22 May 2024 03:42:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 873396B009B for ; Wed, 22 May 2024 03:42:54 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 48F93141137 for ; Wed, 22 May 2024 07:42:54 +0000 (UTC) X-FDA: 82145240268.13.2458D1C Received: from jpms-ob02.noc.sony.co.jp (jpms-ob02.noc.sony.co.jp [211.125.140.165]) by imf20.hostedemail.com (Postfix) with ESMTP id 3E8361C000B for ; Wed, 22 May 2024 07:42:51 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=sony.com header.s=s1jp header.b=P1gf8xIP; spf=pass (imf20.hostedemail.com: domain of Sukrit.Bhatnagar@sony.com designates 211.125.140.165 as permitted sender) smtp.mailfrom=Sukrit.Bhatnagar@sony.com; dmarc=pass (policy=none) header.from=sony.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716363772; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=AIWEN8D6NjuFU1bmJszkWUHQ/Up5x+riI0D821zKlIY=; b=vCtCK0eiDBEszjDcjybFu5W5MzuNwoKZfHgd9dnInm5KG1WU+y8neIbXPiniiAP7z78btR uSyhg7J0f43gm0OLXgMkmIxWNtXA9pP+qhHECpGLYzl5ZfDm0U25clEtx+yHhwB3jp959R IPjTvqV3ykP/eS9IpED5afnKtGytJyY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=sony.com header.s=s1jp header.b=P1gf8xIP; spf=pass (imf20.hostedemail.com: domain of Sukrit.Bhatnagar@sony.com designates 211.125.140.165 as permitted sender) smtp.mailfrom=Sukrit.Bhatnagar@sony.com; dmarc=pass (policy=none) header.from=sony.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716363772; a=rsa-sha256; cv=none; b=EvsneVsU2X60JQX+pb4gAPrkFr9yCs5hnKopSWa/dHZMJuH3lY11a3Po1AlUWeDXmxY76R 6+dcwIs99sIDIUJ4tZSsNwAX4szEkaByrNWmfCenJF8KDlOBc3s6EiglKZB/kFCXPnqjXE ULai7kwZKOMuNi29hI1Qil3DdIVAmyc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sony.com; s=s1jp; t=1716363773; x=1747899773; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=AIWEN8D6NjuFU1bmJszkWUHQ/Up5x+riI0D821zKlIY=; b=P1gf8xIP9GHy/ogH1qSkKB1Fcm4TgLPgoo/CowSHspWU0mywmj++Wlx6 en09xq9hslxfKq6k8e8HH8zaJsNREaTSTa0eyg54/N4k5xi9OEeEcyV69 oPEDPB7M7LAGe8fA1i5QY39ypAf9UvsfaKtQXf9T4DqIYv+ZMmn31fkHW PBwqfRdy2yAKZii6rZ1PkWcK43CmDMidFC79RddaxYXcHJuRqSUGSYrgd vgXO+akTQ79l6tgwBXMfova26pIhnTALVyRbUA55sM0Ma2ZASFfSLabC5 tKQOJF51s+iw33URbKroY2cDuMDTsmgavMPAmNpS5/E9Kfa0mjuQJt6Pz A==; Received: from unknown (HELO jpmta-ob1.noc.sony.co.jp) ([IPv6:2001:cf8:0:6e7::6]) by jpms-ob02.noc.sony.co.jp with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2024 16:42:51 +0900 X-IronPort-AV: E=Sophos;i="6.08,179,1712588400"; d="scan'208";a="415026695" Received: from unknown (HELO OptiPlex-7080..) ([IPv6:2001:cf8:1:5f1:0:dddd:6fe5:f4d0]) by jpmta-ob1.noc.sony.co.jp with ESMTP; 22 May 2024 16:42:51 +0900 From: Sukrit Bhatnagar To: "Rafael J. Wysocki" , Pavel Machek , Christian Brauner , "Darrick J. Wong" , Andrew Morton Cc: linux-xfs@vger.kernel.org, linux-pm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sukrit.Bhatnagar@sony.com Subject: [PATCH 0/2] Improve dmesg output for swapfile+hibernation Date: Wed, 22 May 2024 16:46:56 +0900 Message-Id: <20240522074658.2420468-1-Sukrit.Bhatnagar@sony.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Stat-Signature: fx4rm8upwof9b1w579hxu45coc5hfwcq X-Rspamd-Queue-Id: 3E8361C000B X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1716363771-46901 X-HE-Meta: U2FsdGVkX18Zz66+u7XDB1FJChH0pkEeq5BUf6so93LzO2HTf29VKQZZdDioPtsII3HwsqgQNGme0bzSddWMNNLwlWC6NODQpTaJfjiMUYKbvpD5uqhJsrjW5GIchnaLYo11D0kFlXm26duccnOP+tZrRsgQ8m5/b8QFyGMOZA6SEZcrhNZPilVaisQ/oir/+CsYJ5g5onCX8rd4Rf5o9Z1LrEJjnJjdxI9Rxc/hoK4xjdlvkOpGWmNvqajh9a4bNGSAGIR8PcaneFlk7ijrc6R4kpSo5QKGCkPjmNJp/kBiO/beLYzLKXr/edTEKfwb+1VzXRbcRGscRjn3wlmqEKxDaYKfF5vjrJw9K+k3KbPRW7p3AAKqpOTVFjNo/tXIeevLgPA0I9yGzgOd0w6C3aM/o4mn6QrHtZnn1adDCAxCT4ruFy0HspNWgSI6dTnlF1+edhtI48ZeMMkNr818t/bOcle3BH598QbO5vqdaqgloJLk0Pbl2Q+vUc8asXi4lWOqJUNk6fgnu4EP9j/ShketUSya0Dgi43amhyYLw/sTs0nyEyOcF2l4/nxsO6ViYbMJE3PyU0xU23xDIS4q4DKdECzpGg/dicBV3yld4xMd3F+2bt2Ukf6FCc3UroG9B64qICB30tr0D9OeCbdr5aRUyg7wD0cSTURMKW+7M6L4yJSrgmwqoiYcIxVRi0nIRKehmwsgj5JRwQKcvWXH7Hk+wqcUEb815652ZKCtws1uLQXlsET7cohIHuWXv0iDjRHI90uhbEc6Y6Aed+84rlUlEeVEfDxa2yn8yks26zUel2E2hELVXM7mywAielc9JpxWN9ROzlKj4UweTklZEz4Wljb4glHzeynAT5exdQgITHe41ZiAQkEexU7Tlg2/8bEdwaOFOFr0IRkwAHkCUXki0AOK2zhWNd0hs0Oxo1uw0rwLcFdEdfQAAr1S2esupWbnJya2j02/XMZ845S NaSTjcuk AeP0GMXy/vPbSyaw7R7chiPI2b24xecL7G/z5GjDBt62rZGMz1ow4A+er/Ky7FcZggKGNb6hGcU7Bg70fGlZ+c3DeZwvM1XR6n5dCdF+s00/eXrXgXPl+CpTqGAj6IGkdR4kPWsp9bMvvkrfsHrVoJix+Aw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: While trying to use a swapfile for hibernation, I noticed that the suspend process was failing when it tried to search for the swap to use for snapshot. I had created the swapfile on ext4 and got the starting physical block offset using the filefrag command. Upon looking at the swap activation code, I realized that the iomap part is doing some rounding up for the physical offset of the swapfile. Then I checked the block size of the filesystem, which was actually set to 1KB by default in my environment. (This was in buildroot, using the genimage utility to create the VM disk partitions, filesystems etc.) The block offset is rounded-up and stored in the swap extents metadata by iomap code, but as the exact value is lost for 1KB-block filesystem, hibernate cannot read back the swap header after it finishes writing data pages to swap. Note that this is not a bug in my understanding. Both swapfile and hibernate subsystems have the correct handling of this edge case, individually. Another observation was that we need to rely on external commands, such as filefrag for getting the swapfile offset value. This value can be conveniently printed in dmesg output when doing swapon. Sukrit Bhatnagar (2): iomap: swap: print warning for unaligned swapfile mm: swap: print starting physical block offset in swapon fs/iomap/swapfile.c | 10 ++++++++++ mm/swapfile.c | 3 ++- 2 files changed, 12 insertions(+), 1 deletion(-)