From patchwork Fri Jun 7 14:58:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Pankaj Raghav (Samsung)" X-Patchwork-Id: 13690326 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0DBEC27C53 for ; Fri, 7 Jun 2024 14:59:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 232CF6B0096; Fri, 7 Jun 2024 10:59:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E1E66B0098; Fri, 7 Jun 2024 10:59:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 082F26B009A; Fri, 7 Jun 2024 10:59:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DED106B0096 for ; Fri, 7 Jun 2024 10:59:20 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5938BC02AA for ; Fri, 7 Jun 2024 14:59:20 +0000 (UTC) X-FDA: 82204400880.08.FD4E784 Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by imf28.hostedemail.com (Postfix) with ESMTP id 169E5C000B for ; Fri, 7 Jun 2024 14:59:17 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=NLH1n10p; spf=pass (imf28.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717772358; a=rsa-sha256; cv=none; b=c69apucSN/rs83ri/tYI/duPynmcz3B8dyrv4XXR3x0AubtQdsuul6OwFN/3UyZE7b6zAk R4ltiC5CMROX0Y4LALgNBRMbnt9twQ2T/e8PqcOwB2O6LmNHGKSnX+v9wy/CzAev/Z0tCl ilokEDx666oDzxF/GwjAmVtjy30ZOns= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=NLH1n10p; spf=pass (imf28.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717772358; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=L5/K/voROGxiCi8/nrKyR1+yqBSs4rSx+7KJpqqgfCw=; b=USiPDorXNoiQQQdGwVOPxDEwjK+AQkb1ZVCIX/1PDEOa5cRIRTjLlWZqmg5B9X2EdwtM73 XHgT3PCjbp1gw7ioLG5PkHNT+SnmFeFi6afVnG4Cd2IBovT97US9X9cy2xhLhtU4Gc17dZ Ol4RFcgFg6zpk1J6zW50ktfMu2fP0CM= Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4Vwkqh4dS1z9sSR; Fri, 7 Jun 2024 16:59:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1717772352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=L5/K/voROGxiCi8/nrKyR1+yqBSs4rSx+7KJpqqgfCw=; b=NLH1n10pMvMbTG2IkpAspVJoe3J9POQgeAzS4s4nfxIUCuyJ5o4BEwTlLep/h/I3ARa2ox GMbzxhV684OGNRSRTG6Hb4G7lZ7IUZIzmRlQToB/BVeTHqjQwX3sKFDBhqBvAY0NffdnWH ejgS8ytScZGwMMyj3KmaK36P77dlBj3LzkrOeX1cvH1rKOE45q+VBSCl3blefjcXO2P3aw iVvoWJ7LhfqQ3PsLSN9nGbUYmb0kgGCv3QAWCgV0SlmH2WqKi3tRxxDJfGr9O5ivJ4zN4+ snrxILtMTSaqo8h2XwLhr8yX9SJ/K5i28W2B+TVuBffuO9IcurgEUCXNhmkqmQ== From: "Pankaj Raghav (Samsung)" To: david@fromorbit.com, djwong@kernel.org, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, willy@infradead.org Cc: mcgrof@kernel.org, linux-mm@kvack.org, hare@suse.de, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, Zi Yan , linux-xfs@vger.kernel.org, p.raghav@samsung.com, linux-fsdevel@vger.kernel.org, kernel@pankajraghav.com, hch@lst.de, gost.dev@samsung.com, cl@os.amperecomputing.com, john.g.garry@oracle.com Subject: [PATCH v7 00/11] enable bs > ps in XFS Date: Fri, 7 Jun 2024 14:58:51 +0000 Message-ID: <20240607145902.1137853-1-kernel@pankajraghav.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 169E5C000B X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: ki59moodeto7ohiwzxijanu4f4bompqy X-HE-Tag: 1717772357-590609 X-HE-Meta: U2FsdGVkX195sQWsSAL5R9MrI0mSEE1dZa55FEYKQiV1d1Z/0vK+wrC+TNp9g8Klu+/1p3xpw2wi2O3gDyV0V0GdIyb2vzISCoMZFxmjL+/D7TSrx5eYQEbCnCCgg45HQ1mjQ/4t9v9i7vOe49oQHZwUqv5dYu64kLZyQ9VHOLsFG9l8E9RhNQAy8lIEmMvFgmQl+f5D9eFdMtiQ86LYITyha46LpjfJpPANF7nufjq0HohHtUhQpqH1glLXGQ0whSXE4VmsqXbAdb/HdUI2+uYVQze3LfibCkFK92D0ktwtn7EHuOomLIjzH8i2+RjLdSuEaIY/X7YzUFQ/rJsgtNbWkSh+b6DR48mhYHzo+Y+dZcuj5ObXlQraZyG7Gik1C4b+1uNiXfLETPSz+qaCT1FgMFsVV6jGS7uidWO6DfvZGRQhxoR5Kg16+fnIFSbmNtBYsxRbXXMRpQkiWC0sZsX09aTe1vI5aRNtGt9/ndfLPPneyLj+6OTH/OHbmc5fYXvYus14w8JVOifRvhYssHSEJLu+CR0JkMu/9pMDfa8FGr1OWmliWOI8s08RSm1T9esbhF3DhiClcnfFpZO+/m0U3qw2Nl/2yBg50V2kTPUhON0S2oR444INsjTkGrPJKaaiW1E476vJkXacax520HbMeCL+KeKPscWKG18svKQzFNXeXpNrXfh+V/1BfzAmbYJNY/YMCFKsGBw/lsl7uZHQxpPwY1jCl5zaXQ1arovO+xA76YGs0Ga5Go6xPGq1YSoajd0hib7bGfjCiRmwQEW/naaCNJCRSJStg5gnEYzn+JBjvJVRufilZInAACXbQr5KgIFnIzCvk7gL7eUqjwgBCEFyiiMGEG7YD/DJ50Use+3Py2bj8Vz6IvtASgClOuCb2OvvBHHF1O//iS6Elvqt4I2nxQS7qoNHaFoKgvtOCscDEXpFedcOfTuUjyQvGoT8swbllwvJKUVEDuv o5atxPal vW2px+zqxncMoxl3KamWKoJXIKlZzV6HMMlJqLHHuqaMBHm+MBDn2L1BrHP7nfOrobnv1T3VBuc/BJsIyU5v35iAQgSVNgF1QpwHBMN+tFDsOWgZKcWadYTSa2q4AOLwzI919AHv7p2kjoqOcRgbgAcjKqWUmF1vsBW3oC6bkEir0Wa9AyHq5n2mi/OtCy4qkD3ERe0hE8+P7rLVNngtSV2/5q6uy9FEwui4EHv2BSJY3V9pjVLrjmVhgOTge8B3EUB3XU309hyRu5bwszISj2p6JmgA0LBcSmoQZkqoy/j+iRIIk3QjRGkpTIbNeuBdfgUl+ta4tzrfqnDjU3IOEjxObp2dJ8cXGC/gPrWIn4JOz/5lCBL52jXPhkCR+ITLh7fJGkmPaD63FxhAYoi3wCEr3cW4AZyBZ7pJzk08t4ITF5i0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Pankaj Raghav This is the seventh version of the series that enables block size > page size (Large Block Size) in XFS targetted for inclusion in 6.11. The context and motivation can be seen in cover letter of the RFC v1 [0]. We also recorded a talk about this effort at LPC [1], if someone would like more context on this effort. The major change on this v6 we retry getting a folio and we enable warning if we failed to get a folio in __filemap_get_folio if the order <= min_order (Patch 3)[7]. A lot of emphasis has been put on testing using kdevops, starting with an XFS baseline [3]. The testing has been split into regression and progression. Regression testing: In regression testing, we ran the whole test suite to check for regressions on existing profiles due to the page cache changes. I also ran split_huge_page_test selftest on XFS filesystem to check for huge page splits in min order chunks is done correctly. No regressions were found with these patches added on top. Progression testing: For progression testing, we tested for 8k, 16k, 32k and 64k block sizes. To compare it with existing support, an ARM VM with 64k base page system (without our patches) was used as a reference to check for actual failures due to LBS support in a 4k base page size system. There are some tests that assumes block size < page size that needs to be fixed. We have a tree with fixes for xfstests [4], most of the changes have been posted already, and only a few minor changes need to be posted. Already part of these changes has been upstreamed to fstests, and new tests have also been written and are out for review, namely for mmap zeroing-around corner cases, compaction and fsstress races on mm, and stress testing folio truncation on file mapped folios. No new failures were found with the LBS support. We've done some preliminary performance tests with fio on XFS on 4k block size against pmem and NVMe with buffered IO and Direct IO on vanilla Vs + these patches applied, and detected no regressions. We also wrote an eBPF tool called blkalgn [5] to see if IO sent to the device is aligned and at least filesystem block size in length. For those who want this in a git tree we have this up on a kdevops large-block-minorder-for-next-v7 tag [6]. [0] https://lore.kernel.org/lkml/20230915183848.1018717-1-kernel@pankajraghav.com/ [1] https://www.youtube.com/watch?v=ar72r5Xf7x4 [2] https://lkml.kernel.org/r/20240501153120.4094530-1-willy@infradead.org [3] https://github.com/linux-kdevops/kdevops/blob/master/docs/xfs-bugs.md 489 non-critical issues and 55 critical issues. We've determined and reported that the 55 critical issues have all fall into 5 common XFS asserts or hung tasks and 2 memory management asserts. [4] https://github.com/linux-kdevops/fstests/tree/lbs-fixes [5] https://github.com/iovisor/bcc/pull/4813 [6] https://github.com/linux-kdevops/linux/ [7] https://lore.kernel.org/linux-kernel/Zl20pc-YlIWCSy6Z@casper.infradead.org/#t Changes since v6: - Warn users if we can't get a min order folio in __filemap_get_folio(). - Added iomap_dio_init() function and moved zero buffer init into that. - Modified split_huge_pages_pid() to also consider non-anonymous memory and removed condition for anonymous memory in split_huge_pages_file(). - Collected RVB from Hannes. Dave Chinner (1): xfs: use kvmalloc for xattr buffers Hannes Reinecke (1): readahead: rework loop in page_cache_ra_unbounded() Luis Chamberlain (1): mm: split a folio in minimum folio order chunks Matthew Wilcox (Oracle) (1): fs: Allow fine-grained control of folio sizes Pankaj Raghav (7): filemap: allocate mapping_min_order folios in the page cache readahead: allocate folios with mapping_min_order in readahead filemap: cap PTE range to be created to allowed zero fill in folio_map_range() iomap: fix iomap_dio_zero() for fs bs > system page size xfs: expose block size in stat xfs: make the calculation generic in xfs_sb_validate_fsb_count() xfs: enable block size larger than page size support fs/internal.h | 5 ++ fs/iomap/buffered-io.c | 6 ++ fs/iomap/direct-io.c | 26 ++++++++- fs/xfs/libxfs/xfs_attr_leaf.c | 15 ++--- fs/xfs/libxfs/xfs_ialloc.c | 5 ++ fs/xfs/libxfs/xfs_shared.h | 3 + fs/xfs/xfs_icache.c | 6 +- fs/xfs/xfs_iops.c | 2 +- fs/xfs/xfs_mount.c | 11 +++- fs/xfs/xfs_super.c | 18 +++--- include/linux/huge_mm.h | 14 +++-- include/linux/pagemap.h | 106 +++++++++++++++++++++++++++++----- mm/filemap.c | 38 +++++++----- mm/huge_memory.c | 55 ++++++++++++++++-- mm/readahead.c | 98 ++++++++++++++++++++++++------- 15 files changed, 330 insertions(+), 78 deletions(-) base-commit: d97496ca23a2d4ee80b7302849404859d9058bcd