From patchwork Mon Jun 17 23:11:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Barry Song <21cnbao@gmail.com> X-Patchwork-Id: 13701541 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 699D9C27C79 for ; Mon, 17 Jun 2024 23:11:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C54868D0006; Mon, 17 Jun 2024 19:11:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDD1E8D0001; Mon, 17 Jun 2024 19:11:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A30358D0006; Mon, 17 Jun 2024 19:11:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 81B098D0001 for ; Mon, 17 Jun 2024 19:11:58 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 23BB940199 for ; Mon, 17 Jun 2024 23:11:58 +0000 (UTC) X-FDA: 82241930316.30.77C230E Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf07.hostedemail.com (Postfix) with ESMTP id 5717340007 for ; Mon, 17 Jun 2024 23:11:56 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="RAIJ7RA/"; spf=pass (imf07.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718665908; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=LvCyWt69PGUZt4BpaxsAne+Mf2MHqVNEFtr7gIEXROw=; b=y6b1rzL1G68aghzrr+aDWrwJf3yifsDHrg8vUNAirIIWVGirNHJi2Nh2AjiaA0mANutnXR QpcMIptGEyK6iV7jxAw1zq3shuymek0du5SP++NjmGMkgtiLTXal/LHJceJSE3QK+R4URw bLpx5tWTtAt4IwwCr2aIswNGmmgKHDk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="RAIJ7RA/"; spf=pass (imf07.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718665908; a=rsa-sha256; cv=none; b=ODBklYE06oFRTEJAiNc2LLBrbW6J7Jk/NyN0kmYT0J4MV37mmZfvwMr7RnX1jHMzvCWqbh aPOvS+ibvaietAVIeXX+g272+CbhWcFMl8GHaZTAMlGEio+LhNxl5T24knrkdbU4QpK354 A2VbXi3Zk4DC9EsL5KVfF+xe63ejPcU= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1f6559668e1so39676015ad.3 for ; Mon, 17 Jun 2024 16:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718665915; x=1719270715; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LvCyWt69PGUZt4BpaxsAne+Mf2MHqVNEFtr7gIEXROw=; b=RAIJ7RA/bFxHXLRF0GAUB+qEIxC/v675TRzYB+l4+GxGBQIwhTyyiP75yB/mL4Omqm OYfboStwUlBWNrMW6xjlHwfoug0HWLTZlhRqlEGv0nPxgA8+I6dQPm/kE9WDze7+AudY AbGvlhgTPMTSX2PXOYoao3GTgDMYdox30gT/eM5Ke3SPVDjiTJIQ3kqAIgQpyN9zi840 Mu/YjUNOWRtSVXt37ratPTQWuXyOJStsXxDpdDhC8jpl091HLNn9d+C+h5adjnnF7aK9 xfGvbMqyhrulHXcsBaq5E2eUyLR9L9OTxKTmjJbgW1JarUyigK5aQNiGJxxx+GYoqjGl 8Ocg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718665915; x=1719270715; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LvCyWt69PGUZt4BpaxsAne+Mf2MHqVNEFtr7gIEXROw=; b=M3Uo8kAdwk6doOI4ABdDAqgNECx7t3OFeN0qLfAysWIGvA8mfW/J3Ok+XlD4wZ7BKo TeHhZmI2eZ6gulZ5SyZ0lTYRpedLJdxntCGlWiLtJDRvrhmwc++wMaz10a/WtfWwEpDW w/zi9XXiIJvYu+CAadg8br+qIAOflv+Nz1yNzgS4o56z6HNdOJRVPN0jpsQ7RscfYKWF S1fWzgPXAe6P5CL28mbT6f6hjKzNbgHm8fjyTdA6T/zpXMN61yZ710tPImqc/9nT0KqH X7iFOkJgJFyHDrOaNFOZNIj96cGb2SAUvFal0uYLyx4u0kb08hNOwNreQD6UuWZDijRo 8qIg== X-Forwarded-Encrypted: i=1; AJvYcCV01NYzPAzy2g3EnR+tf5ItWRFErxAHVxEo3/odgU4CURWp1P4rVgjiBS8jPnLBMJncZgVbfTPmnxE7Y6cP5GjAiQQ= X-Gm-Message-State: AOJu0YxUSRcMm/AsUBZZLNbljCNoD/7/TSOZwjNT40BMMWpcU4aCyg2L AS1htyBrGdiOFk+VpuFw9R/abRsIUHR4DlJS8TlzVXxpxeme/KqM X-Google-Smtp-Source: AGHT+IH5DJEcFgg+9xWxSi15GsjyaYgih3hjGgUnN5rZbQBNeoC2YkMtuFoNrtwZuU2horotlw9GLQ== X-Received: by 2002:a17:902:cec4:b0:1f9:8f8d:cc5f with SMTP id d9443c01a7336-1f98f8dcf99mr6363815ad.26.1718665915014; Mon, 17 Jun 2024 16:11:55 -0700 (PDT) Received: from localhost.localdomain ([2407:7000:8942:5500:aaa1:59ff:fe57:eb97]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855e5a0d5sm84658605ad.43.2024.06.17.16.11.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 16:11:54 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org Cc: baolin.wang@linux.alibaba.com, chrisl@kernel.org, linux-kernel@vger.kernel.org, mhocko@suse.com, ryan.roberts@arm.com, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, ying.huang@intel.com, yosryahmed@google.com, yuzhao@google.com Subject: [PATCH v2 0/3] mm: clarify folio_add_new_anon_rmap() and __folio_add_anon_rmap() Date: Tue, 18 Jun 2024 11:11:34 +1200 Message-Id: <20240617231137.80726-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5717340007 X-Stat-Signature: 1qyh7eum7rgdtij8s7hyjftxhwf5wi3b X-Rspam-User: X-HE-Tag: 1718665916-263063 X-HE-Meta: U2FsdGVkX196LOVnOtge+LnxvzvzqZq3qKyN6wNvdLBdmWd+jkh7NQpjQK6Who9IVe4wh5kxfkyW5tkqVwxh+pDSjz33lGQCHNiSVavBgycIHs+/0pVCwFQPHfB8jkphEvnhfTVBWfSO4wMslUFC0B4tb5JGLubjnBhfOSgdayYbAj+YPN4j1XXJq52tk7QEpkwPUinZVNG+U7Wjrgn+5USFhz6f5z5FSdoUd38kzzVH8J3OfLUiu2U4hnfu11KsgvzqP1mOom2L8BGG9eLZL7/HEEMG4XnlCOz2aLOaDaoiRgUR9b8CONTlrTS0gwrTI+ZFRhdK6SuHy9gLtZ2tIEFnn04K31MF6PYlK910DfXjPBL2XZ7NozPM6lRoWfomrzgsBT3yWqst+IR2A+bzSo2mk4wK9PaT8eKMaHjIhiV5mPVGD1Uub41XpfdcxDAlWLZ+T7O+nBg9KzzfbJgMa1SVvLgizmYZtfqqZdXLr/DtYQGVuY/6wWvU20HRYZAJXOaHsptBC/vZtbol7CXCWpcjf8vFH9T68nYD70y5xUTVMoVxp0GgR95m6sZSzovw0xf1RWC9/VcFCFI4+pkgbkSd++sa/ng3lzeEPp92NTKRDhoPrh7gJD9QSu2dVIYmbZKxJp4hJuhAdNUyFJtoQOmCwFaVWqD2K8+X0/cWBZG/wYOi33StqPeaWeIgZd3Jc0J6+3KlA7WFVuKs9EnMltPvnjgt6x/+XP0DAyJEPaFOsW3wIYbS42Qw4Al265cazlkkaFWoDwNFfH1KcbSJAwrtFx3sSW7yirLQW80KcOezaCn3gPq878aRiU6oX0D/GTG95mxnQ+tfZs5MnUY0NJkwFEsGS0pJd80mNiy8N/UcHynouuZweLCGFDe8OTvh8pCrbx/6sWIjFp8Np4uUMy+pIRQyatcsuXvKuCsh1nS2pYeyhv+eaKmu5P3VHzHdBqfaqUJ2XYDy48TtDSf L0s9aGH2 cueEKYjhSIPIdmIV7qjkA9u6lZVwDIS5fJaEIyoy7bEkkm8IJlsOfReAu/EChG6KvWSdEJUr/GB3LkukpLuyIDzJdwW6yWrwICMyQoJKeGAjGnufpC3OHwkjqtuGTPy5q4bW2FVpXIoqJRtk8X+BFrIn4cKMoaZItFg0kixap+caLdGx5nYeUcpMoRxcJXCWgNN8xAgsWTZgxYodwzE95kzuabAzVxluns+nLK3AcqEZSoFgFmsIpWf/S3lN2cuq2jvgnNj+jQvfEjOlcjkUutPC9wuO11f6okzld0Vreov6jDKCEuLXM02K/6y05DFKC1fljo8fJf88L8Nsycf9LL+yg39nzi+FJTQk4Mf3pODfgWBto+MmdH36S3G5Bw79jlUGGcFHLWiFhSZYe2byboguedaQpNYUzfFgWm3ovSjnqGBvZE4x4UMaMVhoOk9h1Td3bJvV8oFWN3lIKw/bPKsv+BN4ZkRriRLb5GRwM8qCLAWkbxuW2y060b1v7MT7TchvT+Voti5/8/62JJjv4GTGX0FbjpVkkk/3ykzkfjnfTCT2pvE44bfjAug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Barry Song The whole thing was originally suggested by David while we tried to weaken the WARN_ON in __folio_add_anon_rmap() while bringing up mTHP swapin[1]. This patchset is also preparatory work for mTHP swapin. folio_add_new_anon_rmap() assumes that new anon rmaps are always exclusive. However, this assumption doesn’t hold true for cases like do_swap_page(), where a new anon might be added to the swapcache and is not necessarily exclusive. The patchset extends the rmap flags to allow folio_add_new_anon_rmap() to handle both exclusive and non-exclusive new anon folios. The do_swap_page() function is updated to use this extended API with rmap flags. Consequently, all new anon folios now consistently use folio_add_new_anon_rmap(). The special case for !folio_test_anon() in __folio_add_anon_rmap() can be safely removed. In conclusion, new anon folios always use folio_add_new_anon_rmap(), regardless of exclusivity. Old anon folios continue to use __folio_add_anon_rmap() via folio_add_anon_rmap_pmd() and folio_add_anon_rmap_ptes(). [1] https://lore.kernel.org/linux-mm/20240118111036.72641-6-21cnbao@gmail.com/ -v2: * fix crashes reported by Yuan Shuai during swapoff, thanks; David also commented unuse_pte() for swapoff; * add comments for !anon according to David, thanks; * add Yuan Shuai's tested-by tags, thanks for Yuan Shuai's testing on real phones; * refine changelog; -v1(RFC): https://lore.kernel.org/linux-mm/20240613000721.23093-1-21cnbao@gmail.com/ Barry Song (3): mm: extend rmap flags arguments for folio_add_new_anon_rmap mm: use folio_add_new_anon_rmap() if folio_test_anon(folio)==false mm: remove folio_test_anon(folio)==false path in __folio_add_anon_rmap() include/linux/rmap.h | 2 +- kernel/events/uprobes.c | 2 +- mm/huge_memory.c | 2 +- mm/khugepaged.c | 2 +- mm/memory.c | 18 +++++++++++++----- mm/migrate_device.c | 2 +- mm/rmap.c | 34 +++++++++++++--------------------- mm/swapfile.c | 15 ++++++++++++--- mm/userfaultfd.c | 2 +- 9 files changed, 44 insertions(+), 35 deletions(-)