From patchwork Mon Jun 17 23:41:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roman Kisel X-Patchwork-Id: 13701554 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 328C6C27C79 for ; Mon, 17 Jun 2024 23:41:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B58EF6B028C; Mon, 17 Jun 2024 19:41:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0A106B028E; Mon, 17 Jun 2024 19:41:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A8876B0290; Mon, 17 Jun 2024 19:41:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7B98E6B028C for ; Mon, 17 Jun 2024 19:41:45 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 36B5D1401BF for ; Mon, 17 Jun 2024 23:41:45 +0000 (UTC) X-FDA: 82242005370.10.A64AC0F Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by imf02.hostedemail.com (Postfix) with ESMTP id 8845680007 for ; Mon, 17 Jun 2024 23:41:43 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=dAZNhDmI; spf=pass (imf02.hostedemail.com: domain of romank@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=romank@linux.microsoft.com; dmarc=pass (policy=none) header.from=linux.microsoft.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718667700; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=nZB/8MvG+rNCUxJrks2r9bqbVls1mBuRzWaQspLUyk4=; b=opVbcYTgsvKyoibZmuq0IhQwviaGffw3c2npqZf7F7viIHD0U84knYd+PqpFq+sz6fgR4c O6QaEy6Q0twd/dbsLolEzQq8EFMG8rkO9je7u7khCrg+mZmv8gDqA6B7z+CsS/a020K5wf GL05MthEnoKDh9pKR8cqX1PBINivvUo= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=dAZNhDmI; spf=pass (imf02.hostedemail.com: domain of romank@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=romank@linux.microsoft.com; dmarc=pass (policy=none) header.from=linux.microsoft.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718667700; a=rsa-sha256; cv=none; b=Qg1NR9PF53erNsQ7QHFrUBqWAzMUtvPliehf1TSnlszg/QHBYp09Y56NnwmbLWl35UH2fs E4EB5vWcr3ih+nBfHqkbH7/CxGC80nUpb9c3PjKkPDRiCRKUkOZHSs0fSQL87WB6YTU/u0 hpeMl7r9FXPet8/J74IW4CzECbEoImk= Received: from xps-8930.corp.microsoft.com (unknown [131.107.160.48]) by linux.microsoft.com (Postfix) with ESMTPSA id 0D2F020B7004; Mon, 17 Jun 2024 16:41:42 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0D2F020B7004 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1718667702; bh=nZB/8MvG+rNCUxJrks2r9bqbVls1mBuRzWaQspLUyk4=; h=From:To:Cc:Subject:Date:From; b=dAZNhDmIbBYjrTXyn6sgmodSXglG3n1mk8O9BVi2TVfQNq/SJfXQ2trs+5eSHDtPl HNjenNbUDzHU7hl8FGCK449hAlyxpsI14He5qUtw1cQKIu8bX7DK4i12qblGnKozAL 9b27g2g0LuPbG3nAD8d2gpf4IPvZljnCnMglNwNc= From: Roman Kisel To: akpm@linux-foundation.org, apais@linux.microsoft.com, ardb@kernel.org, bigeasy@linutronix.de, brauner@kernel.org, ebiederm@xmission.com, jack@suse.cz, keescook@chromium.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nagvijay@microsoft.com, oleg@redhat.com, tandersen@netflix.com, vincent.whitchurch@axis.com, viro@zeniv.linux.org.uk Cc: apais@microsoft.com, ssengar@microsoft.com, sunilmut@microsoft.com, vdso@hexbites.dev Subject: [PATCH 0/1] binfmt_elf, coredump: Log the reason of the failed core dumps Date: Mon, 17 Jun 2024 16:41:29 -0700 Message-ID: <20240617234133.1167523-1-romank@linux.microsoft.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 8845680007 X-Stat-Signature: yadktj5drrrbu7ofwq818ffy5ei5srus X-HE-Tag: 1718667703-629986 X-HE-Meta: U2FsdGVkX1+tXzLrhGgZPOeRMUZ1YjKbfvuij6Cvtx4+QP6GRkizNRu6n81XV4R7bsBdEGSeGrHmUwwRis1nH01oXVXudGlEismhpUqZcbPXc9BET7p8bb8s/i/7YQmbHE0wRwYanFdT5ku/rmN0c1OXJAPQ5zJ5VcB72zHZV45thIVOOE/wUoTEWORNAZ9WlQ482p7DSLrcUdWMI0k2FIdWbcjf1263l7VqbSFKFaHuNeHHxBE4qfkVbdPSsPi1IBdgQOwOKKKwLLZphIxgDqhpF0DM7zfJNiQM3LgWTPiQ1Kpo/5fXyI6w+YhO+x15xzpxgosGotEedj7OuTHavuQZYm3GtcSGpkyCK6AV+QOvyKbUt3pCEmEO8XyN0Tm7bxh24HU/RRnBf1Nqe8d88/wgVtMcpe6aGG5F1FmteQTbxxJvma5URwmurVaHZ3yPqyy/csJbuMsGZIiKlp54AwPO/mZIIVH8XMgmoq8d0/4tCTtFlph8Lxhwla3jvedvTBANIKeP3BYb32kj6pAyhBTOeOWx/+yt3B0c68R4ib0HY9Abpp0x8p9LReWZCaxbfmgTEe6HJ6mJ13qRftoqoczC6ZAYh4NO55pxW4V5M0TuPnfE5roFS4Cletu3o9cHaftIY0Zct4yErDGDyWLz0tXCiaVSwc8Z3Z8DkGmdzlfOWThz5ZwzD/82PHkqSauxx7aqSMUyufWsqXndXrFZrOynkA2qISXN3E/hAeX2clXqi71fGA1ICBgR4nq/rOjrGl752eqWZS5cwEA7hOVEBP8tUhspLdJb0cbQH88OVxJWVr70pXkoOm3/d4o+gk1cWcTUpEFpnPvF0Y3SNsUz/UXMSMJsWESaO49aiiTwfTu616SAqasFIYB4TUHCU8gOVqC3LcEpiRgKT4xUufsonv4/5Kty1w2Gf1I+73FaBLYuCKdSEEIxBKbtCNjyZlyccRZGFipun0tdN2ePoRS h5bTJWAG UJq+ZPp8grgPNg2J5XMyEAuwG+KovhKl5XMb2Pe7+0vfMEOceM/1TL96jR5s4EQo5EIkdu8NC84pWQBkgZFBNM+SVx+5j38435DQL4O0nB4UhWHjte9Anytn1ZePc5cdvptXyPgE6XFuqEMyv7z+mLLm+BNMh6ZQs+mfWnNB4cpeH6f6ZEyjF3PaD7qBbOZWd78EpCBgeWYVjW+D04GRUhNt8kPvVUoiFFOEB45XEdOAn6Z97XGqu68/BFe6lbfcnb6h4A4vS292rWyQgqNfjU3ab3dvcGb4WpDzBeNiBCbhIJiQJF4sXBds9JH/oMiTL52Ck+vauGZgqolO9lR8ZtYB0z2JTEL1J8JpCN/ojgb92FuA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000229, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: A powerful way to diagnose crashes is to analyze the core dump produced upon the failure. Missing or malformed core dump files hinder these investigations. I'd like to propose changes that add logging as to why the kernel would not finish writing out the core dump file. These changes don't attempt to turn the code into a state machine with the numerical error codes. This is just the next step to not logging which is logging :). Please let me know what is good, bad and ugly with these changes! Signed-off-by: Roman Kisel Roman Kisel (1): binfmt_elf, coredump: Log the reason of the failed core dumps fs/binfmt_elf.c | 48 +++++++++++++++++++++------- fs/coredump.c | 69 +++++++++++++++++++++++++++++++--------- include/linux/coredump.h | 4 +-- kernel/signal.c | 5 ++- 4 files changed, 96 insertions(+), 30 deletions(-) base-commit: 831bcbcead6668ebf20b64fdb27518f1362ace3a