From patchwork Mon Jun 24 23:26:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Edward Liaw X-Patchwork-Id: 13710274 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90038C30653 for ; Mon, 24 Jun 2024 23:28:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B8C56B00A4; Mon, 24 Jun 2024 19:28:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18ECA6B00DC; Mon, 24 Jun 2024 19:28:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02FC86B00FF; Mon, 24 Jun 2024 19:28:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D8E686B00A4 for ; Mon, 24 Jun 2024 19:28:58 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 58BA5141366 for ; Mon, 24 Jun 2024 23:28:58 +0000 (UTC) X-FDA: 82267374756.26.71DB9D3 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf14.hostedemail.com (Postfix) with ESMTP id A8B58100005 for ; Mon, 24 Jun 2024 23:28:56 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=qX06HZ6V; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of 3NwF6ZgYKCFw87FC4QAIIAF8.6IGFCHOR-GGEP46E.ILA@flex--edliaw.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3NwF6ZgYKCFw87FC4QAIIAF8.6IGFCHOR-GGEP46E.ILA@flex--edliaw.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719271726; a=rsa-sha256; cv=none; b=TauDeINZ44o96GBFnYiaqv5AuUoTjw3Ochxqvx8iixuGZci2CPLflgxWo1LyYKOnb11uzX pAm5foIMw2D3EXBGaKW5Fxdgur+Hpq/M3hJDyz5ZuFn7xRciHLUd4UPilAbrFOeHjfOcmt BQ4KtzIa/f9Sd8OO2lUQuQvQV2splNI= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=qX06HZ6V; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of 3NwF6ZgYKCFw87FC4QAIIAF8.6IGFCHOR-GGEP46E.ILA@flex--edliaw.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3NwF6ZgYKCFw87FC4QAIIAF8.6IGFCHOR-GGEP46E.ILA@flex--edliaw.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719271726; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=FEnvDY+YQtOlDLldfWY9bO5cHBXotclBQZRJTAhLrGQ=; b=8n7e1dxvvLvqPUzrdTwb/a1B0Q1mAXLnxcFTpTvvRX7cSpdVomoxAnMwCYsEfU8qMPNEJJ tfcpWnw543HiXSj2DmLKoUU/LTovVt5Slgc3XPepUIgj/uBTxjqu43WAF9SVtRmq/raH1t j2YS3hwMdbVXTb5a5k9yjbsF6lC5aMM= Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e02b58759c2so9681338276.3 for ; Mon, 24 Jun 2024 16:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719271735; x=1719876535; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=FEnvDY+YQtOlDLldfWY9bO5cHBXotclBQZRJTAhLrGQ=; b=qX06HZ6VAkC8O1CBTXjRzYv//+fxd50s3RhVodwsr960gvgUs/zqy5O2n9OqIdemqh uj5PWFLEfzqmjl4Wa0QPZzs7N3jRIXsIKlSmGQA72QJXgrOSzKVOHVnBla0O7xo9MXk6 eEIGUGJWS7/l2xJ8+roVRptPsiQcFCzoa1funEUdL+wPzYJdgmX9iyVmu1RPOn2Wzs3X cR+UAO/06JBDwsJ1ZMsR8X7FtDZtNzCWqDsZ7dmGkaAN8b7VYBiJO5/Hcj+taP2PsJuM gakZr17hpxkbM4ta0B4UuF1vXLvTi9txwH63cy00q5yWNTABLu0LvBvwdnA3/rM4lVQn OkTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719271735; x=1719876535; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FEnvDY+YQtOlDLldfWY9bO5cHBXotclBQZRJTAhLrGQ=; b=iMvRHbxpWpzKqYuSQZpozd5gujfJPoz3Jpu8O/YOXZfTJffGRr7LBbLNZfmsP/yjdN nfEXUMow4au+ZVTkLYihFX7kpSTUNEkWoj9ePd/TUHIbp4wAMma//DF1EQMFGdPmHDL6 L0Z1qCfnst5d8seDLEGIYVjHi05VdZgRien2FjjkHEuLCZSHyedGHd2bA8tu2zPpwwmF sCuxxtQx4QF3v40Ucb7Bgp+xCMM7C5KsgIiDkD3MwLMGovsxpt9t/2ApwjyxvGUUbq94 x/6fnwg59CO/Pf/HT9isu9K2l+VZy6XXLSxgyEIDvGc4rpvx9b/OJ/gh3ejhTFDxGrDL K0nw== X-Forwarded-Encrypted: i=1; AJvYcCUkh4grRX78Po2PzTwlw+agZvnguEhELAZIhj3g+xs/j4WKyicAiy5Xwz18uszrqpqH4h1b/JM9BnthDfHhl88U/KY= X-Gm-Message-State: AOJu0YxGtQU0kn01sZJmmYvU0tyuiQSROq9Aee4Vktesr0sbN7UsWU1E odxIJBpW2JVbz8qWUdzMNnMtBB1G/Z6pG9g4JGEmKBhlthI4/ngDmjbhVJro3ypRIgyo5uttJQA 7fA== X-Google-Smtp-Source: AGHT+IGo0nBr4OMWeDQdXO7gLmA8943vaa7AUjGpvpzDg1f7Z8BrI79oFtF9sCT7oXO1KDCB6pUDmCcxQng= X-Received: from edliaw.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:305d]) (user=edliaw job=sendgmr) by 2002:a05:6902:1081:b0:dff:4788:ea88 with SMTP id 3f1490d57ef6-e0303d692f7mr20462276.0.1719271735356; Mon, 24 Jun 2024 16:28:55 -0700 (PDT) Date: Mon, 24 Jun 2024 23:26:09 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.45.2.741.gdbec12cfda-goog Message-ID: <20240624232718.1154427-1-edliaw@google.com> Subject: [PATCH v6 00/13] Centralize _GNU_SOURCE definition into lib.mk From: Edward Liaw To: linux-kselftest@vger.kernel.org, Eric Biederman , Kees Cook , Shuah Khan , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , " =?utf-8?q?Andr=C3=A9_Almeida?= " , Jason Gunthorpe , Kevin Tian , Paolo Bonzini , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Fenghua Yu , Reinette Chatre , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jarkko Sakkinen , Dave Hansen Cc: linux-kernel@vger.kernel.org, usama.anjum@collabora.com, seanjc@google.com, kernel-team@android.com, Edward Liaw , linux-mm@kvack.org, iommu@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sgx@vger.kernel.org X-Rspamd-Queue-Id: A8B58100005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: e77b88dj1j8oq67sckh9efkk5u6oq5pc X-HE-Tag: 1719271736-947918 X-HE-Meta: U2FsdGVkX1/jiZXSMjRk9khSozDWVn41yqOyDbshhlZK9HcLfLiSWapBL2NSdMy0mNKiSagE+Ir1n9KAOEkalRG8FM8eGRuKle41/nsjb3weZYM/A487kL805IyzDyMeYb//91Cf6PeAXhHG/SKL1aO6qEklp/NRtOmvl61cFDMP1YwkpSPr+tjlj5a2g+ABgpwViasmJ4Wj1weUyfheEFdZ9zL/pKThBhhFmrjULvMo5sy2AIOfN+jSslQkL0G1/U/90rMafebzebLOH7GW+Qjy/o3Jfq1DHwaIvtIOUBiT4y//W/A99hx0sUlefUTQmWbUv71uK/6aCyHk4s+NTDmPtEdrnL/jELIaceDB0cwzNWZx1X+AmVnab5umLpfczKm08y1+RkOXYw0z+tuabzjFg5WDMj+DqIXXaLOIBSVQCHeoZn3NomF2sXscJcaUgFg6rdACZejOpINSI3afIzQLRqUbJKxjk3SACEer3EG1h5G9CoEf1gf6UDtgEBpnhO5NpJrBan4FxKRAdDU8VC+vWCF5FpZUw8OoaAPGcfwOP3RMCKcp2JqJjURSzo/BGizpZakBaNp19LQzEAuLcdZ40XeMRa3QpqRIhc2tGHnBu89YzfT9p/QC2mkE0SMEtQiBYTQzoiazv4AEka4c67BrTaQRdhtVJ0zNTVy7MgmbD/+4qcsS748BoS1mME719rGOQrvTv8/9PhW3y9ROXuce4TKZM6XIUO7PijtWF64L56T4th0aF7gNJ+QnJSVduoqdwj/nfe88mT1lvIqlmS35GjGu9R8qoNFUUbTxE6w0brcjfvvaSWTszQcn7jEymiEjsUS2q4fcau60U+DOPIkZkLcE7sbpE0PzHKSornSdvS/n+AiR82jg9+8jaxeJ6v1MbvIXusM9gHiYu6voBnE+gHahmXqNJMqaoVky5SaO+YVahEnX3pB73fVbPD6KOd8oBS1HguNKQyXRuFQ 1fHM0d4N VW/dmiPjQQcIjlf31SkNpA+yAZxlp1ZSNp7pZ0b+LmGRJGwazdVXynT06gRsfqZafsUFAoGOP/3VNu6+hNnt9HTVdLLXP4ATdzLC6wH6mMzoveSokg6HXmB/vhjIXSXTE7BB5ONLwF+r/qxe1aCt8/wxmWnqMS1+30EO0RjeuObXnrazvzCPyfvL0WH1WOV/X9bvSGS09LXZg8CcuTa8vdg783vGBtRxzd/3SezjvmulhTc3W3onI1+6fq/A+nhF024G/GzfLbklJtbKbmo5NlLwGJ7fTi0McY+cm37WOZ1WQAkOI/4jRZfw3WkYzJZAqI8ZiiEXD95nihpKv7rkkwKduUK7v6P3jq0XWRWlFJmEFHu2u4jqh7304WH+6sqePnanbp9yJNNI9BvKGuGbhGhItPRlAZrod4n5IYuMs1rUc7eTPTdfe9rWv3WQfYuNiV/EfDmLwpKnEwrgy28vGjGvOPc9D28EAuXn+wvBN9xL7m82YJGX2pnd+AOBV84OkaqRXVoe22bmhoRAUTiR6DmxJWQVDWlpRsdZ2Nt8RUit6qV2x2NjEBpjMqSSoTw5LmTLBhi3w/de6TKsL8ejKcGEl8txNCRl8D9XRxf+jbrQBHmSxS8aO4IIAag== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Centralizes the definition of _GNU_SOURCE into lib.mk and addresses all resulting macro redefinition warnings. These patches will need to be merged in one shot to avoid redefinition warnings. The initial attempt at this patch was abandoned because it affected lines in many source files and caused a large amount of churn. However, from earlier discussions, centralizing _GNU_SOURCE is still desireable. This attempt limits the changes to 1 source file and 12 Makefiles. v1: https://lore.kernel.org/linux-kselftest/20240430235057.1351993-1-edliaw@google.com/ v2: https://lore.kernel.org/linux-kselftest/20240507214254.2787305-1-edliaw@google.com/ - Add -D_GNU_SOURCE to KHDR_INCLUDES so that it is in a single location. - Remove #define _GNU_SOURCE from source code to resolve redefinition warnings. v3: https://lore.kernel.org/linux-kselftest/20240509200022.253089-1-edliaw@google.com/ - Rebase onto linux-next 20240508. - Split patches by directory. - Add -D_GNU_SOURCE directly to CFLAGS in lib.mk. - Delete additional _GNU_SOURCE definitions from source code in linux-next. - Delete additional -D_GNU_SOURCE flags from Makefiles. v4: https://lore.kernel.org/linux-kselftest/20240510000842.410729-1-edliaw@google.com/ - Rebase onto linux-next 20240509. - Remove Fixes tag from patches that drop _GNU_SOURCE definition. - Restore space between comment and includes for selftests/damon. v5: https://lore.kernel.org/linux-kselftest/20240522005913.3540131-1-edliaw@google.com/ - Rebase onto linux-next 20240521 - Drop initial patches that modify KHDR_INCLUDES. - Incorporate Mark Brown's patch to replace static_assert with warning. - Don't drop #define _GNU_SOURCE from nolibc and wireguard. - Change Makefiles for x86 and vDSO to append to CFLAGS. v6: - Rewrite patch to use -D_GNU_SOURCE= form in lib.mk. - Reduce the amount of churn significantly by allowing definition to coexist with source code macro defines. Edward Liaw (13): selftests/mm: Define _GNU_SOURCE to an empty string selftests: Add -D_GNU_SOURCE= to CFLAGS in lib.mk selftests/net: Append to lib.mk CFLAGS in Makefile selftests/exec: Drop redundant -D_GNU_SOURCE CFLAGS in Makefile selftests/futex: Drop redundant -D_GNU_SOURCE CFLAGS in Makefile selftests/intel_pstate: Drop redundant -D_GNU_SOURCE CFLAGS in Makefile selftests/iommu: Drop redundant -D_GNU_SOURCE CFLAGS in Makefile selftests/kvm: Drop redundant -D_GNU_SOURCE CFLAGS in Makefile selftests/proc: Drop redundant -D_GNU_SOURCE CFLAGS in Makefile selftests/resctrl: Drop redundant -D_GNU_SOURCE CFLAGS in Makefile selftests/ring-buffer: Drop redundant -D_GNU_SOURCE CFLAGS in Makefile selftests/riscv: Drop redundant -D_GNU_SOURCE CFLAGS in Makefile selftests/sgx: Append CFLAGS from lib.mk to HOST_CFLAGS tools/testing/selftests/exec/Makefile | 1 - tools/testing/selftests/futex/functional/Makefile | 2 +- tools/testing/selftests/intel_pstate/Makefile | 2 +- tools/testing/selftests/iommu/Makefile | 2 -- tools/testing/selftests/kvm/Makefile | 2 +- tools/testing/selftests/lib.mk | 3 +++ tools/testing/selftests/mm/thuge-gen.c | 2 +- tools/testing/selftests/net/Makefile | 2 +- tools/testing/selftests/net/tcp_ao/Makefile | 2 +- tools/testing/selftests/proc/Makefile | 1 - tools/testing/selftests/resctrl/Makefile | 2 +- tools/testing/selftests/ring-buffer/Makefile | 1 - tools/testing/selftests/riscv/mm/Makefile | 2 +- tools/testing/selftests/sgx/Makefile | 2 +- 14 files changed, 12 insertions(+), 14 deletions(-) --- 2.45.2.741.gdbec12cfda-goog