From patchwork Tue Jun 25 11:44:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Pankaj Raghav (Samsung)" X-Patchwork-Id: 13710919 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 816A0C30658 for ; Tue, 25 Jun 2024 11:44:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF9836B02E5; Tue, 25 Jun 2024 07:44:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA9636B02E7; Tue, 25 Jun 2024 07:44:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D70EE6B02E8; Tue, 25 Jun 2024 07:44:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BA0A66B02E5 for ; Tue, 25 Jun 2024 07:44:32 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 78D241414E6 for ; Tue, 25 Jun 2024 11:44:32 +0000 (UTC) X-FDA: 82269228384.11.9113531 Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by imf02.hostedemail.com (Postfix) with ESMTP id A916180020 for ; Tue, 25 Jun 2024 11:44:29 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b="kySvDD/n"; spf=pass (imf02.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719315863; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=MKFoJ3j4KB+I/qDQQrYOSbOqrOpG0UvaNnSzD6LfMBw=; b=1jBnZfqYHqcb/eT8ib7OzA4QqKfcGhQGwFVTVI2nYWZIJxfZytg0QY/mg8LAx1IQLS/pxH 79riiMVAFtqcpC8EgfRhoxPyaVyxG60mA7RChYTwkBNoKoupZ2zto8U51CBJpD+zxWEae9 AphucFeO/zsEliy39NqKKcrBql11jxw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b="kySvDD/n"; spf=pass (imf02.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719315863; a=rsa-sha256; cv=none; b=0jy8jSh/b7IdjbggnDNMx0FgdCV2ka0wDnMeS8UE8KBeNGNJ/P0MWzTNX0blBbmfyrdpki AL7bYgO2g8XB9MuwZgQQZbxSkvsGrcz5pYzFiiC1eopa7b/mVPUgQ/H1owu/S9N06OvE9w 5FHMaalyjR7ow4+U099/VoPqw0/WJ4g= Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4W7jfd2YL4z9sWC; Tue, 25 Jun 2024 13:44:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1719315865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MKFoJ3j4KB+I/qDQQrYOSbOqrOpG0UvaNnSzD6LfMBw=; b=kySvDD/nXc/Hs9+I7BRh+UVlcdHThmgtpTwEvLXk5xkZmwR4voWwC7i/AoHPW7N8Qyz76C w/GloDHjcxSc80CoscheghvDuGACxOpuxG/giKR9ACXpRnHGkylrWsiVSCwDZsSCRpdvmI +HdzdxyF7SQ/6egiwEy9WGIinvnY9yQKWDNZgBZHRNaVOBXZIC5ysurjSeD//gFYn1/HUR WL+KpqBXAPZZ341CRvrnc3LAanWaineXW4jOE2aSDS9lCg1X9zVJtGSx5gS3Kf7WLqxwp/ Ey7ZR4VtDu61rjCQoGAUvMA+FYVWvc+bIE33AhIc9nd4QbLaSUBGRzzvYCOBIQ== From: "Pankaj Raghav (Samsung)" To: david@fromorbit.com, willy@infradead.org, chandan.babu@oracle.com, djwong@kernel.org, brauner@kernel.org, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, kernel@pankajraghav.com, hch@lst.de, Zi Yan Subject: [PATCH v8 00/10] enable bs > ps in XFS Date: Tue, 25 Jun 2024 11:44:10 +0000 Message-ID: <20240625114420.719014-1-kernel@pankajraghav.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A916180020 X-Stat-Signature: xn1ruc4pwspth9c8ptwz9ynuyw3h3i3m X-HE-Tag: 1719315869-199301 X-HE-Meta: U2FsdGVkX19X9tUgpXNFj3J3vi2i9XY4o/x+iwgbiEPkzFwIVwR/n2IMEogdZTZpGXT2SUzonTT1t1PwDeKO5qft9S8vgpPV9Ed/qokMag1kY6Y+mrWq1uwJeTDBVmpWSaCeJSSgin6UTozsHq3FWDBnJRXFOnVgC0JxlmiLWApl+t4hNbD9PWyK8oHk/I9uSiNQ0N590XAgNGsPCuZWW6HZkDSJCjJSead14gN4nlD+JT/4h1/W11hTaI0kqvf0C9fHkGWs/wVFcuoEjV500hcP1YmsqgfWm+GMvgmjqVC5cMFHO8N8QdFxJwywS5b4HOqkV+9edBEGddXbbhEzR9zF07fFItAYldsPZKb29oEh8ss+GpGWsrHP5+ktsWHPMn8X2PJEXvu7Ay+uxbwAdA+QK0MDHHDIP0PVyWl1JOWfptO2nOLon6v0X5JnhgQOETMrKQKJgCOFS3yXUfz1jxYhVkv188k4DCieS5vfXlJEpGINb5xtFvJBSepU5J0w0TR/4IKOKQiCKoQEUBoseIWYxIIX1zlXfrFWRxh7aphKuympVWt1K7ULqKfPMUCiCM3F28J9HhkXP+KTdtcoXwQEhOL7ZVvcpm87RahCv4FyHl+BjJwg4MeM9Y9hw5IK57Icicw0EYNjKXruFyzIywcupAQWCL6t26cBprogDyY5NoyEyP/ifZc9J3cDseyYYijE2MbUcCscG6ZGASKY38w7tReyi5JCBsAvrQ/xIRwbipkvqPGZ+Xd5YPx3PbTVhu27NIZ6bfJPvCkG9btAS7uMioTjwXmS0NEpkqnLSiUkxE/O07LQBRsy2UjVeUFAQ9/kc0lEQ+MCGPNLyWxSb9q/nddjhU2i/GSzdn8lehosW0mbvFtPxp+intQ1c/+ckQoZE0Z7+vybgnUnmTi48frJCl2T56+/8ISMXNOnnuG12W6bImcjmnRbnY/xKVyeSx0bDHDCrOtCZ1xkZVU FzW1sXmF W/F3CKquBPKM4OYm+u+rxG/R4jf0HxxOl9kMuHLuIyyW9/VPktlFdc08vekzB6kVdHVh8waGaxSd4FWs+ThChxzGnVxzxZPgR0O9VdtCEmsDlNumjgVT/B39GNYmcTDZU8bbBT4nEKIH99l3DKARKKeZX9rIozAZDWuW5JOQ6WKAjLny+YFe89eL5WswgO58PyvLe07B4vtLQHy2RqyUViFVyKqU0ZCgfCvYkyUt8W0IDoaVV4d4yS4LNoUh9CECznMaxygfknuQD1QuxNXQpMBXNcI/E95ZfQyWKSC1RTw3rCOkAzzMl7vpAcXNncGn9de6f+l28JJfq0yXPTsYJSS/egUXbavT6BLgapqBoHg4bTaX4f3Oo+C33DKUj452bAhcGp5O510jOpfosclXfmuUOlq1g8bax2VzAO1jYAsAIBFdp0PI2ZewpnZgYwboGChul6MbUIWq72EusZDb/LJUkUdp3rYNS8Y6z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Pankaj Raghav This is the eight version of the series that enables block size > page size (Large Block Size) in XFS. The context and motivation can be seen in cover letter of the RFC v1 [0]. We also recorded a talk about this effort at LPC [1], if someone would like more context on this effort. A lot of emphasis has been put on testing using kdevops, starting with an XFS baseline [3]. The testing has been split into regression and progression. Regression testing: In regression testing, we ran the whole test suite to check for regressions on existing profiles due to the page cache changes. I also ran split_huge_page_test selftest on XFS filesystem to check for huge page splits in min order chunks is done correctly. No regressions were found with these patches added on top. Progression testing: For progression testing, we tested for 8k, 16k, 32k and 64k block sizes. To compare it with existing support, an ARM VM with 64k base page system (without our patches) was used as a reference to check for actual failures due to LBS support in a 4k base page size system. There are some tests that assumes block size < page size that needs to be fixed. We have a tree with fixes for xfstests [4], most of the changes have been posted already, and only a few minor changes need to be posted. Already part of these changes has been upstreamed to fstests, and new tests have also been written and are out for review, namely for mmap zeroing-around corner cases, compaction and fsstress races on mm, and stress testing folio truncation on file mapped folios. No new failures were found with the LBS support. We've done some preliminary performance tests with fio on XFS on 4k block size against pmem and NVMe with buffered IO and Direct IO on vanilla Vs + these patches applied, and detected no regressions. We also wrote an eBPF tool called blkalgn [5] to see if IO sent to the device is aligned and at least filesystem block size in length. For those who want this in a git tree we have this up on a kdevops large-block-minorder-for-next-v8 tag [6]. [0] https://lore.kernel.org/lkml/20230915183848.1018717-1-kernel@pankajraghav.com/ [1] https://www.youtube.com/watch?v=ar72r5Xf7x4 [2] https://lkml.kernel.org/r/20240501153120.4094530-1-willy@infradead.org [3] https://github.com/linux-kdevops/kdevops/blob/master/docs/xfs-bugs.md 489 non-critical issues and 55 critical issues. We've determined and reported that the 55 critical issues have all fall into 5 common XFS asserts or hung tasks and 2 memory management asserts. [4] https://github.com/linux-kdevops/fstests/tree/lbs-fixes [5] https://github.com/iovisor/bcc/pull/4813 [6] https://github.com/linux-kdevops/linux/ [7] https://lore.kernel.org/linux-kernel/Zl20pc-YlIWCSy6Z@casper.infradead.org/#t Changes since v7: - Move by min_nrpages in page_cache_ra_unbounded if we found a folio as we don't have a stable reference. - Rename iomap_init to iomap_pagecache_init and add a new iomap_dio_init and mark the zero_fs_64k memory as RO. - Simplified calculation in xfs_sb_validate_fsb_count(). - Collected RVB from willy, Darrick and Hannes. Dave Chinner (1): xfs: use kvmalloc for xattr buffers Luis Chamberlain (1): mm: split a folio in minimum folio order chunks Matthew Wilcox (Oracle) (1): fs: Allow fine-grained control of folio sizes Pankaj Raghav (7): filemap: allocate mapping_min_order folios in the page cache readahead: allocate folios with mapping_min_order in readahead filemap: cap PTE range to be created to allowed zero fill in folio_map_range() iomap: fix iomap_dio_zero() for fs bs > system page size xfs: expose block size in stat xfs: make the calculation generic in xfs_sb_validate_fsb_count() xfs: enable block size larger than page size support fs/iomap/buffered-io.c | 4 +- fs/iomap/direct-io.c | 30 +++++++++- fs/xfs/libxfs/xfs_attr_leaf.c | 15 ++--- fs/xfs/libxfs/xfs_ialloc.c | 5 ++ fs/xfs/libxfs/xfs_shared.h | 3 + fs/xfs/xfs_icache.c | 6 +- fs/xfs/xfs_iops.c | 2 +- fs/xfs/xfs_mount.c | 8 ++- fs/xfs/xfs_super.c | 18 +++--- include/linux/huge_mm.h | 14 +++-- include/linux/pagemap.h | 109 +++++++++++++++++++++++++++++----- mm/filemap.c | 36 +++++++---- mm/huge_memory.c | 55 +++++++++++++++-- mm/readahead.c | 85 +++++++++++++++++++------- 14 files changed, 309 insertions(+), 81 deletions(-) base-commit: b992b79ca8bc336fa8e2c80990b5af80ed8f36fd