From patchwork Wed Jun 26 05:08:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiaqi Yan X-Patchwork-Id: 13712306 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D8E4C27C4F for ; Wed, 26 Jun 2024 05:08:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B56E96B0093; Wed, 26 Jun 2024 01:08:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADFFD6B0096; Wed, 26 Jun 2024 01:08:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 980836B0098; Wed, 26 Jun 2024 01:08:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 777C16B0093 for ; Wed, 26 Jun 2024 01:08:26 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 183F880AA1 for ; Wed, 26 Jun 2024 05:08:26 +0000 (UTC) X-FDA: 82271859012.03.5ACAAC4 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) by imf14.hostedemail.com (Postfix) with ESMTP id 5B95A100018 for ; Wed, 26 Jun 2024 05:08:24 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KRdqX+r2; spf=pass (imf14.hostedemail.com: domain of 3RqJ7ZggKCLMcbTjbrTgZhhZeX.Vhfebgnq-ffdoTVd.hkZ@flex--jiaqiyan.bounces.google.com designates 209.85.210.202 as permitted sender) smtp.mailfrom=3RqJ7ZggKCLMcbTjbrTgZhhZeX.Vhfebgnq-ffdoTVd.hkZ@flex--jiaqiyan.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719378496; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=CGDqphXBU6R+lNPyRUopWgvG7yuYFqi637jqIyNGWis=; b=Izwn02tOLXLahzcu2Y3w72jzErhlB6AUcLuDvtjONFO5v9aGHrF6OrHXp271VKyqDU8B7d MISlkEeFkueH3nhjuieQUbnNdDwyvBARLg0t+m9wE3cLDUFK8Jy6l6uE/uDFAR1tG2dE+0 AGMMGzwe8zIJ920qjr9FJAMqAPvqw20= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KRdqX+r2; spf=pass (imf14.hostedemail.com: domain of 3RqJ7ZggKCLMcbTjbrTgZhhZeX.Vhfebgnq-ffdoTVd.hkZ@flex--jiaqiyan.bounces.google.com designates 209.85.210.202 as permitted sender) smtp.mailfrom=3RqJ7ZggKCLMcbTjbrTgZhhZeX.Vhfebgnq-ffdoTVd.hkZ@flex--jiaqiyan.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719378497; a=rsa-sha256; cv=none; b=Hrsm7att1VRARhgwjxFhgWKz4bp5ervdPsb5zxSEB5t/PTO2DODA3TV7dWVFkupP+pb6zi aKOmQZti7NOTYGb9xjrBqHGtNZPP8dd3ZIrwbsmTxjqWLSK5uESHadbvF5425CJ3KVio77 N1eru8aQPSqQLPAvEicWx6tY5xLkA1o= Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-70679e6722aso247175b3a.1 for ; Tue, 25 Jun 2024 22:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719378503; x=1719983303; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=CGDqphXBU6R+lNPyRUopWgvG7yuYFqi637jqIyNGWis=; b=KRdqX+r2OMEGeIZe99Xtg0Ny05XMwA9XEX49eX0+HObChGtEQqC8ruvKMTtul5erXP H9l/eQTQUR79oyPLXJkac0npjF2sidq0urBWleBniTwMri5rIGpA0VxR6WvXQfJnAr4B JR6DcYeCVlK/CSJ2isA2OI1/UbFxsRMjSODhGTExOdaUampGGIuabiamUmzw/emTjS5u 5DmHJ4pTPkHQaR3f38LCkKyflC54IBuucbpZeB0oot/AYgAkhCZaoAgJf9FP6MPTf3UA fWbLo/4cO47H+wyxjt91ShDM52dEhkAOA6X4Aotb2DOws37MdVZr2iswChRQXAjX8+ql lEdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719378503; x=1719983303; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=CGDqphXBU6R+lNPyRUopWgvG7yuYFqi637jqIyNGWis=; b=erwlux7FGO+aA4KtdlU7RMnYMYokyUb/nj6DZ99sSp6TsYAZRr1uPiGmyVQ4hlLDOm 8ws64wUiQ7TbrMRIGb+AvGjn4IZBi+5zrfnKm2q0mZQPUzQ4QSIbNvWIkbw+/u02p5Jo 8jXi0Nc+SLMd2dyfiM62R1w/FiVjozP/pLdZPLS1LQ3vj6/4Swv30qFYjQgVpvWzAMTx d8wMJpwawuiM3xaqzeHYf+afy9tY86/HtmpsHdYcMHIEmHb/nEeJ6z+v7VTtglWqGQKN NKoD4FBNT/We/ceowdDJPMpOc9zKgh9az9kYbBLE4y3gpTmc7cL46WBlvUsoZpgb8Dnp C4Ig== X-Forwarded-Encrypted: i=1; AJvYcCVBHVaH2zaoKwoKySTEESAq/U8cNLAExJizOnYcyjYlk0DNGrurukm13c2tOnJ4LDUXK6BJWiyIh9SlCnLD0aUlFEM= X-Gm-Message-State: AOJu0YxNrxZBNtS0RfoaIwrwuLUnXHUCZ/28N8a3CH6/+19xieh3EqXJ H4dlgtEHzfneLVL3N+C6XE7LnhiLYzrbALVWcQEs8AqphfReynVKttQQCF7cAK/c90KF31sybck +ZfuYXEUKrA== X-Google-Smtp-Source: AGHT+IFb+0VOH/8Ji5MJY9Uzpp2NjXzdjAP0KEkJlwDoF3zvJdDZjjCYpaexBLDLoxcxVDGz7IEJNGYV1Aobyw== X-Received: from yjq3.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:272f]) (user=jiaqiyan job=sendgmr) by 2002:a05:6a00:4309:b0:705:d750:83dd with SMTP id d2e1a72fcca58-70669e5e132mr340822b3a.0.1719378502937; Tue, 25 Jun 2024 22:08:22 -0700 (PDT) Date: Wed, 26 Jun 2024 05:08:14 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.45.2.741.gdbec12cfda-goog Message-ID: <20240626050818.2277273-1-jiaqiyan@google.com> Subject: [PATCH v6 0/4] Userspace controls soft-offline pages From: Jiaqi Yan To: nao.horiguchi@gmail.com, linmiaohe@huawei.com Cc: jane.chu@oracle.com, rdunlap@infradead.org, ioworker0@gmail.com, muchun.song@linux.dev, akpm@linux-foundation.org, shuah@kernel.org, corbet@lwn.net, osalvador@suse.de, rientjes@google.com, duenwen@google.com, fvdl@google.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, Jiaqi Yan X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 5B95A100018 X-Stat-Signature: gfw3xzdgw4544zamazn6qhb3e8e8meea X-HE-Tag: 1719378504-159842 X-HE-Meta: U2FsdGVkX19jLJ0c0nJjd4CCdHFaRUefw7nV7TpopJM+mVtAWwDW0RPy3yWdIgFCChoL26mXKqugEnFZ6DP2KrScIRYI+4aRna6ttfoxyncZ/9gZm3AFlH2W1egQ8QrNPo5CjZ/GqtlKooS5e40LHeJex2MaRLDNMzvtp3OgMz4O2r5oqUjMG2MfRX+VKeYS+Nf+nlYj/6G+iw24EhpkZT3VnGAR6EE/XeZX+L+3RNgYOrhEByrWvutvxeGNr78yrYnVD648yWBYWwHK1ECiwm5G1Dp9tNlwxobboNNRk3GqmZRQpLpPXeBn8fFcB+Zy2ehBPtlbCtgR1Bzs4jh0aqBzndiNYINJRy+ncBVxhyr1gUPLJL3abfY2bw3/oX1/vunvIvi5wqa2zu74Gs03KNdvEGE9PIOMk98Za47kAFJTIIelTq73mRnFzAbhN1EMzC2P9A3Xz4lsUQVijWg+OkbWfp66+iHckmfvwx0dfcRQ+yrgLBXKuxrCsQ9McZsJ06MoQ3vcUkNcY3slNQxLgCl7s9LSVaiewL8rrsU+Z2RZLfbUI5ZmjNAG9b7GZXYtq/MpCSu4qlHbUZZ60dao5/caZm3kzC6wCGVKnmXEJPetQEEM0/EGwpIYrAXWaAg7Td+sm108GavQKL022o3ztwhUVnCeQmFMwH+1WtIVjp3HcNMK7slCSlF1W4ki90H+5i7YgL0FzPvAe3E0uTVq4+5slperiRrwWZxLVbp7y8dng5ZM9t1gCeIMBA2sD381vvT8nEvXW18VfEVueFrQl0qU0XNl0UvCyIhIfLa9ZaheiVOrvUYl76NeJ96Ptts0p53W+j4SbSKE1NvgOBMkOBgnIdRPpQcPae0VUAg5wIYtU2nNEWmwEN05S4La8HHHZsJXWAAFNbkVVJwNzzdbK8H+4A5gNj99I9HzrDQ7jC2ZKb9Gs0kCgIOZu40al0GEQGeQcvLIKYBVPAeoSI6 3R7SyriJ 3B2SM1+OuYYjuGIstEcU/6lrAUplsp6t6PeILQfsZeWAbfEETLePXBPdMBlZlyL9dx3Ee6xlZjrTAdhHuTfQnLMit7Ecpo00JXhNKTwWCBsTfnmSif5JlNe2bPrBhZGB8Z7tD2AD2qJu+8oxSUg96dOGRLyJFbMOhMfZZNMdzMisJJyjCrvCu0GjlZfL7qCbR6uT/2k0HgncR3ZCbL8/y9u6Zsx1IQek4u9JDFfANEcG/0I0rO6jzx0ZRWLW82RezcVveBM8ZFHs/A4fkAMLlq3tav0vtYJXWZH0rbFD31rQn9UfwSoqtccv2zK/NB8/N0Wfa8fZAcN6XDyQWxamf3KFGsCkPiVNrCZvZX6ZRVo+so5am6pdSjRkh63RDaqbbS1rWsn4jdGlLJqqEQkDuFM4Z1QB+E/giqbgDZqi722CMSXzaKOJhu7Qn5dp+wJWKbT4W4WFnGGFBZ6MlTf7Y8Kr/I4UMXvI2ztbJ3Mw6txwCc0kQTjSmRAAfne5TLflFyQt45UmOoYRYcxr3UK8a/d3igubPNB3Pb8ooHJ8w9z3ZtFPK+phZierklNvpKpzCW0SpwRTZKGtnwrjW2DRHhMuaQCqpRJoNwxZkUdbT6r1ysIGLeNOTHtEDyORQjs8G5tREfXjCsoUfPRxsk8e1UMR6OntUL49ZIRuu1vj6+mDHCmOBekd4hMopAIRsrf/CvCA16uHRorG+l8LsKOEyZuRkFSBiPYxF2m5j32PuZv1Kiz/Ey3Gl6RDaZ3l7ijBUykBx8byanmYBBf7mixIShykTMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Correctable memory errors are very common on servers with large amount of memory, and are corrected by ECC, but with two pain points to users: 1. Correction usually happens on the fly and adds latency overhead 2. Not-fully-proved theory states excessive correctable memory errors can develop into uncorrectable memory error. Soft offline is kernel's additional solution for memory pages having (excessive) corrected memory errors. Impacted page is migrated to healthy page if it is in use, then the original page is discarded for any future use. The actual policy on whether (and when) to soft offline should be maintained by userspace, especially in case of an 1G HugeTLB page. Soft-offline dissolves the HugeTLB page, either in-use or free, into chunks of 4K pages, reducing HugeTLB pool capacity by 1 hugepage. If userspace has not acknowledged such behavior, it may be surprised when later mmap hugepages MAP_FAILED due to lack of hugepages. In case of a transparent hugepage, it will be split into 4K pages as well; userspace will stop enjoying the transparent performance. In addition, discarding the entire 1G HugeTLB page only because of corrected memory errors sounds very costly and kernel better not doing under the hood. But today there are at least 2 such cases: 1. GHES driver sees both GHES_SEV_CORRECTED and CPER_SEC_ERROR_THRESHOLD_EXCEEDED after parsing CPER. 2. RAS Correctable Errors Collector counts correctable errors per PFN and when the counter for a PFN reaches threshold In both cases, userspace has no control of the soft offline performed by kernel's memory failure recovery. This patch series give userspace the control of softofflining any page: kernel only soft offlines raw page / transparent hugepage / HugeTLB hugepage if userspace has agreed to. The interface to userspace is a new sysctl called enable_soft_offline under /proc/sys/vm. By default enable_soft_line is 1 to preserve existing behavior in kernel. Changelog v5=> v6: * incorporate feedbacks from Miaohe Lin * add a ':' in soft offline log. * close hugetlbfs file descriptor in selftest. * no need to "return" after ksft_exit_fail_msg. v4 => v5: * incorporate feedbacks from Muhammad Usama Anjum * refactor selftest to use what available in kselftest.h v3 => v4: * incorporate feedbacks from Miaohe Lin , Andrew Morton , and Oscar Salvador . * insert a refactor commit to unify soft offline's logs to follow "Soft offline: 0x${pfn}: ${message}" format. * some rewords in document: fail => will not perform. * v4 is still based on commit 83a7eefedc9b ("Linux 6.10-rc3"), akpm/mm-stable. v2 => v3: * incorporate feedbacks from Miaohe Lin , Lance Yang , Oscar Salvador , and David Rientjes . * release potential refcount if enable_soft_offline is 0. * soft_offline_page() returns EOPNOTSUPP if enable_soft_offline is 0. * refactor hugetlb-soft-offline.c, for example, introduce test_soft_offline_common to reduce repeated code. * rewrite enable_soft_offline's documentation, adds more details about the cost of soft-offline for transparent and hugetlb hugepages, and components that are impacted when enable_soft_offline becomes 0. * fix typos in commit messages. * v3 is still based on commit 83a7eefedc9b ("Linux 6.10-rc3"). v1 => v2: * incorporate feedbacks from both Miaohe Lin and Jane Chu . * make the switch to control all pages, instead of HugeTLB specific. * change the API from /sys/kernel/mm/hugepages/hugepages-${size}kB/softoffline_corrected_errors to /proc/sys/vm/enable_soft_offline. * minor update to test code. * update documentation of the user control API. * v2 is based on commit 83a7eefedc9b ("Linux 6.10-rc3"). Jiaqi Yan (4): mm/memory-failure: refactor log format in soft offline code mm/memory-failure: userspace controls soft-offlining pages selftest/mm: test enable_soft_offline behaviors docs: mm: add enable_soft_offline sysctl Documentation/admin-guide/sysctl/vm.rst | 32 +++ mm/memory-failure.c | 38 ++- tools/testing/selftests/mm/.gitignore | 1 + tools/testing/selftests/mm/Makefile | 1 + .../selftests/mm/hugetlb-soft-offline.c | 228 ++++++++++++++++++ tools/testing/selftests/mm/run_vmtests.sh | 4 + 6 files changed, 296 insertions(+), 8 deletions(-) create mode 100644 tools/testing/selftests/mm/hugetlb-soft-offline.c