From patchwork Thu Aug 1 06:51:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aruna Ramakrishna X-Patchwork-Id: 13749888 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC730C3DA64 for ; Thu, 1 Aug 2024 06:51:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5981C6B00BA; Thu, 1 Aug 2024 02:51:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D1606B00B2; Thu, 1 Aug 2024 02:51:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3075C6B00B8; Thu, 1 Aug 2024 02:51:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0B6B96B00B1 for ; Thu, 1 Aug 2024 02:51:42 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9ACE61C31B2 for ; Thu, 1 Aug 2024 06:51:41 +0000 (UTC) X-FDA: 82402756002.11.3500D55 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf01.hostedemail.com (Postfix) with ESMTP id B0ECC40009 for ; Thu, 1 Aug 2024 06:51:39 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=c3Bq3o0c; spf=pass (imf01.hostedemail.com: domain of aruna.ramakrishna@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=aruna.ramakrishna@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722495042; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=c5Qa4Pt5RmJwMRl6l2qwFzkAHapDsMU6iAQnMGtr1lw=; b=rpwyuoppetsO4LB7YDkUGk+sJU/s37tFE2t3dj6XXrCPxsApv/fSn3hMkE0ry4cLTqfwy7 ynQZqUCLkvZt2V5GDhGM5IBzeu6VQsF7zsA8E7a5aNAOlIe2z4QFUjOe0Q7ccQL7p+CoTj XuFNX3iu5yq9o3L2P4rzJgrKUk85p+4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722495042; a=rsa-sha256; cv=none; b=eARn9w6JQ2vS4T+5xkhYj7o782sO03qC5uPcJhMsGdIz8bZjNXQji9PQOtwkfxZvMmHedb ILp0ArgAv/ZZWxKROzIIEZD7FNNaNn8psO921K+YlvupYJxap1JYmhxtRozM531s7KFEES oWW6BWyPHc08GXE2M4qjPd4CBUdk3Cc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=c3Bq3o0c; spf=pass (imf01.hostedemail.com: domain of aruna.ramakrishna@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=aruna.ramakrishna@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4713nL1R001277; Thu, 1 Aug 2024 06:51:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=corp-2023-11-20; bh=c5Qa4Pt5RmJwMR l6l2qwFzkAHapDsMU6iAQnMGtr1lw=; b=c3Bq3o0cWZr0feUBMQxEWWhs9qRgea eQqz7wKIdyWOm4WL0JDsb/SRszO6BT2hSFE/dL+iYgFESFKgvprVGqW3FmRZpVr1 5q08Fipz2o87jeGvgNo1ynL2PCl/vlwLxW9O5Y4LjmS0f+/vvKHTQZgug9Du+nVw OxZSptQFkjfyingLT78GUKwHb22wWlb/Xu9Uncxw80eEjYt7lsuYfbTzoBEdXF62 1gbweus8Xi1aqibnd6KIcCi09oZpni43gZarYalAIyADjqQnP1RM9gBpwX6idDEG X8DZvyV9m5Hsl/WaM3KsIrvpIFAmNMUkTV83K88KFu8OXl6LehfuGvYA== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 40mrxc16nf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 01 Aug 2024 06:51:18 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 4715Glmc030804; Thu, 1 Aug 2024 06:51:18 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 40nehveh7d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 01 Aug 2024 06:51:18 +0000 Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 4716pHNC033596; Thu, 1 Aug 2024 06:51:17 GMT Received: from aruramak-dev.osdevelopmeniad.oraclevcn.com (aruramak-dev.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.253.155]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 40nehveh6x-1; Thu, 01 Aug 2024 06:51:17 +0000 From: Aruna Ramakrishna To: linux-kernel@vger.kernel.org Cc: x86@kernel.org, dave.hansen@linux.intel.com, tglx@linutronix.de, mingo@kernel.org, linux-mm@kvack.org, keith.lucas@oracle.com, jeffxu@chromium.org, rick.p.edgecombe@intel.com, jorgelo@chromium.org, keescook@chromium.org, sroettger@google.com, jannh@google.com, aruna.ramakrishna@oracle.com Subject: [PATCH v7 0/5] x86/pkeys: update PKRU to enable pkey 0 before Date: Thu, 1 Aug 2024 06:51:11 +0000 Message-Id: <20240801065116.2088582-1-aruna.ramakrishna@oracle.com> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-01_04,2024-07-31_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 spamscore=0 mlxlogscore=900 suspectscore=0 bulkscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2408010038 X-Proofpoint-GUID: UCDjhJ1qyGjA00qKsIFNSUfm8n7_2w58 X-Proofpoint-ORIG-GUID: UCDjhJ1qyGjA00qKsIFNSUfm8n7_2w58 X-Stat-Signature: 9sf9z8ege3fjtq39yjsqda5x7adic7hg X-Rspamd-Queue-Id: B0ECC40009 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1722495099-385716 X-HE-Meta: U2FsdGVkX19+GLRTEt1vY2Ai+0NOMfhwU/T8te28emds9gejrdnAenWjE7aRjPlO0sA3M1bXYsQ5E+upmsYNFmYf5nfHcKN8jaFPz3GOjguw/yPbvK2gLFVvlPO4Ri1Ydk70Lp7IhpdPGhs12u15/j89f+1z7yVKKW4HkrWKsHPWcXALdnAEMvlytBYw9FVV6mp8N8YIZyuabVhQtseoWXNUoKyDmkvNnLO6L4CDs6/cQcqniTJB8UYuP788W42ik2Qok/O+nL87YzOhpfhdFoO3aWj0aj9g8JFErQjNBcfzhuBdC2nrSTDz28Yq4mgau9KdvDfcnZwkzQiSlR1SxMfR4/gktq6MzK5KoIF0LOtrxJMv2nrIid1fCUzYiaAlQlPZxKqK79+mU0cExiHrfOO0kvJkdrkifHM5MakvoVsHqBLq2fOU4RSbJttPDtLzvcZhhzuHeINwMdHQYIzsQCOC5yQuFPXkYqn8mc2kGcgUv2cV88yoM8jIz3oIcwKI2fvXmQkQF7sLcJPRGCUxuqpp+k8tZ7uWopkK8o6tSBkO/FL9oPhRTCMV9DzQesn47dR/H2dVl6fb3qguxuXGSqgH0C7L3KWeqZZ/Xf34L/rHvm6c87HahEK3o8ujCcbdDOok0G9FulSQKtK9f/3ITkDKTr0xAmKHdXn9i2jYwMDl69/BpuIf2g5uIWPsW/MXzsu7J8GmV7eqfpeM3UYs0TYAf5C20elCSWWBfVy7MPVb/0RWqC78bu193WiUAlnPHHZUXEqRxo3rxAzpkullLP1/A101RcDc9oKug608A+4pQve05/a9aaupeDXtNQHi06rxxEBESzpZthAlXSEj0M5qWd4AAtPG+HJCVehLnWJ5QWvMd6Drg8TYUSguk6FG7HFJvo++jK6+Ry4yQjlS0gbQMLldUpaq1iRw2WWSMgrYWIfqNtPLdwINokK6BkFqhCYUkxgIA5kyZo/dSNP PyKQdxAT 7bsMUAh8GlAX1aA+r13p6AWgBmT3BAGM5xkPnTP6D81Mx6he02X9Pj2Dn3vWQXQbMrt3kBiPP7V6MsPylHwbfzTQkCBDb1lc2YEh6isfF6tULS3BGFffWUstssyNnroIuuPtynXv4z0kWGAJ4fWvrQw7rO6Oy1C7PwErLhfgC8gZXbxGWOGl1kfF2i+sOO8jof466 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: v7 updates: - Rebased patchset to v6.11.0-rc1 - Removed ia32 and x32 function interface changes as PKRU is only supported in 64-bit mode, as suggested by Jeff Xu v6 updates: - Rebased patchset to v6.10.0-rc5 - Changed sig_prepare_pkru() back to enabling all pkeys, based on discussion with Jeff Xu v5 updates: - No major changes, mostly a resend of v4 - except for updating the commit description for patch 5/5 v4 updates (based on review feedback from Thomas Gleixner): - Simplified update_pkru_in_sigframe() - Changed sigpkru to enable minimally required keys (init_pkru and current pkru) - Modified pkey_sighandler_tests.c to use kselfttest framework - Fixed commit descriptions - Fixed sigreturn use case (pointed out by Jeff Xu) - Added a new sigreturn test case v3 updates (based on review feedback from Ingo Molnar and Dave Hansen): - Split the original patch into 3: - function interface changes - helper functions - functional change to write pkru on sigframe - Enabled all pkeys before XSAVE - i.e. wrpkru(0), rather than assuming that the alt sig stack is always protected by pkey 0. - Added a few test cases in pkey_sighandler_tests.c. I had some trouble adding these tests to tools/testing/selftests/mm/protection_keys.c, so they're in a separate file. Aruna Ramakrishna (4): x86/pkeys: Add PKRU as a parameter in signal handling functions x86/pkeys: Add helper functions to update PKRU on the sigframe x86/pkeys: Update PKRU to enable all pkeys before XSAVE x86/pkeys: Restore altstack before sigcontext Keith Lucas (1): selftests/mm: Add new testcases for pkeys arch/x86/include/asm/fpu/signal.h | 2 +- arch/x86/kernel/fpu/signal.c | 27 +- arch/x86/kernel/fpu/xstate.c | 13 + arch/x86/kernel/fpu/xstate.h | 2 + arch/x86/kernel/signal.c | 29 +- arch/x86/kernel/signal_64.c | 6 +- tools/testing/selftests/mm/Makefile | 2 + tools/testing/selftests/mm/pkey-helpers.h | 11 +- .../selftests/mm/pkey_sighandler_tests.c | 479 ++++++++++++++++++ tools/testing/selftests/mm/protection_keys.c | 10 - 10 files changed, 560 insertions(+), 21 deletions(-) create mode 100644 tools/testing/selftests/mm/pkey_sighandler_tests.c base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b prerequisite-patch-id: 7b2144970da943b19b53baab525a0fc653fcd7b8