From patchwork Fri Aug 2 20:31:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jann Horn X-Patchwork-Id: 13751970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28B42C3DA4A for ; Fri, 2 Aug 2024 20:32:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 701466B00AF; Fri, 2 Aug 2024 16:32:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AF906B00B0; Fri, 2 Aug 2024 16:32:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 550B36B00B1; Fri, 2 Aug 2024 16:32:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3509B6B00AF for ; Fri, 2 Aug 2024 16:32:17 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9EA1B120D60 for ; Fri, 2 Aug 2024 20:32:16 +0000 (UTC) X-FDA: 82408452672.08.1860AAE Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf10.hostedemail.com (Postfix) with ESMTP id A3EF8C0008 for ; Fri, 2 Aug 2024 20:32:14 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DmgYYY9m; spf=pass (imf10.hostedemail.com: domain of jannh@google.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=jannh@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722630676; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=9tpvdJVeACeB5qkpDGLZPHMZmPZisvxXSMDixUJOlJA=; b=GVv+OjE1y+8j6uxQLjdFOAVB0qnoMxljRK6QnfQgvSaMssQduPVg3Q5IgXNmlN8ZfsMcw9 ee2mkNApb3VniXfONYqUSvCpBGf9k52X9xBaHlzbwVgWFDkGPwX8p6i0l7GIriaDVG11kp zqccIkTScPtAWtdeJTJMTANfmX5PHMY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722630676; a=rsa-sha256; cv=none; b=q/dRZE3G6au/IiQRmnIQbQQ4k/cc8QcOWIA2TJ3SkOwIE7tewOUhKibe5AHzDO/Zk6JKAw Io6GtYOK6D+Ios033+mpD2r5RchKtG77GOGMlUk5ivASzvDugztCrbjYGYPtZy1wf556wp T6+2edEgc/kQaED7f3t62qxky8LKqOM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DmgYYY9m; spf=pass (imf10.hostedemail.com: domain of jannh@google.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=jannh@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5a869e3e9dfso60243a12.0 for ; Fri, 02 Aug 2024 13:32:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1722630733; x=1723235533; darn=kvack.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=9tpvdJVeACeB5qkpDGLZPHMZmPZisvxXSMDixUJOlJA=; b=DmgYYY9mCPbUnMv81gyCMATQONH1qAnywMNuMhfzLUQgD8V58Rnlx+5KQb9FA4svi5 1r16Ddc6Bm86RmDPCbyUEx1FCdz2pwJHtmAl5kgNZe2LSH5wLX6MkXr1i4BRZH7R2MsN O2Lq62ExHEQtpQg62ly99CMWnSNnIeL9bVlykoJDqBbCZ+MT/C1Qom6lhVtd/N8ysFF/ KjdRFROdXhGYV53e+w/zt2EDXDPOH0Qr8rA1k9ZiqkWsP5vcGsb7bFX0KLfOOM/2tcTp BbvvkVekeu9orZT2l/OCuiSTuJm2DN3bHVYUjEYkcvU4aG6vrGM1UhRYMv+/FgsoeAfk OSIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722630733; x=1723235533; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9tpvdJVeACeB5qkpDGLZPHMZmPZisvxXSMDixUJOlJA=; b=hqTXe53CrJpMh3kJx7n1Wnlx1F87lQM7vCXuAoD83F2/PtPQuvvgGxAUn9No7arcxa 1B5572MaNQa56rIgtpzA4wGm4dfufvA90kc3a5ZVCZXXOHA+0+vdkvepHTQcQ6r4u0go x3+pZFLWRPWsHWETjm6UtwmhhCDNc/ta6fccnXsEdLUHdhCiqlwQyxJL5gEWIsjIwu9G ezgw07z+ZMCY11FmAh/2nHCdF9rOc3xRybhWQoTXowTPTkvQChYDaBvDvIoQ7vSxVphr lT6dpmOII4FX7sIz0iykkyC8/yMJDFW5V2IU6+jMju8sXjTuS7IBTxjiVAqAlxZnFqGY 7/2A== X-Forwarded-Encrypted: i=1; AJvYcCVi1A6FLN0Xncczw1vRvzPKyGtRrdRKc3Z5x+TKMWlCFSKPU9iUs2aWCoDRCYpa7shMeUd4A3svw8aYK331HEknmFg= X-Gm-Message-State: AOJu0YxwLZptyTU1JJDQRbF1BK1HPDSkukbCUeR6jJSDW1rg/989tVgh ZAj9mCY0p0PBrsK1xmI0JB8zQtuvTXGM4gmDpRvGq8byfmYrILIYZxTiHv3Oeg== X-Google-Smtp-Source: AGHT+IFKezzjniHDzNfK5lWdIyO0mUIv4bFhFicChoUyM/ZhxnkL4BLuHlX8swJTNNcyIPpAo2eTDw== X-Received: by 2002:a05:6402:2816:b0:58b:b1a0:4a2d with SMTP id 4fb4d7f45d1cf-5b9bebbc4ebmr17961a12.1.1722630732323; Fri, 02 Aug 2024 13:32:12 -0700 (PDT) Received: from localhost ([2a00:79e0:9d:4:9337:bd1:a20d:682d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36bbd26fc0bsm2700267f8f.117.2024.08.02.13.32.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Aug 2024 13:32:11 -0700 (PDT) From: Jann Horn Subject: [PATCH v6 0/2] allow KASAN to detect UAF in SLAB_TYPESAFE_BY_RCU slabs Date: Fri, 02 Aug 2024 22:31:52 +0200 Message-Id: <20240802-kasan-tsbrcu-v6-0-60d86ea78416@google.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIADhCrWYC/2XOTQrCMBCG4atI1kbyn9SV9xAX7TRpg9pIokGR3 t1UEGq7/Aael3mjZKO3Ce03bxRt9smHoQy13SDo66Gz2LdlI0aYIJpxfK5TPeB7aiI8cKOprCt CndYKFXKL1vnnN3c8ld37dA/x9a1nNl1/IfEfygwTLKQzlSFKCGUOXQjdxe4gXNFUynyu5ULzo iWFijnjKCV0pcVcVwstJq0tGGmdIaBWWs40Jwstp89Ny6FpHQDIPz2O4wfi2NX6YwEAAA== To: Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Marco Elver , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jann Horn , syzbot+263726e59eab6b442723@syzkaller.appspotmail.com X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1722630727; l=6723; i=jannh@google.com; s=20240730; h=from:subject:message-id; bh=6m7b7k4S8KWZIyDEYtTqqzHl0D1lSK3y59XxPtdM71k=; b=ROnheg8tvs64V5aBE3C/N6iTsCrkOSnws3DYdQsxny3FmQBfdmH9iXSA+l0ZCG8iSfWllv24d WhfHmS099E8AKLS35y3E0a7JdnTW9eV4R7Oq5fL43NvVgOV2T/6Tl+v X-Developer-Key: i=jannh@google.com; a=ed25519; pk=AljNtGOzXeF6khBXDJVVvwSEkVDGnnZZYqfWhP1V+C8= X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A3EF8C0008 X-Stat-Signature: kok1zbps4838ty3xg5otj6hpyuuja5du X-HE-Tag: 1722630734-682506 X-HE-Meta: U2FsdGVkX18oSPVl4EPYB+O2qie9cIXV8OMu1StE2Bl+Pc6cov/mWIAe8G848MsmmTAmjoa0nWw/Wz4Ezfz8dEtZDcXtYMJM8rB1nOoYL8a/7C8Pp2MFVdrGT+mRxcZ8B5/6oB6gAP0ellpWKsl3hvDc3eotDJMO1jUil3q30ldhZ/eFQacX2mIYq//KdM/1wNhyDtcdR/rnpdxJKFIuIzmcGqwqU1WVXXlpZatSRBgSQdzYQCDzbZOauUrG+BdVsKLHaTpxNUn2V8ECK7lciBmpwmO3fXxtKXuIAnirjrMpoIvmQV9RjBtXbbcrtP5ioPl9Abrp2BxD+qywiWY8qVUx8aBncmg2EBdsBevoOeIQCYjDweO6yR+tezYQh67fmxkchLOOLtFWLyYXlCeIBxeDxJBoQVFy3bFOn/zeWLsb2KSjRBPmRgWLo7M9GH+uBWW6+EoXOorkkAazhpV6oTfDdbsbiCFdDF87/MZr21neBw8AeuUqBYGNxbOLAfJJV6wWeQWsmVTIFlvvB65hzI+dx41DGv1Tz7z2oUp/1EPHpZRSTBUQwZR0NswLY8232xJwcq4wTSs7Z5fb4eembFV6ZU9Ct3azcGVEFzWrQX2sdas5ZFK2oQISWnesZq3ARCiCVs/hi8OWOcUXJcqyb9JptW/ii/yLlqHAvoMoyvt1a4f87oWR6Me6uGY2QKlFAhRYkPf/LmXA4HCCzxbGz7C6tTirRikC1T/TJ1M6PJqMU3MHQkVPNcszYi31PqV2Uowez/XIAdsVvRrDFWMHbSW2/9dDyB+s5mj8Dc1JtYk4Zht7UNfMb+kbf6eqgWf+85Uig+c1CNlMM8yytCxWYhwLIeSzYvGOX1BYg/pefuASV4DYvM3Hl24/N6qVaxk4cKp3qcQoVepWxH9B+2hNPTQoOP8JDsF6YSF4EHA9MPmRnfk+EIZMpSKQqPCsUgS7XwePxTFlzJxMw3Vd0bA Pmiet5IO ojd0cyF4L6DdEFRXJgXHqkeh4cgj1Fy2H+8I8J/AzKEDr93Wm9sP7CvxsCjW6sSrgTgu6kJBiHdIDsIrPuQzcMToRjxC396HE5i/uyFymSFYdCVRWl61DOd2SCSe1vIW8RVYgW9BtMn7em1pQAyAR2oYKPb+cJ5bAVV5tA/Bwd7YZvSlgXvmbhnvWQR0FEOHlr0GRs9HPCNCG417fyUjj3ZvZtA8FlHL+v6mRko1zIGoPjltbBn2CgNmllxejQ7W8YaUkJ8f/KswzBcMHdvwg46cyMk46heL1yACCgYGO8pJQH72RtY+j/tXztGznzCwoH7Cqao0CWYAgIYsumeO2yVCGnXgG83VNnWn8QIxFf8eKXKZXs5DOmg/s2gL+b1ROKwObIYbrnr1TUXYxdgMx8taGp19rkgt6iDsEsudukcD6YnJrmk2tj8aIbxhytSvlQCP9axorY5oWwR3akWOVLOQAbmT9t8iXdtwmna4pEMTpAkuj2relmQY9bA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi! The purpose of the series is to allow KASAN to detect use-after-free access in SLAB_TYPESAFE_BY_RCU slab caches, by essentially making them behave as if the cache was not SLAB_TYPESAFE_BY_RCU but instead every kfree() in the cache was a kfree_rcu(). This is gated behind a config flag that is supposed to only be enabled in fuzzing/testing builds where the performance impact doesn't matter. Output of the new kunit testcase I added to the KASAN test suite: ================================================================== BUG: KASAN: slab-use-after-free in kmem_cache_rcu_uaf+0x3ae/0x4d0 Read of size 1 at addr ffff888106224000 by task kunit_try_catch/224 CPU: 7 PID: 224 Comm: kunit_try_catch Tainted: G B N 6.10.0-00003-g065427d4b87f #430 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 Call Trace: dump_stack_lvl+0x53/0x70 print_report+0xce/0x670 [...] kasan_report+0xa5/0xe0 [...] kmem_cache_rcu_uaf+0x3ae/0x4d0 [...] kunit_try_run_case+0x1b3/0x490 [...] kunit_generic_run_threadfn_adapter+0x80/0xe0 kthread+0x2a5/0x370 [...] ret_from_fork+0x34/0x70 [...] ret_from_fork_asm+0x1a/0x30 Allocated by task 224: kasan_save_stack+0x33/0x60 kasan_save_track+0x14/0x30 __kasan_slab_alloc+0x6e/0x70 kmem_cache_alloc_noprof+0xef/0x2b0 kmem_cache_rcu_uaf+0x10d/0x4d0 kunit_try_run_case+0x1b3/0x490 kunit_generic_run_threadfn_adapter+0x80/0xe0 kthread+0x2a5/0x370 ret_from_fork+0x34/0x70 ret_from_fork_asm+0x1a/0x30 Freed by task 0: kasan_save_stack+0x33/0x60 kasan_save_track+0x14/0x30 kasan_save_free_info+0x3b/0x60 __kasan_slab_free+0x57/0x80 slab_free_after_rcu_debug+0xe3/0x220 rcu_core+0x676/0x15b0 handle_softirqs+0x22f/0x690 irq_exit_rcu+0x84/0xb0 sysvec_apic_timer_interrupt+0x6a/0x80 asm_sysvec_apic_timer_interrupt+0x1a/0x20 Last potentially related work creation: kasan_save_stack+0x33/0x60 __kasan_record_aux_stack+0x8e/0xa0 kmem_cache_free+0x10c/0x420 kmem_cache_rcu_uaf+0x16e/0x4d0 kunit_try_run_case+0x1b3/0x490 kunit_generic_run_threadfn_adapter+0x80/0xe0 kthread+0x2a5/0x370 ret_from_fork+0x34/0x70 ret_from_fork_asm+0x1a/0x30 The buggy address belongs to the object at ffff888106224000 which belongs to the cache test_cache of size 200 The buggy address is located 0 bytes inside of freed 200-byte region [ffff888106224000, ffff8881062240c8) The buggy address belongs to the physical page: page: refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x106224 head: order:1 mapcount:0 entire_mapcount:0 nr_pages_mapped:0 pincount:0 flags: 0x200000000000040(head|node=0|zone=2) page_type: 0xffffefff(slab) raw: 0200000000000040 ffff88810621c140 dead000000000122 0000000000000000 raw: 0000000000000000 00000000801f001f 00000001ffffefff 0000000000000000 head: 0200000000000040 ffff88810621c140 dead000000000122 0000000000000000 head: 0000000000000000 00000000801f001f 00000001ffffefff 0000000000000000 head: 0200000000000001 ffffea0004188901 ffffffffffffffff 0000000000000000 head: 0000000000000002 0000000000000000 00000000ffffffff 0000000000000000 page dumped because: kasan: bad access detected Memory state around the buggy address: ffff888106223f00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ffff888106223f80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc >ffff888106224000: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ^ ffff888106224080: fb fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc ffff888106224100: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ================================================================== ok 38 kmem_cache_rcu_uaf Signed-off-by: Jann Horn --- Changes in v6: - in patch 1/2: - fix commit message (Andrey) - change comments (Andrey) - fix mempool handling of kfence objects (Andrey) - in patch 2/2: - fix is_kfence_address argument (syzbot and Marco) - refactor slab_free_hook() to create "still_accessible" variable - change kasan_slab_free() hook argument to "still_accessible" - add documentation to kasan_slab_free() hook - Link to v5: https://lore.kernel.org/r/20240730-kasan-tsbrcu-v5-0-48d3cbdfccc5@google.com Changes in v5: - rebase to latest origin/master (akpm), no other changes from v4 - Link to v4: https://lore.kernel.org/r/20240729-kasan-tsbrcu-v4-0-57ec85ef80c6@google.com Changes in v4: - note I kept vbabka's ack for the SLUB changes in patch 1/2 since the SLUB part didn't change, even though I refactored a bunch of the KASAN parts - in patch 1/2 (major rework): - fix commit message (Andrey) - add doc comments in header (Andrey) - remove "ip" argument from __kasan_slab_free() - rework the whole check_slab_free() thing and move code around (Andrey) - in patch 2/2: - kconfig description and dependency changes (Andrey) - remove useless linebreak (Andrey) - fix comment style (Andrey) - fix do_slab_free() invocation (kernel test robot) - Link to v3: https://lore.kernel.org/r/20240725-kasan-tsbrcu-v3-0-51c92f8f1101@google.com Changes in v3: - in patch 1/2, integrate akpm's fix for !CONFIG_KASAN build failure - in patch 2/2, as suggested by vbabka, use dynamically allocated rcu_head to avoid having to add slab metadata - in patch 2/2, add a warning in the kconfig help text that objects can be recycled immediately under memory pressure - Link to v2: https://lore.kernel.org/r/20240724-kasan-tsbrcu-v2-0-45f898064468@google.com Changes in v2: Patch 1/2 is new; it's some necessary prep work for the main patch to work, though the KASAN integration maybe is a bit ugly. Patch 2/2 is a rebased version of the old patch, with some changes to how the config is wired up, with poison/unpoison logic added as suggested by dvyukov@ back then, with cache destruction fixed using rcu_barrier() as pointed out by dvyukov@ and the test robot, and a test added as suggested by elver@. --- Jann Horn (2): kasan: catch invalid free before SLUB reinitializes the object slub: Introduce CONFIG_SLUB_RCU_DEBUG include/linux/kasan.h | 63 ++++++++++++++++++++++++++++++++++--- mm/Kconfig.debug | 30 ++++++++++++++++++ mm/kasan/common.c | 62 ++++++++++++++++++++++--------------- mm/kasan/kasan_test.c | 46 +++++++++++++++++++++++++++ mm/slab_common.c | 12 +++++++ mm/slub.c | 86 ++++++++++++++++++++++++++++++++++++++++++++++----- 6 files changed, 261 insertions(+), 38 deletions(-) --- base-commit: 94ede2a3e9135764736221c080ac7c0ad993dc2d change-id: 20240723-kasan-tsbrcu-b715a901f776