[v2,0/4] memcg: initiate deprecation of v1 features

Message

Shakeel Butt Aug. 14, 2024, 10 p.m. UTC

Let start the deprecation process of the memcg v1 features which we
discussed during LSFMMBPF 2024 [1]. For now add the warnings to collect
the information on how the current users are using these features. Next
we will work on providing better alternatives in v2 (if needed) and
fully deprecate these features.

Link: https://lwn.net/Articles/974575 [1]

Shakeel Butt (4):
  memcg: initiate deprecation of v1 tcp accounting
  memcg: initiate deprecation of v1 soft limit
  memcg: initiate deprecation of oom_control
  memcg: initiate deprecation of pressure_level

Changes since v1:
- Fix build (T.J. Mercier)
- Fix documentation

 .../admin-guide/cgroup-v1/memory.rst          | 32 +++++++++++++++----
 mm/memcontrol-v1.c                            | 16 ++++++++++
 2 files changed, 42 insertions(+), 6 deletions(-)

Comments

Michal Hocko Aug. 15, 2024, 6:29 a.m. UTC | #1

On Wed 14-08-24 15:00:17, Shakeel Butt wrote:
> Let start the deprecation process of the memcg v1 features which we
> discussed during LSFMMBPF 2024 [1]. For now add the warnings to collect
> the information on how the current users are using these features. Next
> we will work on providing better alternatives in v2 (if needed) and
> fully deprecate these features.
> 
> Link: https://lwn.net/Articles/974575 [1]

Acked-by: Michal Hocko <[e-mail]>

I will add these to our SLES kernels to catch our distribution users.

Thanks!

> 
> Shakeel Butt (4):
>   memcg: initiate deprecation of v1 tcp accounting
>   memcg: initiate deprecation of v1 soft limit
>   memcg: initiate deprecation of oom_control
>   memcg: initiate deprecation of pressure_level
> 
> Changes since v1:
> - Fix build (T.J. Mercier)
> - Fix documentation
> 
>  .../admin-guide/cgroup-v1/memory.rst          | 32 +++++++++++++++----
>  mm/memcontrol-v1.c                            | 16 ++++++++++
>  2 files changed, 42 insertions(+), 6 deletions(-)
> 
> -- 
> 2.43.5

Roman Gushchin Aug. 15, 2024, 7:27 p.m. UTC | #2

On Wed, Aug 14, 2024 at 03:00:17PM -0700, Shakeel Butt wrote:
> Let start the deprecation process of the memcg v1 features which we
> discussed during LSFMMBPF 2024 [1]. For now add the warnings to collect
> the information on how the current users are using these features. Next
> we will work on providing better alternatives in v2 (if needed) and
> fully deprecate these features.
> 
> Link: https://lwn.net/Articles/974575 [1]
> 
> Shakeel Butt (4):
>   memcg: initiate deprecation of v1 tcp accounting
>   memcg: initiate deprecation of v1 soft limit
>   memcg: initiate deprecation of oom_control
>   memcg: initiate deprecation of pressure_level

I have a hope that we can deprecate memcg v1 altogether, but having more
information about specific v1 users won't hurt.

Acked-by: Roman Gushchin <[e-mail]>

Thanks!