From patchwork Mon Aug 19 21:35:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Maurer X-Patchwork-Id: 13769021 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D3CBC52D7C for ; Mon, 19 Aug 2024 21:35:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D0C36B0083; Mon, 19 Aug 2024 17:35:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 081336B0085; Mon, 19 Aug 2024 17:35:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB1E46B0088; Mon, 19 Aug 2024 17:35:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CBBFA6B0083 for ; Mon, 19 Aug 2024 17:35:44 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 41CFF1215B1 for ; Mon, 19 Aug 2024 21:35:44 +0000 (UTC) X-FDA: 82470302208.02.0D9B4E1 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf20.hostedemail.com (Postfix) with ESMTP id 784461C0016 for ; Mon, 19 Aug 2024 21:35:42 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=xoHPfRPl; spf=pass (imf20.hostedemail.com: domain of 3rbrDZgcKCG4YYMgdQdSaaSXQ.OaYXUZgj-YYWhMOW.adS@flex--mmaurer.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3rbrDZgcKCG4YYMgdQdSaaSXQ.OaYXUZgj-YYWhMOW.adS@flex--mmaurer.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724103265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=NHr+d6UmIU/9IG30FNpxZ6Aa0eu/YiD/uhxdbWXAtq0=; b=Z8okRGFNoZzH+/pXAHJdyFRIHAkrRPjQ/JLTOBqqVTkCTxR+bfeKGlWVReK1AFW8irqObW 61EFIPCVKAf57Jnl4AynHt9VbxyV/YUusaelUYfUw//I4i9+difArtuc0JZNShrI9NPBAk TmZ7Kr28UCohmOMAerSoc/VCr+SPCSg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724103265; a=rsa-sha256; cv=none; b=1y4xKnU8mWrrmHetWnl8WKaYNNEN2BcMBifo+rDc4LD9WYaF2ri5tgh9ac735MjuuN0ykI OYpaE1/Mq5EmRf/XiPb+QwPerHiQJZKTsHsNOmDY3aPFkuizb0vmg8ibqlbgtnVar7+VzC RbRZtT268eSXjagitkpdSp5i96zdMdo= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=xoHPfRPl; spf=pass (imf20.hostedemail.com: domain of 3rbrDZgcKCG4YYMgdQdSaaSXQ.OaYXUZgj-YYWhMOW.adS@flex--mmaurer.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3rbrDZgcKCG4YYMgdQdSaaSXQ.OaYXUZgj-YYWhMOW.adS@flex--mmaurer.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-6b71aa9349dso32994417b3.1 for ; Mon, 19 Aug 2024 14:35:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724103341; x=1724708141; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=NHr+d6UmIU/9IG30FNpxZ6Aa0eu/YiD/uhxdbWXAtq0=; b=xoHPfRPlyqmsxkQpWUYXwldf2RLYZiRZxTYhRSyHNNjZqiLkJbhMtEt6EMopGJPfC+ vx6c/bCQA+CC2Ihe6Yrx7Ygv2xlKF1yEYsLL2j45bC1xlY9RIKengPC/KP0lk09ElW9I cL3gCvSyn6PHFEjMtECy8u1iq2nL+lhWZ4SKPbR7Jm2tOXHuePTIfw831w2MVtjCLy8e Rkj72op5MYtvwE8RNxwUBkgDUNSvEsQTTER4RlOGMz6j97/Di5Is39DHYAKO8t0ImhDc dVU2NOXHl9oUJ1tGAqJ88WbXdyhdBEzUEpSlrdWv9mqKd2DRXAiQVyy2Nzne7kEnI+Vq M+4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724103341; x=1724708141; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NHr+d6UmIU/9IG30FNpxZ6Aa0eu/YiD/uhxdbWXAtq0=; b=FepagJyvCLhpZpcLrev4895Dw09T1CioRj90FPiYDydQf3o3FkqkUulfy0fcHt8D6R SEDrDhlR+alA8Jrn0nZQ+3PMaI+G9doPiGKfiIt++ajq1LlgngmPW+fM4fcBwiAbKIo0 mzIRJylahWV9icLP65DZe8G9gvPWxOUO67iW++CNlSioiysQz5RlPIcRJ6XMS3DEB/H6 K8mIzDZWcX00cNclbwkfWvPLmrt0djCHyrZ0mA2aq+Xr3VO9KUITEfBpzv9FzWRRsRII Eo/d9ByQYmrcckKTLXMlXDhw615a+V8KlPXFayRTc+62WELTUENBDutl4oS7IzZmEtNb 1mxQ== X-Forwarded-Encrypted: i=1; AJvYcCULmQDWufOIA/qC/HQgLQ8eJzrWfaBBQHo7mS7zeTLH6BuWVIvQkmUP6st2NfCwciZysSreCpq6Jw==@kvack.org X-Gm-Message-State: AOJu0YywVMtIJKK0Cd82jpUstlQXUv56D5ZVc1xPtlSOcxN2H2krrjjg He6cdT5DQzo5xRY/EnxWAQpnSnYmuh2w9EpX8bH9SMeh+oxP0JsNB3Om9d4DahCOSrVk0XJo7uZ V2fCtzA== X-Google-Smtp-Source: AGHT+IFPFz0ZC/TObmbtIW+FNYagPR0uj4bw/LTpIWyJXejA9x5eEzGFXKmI7mbSTIJ28oCMdsYOHWMIix2S X-Received: from anyblade.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:1791]) (user=mmaurer job=sendgmr) by 2002:a05:690c:688d:b0:69f:9a1d:a04e with SMTP id 00721157ae682-6b1bb099b4fmr445507b3.4.1724103341547; Mon, 19 Aug 2024 14:35:41 -0700 (PDT) Date: Mon, 19 Aug 2024 21:35:18 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.46.0.184.g6999bdac58-goog Message-ID: <20240819213534.4080408-1-mmaurer@google.com> Subject: [PATCH v3 0/4] Rust KASAN Support From: Matthew Maurer To: dvyukov@google.com, ojeda@kernel.org, andreyknvl@gmail.com, Alex Gaynor , Wedson Almeida Filho , Nathan Chancellor Cc: aliceryhl@google.com, samitolvanen@google.com, kasan-dev@googlegroups.com, linux-mm@kvack.org, glider@google.com, ryabinin.a.a@gmail.com, Matthew Maurer , Boqun Feng , Gary Guo , " =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= " , Benno Lossin , Andreas Hindborg , Nick Desaulniers , Bill Wendling , Justin Stitt , rust-for-linux@vger.kernel.org, llvm@lists.linux.dev X-Rspamd-Queue-Id: 784461C0016 X-Stat-Signature: jeehe4puzjoyubkb7gqwogmcc4kda95e X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1724103342-384324 X-HE-Meta: U2FsdGVkX19pLTSzq0Lf5qXjbVasNUQH32TdnxS/lmIX5bXynLH3dnIIW/mogdCdTuY+cf5lxgOf51XWq1l/ciSMfZFNnz59F172AJud1vYxBf2eursZQw0eYV6XsL8XUF6aG60DOZkAW2N0MALttihxjuUJL+M7YRghD4kEbgHztIJGlrwifoN9AWQ82utFii9JYQs8s21vSODiidb9zs4SEjnKX0kPRKOJFcpGpR0wLZqW6I+L5TC49kjaeFcQPLEaS05scEZAcW4WHJzNTCddXIEsjEfEROOIkpZwm0FJp/76IOAUpD5T/88yP3SOJY6fmepr1y9Q92FEMNgAzD6o0DkvrOAPjtPb0KBB0foaOnmS9s+f4ibpd+HuqP5MKb9FFSRBnby2Kogw2oDfBDcPuT+sSOl8Uq2AY8b72FZ2qoDid7Qtveabf415jfD4+96gcIQflYZoUDlYf9yhb9saLQ6S6+DiIJJ3DhjMd1nrTttBwYg9Tki4ijlQBpkkm05oQQGKfzIumwq9Ag8vkyecEeTs4yRv+akXPmKcigfi8yl9jP0S3oEMByvXwWbe0eIXLkc8oQcUG/KIal1/SM/OtO3L2GizqU4kDZlHJzMIYmsvpmFn8tXjm/f1pOI4qGyxcjseUmc5i/7ElrZEbGSUPFnvgu4WYoRfSAxwoNZ1hR7NqQSVuhVB82BocpsiBhgdva0wk7STKWAEi8aSj9+2SqDveVNAORvcArM9/0v7UccXhF07vOBeNVDOvbY+VrGaiSepu+BENENoJS4JNS7kSRGn//GcEHyBuWfcxwNwsAXDt2rS+ZlsZV+gyQVMbDZ+KocfTBb6tUzft4FbcNzrax7dHhpqXlU1tT8BwSSw+ER+bUBlUEPjIhAOjdKq4RYRis0fy2XSoD06/+d3vo24anMKRjoFiKMjsY/7LNy81LNxIHmury/qxE9qbfHZ3qJzkYKh/1uHlOW3H3N gs4Fmo8K f2tPXZOI/eAH3PF719nDG5qs3i8F52swlDwIOhQHhkJtjzCX+mxtUGbA8nc+wDn+K9EE5XkI7WU7wgYuf0+4C6G8lAQUvc+JmJoYltUBAtHFevING/+t8y34S3DSbyvfOQXtfbvY2Ankg2TKG7yjA2lGdkOUx7thRl4ZVT4q3uvJWnLeeer+tVJCU7LOBeR9W7+gT5WjVKoNaC3xp7hKE1eIX65NBqvMS16o63+WsIV1WCFiZSv8jhE5d/C6lORwNqXlHxWLLVfZAKfWDJ/UCkuR5BaoeybQPeNRI1cHxR//P+CPZN4UogV64IWYIiz5mWPGhpW9WJWW6THjsEfdFmK/TbD/b4k7afjjUbxXYmMiTnaFnOiCMnly7iyI3zlqCTI+mWPHTkW7CUfG0Q8D+e2uKEpHJq/nUdCWgeJITAZJLwBxcS62odw6LW/bnZ6fE5qTuDTw4MYv8k/Rp3p5KcCa5+REfRhBKRtlYOmbNW1S2vpm5tPsBXgSVadVRHu6IOcF/8I0WIp9ysXFZ2jqk6zYXvI8yregq7brQe3YYvPd8yKr4hyJdALb3h4KdnnDqUxBp6JDzOjE/Nva4/Qjo2VYmJSMtiBjRBcegDNzTo4gz2r5CRSdtFuiZeH07Bmm+jGyFg5TZFHRON7Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Right now, if we turn on KASAN, Rust code will cause violations because it's not enabled properly. This series: 1. Adds flag probe macros for Rust - now that we're setting a minimum rustc version instead of an exact one, these could be useful in general. We need them in this patch because we don't set a restriction on which LLVM rustc is using, which is what KASAN actually cares about. 2. Makes `rustc` enable the relevant KASAN sanitizer flags when C does. 3. Adds a smoke test to the `kasan_test` KUnit suite to check basic integration. This patch series requires the target.json array support patch [1] as the x86_64 target.json file currently produced does not mark itself as KASAN capable, and is rebased on top of the KASAN Makefile rewrite [2]. Differences from v2 [3]: 1. Rebased on top of the maintainer's cleanup of the Makefile. 2. Cleaned up the UaF test based on feedback. 3. Calls out that KASAN_SW_TAGS is not yet supported in the config. The notable piece of feedback I have not followed is in the renaming of kasan_test.c to kasan_test_c.c - this was done in order to allow the module to be named kasan_test but consist of two .o files. The other options I see are renaming the test suite or creating a separate Rust test suite, but both of those seemed more invasive than the rename. Let me know if you have another approach you'd prefer there. [1] https://lore.kernel.org/lkml/20240730-target-json-arrays-v1-1-2b376fd0ecf4@google.com/ [2] https://lore.kernel.org/all/20240813224027.84503-1-andrey.konovalov@linux.dev [3] https://lore.kernel.org/all/20240812232910.2026387-1-mmaurer@google.com/ Matthew Maurer (4): kbuild: rust: Define probing macros for rustc kbuild: rust: Enable KASAN support rust: kasan: Rust does not support KHWASAN kasan: rust: Add KASAN smoke test via UAF init/Kconfig | 1 + mm/kasan/Makefile | 9 +++- mm/kasan/kasan.h | 1 + mm/kasan/{kasan_test.c => kasan_test_c.c} | 11 +++++ mm/kasan/kasan_test_rust.rs | 19 ++++++++ scripts/Kconfig.include | 8 ++++ scripts/Makefile.compiler | 15 +++++++ scripts/Makefile.kasan | 54 ++++++++++++++++------- scripts/Makefile.lib | 3 ++ scripts/generate_rust_target.rs | 1 + 10 files changed, 105 insertions(+), 17 deletions(-) rename mm/kasan/{kasan_test.c => kasan_test_c.c} (99%) create mode 100644 mm/kasan/kasan_test_rust.rs