| Message ID | 20240924123954.18933-1-richard.weiyang@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | cleanup maple_alloc related functions | expand |
On Tue, Sep 24, 2024 at 12:39:50PM GMT, Wei Yang wrote: > Patch 1/2: some fields of the maple_alloc is not necessary to change, so we > can skip some operations > Patch 3: a valid alloc check could be hide in current code, so we don't need > to do a separate check > Patch 4: found on rare case where allocation would fail even has enough > memory > > Wei Yang (4): > maple_tree: clear request_count for new allocated one > maple_tree: total is not changed for nomem_one case > maple_tree: simplify mas_push_node() > maple_tree: fix potential allocation failure even has memory > > lib/maple_tree.c | 26 ++++++++++++-------------- > 1 file changed, 12 insertions(+), 14 deletions(-) > > -- > 2.34.1 > > Andrew - Liam is away at the moment - could we hold off on taking this series to unstable until he's back and had a chance to review please? It may be best to avoid taking maple tree changes other than urgent bug fixes or the like until his return also. Wei - please hold off on series like this until Liam's had a chance to reply to this thread. Thanks!
On Tue, Sep 24, 2024 at 04:03:35PM +0100, Lorenzo Stoakes wrote: >On Tue, Sep 24, 2024 at 12:39:50PM GMT, Wei Yang wrote: >> Patch 1/2: some fields of the maple_alloc is not necessary to change, so we >> can skip some operations >> Patch 3: a valid alloc check could be hide in current code, so we don't need >> to do a separate check >> Patch 4: found on rare case where allocation would fail even has enough >> memory >> >> Wei Yang (4): >> maple_tree: clear request_count for new allocated one >> maple_tree: total is not changed for nomem_one case >> maple_tree: simplify mas_push_node() >> maple_tree: fix potential allocation failure even has memory >> >> lib/maple_tree.c | 26 ++++++++++++-------------- >> 1 file changed, 12 insertions(+), 14 deletions(-) >> >> -- >> 2.34.1 >> >> > >Andrew - Liam is away at the moment - could we hold off on taking this >series to unstable until he's back and had a chance to review please? > >It may be best to avoid taking maple tree changes other than urgent bug >fixes or the like until his return also. > >Wei - please hold off on series like this until Liam's had a chance to >reply to this thread. Thanks! Sure, let me know when it is ok. BTW, I don't see Andrew has taken it in unstable. Do I miss the mail?
On Wed, Sep 25, 2024 at 01:03:05AM GMT, Wei Yang wrote: > On Tue, Sep 24, 2024 at 04:03:35PM +0100, Lorenzo Stoakes wrote: > >On Tue, Sep 24, 2024 at 12:39:50PM GMT, Wei Yang wrote: > >> Patch 1/2: some fields of the maple_alloc is not necessary to change, so we > >> can skip some operations > >> Patch 3: a valid alloc check could be hide in current code, so we don't need > >> to do a separate check > >> Patch 4: found on rare case where allocation would fail even has enough > >> memory > >> > >> Wei Yang (4): > >> maple_tree: clear request_count for new allocated one > >> maple_tree: total is not changed for nomem_one case > >> maple_tree: simplify mas_push_node() > >> maple_tree: fix potential allocation failure even has memory > >> > >> lib/maple_tree.c | 26 ++++++++++++-------------- > >> 1 file changed, 12 insertions(+), 14 deletions(-) > >> > >> -- > >> 2.34.1 > >> > >> > > > >Andrew - Liam is away at the moment - could we hold off on taking this > >series to unstable until he's back and had a chance to review please? > > > >It may be best to avoid taking maple tree changes other than urgent bug > >fixes or the like until his return also. > > > >Wei - please hold off on series like this until Liam's had a chance to > >reply to this thread. Thanks! > > Sure, let me know when it is ok. Thanks, Liam should reply to the thread once he's back then we're good to go :) > > BTW, I don't see Andrew has taken it in unstable. Do I miss the mail? Yeah he's not taken yet, kind of getting ahead of things here - not a comment on your series - more an act of time/resource management :) Cheers! > > -- > Wei Yang > Help you, Help me >
Patch 1/2: some fields of the maple_alloc is not necessary to change, so we can skip some operations Patch 3: a valid alloc check could be hide in current code, so we don't need to do a separate check Patch 4: found on rare case where allocation would fail even has enough memory Wei Yang (4): maple_tree: clear request_count for new allocated one maple_tree: total is not changed for nomem_one case maple_tree: simplify mas_push_node() maple_tree: fix potential allocation failure even has memory lib/maple_tree.c | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-)