From patchwork Tue Oct 1 16:20:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vlastimil Babka X-Patchwork-Id: 13818457 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09944CEACE6 for ; Tue, 1 Oct 2024 16:21:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 848722800C1; Tue, 1 Oct 2024 12:21:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77FA62800BF; Tue, 1 Oct 2024 12:21:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FA5F2800C0; Tue, 1 Oct 2024 12:21:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3B7A02800BF for ; Tue, 1 Oct 2024 12:21:02 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EAFED160C75 for ; Tue, 1 Oct 2024 16:21:01 +0000 (UTC) X-FDA: 82625547522.05.AA73937 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf14.hostedemail.com (Postfix) with ESMTP id 898BF100007 for ; Tue, 1 Oct 2024 16:20:59 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=iaEL4Lld; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tEWKbSau; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LjpeQNy8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DHkhsOPK; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727799566; a=rsa-sha256; cv=none; b=dkcnOP5EnvHEDkEB4VWJCrk96ronoUkOA+16ypImd5uT4S7nWlJHUCPY0n0nc0cjfA8Ggh ZErU9ZR8XgiluRjxq5ZFIPhsDQNdm6k2n42IQTN4AlMKApU953AV/mykOfO+uFQAhdh+xl hsdvgQ1byRSx80kWKaO2F1Br/GXu+Gw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=iaEL4Lld; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tEWKbSau; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LjpeQNy8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DHkhsOPK; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727799566; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=E3PhvcmkdUaKSuNudlm3dhlTOitdcFDsZnftiGiVqUw=; b=WvUEBV+Awuro2pEpPeIUmFHYxNcdmMyiQXt4be4LfQ+bFjMZkspJxEklYTTRM8nLtq25eN EfzBfmKzmSkWOKu/qos8k9HrInFAmG41Nj3h+lsVTN1heIV0FSd0m7cXH1m6F8cQmQ7LOg M4BObUe3jqpEh522v7jpLMv9heqnwgs= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B56F221B52; Tue, 1 Oct 2024 16:20:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727799657; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=E3PhvcmkdUaKSuNudlm3dhlTOitdcFDsZnftiGiVqUw=; b=iaEL4Lld++ApSkAycDIwCObVHeLo57S2Juic3KKfsJng0AKagrzk3SuSVTwNlNwmLemyVi n4JQjcitu47HHRectmuqyBkgu8S55gKxgiTdgZW/OD51Ryb4aVsGsWGsG+QuOMMYhMvj9z 0b8eJDcw43cyfdPOv+qVf+e286g8D10= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727799657; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=E3PhvcmkdUaKSuNudlm3dhlTOitdcFDsZnftiGiVqUw=; b=tEWKbSauBTSa3OKgNTEk7pwfR+qwoeg7UgC3IJpuvy14YNgsiR0PX07dI302GpJ8ZcOQqb Ol+ht/PTuLfNOHDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727799656; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=E3PhvcmkdUaKSuNudlm3dhlTOitdcFDsZnftiGiVqUw=; b=LjpeQNy8M9fyrecwMvXMgrlKRj9pxfifObq0F/b5NqbUiF6NszDrbHjGtzDzno2gfe2s2r w+tE3xSY7sGthiTprodwALIDHqjFit5xDkaAGnngfGNs2q/Gr8n59rnjS6EbIORrBwfg6f +gUeRQK5TPIm/Fyt0Uw7ltTerKRKX4Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727799656; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=E3PhvcmkdUaKSuNudlm3dhlTOitdcFDsZnftiGiVqUw=; b=DHkhsOPK5Ol1ydtCnAMX5wm0uxCplIcMWDZdJ10GEI4Qms/wHl2gZGzfl7ZLXkFUw0P6HP yC8k4Z4IK9+wbBDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 93C0513A6E; Tue, 1 Oct 2024 16:20:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Gpe9I2gh/GaHRAAAD6G6ig (envelope-from ); Tue, 01 Oct 2024 16:20:56 +0000 From: Vlastimil Babka Subject: [PATCH slab hotfixes v2 0/2] slub kunit tests fixes for 6.12 Date: Tue, 01 Oct 2024 18:20:47 +0200 Message-Id: <20241001-b4-slub-kunit-fix-v2-0-2d995d3ecb49@suse.cz> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAF8h/GYC/32NTQ6CMBCFr0Jm7Zi2NBpceQ/DotMWO5GA6QBRC Xe3wb3L9/e9FSRmjgKXaoUcFxYehyLMoQKf3HCPyKFoMMpY1dQKyaL0M+FjHnjCjl946sjZoL0 +WwNl98yx2DvzBtI7qtI4/Zy2xIllGvN7f1z0XvoDXzQqrI13TSAir/VVZolH/4F227YvY3sYF L8AAAA= X-Change-ID: 20240930-b4-slub-kunit-fix-6fba4d1c1742 To: Christoph Lameter , David Rientjes Cc: Roman Gushchin , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , kernel test robot , Guenter Roeck , "Paul E. McKenney" , Boqun Feng , Uladzislau Rezki , rcu@vger.kernel.org, David Gow , Rae Moar , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Brendan Higgins X-Mailer: b4 0.14.2 X-Rspamd-Queue-Id: 898BF100007 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: twrcinagcyijs5t7z7r7yzfk9eemudk7 X-HE-Tag: 1727799659-567523 X-HE-Meta: U2FsdGVkX19xKaqpuYOGPh5daKuCflQ4KPASEnJCJFeF7yFLjs9KJWIJke/Fr7Pm4JvqilldEEL1GnbsyqayUNtD/6VT2tRnCK5m+9SV3SRXGFr3IqU8+tzyH5hAXT0HQeTMTH6Y0J5muAskwEK9Hpzlc11Ig/ojWT4DPt5U+JbAAMwGh9OxRT/zYmZphc+juk9GC7/T2PtTsQbwzwhmF4AqQrumLNmQ61JQOBHgznbdw8K9ctMa6WBYPsDYV5FJqrr7n1oYqZWdzqF8G4KvZ1u8d9LGlv6TRiVHYAGZD/oesybS5+716MWIpBx5M+PMsmNh0E31DhMGix1DKarucDJwALYquCs3a/lw+3NWUPSf2ONQI7AJx6wxqOEXWgRQZN7I4ZIIVznQI6S8SY7yPmP5D+xke7zpN0efBLrH+tkw8ehEJAJe3xtsAzJDfswkoRVqeekrvRNQmdcAiVVh7vZufjEsGKdb4BdvaefqnBrEU0tV6dYTTwKwmKYUkd96u8SyvNlZpUzGQ5vWvf6sWa3GUNauWn1NmZCdmGd+YhsduRZi4YVcFt/1AIS4irITQFpskbrpt/B7IXafpvE0SVYzzZZAqFMMOmhLHEyIHB3T/UvVHG74GgApfLu0Q8lQjrjVuOTuy7Celw27f5/PjDMN1vXM4IYV/osinuR4mVeWnhQk9rk/snnHozkjfSvz/2ElZntvdf+xSDthZCXv04zwEa2a3Ngwnn8cLapngUzcvo69dgIkQpOcY4LLeElgzPzfQEZwdS1gBXWVz39WfiVkoA9iBKeQPuwTIgvlzQUK/d4r/ji1SPRyqTlNFR2hZ+fZn3SO8DfOneM1LDhT8RY1SRxl7QIy6IMsA51l+xHAxj3p5dMRzE1vvrWQ9mi5xJVHqthjXSiCyJNUnpymWk5Blai0GDJClwMQILIvL2JdVPxGAUWH1qII/mP2QZmW5OisrtQFHq/CxXRK7R0 C+4rlBzC Y7vsYDiRY3cFtLrmCV6Hz+4U9ogrEM+OfADEYLGIpIUGomESAcEPXf3lgilH5rZ8apRJv+z0klblRtePyzxck9YSk7JTREH7+9FL9f10Js8HQY0LPe9vxZW1mvf3XStqiQpgFmSLWBhQ8YYNSyPk1DrDEbYhfbY5Pxt3FcjxD8/KyEUF2m1b4ftDmu3v7Ucc3Ypqs7okdOVBdZiqYxhlvTN/GLNTploCOnxH4a0lQH3FEWG9PnSmb09KfNk8GYTzC931Tya8TpJ1QJimqN+3CUN56TG7jD4dbPHWLJqy0BHaUXcrFGZveAUJRX+Dz13tFM7v17XgWOoekuy9XBRuU1Mvafg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The SLUB changes for 6.12 included new kunit tests that resulted in noisy warnings, which we normally suppress, and a boot lockup in some configurations in case the kunit tests are built-in. The warnings are addressed in Patch 1. The lockups I couldn't reproduce, but inspecting boot initialization order makes me suspect the test_kfree_rcu() calling kfree_rcu() which is too early before RCU finishes initialization. Moving the exection later was tried but broke tests marking their code as __init so Patch 2 skips the test when the slub kunit tests are built-in. So these are now fixes for 4e1c44b3db79 ("kunit, slub: add test_kfree_rcu() and test_leak_destroy()") The plan is to take the fixes via slab tree for a 6.12 rcX. Signed-off-by: Vlastimil Babka --- Changes in v2: - patch 2 skips the test when built-in instead of moving kunit execution later - Link to v1: https://lore.kernel.org/r/20240930-b4-slub-kunit-fix-v1-0-32ca9dbbbc11@suse.cz --- Vlastimil Babka (2): mm, slab: suppress warnings in test_leak_destroy kunit test slub/kunit: skip test_kfree_rcu when the slub kunit test is built-in lib/slub_kunit.c | 18 ++++++++++++------ mm/slab.h | 6 ++++++ mm/slab_common.c | 5 +++-- mm/slub.c | 5 +++-- 4 files changed, 24 insertions(+), 10 deletions(-) --- base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc change-id: 20240930-b4-slub-kunit-fix-6fba4d1c1742 Best regards,