From patchwork Wed Oct 2 23:44:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Almeida?= X-Patchwork-Id: 13820553 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56CFDCF8547 for ; Wed, 2 Oct 2024 23:45:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD5296B04E7; Wed, 2 Oct 2024 19:45:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A85B36B04E8; Wed, 2 Oct 2024 19:45:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94CE26B04E9; Wed, 2 Oct 2024 19:45:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 645456B04E7 for ; Wed, 2 Oct 2024 19:45:15 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9F107120C39 for ; Wed, 2 Oct 2024 23:45:14 +0000 (UTC) X-FDA: 82630295748.10.619AF96 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf04.hostedemail.com (Postfix) with ESMTP id ED0B340007 for ; Wed, 2 Oct 2024 23:45:11 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=GvKN74QA; spf=pass (imf04.hostedemail.com: domain of andrealmeid@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=andrealmeid@igalia.com; dmarc=pass (policy=none) header.from=igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727912585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=kj7oVNFXBHyRs7B0iMgteogxKX3su9r74K3KaL3e4KM=; b=JAdUC8aim4IsZtu46CFR9MWTLWwaH76W2xn2tVgkSr76QBNj6jKTqSp9okqeu3U4MU+HFo m/dMSMHYa2j8nu6K7UkXsvikKVI1rPoIAESZ67yfxgSRuQhuulz/hlWBgFYVmz/zfDEEqM XAKTgHd1YKm9IqEX9fw2zEn+ZgR5TeQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727912585; a=rsa-sha256; cv=none; b=m1oQ6DCuZOJ0FkqLE2FpIQcZScfstt1+pmRDsHGQf1RnyY17zYPcqCDaJJ1/EHRPCNppmw LKhPjnaPDtxLGuWmdmwIizLDB1wJMwWQmb81sSwTuo6XkJatmL2v6QmOfcd8o5fNJBugis Rki417Ed5yBSMbFpWa4jTtZQGZINBjI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=GvKN74QA; spf=pass (imf04.hostedemail.com: domain of andrealmeid@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=andrealmeid@igalia.com; dmarc=pass (policy=none) header.from=igalia.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kj7oVNFXBHyRs7B0iMgteogxKX3su9r74K3KaL3e4KM=; b=GvKN74QA18wBN9dzszPvApYpMT xXSMBzdxoZNJVxGCDghI4infFlHUSKbBT84HZjWY2ZMVXKovWm4WBknybp9kjlh+lVpl1m0eupTns MDfdXJlUwEx77as+qiIyt7ZNSN3UoQ0yUdE62M1xY1iMTr4nd8yVL9SyC+sr1o1BYBbxv7x0AKd46 BwuSvvo59M0hJUiKXgKJXDdObGuptXFO3MC8Wjh31Rw9PfvjprnIHvO0t0g72SR/cdvr4mE7HLvWq PwpTVJ9Cu+FwTBLQVi3LyZzfkPDY3/G5ec1le9lWwVf1oGS0NhyICLaqbFrN2LDJFZGv/FoDCFy02 xqfhKIjw==; Received: from [187.57.199.212] (helo=localhost.localdomain) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1sw91e-0045tc-Qk; Thu, 03 Oct 2024 01:44:59 +0200 From: =?utf-8?q?Andr=C3=A9_Almeida?= To: Hugh Dickins , Andrew Morton , Alexander Viro , Christian Brauner , Jan Kara , krisman@kernel.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-dev@igalia.com, Daniel Rosenberg , smcv@collabora.com, Christoph Hellwig , Theodore Ts'o , =?utf-8?q?An?= =?utf-8?q?dr=C3=A9_Almeida?= Subject: [PATCH v5 00/10] tmpfs: Add case-insensitive support for tmpfs Date: Wed, 2 Oct 2024 20:44:34 -0300 Message-ID: <20241002234444.398367-1-andrealmeid@igalia.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 X-Rspamd-Queue-Id: ED0B340007 X-Stat-Signature: bmu7nutcwec4ueddragosgcuf9pidhz9 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727912711-377511 X-HE-Meta: U2FsdGVkX18Y/sUo9oJWPxa7e/nh0mLFZmvf67Foc7CcV2x5qmhPSDdhaSB1aYcro/wrgHllHXedi+Vc2XrLclF25uQkP3XXTaa0aU24LZ1NbTBeRB34pwG2NbXKkIEe/IGJKsEWMP/HIv/0y7ixsnoulvBXW2jBItLLZ6Sl4UcKdvNA0zg2SQegS9cZ+nSK6Hm8nDhYTCwIoBoYLuE0/RDwJAaqfoR1911jo8zO9B0eyNroIqFNKnBrE8Mg65axpLYhGXr6f0pqKjDenY9aWWOcO5fMkva76hQEJ/OrUp6/mpL0lU+kh3IF+iao5E6xLEj4D64GDAhoB0+jgYxIOaBApUy0X/j233PkHJ1sHO2UTwrFfezVhddVNqWY2H6jNPCQ/IGiDdxmoyCPELj2W/lPbFdy8rR8MXGaLwygj3MLB3xiOG5GXCqVa2OA0eNZnglc36/B8xr+WNENXFYM0Vz6B8fsA9uXw5wzFrYHBsgiTqVkr4kceuRGisGaSujYA+MwiLpvjnl/JWOxgdPCSVntHaQI5dOxYwWNRahGF5zvmRT/4edMqXnpAsHK96XhnKuz1GLx0VDfYQr5kHKu+HIGm/7/ENyGmhZzBi0MqXX+OpEXO6Mj+YXNNr2AGVkkeGe9teBJb6dkpck1YUlXrsyu+eHF+1WE4IYdDa5h9v0ps+MklrpQquBI2mMYvvDB3irWjDman9XENSYQ53iVj3bC1u7qHhf1SbwDIcgqtWZrb2tBfVJQzSUyUWxi6F14ejiJyLXDJ8jEIs49rmJWlTPrLEJWDo5UAlnI+x6hWenI+4NGz407t3EZbgzM93GwdbLR0OIVtlxNwNROHld3vAoLbqWg7JmQeIwBDTtkrIvY4hzaGPpQTx0qvSsYAcuXEBf93b/cwALKyuqM++7iJIT72ljxsNWmwkQeNc40k3E0+N3cGyjeMg6nItEG0/WzUMrlDlxz6u+V5oGpQea GJj3f69S 4nAlgd+r0vEGUaRka4KmPBhy3EfA2y3L3oSwmDbiX437TxQFece8AnW+kyFWl2Ivev4SucEgCkb8oZMU9nZLGJhZLC4AjF/PoZOmix5xk8Cy+j+bjoqiUXPYPTzwQMY9YfudSbYO1m9tHg1Juyok3ACdOqAbPfJIAmu8b1kas3JxeeavD9BgTZJN14V/XV5S/ana4gXdqHp+5uC+8J312hLIFFfEDhbO9CwSAj4Qezz2obsCC0oJmUg3iQfaW0hlCJGVdeZeKpmks1lfNrtS2iO331JTtGPnNiWKmAZtV/N1Z+BJzTyDa4Q4D4az7tJHQWNcNM+P2ffULLQZP5o3MVSBV1+nZ8oTBTf51Cm0aBr8mTkg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, This patchset adds support for case-insensitive file names lookups in tmpfs. The main difference from other casefold filesystems is that tmpfs has no information on disk, just on RAM, so we can't use mkfs to create a case-insensitive tmpfs. For this implementation, I opted to have a mount option for casefolding. The rest of the patchset follows a similar approach as ext4 and f2fs. * Use case (from the original cover letter) The use case for this feature is similar to the use case for ext4, to better support compatibility layers (like Wine), particularly in combination with sandboxing/container tools (like Flatpak). Those containerization tools can share a subset of the host filesystem with an application. In the container, the root directory and any parent directories required for a shared directory are on tmpfs, with the shared directories bind-mounted into the container's view of the filesystem. If the host filesystem is using case-insensitive directories, then the application can do lookups inside those directories in a case-insensitive way, without this needing to be implemented in user-space. However, if the host is only sharing a subset of a case-insensitive directory with the application, then the parent directories of the mount point will be part of the container's root tmpfs. When the application tries to do case-insensitive lookups of those parent directories on a case-sensitive tmpfs, the lookup will fail. For example, if /srv/games is a case-insensitive directory on the host, then applications will expect /srv/games/Steam/Half-Life and /srv/games/steam/half-life to be interchangeable; but if the container framework is only sharing /srv/games/Steam/Half-Life and /srv/games/Steam/Portal (and not the rest of /srv/games) with the container, with /srv, /srv/games and /srv/games/Steam as part of the container's tmpfs root, then making /srv/games a case-insensitive directory inside the container would be necessary to meet that expectation. * Testing I send a patch for xfstests to enable the casefold test (generic/556) for tmpfs.[1] The test succeed. You can test this patchset using: sudo mount -t tmpfs -o casefold tmpfs mnt/ And making a dir case-insensitive: mkdir mnt/dir chattr +F mnt/dir [1] https://lore.kernel.org/fstests/20240823173008.280917-1-andrealmeid@igalia.com/ Changes in v5: - New patch "Always set simple_dentry_operations as dentry ops" - "Squashed libfs: Check for casefold dirs on simple_lookup()" into "tmpfs: Add casefold lookup support" - Fail to mount if strict_encoding is used without encoding - Inlined generic_ci_validate_strict_name() - Added IS_ENABLED(UNICODE) guards to public generic_ci_ funcs - Dropped .d_revalidate = fscrypt_d_revalidate, tmpfs doesn't support it v4: https://lore.kernel.org/lkml/20240911144502.115260-1-andrealmeid@igalia.com/ Changes in v4: - Got rid of shmem_lookup() and changed simple_lookup() to cover casefold use case - Simplified shmem_parse_opt_casefold() and how it handle the lastest_version option - Simplified utf8_parse_version() to return the version in one variable instead of three - Rewrote part of the documentation patch - Make sure that d_sb->s_d_op is set during mount time - Moved `generic_ci_always_del_dentry_ops` to mm/shmem.c as `shmem_ci_dentry_ops` v3: https://lore.kernel.org/lkml/20240905190252.461639-1-andrealmeid@igalia.com/ Changes in v3: - Renamed utf8_check_strict_name() to generic_ci_validate_strict_name(), and reworked the big if(...) to be more clear - Expose the latest UTF-8 version in include/linux/unicode.h - shmem_lookup() now sets d_ops - reworked shmem_parse_opt_casefold() - if `mount -o casefold` has no param, load latest UTF-8 version - using (IS_ENABLED(CONFIG_UNICODE) && IS_CASEFOLDED(dir) when possible - Fixed bug when adding a non-casefold flag in a non-empty dir v2: https://lore.kernel.org/lkml/20240902225511.757831-1-andrealmeid@igalia.com/ Changes in v2: - Found and fixed a bug in utf8_load() - Created a helper for checking strict file names (Krisman) - Merged patch 1/ and 3/ together (Krisman) - Reworded the explanation about d_compare (Krisman) - Removed bool casefold from shmem_sb_info (Krisman) - Reworked d_add(dentry, NULL) to be called as d_add(dentry, inode) (Krisman) - Moved utf8_parse_version to common unicode code - Fixed some smatch/sparse warnings (kernel test bot/Dan Carpenter) v1: https://lore.kernel.org/linux-fsdevel/20240823173332.281211-1-andrealmeid@igalia.com/ André Almeida (10): libfs: Create the helper function generic_ci_validate_strict_name() ext4: Use generic_ci_validate_strict_name helper unicode: Export latest available UTF-8 version number unicode: Recreate utf8_parse_version() libfs: Export generic_ci_ dentry functions tmpfs: Always set simple_dentry_operations as dentry ops tmpfs: Add casefold lookup support tmpfs: Add flag FS_CASEFOLD_FL support for tmpfs dirs tmpfs: Expose filesystem features via sysfs docs: tmpfs: Add casefold options Documentation/filesystems/tmpfs.rst | 24 +++ fs/ext4/namei.c | 5 +- fs/libfs.c | 12 +- fs/unicode/utf8-core.c | 26 ++++ fs/unicode/utf8-selftest.c | 3 - include/linux/fs.h | 49 ++++++ include/linux/shmem_fs.h | 6 +- include/linux/unicode.h | 4 + mm/shmem.c | 226 ++++++++++++++++++++++++++-- 9 files changed, 332 insertions(+), 23 deletions(-)