mbox series

[v3,0/3] simplify split calculation

Message ID 20241113031616.10530-1-richard.weiyang@gmail.com (mailing list archive)
Headers show
Series simplify split calculation | expand

Message

Wei Yang Nov. 13, 2024, 3:16 a.m. UTC
In version 1 [1], we found current split would result into deficient node.

By discussion, current implementation would lead to jitter problem. Since this
is a rare case in real world, we decide to simplify the split calculation.

Patch 1: simplify split calculation
Patch 2: add a test case to check deficient node
Patch 3: validate deficient node except for root node

[1]: https://lkml.kernel.org/r/20241020024628.22469-1-richard.weiyang@gmail.com

Wei Yang (3):
  maple_tree: simplify split calculation
  maple_tree: add a test check deficient node
  maple_tree: only root node could be deficient

 lib/maple_tree.c      | 25 +++++++------------------
 lib/test_maple_tree.c | 28 ++++++++++++++++++++++++++++
 2 files changed, 35 insertions(+), 18 deletions(-)

Comments

Liam R. Howlett Nov. 13, 2024, 6:39 p.m. UTC | #1
* Wei Yang <richard.weiyang@gmail.com> [241112 22:17]:
> In version 1 [1], we found current split would result into deficient node.
> 
> By discussion, current implementation would lead to jitter problem.

I don't recall it leading to a jitter, I was concerned about that but I
don't think this leads to jitter.


> Since this
> is a rare case in real world, we decide to simplify the split calculation.
> 
> Patch 1: simplify split calculation
> Patch 2: add a test case to check deficient node
> Patch 3: validate deficient node except for root node
> 
> [1]: https://lkml.kernel.org/r/20241020024628.22469-1-richard.weiyang@gmail.com
> 
> Wei Yang (3):
>   maple_tree: simplify split calculation
>   maple_tree: add a test check deficient node
>   maple_tree: only root node could be deficient
> 
>  lib/maple_tree.c      | 25 +++++++------------------
>  lib/test_maple_tree.c | 28 ++++++++++++++++++++++++++++
>  2 files changed, 35 insertions(+), 18 deletions(-)
> 
> -- 
> 2.34.1
>
Wei Yang Nov. 14, 2024, 12:53 a.m. UTC | #2
On Wed, Nov 13, 2024 at 01:39:37PM -0500, Liam R. Howlett wrote:
>* Wei Yang <richard.weiyang@gmail.com> [241112 22:17]:
>> In version 1 [1], we found current split would result into deficient node.
>> 
>> By discussion, current implementation would lead to jitter problem.
>
>I don't recall it leading to a jitter, I was concerned about that but I
>don't think this leads to jitter.
>

Sorry for my misunderstanding.

>
>> Since this
>> is a rare case in real world, we decide to simplify the split calculation.
>> 
>> Patch 1: simplify split calculation
>> Patch 2: add a test case to check deficient node
>> Patch 3: validate deficient node except for root node
>> 
>> [1]: https://lkml.kernel.org/r/20241020024628.22469-1-richard.weiyang@gmail.com
>> 
>> Wei Yang (3):
>>   maple_tree: simplify split calculation
>>   maple_tree: add a test check deficient node
>>   maple_tree: only root node could be deficient
>> 
>>  lib/maple_tree.c      | 25 +++++++------------------
>>  lib/test_maple_tree.c | 28 ++++++++++++++++++++++++++++
>>  2 files changed, 35 insertions(+), 18 deletions(-)
>> 
>> -- 
>> 2.34.1
>>