From patchwork Thu Nov 21 10:18:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13881823 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7BBFD6E2CA for ; Thu, 21 Nov 2024 10:18:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77A776B007B; Thu, 21 Nov 2024 05:18:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7038D6B0082; Thu, 21 Nov 2024 05:18:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A4086B0083; Thu, 21 Nov 2024 05:18:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 36F5D6B007B for ; Thu, 21 Nov 2024 05:18:55 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BB38F41285 for ; Thu, 21 Nov 2024 10:18:54 +0000 (UTC) X-FDA: 82809702864.11.E606FF7 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf20.hostedemail.com (Postfix) with ESMTP id B0D061C0005 for ; Thu, 21 Nov 2024 10:17:45 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf20.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732184265; a=rsa-sha256; cv=none; b=m9Dasx8+eg3mEqpDUtXcmnE71n/4ET2EvU9LxxRpb2a8bBwT4VAUTpEqvMhP1RdhKNuOCG QU3IY5o7TXOHFRpr8PmEkIV+CWTS00WsCBnDPUkeoDNCK9JXshXscScSJYpp228ESDkxAl b8f2jddYmDuxAGyftwBOlnvCr+wgdaU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf20.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732184265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=vDBXc531Gck5wP+5E8tJSLXonISf+MOKNkjLOZFWInc=; b=Kbm2x4wM+4JcrYbyEOP6QCICeJGMuBuIio8UDyZPYiFtKc62KxewiDCL+q7VQCwuchtRRx pKVF/HEZU+Y2Au9ERWNzqLSKQJdz6dcoNFTfLB/99bt0X6/JNu9MdXuavugqd5QwACvrsB hmkdaKxth3fmS9FD6XRSW1wEjlaW7zU= Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XvDcx48K9z6K6CQ; Thu, 21 Nov 2024 18:15:13 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id C0276140A86; Thu, 21 Nov 2024 18:18:47 +0800 (CST) Received: from SecurePC-101-06.china.huawei.com (10.122.19.247) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 21 Nov 2024 11:18:46 +0100 From: Jonathan Cameron To: , , , CC: , , Yicong Yang , Niyas Sait , , Vandana Salve , Davidlohr Bueso , Dave Jiang , Alison Schofield , Ira Weiny , Dan Williams , Alexander Shishkin , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Gregory Price , Huang Ying Subject: [RFC PATCH 0/4] CXL Hotness Monitoring Unit perf driver Date: Thu, 21 Nov 2024 10:18:41 +0000 Message-ID: <20241121101845.1815660-1-Jonathan.Cameron@huawei.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Originating-IP: [10.122.19.247] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To frapeml500008.china.huawei.com (7.182.85.71) X-Rspam-User: X-Rspamd-Queue-Id: B0D061C0005 X-Rspamd-Server: rspam11 X-Stat-Signature: hcspfhnd3zh94bjfskwtucagqr9436rw X-HE-Tag: 1732184265-30101 X-HE-Meta: U2FsdGVkX188KCWy1EAAkGd+nXlK+4CaJT+KS2M/ki5T+n1Z/X+SW4BDZQh9lD8n19ynSAMqRN0SCkvOuj12jmQeF+pRBh7dcy2nvlbQtdS+6iolKgx66JU4P2qs/yQdfFw+kUPBbQgZ4Pbfj1ipGzZRhmwaGCPkKvMsvvlygAlvWCNhH8A4a5wENU4zbyqRUBHzNQK+9cCEj1KcrxP+cBMO+rn/Dd24Ct5yLlG99iyceK8fgpMmClBEMNfp8nZ03hvZ8FMMSzDbZleXN0no7QM2aEvLN4IL5uPmi6ml5nlmUEA14/IVRTlrK2J9/aPRefjqOLZNBi8a8bi2qvO+V2G7BHjdHM6M9UKI9sRSTPA2CSli/DqP2sM7r4Bt3EyOEJ1Emm3eqHEPPFo/+dX7GbKa+W00++KViL0JyQNwAHuYoVM4oKESnEyHiM7GVrx8OXGgtjqiDyq1/QRxJc8uh84VwqxOZ7hO1icQZQNuDJrw/4rs4Xhfb3STuefbOdehkE7jui2rA5dfzqiGumFg8T3pMFt0f2JMCUXOnPntAhTGJ8F/aCoEZLFdnYikPeRm7lKIjKpHEg14iFmMmhHMUPyyiHheDwUf099lirKDfj7tiELxiMLUQ4MawFd0MHe2Wb3N5icEePNMufu0FmAT8yqrQpgcfiCkxCikZ+l7HJYfoQjP8zAxifMBKLGMcOvxiJ8D+bZI6SKPFTmW9VOuRridauZjjpN0UX4hzw6rj30AaXt0Ke+A4nltRpfXutX1K2efWXfV+0Iy1YF3z0BEI4KZy7BPjJoY/nccR1WvE59+pIqfT6Rpjwe8Dd79n30wMPS0rIRJ3HoBLRqOr53zd4PtIGuiOfjIZfBbX9taSrAq6rik7QpOmuUoTUaQ556maM5mfoc3PUEaSL7sDvPyV7uyzJIcMPW1E72woYpVk02sgxx6ArrpYymL4jCQNSHFIX2n2nEn0oR3IpGlP+A q645cvku r2c9MSuezTApvwUGLadaXrx/jXDJ3hPK+8tFC2ys4ZajW4AIQC9JEUCrgaqzS+7DQO9hXu1sB65OBgPRsslRwxvewbSgSjtf9hA1gW+omXNOF7OcNfEMXzkARcfJ8Ffj2r+elpMl/QPb6MrjqKRkdpk7vwpQVcNdUS6BFNx3R04OI1TsEqcydb+aw6g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The CXL specification release 3.2 is now available under a click through at https://computeexpresslink.org/cxl-specification/ and it brings new shiny toys. RFC reason - Whilst trace capture with a particular configuration is potentially useful the intent is that CXL HMU units will be used to drive various forms of hotpage migration for memory tiering setups. This driver doesn't do this (yet), but rather provides data capture etc for experimentation and for working out how to mostly put the allocations in the right place to start with by tuning applications. CXL r3.2 introduces a CXL Hotness Monitoring Unit definition. The intent of this is to provide a way to establish which units of memory (typically pages or larger) in CXL attached memory are hot. The implementation details and algorithm are all implementation defined. The specification simply describes the 'interface' which takes the form of ring buffer of hotness records in a PCI BAR and defined capability, configuration and status registers. The hardware may have constraints on what it can track, granularity etc and on how accurately it tracks (e.g. counter exhaustion, inaccurate trackers). Some of these constraints are discoverable from the hardware registers, others such as loss of accuracy have no universally accepted measures as they are typically access pattern dependent. Sadly it is very unlikely any hardware will implement a truly precise tracker given the large resource requirements for tracking at a useful granularity. There are two fundamental operation modes: * Epoch based. Counters are checked after a period of time (Epoch) and if over a threshold added to the hotlist. * Always on. Counters run until a threshold is reached, after that the hot unit is added to the hotlist and the counter released. Counting can be filtered on: * Region of CXL DPA space (256MiB per bit in a bitmap). * Type of access - Trusted and non trusted or non trusted only, R/W/RW Sampling can be modified by: * Downsampling including potentially randomized downsampling. The driver presented here is intended to be useful in its own right but also to act as the first step of a possible path towards hotness monitoring based hot page migration. Those steps might look like. 1. Gather data - drivers provide telemetry like solutions to get that data. May be enhanced, for example in this driver by providing the HPA address rather than DPA Unit Address. Userspace can access enough information to do this so maybe not. 2. Userspace algorithm development, possibly combined with userspace triggered migration by PA. Working out how to use different levels of constrained hardware resources will be challenging. 3. Move those algorithms in kernel. Will require generalization across different hotpage trackers etc. So far this driver just gives access to the raw data. I will probably kick of a longer discussion on how to do adaptive sampling needed to actually use these units for tiering etc, sometime soon (if no one one else beats me too it). There is a follow up topic of how to virtualize this stuff for memory stranding cases (VM gets a fixed mixture of fast and slow memory and should do it's own tiering). More details in the Documentation patch but typical commands are: $perf record -a -e cxl_hmu_mem0.0.0/epoch_type=0,access_type=6,\ hotness_threshold=1024,epoch_multiplier=4,epoch_scale=4,range_base=0,\ range_size=1024,randomized_downsampling=0,downsampling_factor=32,\ hotness_granual=12 $perf report --dump-raw-traces Example output. With a counter_width of 16 (0x10) the least significant 4 bytes are the counter value and the unit index is bits 16-63. Here all units are over the threshold and the indexes are 0,1,2 etc. . ... CXL_HMU data: size 33512 bytes Header 0: units: 29c counter_width 10 Header 1 : deadbeef 0000000000000283 0000000000010364 0000000000020366 000000000003033c 0000000000040343 00000000000502ff 000000000006030d 000000000007031a Which will produce a list of hotness entries. Bits[N-1:0] counter value Bits[63:N] Unit ID (combine with unit size and DPA base + HDM decoder config to get to a Host Physical Address) Specific RFC questions. - What should be in the header added to the aux buffer. Currently just the minimum is provided. Number of records and the counter width needed to decode them. - Should we reset the counters when doing sampling "-F X" If the frequency is higher than the epoch we never see any hot units. If so, when should we reset them? Note testing has been light and on emulation only + as perf tool is a pain to build on a striped back VM, build testing has all be on arm64 so far. The driver loads though on both arm64 and x86 so any problems are likely in the perf tool arch specific code which is build tested (on wrong machine) The QEMU emulation needs some cleanup, but I should be able to post that shortly to let people actually play with this. There are lots of open questions there on how 'right' we want the emulation to be and what counting uarch to emulate. Jonathan Cameron (4): cxl: Register devices for CXL Hotness Monitoring Units (CHMU) cxl: Hotness Monitoring Unit via a Perf AUX Buffer. perf: Add support for CXL Hotness Monitoring Units (CHMU) hwtrace: Document CXL Hotness Monitoring Unit driver Documentation/trace/cxl-hmu.rst | 197 +++++++ Documentation/trace/index.rst | 1 + drivers/cxl/Kconfig | 6 + drivers/cxl/Makefile | 3 + drivers/cxl/core/Makefile | 1 + drivers/cxl/core/core.h | 1 + drivers/cxl/core/hmu.c | 64 ++ drivers/cxl/core/port.c | 2 + drivers/cxl/core/regs.c | 14 + drivers/cxl/cxl.h | 5 + drivers/cxl/cxlpci.h | 1 + drivers/cxl/hmu.c | 880 ++++++++++++++++++++++++++++ drivers/cxl/hmu.h | 23 + drivers/cxl/pci.c | 26 +- tools/perf/arch/arm/util/auxtrace.c | 58 ++ tools/perf/arch/x86/util/auxtrace.c | 76 +++ tools/perf/util/Build | 1 + tools/perf/util/auxtrace.c | 4 + tools/perf/util/auxtrace.h | 1 + tools/perf/util/cxl-hmu.c | 367 ++++++++++++ tools/perf/util/cxl-hmu.h | 18 + 21 files changed, 1748 insertions(+), 1 deletion(-) create mode 100644 Documentation/trace/cxl-hmu.rst create mode 100644 drivers/cxl/core/hmu.c create mode 100644 drivers/cxl/hmu.c create mode 100644 drivers/cxl/hmu.h create mode 100644 tools/perf/util/cxl-hmu.c create mode 100644 tools/perf/util/cxl-hmu.h