From patchwork Wed Dec 4 12:54:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13893708 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 088B8E7716E for ; Wed, 4 Dec 2024 12:55:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5140D6B008C; Wed, 4 Dec 2024 07:55:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3290A6B0098; Wed, 4 Dec 2024 07:55:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AD026B0093; Wed, 4 Dec 2024 07:55:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DAF8F6B0092 for ; Wed, 4 Dec 2024 07:55:07 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5EB44AED80 for ; Wed, 4 Dec 2024 12:54:53 +0000 (UTC) X-FDA: 82857271098.28.6AE8BE3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 70AB64001A for ; Wed, 4 Dec 2024 12:54:36 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dQo4ssTx; spf=pass (imf07.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733316876; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=MB2MAmGSlUi5YLf0fUp0VNgn+MFysC4aDDm3o00zI78=; b=ypW7qXiRI0mzcqLdmxWWM7Mub4hDXIAEB98MaO/71DYYSXSHeZ4OoCClJpGpvwa3ZoB1k3 1exArZWD0TM5V5MDw39mA9cmUmHaa4RnfQG+vKBpMWXxJEhaW1CjJ8I0dineFcgrCkC/Wq 0OMuZGluM791vDz9NqNvZczToDlwCWQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733316876; a=rsa-sha256; cv=none; b=FqECViB6VYL11Skc2V3pF2gYaWoUZKkNTnkCyUHWEfeLNjLh43wmUOXoQuFefxF31t0YMG V8z7Cj2H0thtyXEkxiD4xyM6U8UQgAIm6DlF6KAFz5U9qPhMdUTsrCeSin5hRqQbh8kbRm fbuBuo7mu4GoWUGPRmgNqqeB9GYHYhQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dQo4ssTx; spf=pass (imf07.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733316890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MB2MAmGSlUi5YLf0fUp0VNgn+MFysC4aDDm3o00zI78=; b=dQo4ssTxIMyeopv1YcD3KVbQGNNDW3P4KZYdCNxbig923f15xWFwztyquizyZ94zgoSqIa 3S+SdmXIZpkbLPOHz27GUV8fnaK36y+NfMpPtyQuHZHl0A6JpD90TzuCx4uQt9L7owuZhY lT68kMjUzHBw4OpyoQo7wQjLBePg3Z8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-511-nKSoDtl0PuKshNyhb7IqBg-1; Wed, 04 Dec 2024 07:54:49 -0500 X-MC-Unique: nKSoDtl0PuKshNyhb7IqBg-1 X-Mimecast-MFC-AGG-ID: nKSoDtl0PuKshNyhb7IqBg Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43498af79a6so4979315e9.0 for ; Wed, 04 Dec 2024 04:54:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733316888; x=1733921688; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MB2MAmGSlUi5YLf0fUp0VNgn+MFysC4aDDm3o00zI78=; b=KmBy302Iv+47uUdHLYTweb2P6KMC12fqYs27KRkdjhTcY0ryLRsC9z6SXo0Og3Y9Gm Fn6h29OdeP2IFNa2N92xuwKWJZi3yAjxV0QGV+tok1muV/DOLoGYYW9HIlTYIAXxxLag yaWlQgdnP+6ehYIymsm35jmaBoSLvP3AaIOzx5b/jzvuEic/N2ZDOdxdmxdJwZCrvR2G rXW44WI+sI7FYjWF4hBRZJEP3GM1vGpYNtXYDhyy5+Gz3rWTc85ApecDCupzZDmCpcJR E9quj6Jz161XcdaG3Z5K9tr1/n8B+P1ZYqcMWkFfSMa/MVrX1Kd6itVaYGDiF027S94e NrTA== X-Gm-Message-State: AOJu0YzRz+hQxhHp2G6UDc3R8GhTh4rUqKEYuTn0YsmBcGiW5vfnO2Bo EXmLXDY3+osNbpwUfWW+G2JEpdxqo2+Pb8fk2mUneJ6eJ+essbprsGn5tZlyMKnbungWJH4yjUz cXefuiv5Dv4hYsKhR4iqzG7jA023+cqRUpy7Zau97HsS0ww0F X-Gm-Gg: ASbGncu93NAAypnUuc4H+Nj+uoDA2THY9mlYwkTkAVGch55nDBxLVHwLowHCsqGjzL5 CLm9qwHUA7T60jOxk1qteXqcdWSk9+5T1DF5/tCBOeVQ6wPNltST3CtkV1x+LmubJheEatO5mHf c5OO3BJIzvUO+TEwXsoVrF8SMC2rb53f0ephwIY04GzJ2fS8aMWX382I8t6axWYv80sb/rQArFO 2resDBSIuqfTRl3AmDTNbyKxa23MMf73Ye6MQtIZPb0a63kEraOVDTsxN8M8L/RR4QGDd+8i6lA cGbCGyS6CmetTSzbJ9AJM1Qy+ZslNDPy5YI= X-Received: by 2002:a05:600c:6c8a:b0:434:8e8a:d4ec with SMTP id 5b1f17b1804b1-434afc3b6e1mr245982125e9.13.1733316888159; Wed, 04 Dec 2024 04:54:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IHjMr0hScnPOMMpphAyax2V0MFBHZqym1YHIjea01hMzMXczx6opOHdnARaXNIvDZGqHVvbtg== X-Received: by 2002:a05:600c:6c8a:b0:434:8e8a:d4ec with SMTP id 5b1f17b1804b1-434afc3b6e1mr245981785e9.13.1733316887744; Wed, 04 Dec 2024 04:54:47 -0800 (PST) Received: from localhost (p200300cbc70be10038d68aa111b0a20a.dip0.t-ipconnect.de. [2003:cb:c70b:e100:38d6:8aa1:11b0:a20a]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-434d52c0bc7sm23514855e9.35.2024.12.04.04.54.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2024 04:54:46 -0800 (PST) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, kexec@lists.infradead.org, David Hildenbrand , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?utf-8?q?Eugenio_P=C3=A9rez?= , Baoquan He , Vivek Goyal , Dave Young , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , Eric Farman , Andrew Morton Subject: [PATCH v2 00/12] fs/proc/vmcore: kdump support for virtio-mem on s390 Date: Wed, 4 Dec 2024 13:54:31 +0100 Message-ID: <20241204125444.1734652-1-david@redhat.com> X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Xma3-2KsQ8KowJKVPDbqonpf6FYtVnok1kY92wfx9bI_1733316888 X-Mimecast-Originator: redhat.com X-Rspamd-Queue-Id: 70AB64001A X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: sz86qt644ajuodfxh56dirzert9t89yn X-HE-Tag: 1733316876-833613 X-HE-Meta: U2FsdGVkX1/Km590ZH4PCs5KRr6L7r1tIhd0cWuVzMfrDth3DBbFJtm76V0K/vM7Gieh2hgV5RrScp4sWvCY7OokXFIaoVBozcMb4EBhM+R71Ta/xCCZ7117u/mPPRBJDyf9I4AnhlB6mcyNeWPegyVTNI9nGmFv116cX91ky3LrpXQi8VTmLqiFZPBYzHBzJT+aXbkPJJpU5nDAZ8ASjgkM5oqJWRlXdX1nmr6m0GbG3AyCDnvNNzkEbIVzXooCnhvqg+6rSX11N+CmBJtEbWrgD9Qs0fldIhqgNjifo2VtgmKeI1ocL9167VNAcfYxTWZbX0MQ2ruT8D4GkpYom5s1TUwFLKlI3YOE+nJ86HRufuOndTAKXkMGPTJmdQbDKfnUoO3ajxlB2GhdYmvuq3ahgubgBvtetxJ1/lnuYuuWfAA3AMMAotaBpHYf4Dr3R2fZPqX/K2e7NBJaxYgR7hkyjHcfA2WQd5s/lR6sSSu5XbZuuGc5QaiuGdMBiIA9/E4WeYy67Z/wBINoIonMxdE72Aj8zM1MIt2sFeoxzF6LpHqily19R0ZHFC/Ve0hNnU2ItR2YNYan64363EYimOyOtw4Rb8Uyn1WfOQB+gDu08ekZ2uoa9LqlNhR9P5HcxOfCYCOg/eXx0EWrqD6esAbtAlf33yre73FUAWj2gKNBdLMp00v05rX70LlrJiuG+sjnGIRd2zNqA92+WvgmeF2teqnMD7ycL8a/2dl/yzRJu6i2L5K/wEuYVad+jkTjTMqMFGaTjEXkWU6P53sejY+LXbg8u0xvxFKnhDKdXv98uqlAueIDG2XxDmSqcm0xLHSYIX0LHaw7jqVN9lgvroM20REsQxfIy8PGFVBvqokKL6wi6yUfLC/2C11HejreEFwSgqEu9qhupRtl+bqcuiugYN894bIdCSyItXJtvZxC2EKbFim0RH5lBAjGxWmQbQzc4Q0ahSy8ve30Cc+ y/UDG+Dz vNS6tG9vuiz4zJPd6qVEPRO6Jl1tb0q87lMqoFbKyMgPHIfGeKRIe9RjIqGwjO4u0w5txqdVSD0rSQ026Qe9ukscCqcA1O1/Hw3+DBNsVlZJJMulwlEyejRaBGXT3wQTACwibFBkjCQGyPEQWlsOGcEI0uOK4BLpekB3VbQ4YYV7xL1yU7tx0u8eQ6X+Hxj9DfT/YBz9icewylzEgesYD9I+737XCjAp/2NVcJRKOBI5OXcQgkNElxqIFTyHEjpnHIdEyjUXBwlujOrzt+1GU2ntZFxa+E9xWYKSZNY3uQsuqADxeHUZTW5oP6f1uCR5xlGMYo8t4BFTA0x0OKD7fERBGKXewZ47nGaMnuwk5cI2n6GGU9qXAt0o+AoCC2Xk0YQsd1lhzMbkD3B0FuvM9h6zLtDLy8KMEMxTa1ejzny7S76Pll7pWBW/2vTJcYqSAiF19qieTwdBtKfOeOa9chEfefdeQhjRjP3jH/cf1r1GEbr6YVZMyT7ec7sEbYW7JwxSIXME4lC1ZQ7LEuk2DZS8a5RvywTGG7uKNWbERhVqLDM1F0nYmkRRG695XGCwZRYUP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The only "different than everything else" thing about virtio-mem on s390 is kdump: The crash (2nd) kernel allocates+prepares the elfcore hdr during fs_init()->vmcore_init()->elfcorehdr_alloc(). Consequently, the kdump kernel must detect memory ranges of the crashed kernel to include via PT_LOAD in the vmcore. On other architectures, all RAM regions (boot + hotplugged) can easily be observed on the old (to crash) kernel (e.g., using /proc/iomem) to create the elfcore hdr. On s390, information about "ordinary" memory (heh, "storage") can be obtained by querying the hypervisor/ultravisor via SCLP/diag260, and that information is stored early during boot in the "physmem" memblock data structure. But virtio-mem memory is always detected by as device driver, which is usually build as a module. So in the crash kernel, this memory can only be properly detected once the virtio-mem driver started up. The virtio-mem driver already supports the "kdump mode", where it won't hotplug any memory but instead queries the device to implement the pfn_is_ram() callback, to avoid reading unplugged memory holes when reading the vmcore. With this series, if the virtio-mem driver is included in the kdump initrd -- which dracut already takes care of under Fedora/RHEL -- it will now detect the device RAM ranges on s390 once it probes the devices, to add them to the vmcore using the same callback mechanism we already have for pfn_is_ram(). To add these device RAM ranges to the vmcore ("patch the vmcore"), we will add new PT_LOAD entries that describe these memory ranges, and update all offsets vmcore size so it is all consistent. My testing when creating+analyzing crash dumps with hotplugged virtio-mem memory (incl. holes) did not reveal any surprises. Patch #1 -- #7 are vmcore preparations and cleanups Patch #8 adds the infrastructure for drivers to report device RAM Patch #9 + #10 are virtio-mem preparations Patch #11 implements virtio-mem support to report device RAM Patch #12 activates it for s390, implementing a new function to fill PT_LOAD entry for device RAM v1 -> v2: * "fs/proc/vmcore: convert vmcore_cb_lock into vmcore_mutex" -> Extend patch description * "fs/proc/vmcore: replace vmcoredd_mutex by vmcore_mutex" -> Extend patch description * "fs/proc/vmcore: disallow vmcore modifications while the vmcore is open" -> Disallow modifications only if it is currently open, but warn if it was already open and got closed again. -> Track vmcore_open vs. vmcore_opened -> Extend patch description * "fs/proc/vmcore: prefix all pr_* with "vmcore:"" -> Added * "fs/proc/vmcore: move vmcore definitions out if kcore.h" -> Call it "vmcore_range" -> Place vmcoredd_node into vmcore.c -> Adjust patch subject + description * "fs/proc/vmcore: factor out allocating a vmcore range and adding it to a list" -> Adjust to "vmcore_range" * "fs/proc/vmcore: factor out freeing a list of vmcore ranges" -> Adjust to "vmcore_range" * "fs/proc/vmcore: introduce PROC_VMCORE_DEVICE_RAM to detect device RAM ranges in 2nd kernel" -> Drop PROVIDE_PROC_VMCORE_DEVICE_RAM for now -> Simplify Kconfig a bit -> Drop "Kdump:" from warnings/errors -> Perform Elf64 check first -> Add regions also if the vmcore was opened, but got closed again. But warn in any case, because it is unexpected. -> Adjust patch description * "virtio-mem: support CONFIG_PROC_VMCORE_DEVICE_RAM" -> "depends on VIRTIO_MEM" for PROC_VMCORE_DEVICE_RAM Cc: Heiko Carstens Cc: Vasily Gorbik Cc: Alexander Gordeev Cc: Christian Borntraeger Cc: Sven Schnelle Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Xuan Zhuo Cc: "Eugenio Pérez" Cc: Baoquan He Cc: Vivek Goyal Cc: Dave Young Cc: Thomas Huth Cc: Cornelia Huck Cc: Janosch Frank Cc: Claudio Imbrenda Cc: Eric Farman Cc: Andrew Morton David Hildenbrand (12): fs/proc/vmcore: convert vmcore_cb_lock into vmcore_mutex fs/proc/vmcore: replace vmcoredd_mutex by vmcore_mutex fs/proc/vmcore: disallow vmcore modifications while the vmcore is open fs/proc/vmcore: prefix all pr_* with "vmcore:" fs/proc/vmcore: move vmcore definitions out of kcore.h fs/proc/vmcore: factor out allocating a vmcore range and adding it to a list fs/proc/vmcore: factor out freeing a list of vmcore ranges fs/proc/vmcore: introduce PROC_VMCORE_DEVICE_RAM to detect device RAM ranges in 2nd kernel virtio-mem: mark device ready before registering callbacks in kdump mode virtio-mem: remember usable region size virtio-mem: support CONFIG_PROC_VMCORE_DEVICE_RAM s390/kdump: virtio-mem kdump support (CONFIG_PROC_VMCORE_DEVICE_RAM) arch/s390/Kconfig | 1 + arch/s390/kernel/crash_dump.c | 39 ++++- drivers/virtio/virtio_mem.c | 103 ++++++++++++- fs/proc/Kconfig | 19 +++ fs/proc/vmcore.c | 283 ++++++++++++++++++++++++++-------- include/linux/crash_dump.h | 41 +++++ include/linux/kcore.h | 13 -- 7 files changed, 407 insertions(+), 92 deletions(-) base-commit: feffde684ac29a3b7aec82d2df850fbdbdee55e4