From patchwork Sat Jan 11 04:25:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 13935766 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A84BE7719A for ; Sat, 11 Jan 2025 04:26:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D07966B0082; Fri, 10 Jan 2025 23:26:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CB8246B0083; Fri, 10 Jan 2025 23:26:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B58616B0085; Fri, 10 Jan 2025 23:26:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 96CB06B0082 for ; Fri, 10 Jan 2025 23:26:11 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 46C6FC0D2A for ; Sat, 11 Jan 2025 04:26:11 +0000 (UTC) X-FDA: 82993883742.13.97112C8 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) by imf10.hostedemail.com (Postfix) with ESMTP id 8081EC0003 for ; Sat, 11 Jan 2025 04:26:09 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CjSFMHSP; spf=pass (imf10.hostedemail.com: domain of 34PKBZwYKCBE9B8v4sx55x2v.t532z4BE-331Crt1.58x@flex--surenb.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=34PKBZwYKCBE9B8v4sx55x2v.t532z4BE-331Crt1.58x@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736569569; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=Eu5sbhl2ySOPh1lykrtQeEYkFdZ3PTKUjmg3zzYCqEk=; b=lMAK9c++OeASPYtRGXhyJHdQ2kXWuboR5zNGOv6DrBDSlZOS+Bb1U+0JhPRKUDUNX0upC3 Uzh45ocjcPSSxpul2myaxKD8qVGvoyx1rmkl7BUjITIwt+H+Qhqmfh3fzlTI/KwBO3wj3H RRG5DEqF/WBlw9ix8y0qbSrrvh1pfLM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736569569; a=rsa-sha256; cv=none; b=gPfKflwvISAwV5843RzfKEd6Oq3NejlBFmXaGseh5+9wUGWaEwOysGhgWgOX0uaMDmTJdh bGNiSTUItwNGZIftWu6CO2GpaIXZFlIU4kMTrUSIGia4fnf4NgFB4X2Vi/NbLppO+669la afjXeCPBY1v4rLYXQ74NXFPFB0HV6IA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CjSFMHSP; spf=pass (imf10.hostedemail.com: domain of 34PKBZwYKCBE9B8v4sx55x2v.t532z4BE-331Crt1.58x@flex--surenb.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=34PKBZwYKCBE9B8v4sx55x2v.t532z4BE-331Crt1.58x@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2164861e1feso47535835ad.1 for ; Fri, 10 Jan 2025 20:26:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736569568; x=1737174368; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=Eu5sbhl2ySOPh1lykrtQeEYkFdZ3PTKUjmg3zzYCqEk=; b=CjSFMHSPXoM/9POFnbdLSdqr5aw79h/ZjDLixZajKG9RvJ2g6zrOP1GAZCKAjB+hjX IWcjrILlUvzlUp3eOph93Ofok0AneiP4AU+rX7guoM4Ckw9nYjUV1pS/IrclFfpJsoWF o8sQk0AN8El96UoNbUf0thKaIMBqSfIFJCbo4gzrY0djupSW+x42mhacUcU6RkO7PPKa vzhkvxMXpxfE5AfPq68t7cJvFhrYrHfj7U4aluXDC4cTWGXmT+1MJeF71OqND+K9gjMp 9C5y7wCx7KMJzK75v0W2LzVlATG9WYPhg+XI4P9+sWmqERftVuQOFvTgshqcENzVkcZ5 Dn1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736569568; x=1737174368; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Eu5sbhl2ySOPh1lykrtQeEYkFdZ3PTKUjmg3zzYCqEk=; b=R9YT6uD4TF5My1KrQRa1YNqcz5y9Db7zDJwU1rBH2VQOnd1O3k/SPpSqHcjJGgYcbE t+U3sKbP/QYcy/m20XmnTcZ2xVkVVu4sW8/bHAkEVmhTW+okcodXXQkFahJLYU/PTQJf 2phk2xZSSH1bHNFuxqsTrekp2/LAP7GVCDoM4NOG00UlWuvitKASxl5TG/jJFIw2ylyD UVsy3RWWCfjY3izxDqowzJOJ9SL9wHbRQRO1SARD9jnzEB6GZYgNUklec0xaOm1B5Pka 55czeKpw7nKpwsWlFOw2ZW4Iwg/nKhsah1pm8UD5mMzl3k9m7+hklaIeBGVe9ZkPzoac 7mKQ== X-Forwarded-Encrypted: i=1; AJvYcCXZNQTMcs+j0tCwVb5TdoPq/1gDkF16UohmKlu/a7Rs1j1RyAVtqeSOo/VGL935gd3DZtxYlp/MNw==@kvack.org X-Gm-Message-State: AOJu0Yxej4waUVc4X9aeLyYMJE9pTwxerYxOlwyleux1NGWsMncuLALp bZTO0mWdE2KAhKil9jb/on/frjlymfAYM98HYTTp4973WLYXjrpIMrPkdGxgnPwOC0m6P/refGh AbA== X-Google-Smtp-Source: AGHT+IHCKkNsg7Je2tguAx3Fa2vj4+MV11mRFGblDUn+ozDW/D6XKXXy3Bs9jHU9xB/vfmoUDos+532mwNU= X-Received: from pgyy67.prod.google.com ([2002:a63:3246:0:b0:801:9268:c344]) (user=surenb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:8cc3:b0:1d9:2b51:3ccd with SMTP id adf61e73a8af0-1e88cf7ba29mr22017767637.7.1736569568042; Fri, 10 Jan 2025 20:26:08 -0800 (PST) Date: Fri, 10 Jan 2025 20:25:47 -0800 Mime-Version: 1.0 X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Message-ID: <20250111042604.3230628-1-surenb@google.com> Subject: [PATCH v9 00/17] reimplement per-vma lock as a refcount From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, david.laight.linux@gmail.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, richard.weiyang@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com, surenb@google.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8081EC0003 X-Stat-Signature: fg1wu7jaccog3zmkaesitram5ejxopb4 X-Rspam-User: X-HE-Tag: 1736569569-351048 X-HE-Meta: U2FsdGVkX183kHlqVryYsINfF8hqMskxMUwo1o88ps4o39PA1PagKTZtEIKAOFt9zEzRiwvnKrUwUvDklbv64ujGwmSbXuRcax2BFOfqcfbfEBAvwzhm6WPCwbeoMPWX9m1QgwvUonRdyH25aiW6ajTDsO1XjQSL2VSRFyZt8zhzkwtaYVkt/4Uhpp84apnt9JB0o6PiPMrRt844MgevRDyMF7aZbhseUJt7IGBsQTHrr6fFbIlC5Rd9L/JGxRX2ZrFRgtxKDoBATfO07VhPldAryVAZmf/mUUqf9gKUfVVuqk77n3G1cYYJCgqEZZy/VUmqNTPw0BlPqlMzzwQmg8pSHo+SFbqB47zC2PPKi0UWG+8WdPrZkoAuFaols/NFVD0Ao3JAVtzSJXRxGs0zVn+AMWXBzni3Tjd9dQX9f2BPPOvrR/6j5RlBSginNqdRaHLSi4kOyz6xccenHx5JFco9l8BlMr+vKjG3c/zzJ61vBL26a234dQ1ak4k/dm2lGyEcZNK8hpou9umzdJe88tj55IotVxy2+X/UJfSZ06nprV9NcWMciZ698mWydzMjcJ88N1MLxi8DtgDyfYNSj94TVLHYs0rTMxu8ynXC2r3sD5CIjXadf4DOegj+20Tl/tAmQhxlAT6gSn/5uDmiIhH5jb2M+7kWeKieHsO5EzN9IXB+E+CMNh7fpAElZLTw6CMqbMcfylFategKE9LhvL3PL2DvoOfydFPa5HDf2OlQEiCxavtf89G9fYX554hcc/+7H9MwtR3xokCIfNct6cTHKjhpRSQk/TWnnvjbP5wG/DICXEuggySGGLtmTSz+TYddijRRw2i7o4eDmxL/AzEwQwTBpL348zmUK1vPCAngxn37wOlmizu16RVbhaa2lm8vJAJbNolTvOELigxLiYLd9ZdiLlpeOZQgh+9jpvcSO6gWqASAT6AUkgEXuzmgzAkAj43edM68hR1Svcq 10Mrx4Pz Rk/Y6cBLRLoasC90DiZgqSq3uISyhvcIqn9/qSgB/9qjc31Hu2Fo68hBTUljtazKEoGIprp/IuxIR4WP64AyIfuGNw9+I3TPfKHQ9Pk3jA/8RhI0Y/P1ovkNkW89dgzFROQF1n7iNj9XO24e5IwIEofUgTDRBlMQkezq/8M2j95QX4MzHlMPFxLemd4gyhDbLtggooDEM51gICijOZXRKZUeODZLS/6fJO37cI9+Eu2e8wBVu6xNZysiOnVBgBhGH3INUQREEf6Gg8HhaTJ1WF13i+i5WXT8hJv4Ds3yavxnn5euElG62sr0APagBsABWyyOxeLMrB2JsaDUqxWW5QFda71KqDZ/KxEZThIjluAjBSKN94/KSmU9cRNTtod2ucbKn1T43kkPoJ/zHmZ/jYn64Rh5REDFJHF213/vIlaOjKtcNxzNEp4axhAvnucqhP69fvTWIOzSuIiPvV5Vk0tXTE0kcBLCdmWu1NSziXumhPnXCqg92M93mvhHcP6lJRSRicgO9FhY0M34ulGRSvAXCNUAw5pZtfpnU+qYOtxZ42CnvLTRzzM0cfQStHRA6OpMK2mdnIWc7K2JVqC1wBURolq4BAwyCPgRSG8rmoH2sQqqK47pXhNQ/j8HUqtRZ7qiimcdYmGaY54khtKQr798sVBL1r7GSwvyW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Back when per-vma locks were introduces, vm_lock was moved out of vm_area_struct in [1] because of the performance regression caused by false cacheline sharing. Recent investigation [2] revealed that the regressions is limited to a rather old Broadwell microarchitecture and even there it can be mitigated by disabling adjacent cacheline prefetching, see [3]. Splitting single logical structure into multiple ones leads to more complicated management, extra pointer dereferences and overall less maintainable code. When that split-away part is a lock, it complicates things even further. With no performance benefits, there are no reasons for this split. Merging the vm_lock back into vm_area_struct also allows vm_area_struct to use SLAB_TYPESAFE_BY_RCU later in this patchset. This patchset: 1. moves vm_lock back into vm_area_struct, aligning it at the cacheline boundary and changing the cache to be cacheline-aligned to minimize cacheline sharing; 2. changes vm_area_struct initialization to mark new vma as detached until it is inserted into vma tree; 3. replaces vm_lock and vma->detached flag with a reference counter; 4. regroups vm_area_struct members to fit them into 3 cachelines; 5. changes vm_area_struct cache to SLAB_TYPESAFE_BY_RCU to allow for their reuse and to minimize call_rcu() calls. Pagefault microbenchmarks show performance improvement: Hmean faults/cpu-1 507926.5547 ( 0.00%) 506519.3692 * -0.28%* Hmean faults/cpu-4 479119.7051 ( 0.00%) 481333.6802 * 0.46%* Hmean faults/cpu-7 452880.2961 ( 0.00%) 455845.6211 * 0.65%* Hmean faults/cpu-12 347639.1021 ( 0.00%) 352004.2254 * 1.26%* Hmean faults/cpu-21 200061.2238 ( 0.00%) 229597.0317 * 14.76%* Hmean faults/cpu-30 145251.2001 ( 0.00%) 164202.5067 * 13.05%* Hmean faults/cpu-48 106848.4434 ( 0.00%) 120641.5504 * 12.91%* Hmean faults/cpu-56 92472.3835 ( 0.00%) 103464.7916 * 11.89%* Hmean faults/sec-1 507566.1468 ( 0.00%) 506139.0811 * -0.28%* Hmean faults/sec-4 1880478.2402 ( 0.00%) 1886795.6329 * 0.34%* Hmean faults/sec-7 3106394.3438 ( 0.00%) 3140550.7485 * 1.10%* Hmean faults/sec-12 4061358.4795 ( 0.00%) 4112477.0206 * 1.26%* Hmean faults/sec-21 3988619.1169 ( 0.00%) 4577747.1436 * 14.77%* Hmean faults/sec-30 3909839.5449 ( 0.00%) 4311052.2787 * 10.26%* Hmean faults/sec-48 4761108.4691 ( 0.00%) 5283790.5026 * 10.98%* Hmean faults/sec-56 4885561.4590 ( 0.00%) 5415839.4045 * 10.85%* Changes since v8 [4]: - Change subject for the cover letter, per Vlastimil Babka - Added Reviewed-by and Acked-by, per Vlastimil Babka - Added static check for no-limit case in __refcount_add_not_zero_limited, per David Laight - Fixed vma_refcount_put() to call rwsem_release() unconditionally, per Hillf Danton and Vlastimil Babka - Use a copy of vma->vm_mm in vma_refcount_put() in case vma is freed from under us, per Vlastimil Babka - Removed extra rcu_read_lock()/rcu_read_unlock() in vma_end_read(), per Vlastimil Babka - Changed __vma_enter_locked() parameter to centralize refcount logic, per Vlastimil Babka - Amended description in vm_lock replacement patch explaining the effects of the patch on vm_area_struct size, per Vlastimil Babka - Added vm_area_struct member regrouping patch [5] into the series - Renamed vma_copy() into vm_area_init_from(), per Liam R. Howlett - Added a comment for vm_area_struct to update vm_area_init_from() when adding new members, per Vlastimil Babka - Updated a comment about unstable src->shared.rb when copying a vma in vm_area_init_from(), per Vlastimil Babka [1] https://lore.kernel.org/all/20230227173632.3292573-34-surenb@google.com/ [2] https://lore.kernel.org/all/ZsQyI%2F087V34JoIt@xsang-OptiPlex-9020/ [3] https://lore.kernel.org/all/CAJuCfpEisU8Lfe96AYJDZ+OM4NoPmnw9bP53cT_kbfP_pR+-2g@mail.gmail.com/ [4] https://lore.kernel.org/all/20250109023025.2242447-1-surenb@google.com/ [5] https://lore.kernel.org/all/20241111205506.3404479-5-surenb@google.com/ Patchset applies over mm-unstable after reverting v8 (current SHA range: 235b5129cb7b - 9e6b24c58985) Suren Baghdasaryan (17): mm: introduce vma_start_read_locked{_nested} helpers mm: move per-vma lock into vm_area_struct mm: mark vma as detached until it's added into vma tree mm: introduce vma_iter_store_attached() to use with attached vmas mm: mark vmas detached upon exit types: move struct rcuwait into types.h mm: allow vma_start_read_locked/vma_start_read_locked_nested to fail mm: move mmap_init_lock() out of the header file mm: uninline the main body of vma_start_write() refcount: introduce __refcount_{add|inc}_not_zero_limited mm: replace vm_lock and detached flag with a reference count mm: move lesser used vma_area_struct members into the last cacheline mm/debug: print vm_refcnt state when dumping the vma mm: remove extra vma_numab_state_init() call mm: prepare lock_vma_under_rcu() for vma reuse possibility mm: make vma cache SLAB_TYPESAFE_BY_RCU docs/mm: document latest changes to vm_lock Documentation/mm/process_addrs.rst | 44 ++++---- include/linux/mm.h | 156 ++++++++++++++++++++++------- include/linux/mm_types.h | 75 +++++++------- include/linux/mmap_lock.h | 6 -- include/linux/rcuwait.h | 13 +-- include/linux/refcount.h | 24 ++++- include/linux/slab.h | 6 -- include/linux/types.h | 12 +++ kernel/fork.c | 129 +++++++++++------------- mm/debug.c | 12 +++ mm/init-mm.c | 1 + mm/memory.c | 97 ++++++++++++++++-- mm/mmap.c | 3 +- mm/userfaultfd.c | 32 +++--- mm/vma.c | 23 ++--- mm/vma.h | 15 ++- tools/testing/vma/linux/atomic.h | 5 + tools/testing/vma/vma_internal.h | 93 ++++++++--------- 18 files changed, 465 insertions(+), 281 deletions(-)