From patchwork Wed Feb 12 09:25:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yunsheng Lin X-Patchwork-Id: 13971472 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEA41C02198 for ; Wed, 12 Feb 2025 09:33:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31158280009; Wed, 12 Feb 2025 04:33:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BF75280004; Wed, 12 Feb 2025 04:33:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D599280009; Wed, 12 Feb 2025 04:33:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 01FEA280004 for ; Wed, 12 Feb 2025 04:33:50 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B00B91C9354 for ; Wed, 12 Feb 2025 09:33:22 +0000 (UTC) X-FDA: 83110779444.22.15E6D4B Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf24.hostedemail.com (Postfix) with ESMTP id B555318001D for ; Wed, 12 Feb 2025 09:33:19 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739352801; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=RLfBc0WOFadngRqCzOfSP857klROacANH1eVoltCHBA=; b=GQA5eAMMAJVa1jh6dFr5ZeLV9kyrfpSxZSDYbPc0muYRHp9rvGzW852DVBY7yzq9/VCKwy SDMo4LbrixPehPUQs6M9xjd3nZsCPd31dL75BV7SIN7l3sFuG+LcXkOW+Tili4tm9YS+1a sR55A4efzX7JkD1YPO9DR7R+KqP12KA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739352801; a=rsa-sha256; cv=none; b=fHe4uMqp7MBveY4/qlWJAz5Jg4sPIZVFKM7+tJglwhiOzO3TrwWXF+hkerZ0WhZsVem9eK 2UFg/D1n7+7WVbj2mZfloiNRDRj75r/2cdeWGM74LvkZk/mZzW19fyG9RVz7zq6siDfvKZ yU/nyeF8HPy19euiRFbOLSV92+sgiHY= Received: from mail.maildlp.com (unknown [172.19.88.163]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4YtCgq66YKz1V6dV; Wed, 12 Feb 2025 17:29:27 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id 428F7180069; Wed, 12 Feb 2025 17:33:14 +0800 (CST) Received: from localhost.localdomain (10.90.30.45) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 12 Feb 2025 17:33:13 +0800 From: Yunsheng Lin To: , , CC: , , , Yunsheng Lin , Alexander Lobakin , Robin Murphy , Alexander Duyck , Andrew Morton , IOMMU , MM , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Matthias Brugger , AngeloGioacchino Del Regno , , , , , , Subject: [PATCH net-next v9 0/4] fix the DMA API misuse problem for page_pool Date: Wed, 12 Feb 2025 17:25:47 +0800 Message-ID: <20250212092552.1779679-1-linyunsheng@huawei.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 X-Originating-IP: [10.90.30.45] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemf200006.china.huawei.com (7.185.36.61) X-Rspam-User: X-Stat-Signature: fz6t8uzrueqkm6enzw67swxiugjfwh8u X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B555318001D X-HE-Tag: 1739352799-555477 X-HE-Meta: U2FsdGVkX18Kh2+0QwLoK9FGV9nMX8otV4gR3KRKlLEdq0pUGmni92WgZ12vJ6iV/u+zqKx27ArDfIdNsJGEawqT6gw9MBEPG+M1cWNnPZ1b9WE5KzbiA75QQEHDin0IL8t8i+QNkX9DFYFySLfp+EkAOmEWOsvY53tJCJmzqi1pXjwHre2rMuaIDbxHPdObEffFFD95y0FCvbXwM6S7RqSUPNC5GITFr7JpNzhdregXbx86MS0nWq3L049/YYpz+99hDzoK1B3ZlKeYrdl3aBo1W3++zSPaf3ruz0NZ9T35qtgGcmN9NFDdPFjbsK2c9CCVphEx6iGKc5XPbpGDM+UZMdrwnMY2vA103FO6FnXdRdykIhYGTR8I73UXsmMtoN3CeHKz1LVJY41hRvQJ7iFEMihEQqY/rUkeNewcHfvl+GOsfZ3Xpcr5Wa9Sa4IWfbkSh/nEgxS6CTIeVpIQTtXlQZn0G1xvH9LSSw1Jd6DtgENaRq7maGLTBDDdFpXalk805P/ASDCbyFwWjms61Js+sH+kudNGtatcl7A63nKMikdFyAcFIypr9C2wVY7MPI3ASM/0dBDifHC8XFBohtMJGw+y+N5kY0GSKBRvCFa2Sre4WRqpRCo8ppzitqxem9UZ84PpMIM9bVpNpO42rR8Lv3t9W3e/AG4PYOctePrEB7yam6bGbFYsGCZPoQzHzbArcNUpRgF91Ya/nTLmzR0draes63PylfI+nEi9riS9pwiSp/T4/s0jKePj4xu7i8FQkejZIhnNcnC6DXGNz8sB+i4XF7SF3ZNqSxRr420vST/HAL4y1UuRz5KigRe/6HKWx3Zl788w1gJ5fYUaXgk3irhySB1yfzVqasIIUifeng+gU5kigj666emjmp6umVifE2F2gxaXf4bwEdlAzFh+iUlIfXutNCZmFIxnm6X3z3sjb7BskLhKoBYZVIJaPgZJrXTBlBRa0is/xJI dng860Pg AUdcxQvij7PN1TpydnV2Mftr6ul0gE78WfVkecrkmArljBew1BT/HThDkuAJsT5eJQzxZToi7SaBT28v5/NliohYM7zwerY+UU7U7oEs0oQQCb1EM8jjU5/fLLa5rl1YyDpiHNrz0ifoPwuN0KhNNb2NeVNrLsbW6FNLxSzWydufEa7TxmwzloKP58gwd+mYd3+z2kSD99p/VZRCtNT6SdywzUMjarR4l4qUH5hXhZ7CZy7j9v0gzuLAiY+CimRx+4Wn6dfNpU1p+1eqIhywMVjZ/8GUr+IeLk7XF0m7xGN7xZ7WEfEJ/JF4g3MHfW8Czt/yVjZq98ohbhD/P00i3WktM4G/4gHe90ivPMMj691afP1wVr+E3DDh4osZA2kf+xsQykSvyhPXoPUt5SMatGrKmNHwLOf/xlZtyMaQ7Gt/80Khht+8bAmrEDbe5HK81uJt4GS5uiOAWKWoFxFPiGMcXJ6srYwghvUVYdrnEOFqayI8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patchset fix the dma API misuse problem as mentioned in [1]. From the below performance data, the overhead is not so obvious due to performance variations in arm64 server and less than 1 ns in x86 server for time_bench_page_pool01_fast_path() and time_bench_page_pool02_ptr_ring, and there is about 10~20ns overhead for time_bench_page_pool03_slow(), see more detail in [2]. arm64 server: Before this patchset: fast_path ptr_ring slow 1. 31.171 ns 60.980 ns 164.917 ns 2. 28.824 ns 60.891 ns 170.241 ns 3. 14.236 ns 60.583 ns 164.355 ns With patchset: 6. 26.163 ns 53.781 ns 189.450 ns 7. 26.189 ns 53.798 ns 189.466 ns X86 server: | Test name |Cycles | 1-5 | | Nanosec | 1-5 | | % | | (tasklet_*)|Before | After |diff| Before | After | diff | change | |------------+-------+-------+----+---------+--------+--------+--------| | fast_path | 19 | 19 | 0| 5.399 | 5.492 | 0.093 | 1.7 | | ptr_ring | 54 | 57 | 3| 15.090 | 15.849 | 0.759 | 5.0 | | slow | 238 | 284 | 46| 66.134 | 78.909 | 12.775 | 19.3 | And about 16 bytes of memory is also needed for each page_pool owned page to fix the dma API misuse problem 1. https://lore.kernel.org/lkml/8067f204-1380-4d37-8ffd-007fc6f26738@kernel.org/T/ 2. https://lore.kernel.org/all/f558df7a-d983-4fc5-8358-faf251994d23@kernel.org/ CC: Alexander Lobakin CC: Robin Murphy CC: Alexander Duyck CC: Andrew Morton CC: IOMMU CC: MM Change log: V9. 1. Drop the fix of a possible time window problem for NPAI recycling. 2. Add design description for the fix in patch 2. V8: 1. Drop last 3 patch as it causes observable performance degradation for x86 system. 2. Remove rcu read lock in page_pool_napi_local(). 3. Renaming item function more consistently. V7: 1. Fix a used-after-free bug reported by KASAN as mentioned by Jakub. 2. Fix the 'netmem' variable not setting up correctly bug as mentioned by Simon. V6: 1. Repost based on latest net-next. 2. Rename page_pool_to_pp() to page_pool_get_pp(). V5: 1. Support unlimit inflight pages. 2. Add some optimization to avoid the overhead of fixing bug. V4: 1. use scanning to do the unmapping 2. spilt dma sync skipping into separate patch V3: 1. Target net-next tree instead of net tree. 2. Narrow the rcu lock as the discussion in v2. 3. Check the ummapping cnt against the inflight cnt. V2: 1. Add a item_full stat. 2. Use container_of() for page_pool_to_pp(). Yunsheng Lin (4): page_pool: introduce page_pool_get_pp() API page_pool: fix IOMMU crash when driver has already unbound page_pool: support unlimited number of inflight pages page_pool: skip dma sync operation for inflight pages drivers/net/ethernet/freescale/fec_main.c | 8 +- .../ethernet/google/gve/gve_buffer_mgmt_dqo.c | 2 +- drivers/net/ethernet/intel/iavf/iavf_txrx.c | 6 +- drivers/net/ethernet/intel/idpf/idpf_txrx.c | 14 +- drivers/net/ethernet/intel/libeth/rx.c | 2 +- .../net/ethernet/mellanox/mlx5/core/en/xdp.c | 3 +- drivers/net/netdevsim/netdev.c | 6 +- drivers/net/wireless/mediatek/mt76/mt76.h | 2 +- include/linux/mm_types.h | 2 +- include/linux/skbuff.h | 1 + include/net/libeth/rx.h | 3 +- include/net/netmem.h | 31 +- include/net/page_pool/helpers.h | 15 + include/net/page_pool/memory_provider.h | 2 +- include/net/page_pool/types.h | 46 +- net/core/devmem.c | 6 +- net/core/netmem_priv.h | 5 +- net/core/page_pool.c | 423 ++++++++++++++++-- net/core/page_pool_priv.h | 10 +- 19 files changed, 504 insertions(+), 83 deletions(-)